- Feb 09, 2024
-
-
Yann authored
An editor can trigger a TypeError exception leading to a 503 error message `trim() expects parameter 1 to be string, null given` in the backend page module by creating `menu_categorized_content` objects with `selected_categories` and then turning them into `menu_section` objects. This change mitigates the type error by using a null-coalesce fallback passing an invalid type to the `trim()` method in `StandardContentPreviewRenderer::generateListForMenuContentTypes()`. Resolves: #103052 Releases: main, 12.4, 11.5 Change-Id: I4c0ecbd20c7cdfee22fa324f6b80391be47a1b88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82794 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
Oliver Bartsch authored
The "Export" button in the list module, used to trigger exporting a table does now also respect the `options.impexp.enableExportForNonAdminUser` TSconfig option, preventing a permission exception. The `mod.web_list.noExportRecordsLinks` is no longer used for managing the display of the "Download" button (displayed in the table's header row), but instead a dedicated TSconfig option `mod.web_list.displayRecordDownload` is introduced. Using per-table syntax, it's also possible to manage the "Download" Button for each table individually. Resolves: #99781 Releases: main, 12.4 Change-Id: I8b967218626ecc05dccf4bd7ac441db56a21a753 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82817 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Benjamin Kott authored
Resolves: #103094 Releases: main Change-Id: Ib755aacd6f3e9a8149691957c08151b36144325b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82882 Reviewed-by:
-
Oliver Bartsch authored
The ExtendedFileUtility component provides the file name as argument for the `fileNotDeletedHasReferences` label. This information is now displayed correctly by adding the missing placeholder to the label. Resolves: #103091 Releases: main, 12.4 Change-Id: Ic9e40034bdf4f3d14e874014210e5d22235cd8c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82875 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
Lit elements need to get created in the correct browser scope (i.e. frame) to get rendered in Firefox, which is a huge issue in modals (that reside in the global scope), that are triggered in an iframe scope. This commit introduces a helper method `loadModuleFrameAgnostic()` that loads the module depending on the context the Install Tool is in (standalone vs. iframe). All Install Tool modules are modified to load renderable modules (info boxes, flash messages and progress bars) explicitly. Also, a superfluous progress bar is removed from the "Directory status" module that breaks the whole modal in case a user prefers reduced motions. Resolves: #103048 Releases: main Change-Id: I00834e1000c689d4581cbd3ef0124a1f8a391186 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82791 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #103089 Releases: main Change-Id: I87cfaf2baeafb290930cb6142e80ad490fb1a05c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82872 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Torben Hansen authored
The identifier in the `AsEventListener` PHP attribute uses a space. Allthough this technically works, we do not use spaces elsewhere for event listener identifiers. This change therefore removes the superfluous space. Resolves: #103041 Related: #102440 Releases: main Change-Id: I159ff18e4769e71cba120ccb1dd2b668fd825aea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82784 Reviewed-by:
-
Andreas Kienast authored
`argon2id` is available since PHP 7.3. Since this version requirement is fulfilled for quite some time already, it's time to set the hashing algorithm as the default one. Resolves: #103084 Releases: main Change-Id: Iad3f4f4e33a7c3aa1b3d790931cf7bff900935b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82865 Reviewed-by:
-
Thomas Hohn authored
The so called "death star" range for replacements has to be used with caution [1] as it replaces all versions of the replaced packages, including old or insecure versions. That effectively means the replacing package marks itself as matching in queries for insecure versions, once a security advisory[2] is submitted for the replaced packages. The extension replacements are now adapted to use the more precise self.version qualifier to avoid matching named security advisories as suggested by: https://github.com/Roave/SecurityAdvisories/issues/127#issuecomment-1933647035 [1] https://getcomposer.org/doc/04-schema.md#replace [2] https://github.com/advisories/GHSA-cgr9-h9qq-x9fx Resolves: #103082 Releases: main, 13.0, 12.4, 11.5 Change-Id: I6353df15d6cbf039bab60644a103669495b26605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82863 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Kott authored
The lower part of the node name was inadvertently truncated. This patch ensures that the text is no longer cut off. Resolves: #103077 Releases: main Change-Id: I54dfe7300d1c15ab0b28393e7b15196e2f42aa8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82870 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Andreas Kienast authored
In some cases it was missed to enable modal actions again after their execution in the Install Tool. This patch adds the necessary statements to enable said buttons again. Resolves: #101224 Releases: main, 12.4 Change-Id: I793f157302df15912f0506c376d9db2d6041ebcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82815 Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Benjamin Kott authored
With the move to native drag and drop in the tree component #103043, d3js became obsolete and is now removed. Resolves: #103087 Releases: main Change-Id: I8592ca50550b242b9e452ef0a782cbf60e81a8e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82869 Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save sortablejs@^1.15.2 npm run build Resolves: #103064 Releases: main, 12.4 Change-Id: I34c76bbd6b856c10a7a420d6fe652a47fbf0e095 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82823 Reviewed-by:Fabien Udriot <fudriot@omic.ch> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save alwan@^2.0.2 npm run build Resolves: #103038 Releases: main Change-Id: Iba79bd1e91c2ffcdfc7ff23e11786d4f6b9ee305 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82781 Reviewed-by: -
Benni Mack authored
This change ensures that `?id=` only validates against an integer-interpreted value, disallowing `?id=nonsense23` which previously resolved to "23" In case an invalid `?id=` parameter value is provided throw a page not found error. Resolves: #103057 Releases: main, 12.4 Change-Id: Iaeb3096944b6872b73b056b690bf4f7fabbe9a6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82814 Reviewed-by:
-
- Feb 08, 2024
-
-
Benjamin Kott authored
The configured browser capabilities (`chromeOptions`) are passed by `codeception/module-webdriver` to `php-webdriver` as is. php-webdriver expects the PHP constant ChromeOptions::CAPABILITY to be used instead of hardcoding any strings. Therefore php-webdriver 1.15 changed this constants value from `chromeOptions` to `goog:chromeOptions` [1], which means that the option `chromeOptions` is no longer respected and the configured window size (and the headless flag) is ignored. We now use the newer W3C webdriver comaptible `goog:chromeOptions` option and define window size definition via codeception's respective option `window_size` while we are at it. [1] https://github.com/php-webdriver/php-webdriver/commit/235c2aa07 Resolves: #103081 Releases: main, 12.4 Change-Id: Iec345b5ec0226d38b62081aa8c3a51dd3100bdb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82860 Reviewed-by:
-
- Feb 07, 2024
-
-
Simon Schaufelberger authored
A new test case is added to cover the case when a TCA definition exists without `ctrl`. The test case has been added to the test extension `blog_example` which is not part of the public extension. Resolves: #103025 Releases: main, 12.4, 11.5 Change-Id: Iccd4428ad544fd6a94ed48ec97264b2945463d04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82771 Tested-by:
-
Benjamin Kott authored
The SVG based renderer for the page, file and select trees has been replaced by a HTML based one. It uses reactive rendering based on lit's component model. Using HTML and CSS rendering offers more flexibility than SVG, so that RTL and dark mode support could now be implemented. Releases: main Resolves: #102125 Resolves: #103043 Resolves: #100467 Resolves: #98088 Resolves: #97346 Change-Id: Ic27b1d08c232d9074a734c80e222fb801672b967 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81411 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Stefan Bürk authored
This change adds a composer command dispatcher to `Build/Scripts/runTests.sh` to allow the execution of any composer command without the hassle to have a proper composer installed on the host system. This also helps for onboarding new contributors not having a proper php and composer ecosystem installed on the host system. For example, to raise dependencies following can now be used: > Build/Scripts/runTests.sh -s composer -- require --dev \ typo3/testing-framework:dev-main Other examples: > Build/Scripts/runTests.sh -s composer -- dumpautoload > Build/Scripts/runTests.sh -s composer -- info | grep "symfony" Resolves: #103045 Releases: main, 12.4, 11.5 Change-Id: I65fa14e2c8d0d1a1204b3bed701d8c3458b6e3bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82787 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Stefan Bürk authored
The COMPOSER_ROOT_VERSION environment variable in `Build/Scripts/runTests.sh` has not been updated. This change corrects this. Resolves: #103073 Releases: main Change-Id: I9fa3406ac471e749546473db10db3020d4f92685 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82857 Reviewed-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev sass@^1.17.0 npm run build Resolves: #103065 Releases: main, 12.4 Change-Id: Id8d3ad111a751299266bdc3abe59c54a15df010c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82824 Reviewed-by:
-
- Feb 06, 2024
-
-
Christian Kuhn authored
This finediff minor raise alignes supported PHP versions >=8.2 with core, symfony, phpunit v11. Releases: main Resolves: #103066 Change-Id: I7af5103daf65a57ca865fa3236803df9368894bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82825 Tested-by:
-
Dimitri König authored
There have been quite a lot of patches around the pagelayout condition, which was introduced in early TYPO3 v11. It was broken in the beginning and got fixed with #98044. Soon after, a major refactoring of the ConditionMatcher has been applied with #100047, which re-introduced bugs regarding the pagelayout TypoScript condition. These have partially fixed with #100764 and #100921. The affected code is a bit messy due to a weird sorted array returned by the 'rootline' methods and classes, which we can't resolve right now. The fix itself revolves a last issue by reversing the rootline again. This was already done in the old backend ConditionMatcher. The frontend ConditionMatcher received the fullRootline, which is already reversed (deepest first). With the introduction of IncludeTreeConditionMatcherVisitor this has been unified, but the array_reverse was forgotten. In addition, the fullRootline from the frontend controller and BackendUtility::getPagesTSconfig() calls are sorted with `ksort` before passed over, meaning we always receive a top-down (root-first) rootline. Hence, the array_reverse is a viable fix for both backend and frontend. The patch covers BE pageTS, FE TypoScript and FE getData with tests to cover the situation once and for all. Resolves: #102268 Related: #100047 Related: #100764 Related: #100921 Related: #98044 Related: #97816 Releases: main, 12.4 Change-Id: Ibec77f3cf63073e40e4a711d69f584b9265b1ad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82560 Tested-by:
-
Andreas Kienast authored
Resolves: #103055 Releases: main, 12.4 Change-Id: If1c9f1dee8952faba5ed65bf54770a51aefdd37d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82812 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Feb 05, 2024
-
-
Andreas Kienast authored
The version was outdated and is removed as it is not needed, since there is no intent to publish the build-folder as-is on npmjs. Resolves: #103039 Releases: main, 12.4 Change-Id: I799e03b00caefea946fb9700a6863ae325551f90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82782 Reviewed-by:
-
Stefan Bürk authored
To give extensions the ability to change the expected database schema, adding or changing columns of existing TYPO3 Core tables or other extension tables, `ext_tables.sql` of extension are read and taken as partial table definitions. All table definitions are merged at a later point in the `ConnectionMigrator`, forcing proper handling of partial table information. This change moves the table definition merge process from the `ConnectionMigrator` to the `SchemaMigrator` at the earliest possible place to pave the way for further code cleanups. Resolves: #103015 Related: #103014 Releases: main Change-Id: I7f5bfa6f438604ca6295f20eb85fb9e24a44189a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82758 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
The element browsers, such as file browser, folder browser or the create folder browser are rendering the FileList in the `browse` mode. In this case the context menu component is not loaded. This is correct, since using the context menu inside the modal would lead to various side effects. Because the JS component is not loaded for mentioned reasons, wrapping the icons with the click menu needs to be omitted. This otherwise leads to further side effect, e.g. loading a second folder tree in the create folder browser. Therefore, this change now omits wrapping the icon with then click menu when the Filelist is used in the `browse` mode. Resolves: #103001 Releases: main, 12.4 Change-Id: Ifd4daf5487b5dd9c74553d48cd0c2270b2c4f58b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82755 Tested-by:
-
Stefan Bürk authored
This change adds further MySQL Server versions to the `Build/Scripts/runTests.sh` to allow executing local functional and acceptance tests with these version. Added versions: - MySQL 8.1 - MySQL 8.2 - MySQL 8.3 Resolves: #103030 Releases: main, 12.4, 11.5 Change-Id: I578ed524560ae1907ab8a79df7694470f9aa234a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82777 Tested-by:
-
Simon Praetorius authored
This patch should cover all of the arguments and variants both <f:image /> and <f:uri.image /> offer to generate images in Fluid templates. Resolves: #103013 Releases: main Change-Id: Ibf55b785d74d076edef121ac2f43e862677acdd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82757 Tested-by:
-
- Feb 04, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @lit/reactive-element@^2.0.4 \ lit@^3.1.2 \ lit-element@^4.0.4 \ lit-html@^3.1.2 npm run build Resolves: #103024 Releases: main, 12.4 Change-Id: Iec49465ce10b9da4cd2a05bcc13c09dd49508ef0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82768 Tested-by:
-
- Feb 03, 2024
-
-
Stefan Bürk authored
Doctrine DBAL released the stable version for the next major version, v4.0.0. [1] This change upgrades to the stable version and ends the usage of the release candidate as intermediate solution. Stability workaround for the distribution test composer.json is removed. > \ composer req --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"^4.0" ; \ composer req --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"^4.0" ; \ composer req --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"^4.0" ; \ composer req -W \ "doctrine/dbal":"^4.0" > COMPOSER=composer.dist.json composer rem --no-update \ -d Build/composer "doctrine/dbal" [1] https://github.com/doctrine/dbal/releases/tag/4.0.0 Resolves: #103029 Related: #102875 Releases: main Change-Id: I36986769273822473a6ee9133af19c0c253b64e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82776 Tested-by:Oliver Wand <wand@itaw.de>
-
Stefan Bürk authored
TYPO3 uses a composer package [1] to import locales along with translations and a custom script has been added to create and update included translation files. This change updates the language files with the last updates and requires the package with the current highest version as minimum. Used command(s): > composer req --dev \ "sokil/php-isocodes-db-i18n":"^4.0.19" > php Build/Scripts/updateIsoDatabase.php [1] sokil/php-isocodes-db-i18n Resolves: #103027 Related: #100659 Releases: main, 12.4 Change-Id: I2839113ed3894cec58b41c85abd59039cab00725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82773 Tested-by:Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
-
Stefan Bürk authored
The `Symfony\Component\Translation\Dumper\XliffFileDumper` is extended to add processing workflowes needed to update the xliff files based on the ISO Database with `Build/Scripts/updateIsoDatabase.php`. Symfony 7 added method types and return types, and therefore the extended method `dump()` needs a compatible return type. The corresponding `:void` return type is added now. Resolves: #103026 Releases: main, 12.4 Change-Id: Id39dbbab9cccffc0b0900267bdc411187623f6fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82772 Reviewed-by:
-
Jochen Roth authored
Currently, having a inlineLanguageLabelFiles defined without passing any additional config leads to an undefined key warning. This has been fixed by adding a fallback to an empty array. Resolves: #103020 Releases: main Change-Id: I4234a8efe5d33ee53afebbfe8d4fc36859b032ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82762 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Feb 02, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.12.0 \ @codemirror/lang-html@^6.4.8 \ @codemirror/language@^6.10.1 \ @codemirror/lint@^6.5.0 \ @codemirror/view@^6.23.1 \ @lezer/common@^1.2.1 \ @lezer/lr@^1.4.0 npm run build Resolves: #103023 Releases: main, 12.4 Change-Id: I4b21ebc335f3bc3483a957e0c6c48d62e0e4f622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82765 Reviewed-by: -
Albrecht Köhnlein authored
The methods `logicalAnd()` and `logicalOr()` allow any number of constraints as parameters. The outdated PHPdoc comment still said "two". Resolves: #103007 Releases: main, 12.4 Change-Id: I582eb3f1c17fb3149a49a15649469794ce386149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82753 Tested-by:
-
Stefan Bürk authored
The `Build/Scripts/runTests.sh` supports `podman` and `docker` as container cli binary since quite a while now, albeit docker has been kept as default if not specified using `-b`. This change removes the hard default and will now use `podman` as default. In case `podman` is not available `docker` is used. As a side-effect, the binary for CI is no longer enforced the hard way. PostgreSQL 16 is added as database version. Resolves: #103018 Releases: main, 12.4, 11.5 Change-Id: Iedcd7cbcd2380adb6781bd8b4f075da86e25c03b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82761 Tested-by:
-
- Feb 01, 2024
-
-
Oliver Bartsch authored
There is no valid reason to force a minimum amount of 5 records to be displayed in the list view. Therefore, the range is reset to 0 - 10000, as it was before #92103. Resolves: #103011 Related: #92103 Releases: main, 12.4 Change-Id: Icd22e6a77dc554774dcde6a6a3dc3c2a799d2d7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82759 Reviewed-by:
Christian Weiske <typo3-2022@cweiske.de> Tested-by:
-
Albrecht Köhnlein authored
In case modules do not provide a "shortDescription" the module card is now rendered without title in the "About" module Resolves: #103005 Releases: main, 12.4 Change-Id: Ic383df283eb7c3e3e175862f808ea731531ccfff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82752 Tested-by:
-
- Jan 31, 2024
-
-
Peter Kraume authored
Resolves: #102999 Related: #98545 Releases: main Change-Id: I0d8b4f6d05cf77dee49265912029b8257e7b92e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82727 Reviewed-by:
-
