- Sep 02, 2022
-
-
Andreas Fernandez authored
Items were previously rendered in BackendController into a large HTML string that was passed to Fluid. This commit resolves an open TODO and moves the rendering of the toolbar items to the Topbar partial. The data attribute `toolbar-identifier` is unused and therefore removed. Resolves: #98214 Releases: main Change-Id: I8fd0e65b9f30aaf27271be47d1b77ea7960d17ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75555 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Nikita Hovratov authored
With patch #97786 a bug was fixed, to only toggle inline controls in their own scope. For this a new helper class was introduced and added for vanilla inline controls. However, there are two other special inline control types for record selectors. Most commonly known from the FileSelector for FAL. The helper class is now added there as well. Resolves: #98233 Related: #97786 Releases: main, 11.5 Change-Id: Ifb2eb4205ecec50540a70943163c639f04de5ea1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75596 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Harry Glatz <glatz@analog.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Sep 01, 2022
-
-
Nikita Hovratov authored
Resolves: #98234 Related: #97462 Releases: main Change-Id: I415b289ce4cb889e5b6fb85e9fb0746aac771865 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75593 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Aug 30, 2022
-
-
Lina Wolf authored
Releases: main, 11.5 Resolves: #98219 Change-Id: Ib60a14ff4a80eb4333187d3eff4ebf2a0262383d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75559 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
linawolf authored
Replace the todo with information. Thanks at Florian Weiss for pointing this out and providing me with the screenshot Releases: main, 11.5 Resolves: #98215 Change-Id: Ia14e18ecd260ee9dfa98dae88aa68e8e7b4f1612 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75556 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Aug 28, 2022
-
-
Stefan Bürk authored
Symfony recently released new version v5.4.12 and v6.1.4 of the framework which contains a change in `symfony/mailer` throwing a TransportException and passing null as 2nd ($code) argument. This is deprecated since PHP8.1 and emits now a corresponding depcreaction warning in some circumenstances and breaking one mailer unit test. See: https://github.com/symfony/symfony/issues/47402 This change temporarly skips the test for PHP8.1 until the fix has been merged and released a new version by symfony. Resolves: #98216 Releases: main, 11.5 Change-Id: I12a18f425bd573e1943dddad909c7c3256c1fd87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75557 Tested-by:
-
- Aug 26, 2022
-
-
Stefan Bürk authored
Core php file header check got silently be disabled. Since then the one or other file header error has slipped into the core. It also pops up from time to time in reviews of patches that file headers are missing (or are wrong). This change ensures that file headers are checked again and can be fixed by given contributers the proper tools at hand. Changes: * add cglFixMyCommitFileHeader.(sh|bat) * add cglHeader and cglHeaderGit to runTests.sh along with proper help text * extend pre-commit hook to execute both fixer scripts side-by-side with error output and fixing possibility * fix minor issue with header comment php-cs-fixer config Additionally the cglHeader check is added to gitlab workflow pre-merge (commit files) and nightly (all files). Slipped in errors has been fixed with a dedicated change #98204. Resolves: #98203 Related: #98204 Releases: main Change-Id: I9567d1dcf8fb53d4901a575213c0ff16dc33ffd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75549 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Aug 25, 2022
-
-
Stefan Bürk authored
Automatic check of php file header has been silently disabled somewhere in the past, thus wrong file headers has slipped into the core. With #98203 this will be ensured again. To avoid making nightly core ci unhappy this change acts as pre-patch to streamline the file header issues. * add missing file headers * fix invalid file headers * move file headers to the right place Resolves: #98204 Related: #98203 Releases: main Change-Id: I37bf8e08fcab37f05352f2c315f4084b77211ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75550 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benjamin Franzke authored
Update (most) vulnerable dependencies/packages found by `npm audit fix --force --dry-run`. Notes redarding package changes: * The outdated grunt-postcss plugin is replaced by a (maintained) fork for compatibility with newer grunt versions. * karma is updated to v6 and pulls in @types/node which conflicts with TypeScript type definitions by @types/requirejs. Therefore 3rd party type declarations from packages (@types/*) are now explicitly enabled in tsconfig.json – note that there is no other way to exclude from typeRoots: https://github.com/microsoft/TypeScript/issues/18588 * grunt-lintspaces and grunt-contrib-imagemin are replaced as these packages have been not been updated to not depend on vulnerabe dependencies, while grunt-lintspaces and grunt-contrib-imagemin would cause downgrades to older version when running `npm audit fix --force` (because only the older versions do not depend on vulnerable software). * (grunt-contrib-)imagemin is replaced by squoosh (by google) as a) imagemin dependencies ("bin-build" > "download") rely on vulnerable versions of "got". Neither of these packages is currently updated,see https://github.com/kevva/download/issues/224 b) imagemin is unmaintained: https://github.com/imagemin/imagemin/issues/385 and suggests squoosh as replacement * stylefmt is replaced by a maintained fork. There is one remaining packages that pulls in a vulnerability alerts: * jquery-ui is marked as vulnerable (severity: high), but worked on in a separate patch #96497. (We don't actually use the vulnerable library parts though). Vulnerability report before this patch: 74 vulnerabilities (1 low, 30 moderate, 38 high, 5 critical) Vulnerability report after this patch: 1 high severity vulnerability (this is jquery-ui) Commands executed: # Supposed to be non breaking, but broke grunt-css npm audit fix npm remove grunt-postcss npm install @lodder/grunt-postcss # Preparation for `npm audit fix --force` (breaking changes) npm install grunt@^1.5 npm install grunt-lintspaces@^0.10.0 npm remove grunt-lintspaces npm install --save-dev lintspaces-cli npm remove grunt-contrib-imagemin npm install --save-dev npm remove stylefmt npm install --save-dev @ronilaukkarinen/stylefmt npm audit fix --force Releases: main Resolves: #98198 Change-Id: I09df87fe131a499790e6c5f95f1c51e9216b71c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75539 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Aug 24, 2022
-
-
Daniel Hettler authored
Properly guard array key access for "sheetTitle" in `\TYPO3\CMS\Backend\Form\Container\FlexFormTabsContainer->render()`. Resolves: #98201 Releases: main, 11.5 Change-Id: Iafa5fd4623d53501e655739d7aabc543d26ed216 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75546 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Oliver Bartsch authored
InlineControlContainer allows to add custom controls via a userFunc (hook). However, since the resultArray was not passed to the userFunc, e.g. no JS module could be added for the custom control. This is now fixed by passing the resultArray by reference to the userFunc. Resolves: #98199 Releases: main, 11.5 Change-Id: I404d2673a65bb40cf7f389fb5c0f7bec7dcd7c4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75543 Tested-by:
-
Tobias Jungmann authored
If a preview page is already open, clicking on the "view" button in the content editor window would not reload the page. That means, that the preview page would not show changes if the preview page url and the target url are similar (e.g. only differentiate in hash/query or are exactly the same). This patch looks if a window with the given windowName is already open (looking in `this.windows` did not work well because the existing windows aren't saved in a global context, yet) and compares the URL of an open window (if there's one) with the given URL. If the URLs are similiar (i.e. the origin and the path name are the same) the page will be reloaded. Resolves: #93706 Releases: main, 11.5 Change-Id: Ib3d9e49f56e6ef45df1cd7d82fa58dffb74a3750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75164 Tested-by:
-
Stefan Bürk authored
With #95819 the detection of Domain Object properties was changed to use ClassSchema in order to support uninitialized properties is models. This was not possible with `DomainObjectInterface::_getProperties()` which used `get_object_vars()` under the hood. However, with mentioned change, other properties which had been ignored by `get_object_vars()` were now propagated to persistence, even if those properties were not configured in TCA. The change in behavior is considered a regression and is now addressed: The retrieval of the property value is delayed until after it is ensured that the property is a persistable property (which asserts that we are not reading from private properties). Resolves: #98148 Related: #95819 Releases: main, 11.5 Change-Id: I94d41715a49953045d32361a00bc274c15112a1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75534 Reviewed-by:
theline <typo3@root-access.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Stefan Frömken authored
Releases: main Resolves: #98196 Change-Id: I55b2c082c96e580d345c32f04bc47d941e50425a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75540 Tested-by:
-
Torben Hansen authored
The constant `TODAYS_SPECIAL` has never been used in TYPO3 core and also 3rd party extensions in TER do not make use of it. The constant can therefore be removed safely from the class. Resolves: #98195 Releases: main Change-Id: I187817b2641d97c48832e757ad0de710e49ce31f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75538 Tested-by:
-
- Aug 23, 2022
-
-
Benjamin Franzke authored
Yarn has been added to TYPO3 back in 2017 because npm shrinkwrap files were not stable and package-lock.json and `npm ci` not yet established. By now the yarn version in TYPO3 (v1) got outdated and an update to yarn v3 would be required sooner or later. The update to yarn v3 brings quite some problems for the TYPO3 codebase: - Yarn v3 is executed/proxied through yarn v1 (installed on the developer machine) – therefore the yarn v3 executable needs to be tracked within git. See https://yarnpkg.com/cli/set/version#details - Yarn v3 pulls in @types/node (through the "got" package) for unknown reasons, causing clashes with TypeScript declarations for requirejs (window.require vs node's require()) As package-lock.json is solid thesedays, there is no real need to depend on yarn anymore. We basically switch to npm because that switch is way more straightforward than migrating to yarn v3 and it removes one dependency. Note that `npm install` properly honors `package-lock.json` these days (no implicit version upgrades due to the lock file), but is faster than `npm ci`, therefore it is used in `grunt build` and runTests.sh for all developer oriented build-targets. All CI checks use `npm ci` to enfore a clean install. We set the required npm verson to v8 in order to use the newest package-lock.json v3 format and .nvmrc is updated to suggest the recent nodejs v16 LTS release, as npm v8 is shipped with nodejs v16 by default. Note that node v14 may still be used to compile packages, but npm v8 is needed for dependency installation (installable via `npm install -g npm` in node v14 installations). For that reason the CI docker images are updated to use nodejs v16 instead of nodejs v14, see following ticket for details: https://git.typo3.org/typo3/CI/testing-infrastructure/-/issues/3 Executed Commands: cd Build/ # be sure the node_modules folder dir and is updated yarn install sed -i 's/"yarn": "^1.22.0"/"npm": ">=8.0.0 <9.0.0"/' package.json rm -f package-lock.json # npm install >= v7 can read yarn.lock and will create # package-lock.json as a result npm install git add package-lock.json git rm -f yarn.lock npm remove "jquery-ui" # The use of `git@` in the HTTPS URLs is a workaround for NPM's # auto-rewrite that results in an SSH URL being used instead, # which fails to install in CI. # See npm/cli#2610 for more information. npm install "git+https://git@github.com/jquery/jquery-ui#1.11.4" # Fix fsevents not being installed npm install rollup@~2.32.0 # Explicitly pull in popperjs which would be included by npm's # resolver in npm >8.5 npm install @popperjs/core@^2.11.6 # Let npm build a new, fully clean tree, without old yarn cruft rm -rf node_modules/ npm install grunt default Resolves: #96355 Related: #83038 Releases: main Change-Id: I88c1ecb1b12dcd117ac4200307af72d330c76d27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72642 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Aug 22, 2022
-
-
Kevin Appelt authored
The check if the image has to be processed has been moved to dedicated methods to enhance readability and testability The condition still checks if the image is wider than the defined maximum width. The check if the entire image is used should now be easier to understand. No offset and 100% of the width and height of the image correspond to the full image and negated in its entirety. Resolves: #98118 Releases: main, 11.5 Change-Id: I8283e2f74310654455fb247e84c9e4204f3e1dd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75422 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Oliver Hader authored
Avoid undefined array key warning in case 'config' is not given in TypoScript settings. Resolves: #98145 Releases: main, 11.5 Change-Id: I20df94bd34f9f7197eee7905f5aa1c2af35d0601 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75529 Tested-by:
-
- Aug 21, 2022
-
-
Peter Kraume authored
Resolves: #98183 Releases: main, 11.5 Change-Id: Ib4d123e86a9b158b86e20322fc53ca94ff5b9be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75525 Tested-by:
Thomas Löffler <loeffler@spooner-web.de> Reviewed-by:
-
- Aug 19, 2022
-
-
Andreas Fernandez authored
Previous TYPO3 installations allowed to configure an interface selector in the backend login that gave the authenticating backend user the possibility to choose whether to get redirected to frontend or backend by configuring `$GLOBALS['TYPO3_CONF_VARS']['BE']['interfaces'] = 'backend,frontend'`. If only one option was configured, the redirect to either backend or frontend was enforced, where `backend` was the default configuration. This feature was meaningful once TYPO3 shipped EXT:feedit, but was conceptually broken ever since, as the matter of fact a TYPO3 installation can contain multiple site roots was overseen and a user may get redirected to the wrong frontend. Also, if EXT:adminpanel is not installed, there is no one-click solution to access the TYPO3 backend. Resolves: #98179 Releases: main Change-Id: Ic759e6c1016d70c07dc8862a0b8c21b14c3d904b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75487 Tested-by:
-
Andreas Fernandez authored
If a record is edited via single field mode (aka "columnsOnly"), the label field as defined via TCA may be missing, rendering "[No title]" in the notification message. Before compiling the notification message, it is now checked whether the label exists already. If not, the label of the record is fetched from the database, if such label field is configured via TCA at all. Resolves: #98142 Releases: main Change-Id: I2babfcae354b1fad15c653e61449353cd2efb8a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75443 Tested-by:
-
Chris Müller authored
If either labels or base are not given, the default values kick in: labels = iec and base = 1024 With the new fallback values in place test ContentObjectRendererTest notAllStdWrapProcessorsAreCallableWithEmptyConfiguration() needs a minor adaption. Resolves: #98154 Releases: main, 11.5 Change-Id: Ib2a242454197be94a75fb3d5bffbb8d0be8a1523 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75484 Tested-by:
-
Andreas Fernandez authored
The context menu module now passes the dataset bound to a context menu item to the respective callback action, excluding `callback-action` and `callback-module`. The context menu items bound to `this` in the respective callback actions are not required anymore, allowing to ditch jQuery in the `context-menu-actions` modules. For this reason, binding the context menu item to `this` is deprecated, usages will trigger a deprecation log entry in the browser's console. Resolves: #98168 Releases: main Change-Id: Ibaf3c5b343323dcd29bd9aae3212ebcee91d83ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75491 Tested-by:
-
Andreas Fernandez authored
The patches #98164 and #98165 conflicted with each other as one made the modal API stricter while the other populated the modal with a soon-to-be invalid configuration. This currently breaks all subsequent builds. The modals received objects of type `Node` which are not consumable by jQuery's `append()` method. To solve this issue, `Node` is now converted to a `DocumentFragment`, which can be consumed by all involved parties. Resolves: #98177 Related: #98164 Related: #98165 Releases: main Change-Id: I4524b383e559d3b1342c0bf95e435caec6d36cc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75517 Tested-by:
-
Larry Garfield authored
Doing so allows us to remove an unnecessary test, as well. 'mixed' type declarations not included to allow backporting. Used command: > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98027 Releases: main Change-Id: I3c499e557c5d5bc31bf471e577760f4268fa26cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75295 Tested-by:
-
Torben Hansen authored
This patch fixes a warning on PHP 8.1, when a FlexForm has a sheet with no fields in it. Resolves: #98166 Releases: main, 11.5 Change-Id: Iec814a10bb755fb78a8de95b432d8cb6042a07d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75490 Tested-by:
-
Andreas Fernandez authored
Two usages of jQuery are removed in EXT:dashboard. jQuery was only used to convert a string containing HTML to a jQuery object to be able to render markup in the DOM. Resolves: #98165 Releases: main Change-Id: I54c1f6f2a99a7ccfe63c95e5b2ab84afc7451ff9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75489 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Andreas Fernandez authored
The configuration definition of `content` in the Modal API is extended to accept objects of types `Element` and `DocumentFragment` as well, which allows passing arbitrary DOM nodes to the API, if TypeScript is used. Since jQuery is still the main actor in the Modal API, no further adjustments are required for now as jQuery can consume the added types. In the same run, the API definition got stricter as `Modal.advanced()` allowed to pass any arbitrary configuration not covered by the internal `Configuration` interface. Resolves: #98164 Releases: main, 11.5 Change-Id: Ibf7cc836fcffa870a1eb4c5d4615c44e046cf192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75488 Tested-by:
-
- Aug 17, 2022
-
-
Benni Mack authored
This change raises the used Symfony Components to at least version Symfony 6.1. The requirement for "typo3/symfony-psr-event-dispatcher-adapter" is removed, as this was for support for allowing symfony4 AND symfony5 with the same TYPO3 major version. A few important highlights: * Symfony DI now only accepts objects or null to be returned by $container->get('myService') * Lots of typehints were added, this is mainly an issue if extensions extend Symfony classes * PHP 8.1+ requirements (which we already have in place for TYPO3 v12) See all features within Symfony 6.1: * https://symfony.com/blog/category/living-on-the-edge/6.1 Symfony 6 is supported until November 2027 (once we upgrade to Symfony 6 LTS, which will happen in November 2023) unlike Symfony 5 LTS which has an EOL on November 2025. Used commands: > composer req composer/composer:^2.3.0 -W --dev > composer remove typo3/symfony-psr-event-dispatcher-adapter > composer remove --no-update -d typo3/sysext/core \ typo3/symfony-psr-event-dispatcher-adapter > composer req --no-update -d typo3/sysext/adminpanel \ symfony/var-dumper:^6.1 > composer req --no-update -d typo3/sysext/core \ psr/container:^2.0 \ symfony/config:^6.1 \ symfony/console:^6.1 \ symfony/dependency-injection:^6.1 \ symfony/event-dispatcher-contracts:^3.1 \ symfony/expression-language:^6.1 \ symfony/filesystem:^6.1 \ symfony/finder:^6.1 \ symfony/http-foundation:^6.1 \ symfony/mailer:^6.1 \ symfony/mime:^6.1 \ symfony/options-resolver:^6.1 \ symfony/rate-limiter:^6.1 \ symfony/routing:^6.1 \ symfony/yaml:^6.1 > composer req --no-update -d typo3/sysext/extbase \ symfony/dependency-injection:^6.1 \ symfony/property-access:^6.1 \ symfony/property-info:^6.1 > composer req --no-update -d typo3/sysext/fluid \ symfony/dependency-injection:^6.1 > composer req --no-update -d typo3/sysext/form \ symfony/expression-language:^6.1 > composer req --no-update -d typo3/sysext/install \ symfony/finder:^6.1 \ symfony/http-foundation:^6.1 > composer req --no-update -d typo3/sysext/redirects \ symfony/console:^6.1 > composer req -W \ psr/container:^2.0 \ symfony/config:^6.1 \ symfony/console:^6.1 \ symfony/dependency-injection:^6.1 \ symfony/event-dispatcher-contracts:^3.1 \ symfony/expression-language:^6.1 \ symfony/filesystem:^6.1 \ symfony/finder:^6.1 \ symfony/http-foundation:^6.1 \ symfony/mailer:^6.1 \ symfony/mime:^6.1 \ symfony/options-resolver:^6.1 \ symfony/property-access:^6.1 \ symfony/property-info:^6.1 \ symfony/rate-limiter:^6.1 \ symfony/routing:^6.1 \ symfony/var-dumper:^6.1 \ symfony/yaml:^6.1 Resolves: #98158 Releases: main Change-Id: Ibfa656fb499003405d1c2cb49570e735698b6a6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75427 Tested-by: -
Torben Hansen authored
Since ext:felogin already uses strict type declarations for function arguments and return types, various parameter- and return-type declarations in PHPDoc comments can safely be removed. With this patch the following changes are applied: * removed superfluous @param type declarations * removed superfluous @return declarations * removed non-thrown @throws annotations * added missing function type declarations in tests Used command: > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98139 Releases: main, 11.5 Change-Id: I47749a748e808f6801928951397ed0bff8d6a115 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75439 Tested-by:
-
Torben Hansen authored
Since the demand object already uses strict types, it is safe to use strict comparison when properties of the demand object are used as operand. Resolves: #98141 Releases: main Change-Id: I6741c022f9d382416be6cab034d793fedfa35477 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75441 Tested-by:
-
Andreas Fernandez authored
This patch aims to remove jQuery from the TYPO3 backend login. Since some jQuery magic was used to dynamically adjust the height of the carousel with a nice animation, which is not so easy to solve in pure CSS and JavaScript, the carousel now has a fixed height. To make the approach a little bit more appealing and usable for mobile users who usually don't see a scrollbar, the top and bottom area of the carousel container are faded if text is overflown to indicate a scrollable area. To make sliding to the next slide in the carousel less "jumpy", smooth scrolling is explicitly enabled here. Resolves: #98157 Releases: main Change-Id: I08ecd847d29696fd25f6330cee089a55a03102c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75473 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in AbstractItemProvider Resolves: #98151 Releases: main, 11.5 Change-Id: Ic74ec7771be077aa5e6a84e8db3310fc895dcc02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75476 Reviewed-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in extbase Backend class. Resolves: #98149 Releases: main, 11.5 Change-Id: I6f32f67672332758cc02708d07481b93edb09b82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75474 Reviewed-by:
-
Tomasz Woldański authored
Patch fixes warning on PHP 8.1 in MenuProcessor Resolves: #98150 Releases: main, 11.5 Change-Id: I9cee1d6d0adcde22a74e040ac53657db3348c514 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75475 Reviewed-by:
-
Torben Hansen authored
When a FlexForm has an empty data structure, a warning is thrown in PHP8, because it is not checked in FlexFormNoTabsContainer if the resolved sheet name actually exists as key in the flexFormRowData array. This patch uses the null coalescing operator to fix the problem. Resolves: #98147 Releases: main, 11.5 Change-Id: Ie4bde3af79a9a473cc02aff9f1ec299fff1bc259 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75448 Tested-by:
-
Christian Kuhn authored
Workspace backend module: With #94935 the "Entire workspace" mass drop down has been placed more prominently by moving it to the first position in the action drop down row. The "Entire workspace" action publishes *all* pending workspace changes of *all* pages at once. Depending on use case, this can be dangerous: There are cases where a workspace is used to prepare a small amount of changes, to then publish everything at once. This is fine. There are also use cases where editors use one big workspace to prepare distinct changes in multiple pages and then publish single pages only. In the latter case, accidently using the "Publish absolutely everything" drop down will publish lots of unwanted changes. To mitigate this risk, admins get a new toggle in the workspace 'publish_access' field of workspace records to hide the "Entire workspace" action drop down of this workspace when checked. Resolves: #98155 Related: #94935 Related: #96468 Releases: main, 11.5 Change-Id: Ia55bf509df17842ad1f6c5fdea031fb633419f08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75478 Tested-by:
Claus-Peter Eberwein <claus-peter.eberwein@b13.com> Tested-by:
-
Chris Müller authored
With #98090 TYPO3_CONF_VARS['SYS']['UTF8filesystem'] was set to true for new installations. This should also be documented in the changelog. Resolves: #98144 Related: #98090 Releases: main Change-Id: Ia18c0347c745967586a47ff5167327bac283051e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75445 Tested-by:
-
- Aug 16, 2022
-
-
Benni Mack authored
Backend modules which use absolute paths (which do not exist) should not raise an exception / error when using versionNumberInFilename checks. This happens e.g. with EXT:solr backend modules since #97939 was fixed. In the long-term extensions should define proper paths, so they also work in TYPO3 installations within a subfolder but for the time being, this change helps to solve the problem. Resolves: #98152 Related: #98106 Related: #97939 Releases: main, 11.5, 10.4 Change-Id: I071f2e63d4423d157f0f060a1295cb145474ee9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75477 Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
-
- Aug 15, 2022
-
-
Elias Häußler authored
With #93887 (respectively #92406), a more convenient rendering mechanism for forms was introduced. A new FormRequestHandler centralized all the logic from the <formvh:render> view helper to allow smoother form handling. However, the new implementation used to hide the current ContentObjectRenderer implementation and instead always fetched a new instance with GeneralUtility::makeInstance(). This no longer allows to determine the current content object rendering context from e.g. form finishers. Since the current implementation can be retrieved by the ConfigurationManager, it is now used in the <formvh:render> view helper, falling back to a new ContentObjectRenderer instance in case the ConfigurationManager does not actually provide an instance of ContentObjectRenderer. Resolves: #97977 Related: #93887 Related: #92406 Releases: main, 11.5 Change-Id: Iabf4e93e6aff8da742321958730521ef1696f130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75247 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
-
