- Mar 01, 2023
-
-
Oliver Bartsch authored
Resolves: #100054 Releases: main Change-Id: I820853416f953b2d34080e517ada6748ce684143 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77995 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Markus Friedrich authored
FrontendRestrictionContainer supports the usage of a local Context, but isn't passing the frontend group settings to the FrontendGroupRestriction. This commit extends the FrontendRestrictionContainer and ensures the frontend groups from the local environment are passed, improving the possibility to use simulated environments. Resolves: #100023 Releases: main, 11.5 Change-Id: Ie43911cce244acd6bbed54dd56d7d74f6fd24466 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77940 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
After just a couple of years streamlining the core request handling, we finally have no non-deprecated usages to GeneralUtility::_GP() anymore and can happily deprecate it. Resolves: #100053 Related: #99615 Related: #99633 Releases: main Change-Id: Ib1acb97b5fd8e66aa3bcc285b01a93f31964c0cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77990 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Thomas Hohn authored
The method getFileContents has return type string. However it contains a call to file_get_contents, that can return a boolean in case of failure. Added a check for if the file is readable and a cast to string when returning the value of the call to file_get_contents. In case of failure it will return the empty string, which will be caught properly in the method loadAndParse. Afterwards the error handling could be improved in loadAndParse to be more specific. Resolves: #100048 Releases: main, 11.5 Change-Id: Icf72332cdc2429318692682bf23e6d230109bdb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77984 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
The internal property $this->checkSimilar is always true and never set differently. It can be removed from the codebase. Resolves: #100052 Releases: main Change-Id: I8c224d91f8866822d64e5a1b0de136ba256d6072 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77988 Tested-by:
-
Thomas Hohn authored
The method getFileContents has return value string. But since there is no guarantee that the file exists before calling file_get_contents, a call to is_readable has been added. This handles both the PHP Warning and ensures type correctness. Resolves: #99926 Releases: main, 11.5 Change-Id: I9786a6737d7e3b0c3d04272364d868fd4101307c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77978 Reviewed-by:
JAKOTA Design Group GmbH <suchowski@jakota.de>
-
Andreas Fernandez authored
The option dropdown in LiveSearch now has a counter indicating the number of active search options. Resolves: #100017 Releases: main Change-Id: I252c699dcb17318ccfcaa622d69b0ffd6ccf1901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77935 Tested-by:
-
Christian Kuhn authored
The TypoScript condition matching and our symfony expression language handling is a heavily convoluted mess: The entire API tends to fetch lots of global state, the classes are complex, hard to understand and handle, over-abstracted and full of anti-patterns. The patch aims to mitigate this. The main strategy is to provide relevant data from within callers directly instead of fetching globals TYPO3_REQUEST, calling GeneralUtility::_GP() and GeneralUtility::getIndpEnv(). * For TypoScript 'condition' expression handler usages, the frontend/backend related ConditionMatcher classes are obsoleted. The IncludeTreeConditionMatcherVisitor class within the new TypoScript parser is now the construct that prepares TypoScript relevant variables to initialize the symfony expression language construct, and gets variables actively hand over. * The default provider now prepares variables from state that can be injected, the entire ProviderInterface no longer relies on runtime state from globals. * Access to runtime Request object is streamlined: Especially PageTsConfig and UserTsConfig can not rely on a given request object since the DataHandler uses this a well, which denies systematic usage of request related data. This is deprecated. * The ProviderInterface config handling should still be streamlined towards a symfony service provider approach. The current solution is kept for now, an @todo is added to briefly outline on how this should be changed in v13 as a breaking change. * Note this patch avoids the last core usage of GeneralUtility::_GP() which will be deprecated with another patch. Additionally, a hard to fix call to GeneralUtility::getIndpEnv() is avoided. Change-Id: I476b69776e950a5a7e5ed937d2e2c58fe00f133f Resolves: #100047 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77981 Tested-by:
-
Benni Mack authored
With TYPO3 v9 and site handling, and speaking URLs that are supported in workspaces, there is no technical reason to avoid POST requests in Workspaces. This limitation was added by Kasper in TYPO3 v4.0 in the infamous "tslib_fe" class, whereas the current code base is much more structured and we can now safely say, that we have Cookie handling and POST requests under control via Site Handling, and middlewares. This way, forms can be tested and submitted in Workspace previews. Resolves: #100051 Releases: main, 11.5 Change-Id: I5ed6afd2384ef685453034f852373bb6e073c974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77974 Reviewed-by:
-
Jochen Roth authored
Currently it's possible to set the cropping to 0x0 in size. This leads to an error. This has been fixed by setting a minimal required width/height for the cropping. Resolves: #99943 Releases: main, 11.5 Change-Id: I3b6af446c3bfb02c1f752e0e721f63920fa94c5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77858 Tested-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Andreas Fernandez authored
DataHandler has an internal check that compares the sent payload with the state of the affected database record and removes fields from the payload that didn't change. Everytime a database record is updated, DataHandler resets the internal stage to "0" to start a new editing workflow, if the affected database table supports workspaces. This handling is unfortunately executed *after* the payload comparison is done, leading to a payload that always instructs to update the field `t3ver_stage`, even if the change is not necessary, leading to superfluous database updates. This has a massive negative performance impact in simple shared hosting environments, especially with tt_content records that have many file references attached. The payload comparison is now executed after setting `t3ver_stage` to filter out superfluous updates. Resolves: #100035 Releases: main, 11.5 Change-Id: Ie0e29f7efe8d6289849bf117fbc852108fac1dd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77948 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Add return type hints to the IP comparison related methods in GeneralUtility. Resolves: #100050 Releases: main Change-Id: Idcca71236341dc1fe789bae9e9e14d6e8835fac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77986 Tested-by:
-
Alexander Schnitzler authored
After extbase's repository interface and classes received support for phpstan generics, the rest of the persistence related classes also support phpstan generics: - QueryInterface and Query - QueryResultInterface and QueryResult - Otherwise involved classes like factories and data mappers Releases: main Resolves: #99945 Change-Id: Id371cde3ef5d4987f1d1971e6476e63728d8d55f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77846 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
- Feb 28, 2023
-
-
Simon Schaufelberger authored
Matomo comes with some custom tracking parameters which should be excluded from cHash generation by default. Previously they were prefixed with pk_ from Piwik but with the name change, new parameters have been introduced. Matomo tracking parameters in default instance: mtm_campaign, mtm_keyword Resolves: #99999 Releases: main, 11.5, 10.4 Change-Id: I17cf6c7071f378bd9a439628036d19f265dc19d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77947 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Josef Glatz authored
This patch adds correct wording for the clipboard section of the list module. Clipboard entries are called "elements". Along with "Copy elements" and "Move elements", the remaining buttons must also be named identically to improve the user interface in this area. Therefore the button to remove a single element from clipboard is named from "Remove item" to "Remove element". Resolves: #100044 Releases: main Change-Id: I872d0851d3d11359e454e33cfb1670233d335058 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77979 Tested-by:
-
Oliver Bartsch authored
This prevents an exception on logging into the install tool by adding a factory method to allow injecting the new MailerInterface into the AuthenticationService. Resolves: #99990 Related: #97747 Releases: main Change-Id: I73a796cdd121a4d5fef27c6aa4c4d1a1882287ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77900 Reviewed-by:
-
- Feb 27, 2023
-
-
Thomas Hohn authored
Added Null coalescing operator, when value of $row['uid'] and $row['pid'] is accessed in getRecordOverlay to avoid PHP warning. Resolves: #99993 Releases: main, 11.5 Change-Id: Ia5b9983f6679001734b81bbd4a56d697bb3ce454 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77907 Tested-by:
-
Thomas Hohn authored
Added a missing else case in getImageDimensions when image size can't be determined. Return null instead of a boolean. Resolves: #99998 Releases: main, 11.5 Change-Id: Idfe6bf49612392f66f1c3c60a47f2c463c6eb4ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77913 Tested-by:
-
Andreas Fernandez authored
The JavaScript module `autosize` used to automatically change a textarea size is updated to version 6.0. This version brings ECMAScript modules, therefore the build chain is adapted. Resolves: #99981 Releases: main Change-Id: I88c1fff83b9e4fb11be8cbef55711433d4701451 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77888 Tested-by:
-
Thomas Hohn authored
If $elementUid is 0 in ElementHistoryController::getEditLockFromElement it must be handled seperatly since the call to BackendUtility::getRecord will return null. Resolves: #100000 Releases: main, 11.5 Change-Id: Ib53a5d06cbb098b9548a8293337b365d768d8fa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77914 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #100039 Related: #97013 Releases: main Change-Id: I9899ebddee90b971015d242773ad83d4695e7b2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77972 Reviewed-by:
-
Thomas Hohn authored
Fix the misspelling of cancleButton to cancelButton. Resolves: #99991 Releases: main Change-Id: I98666f34cc11d8614ada68d483d5af014772838a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77912 Reviewed-by:
-
Chris Müller authored
Resolves: #100015 Related: #97454 Releases: main Change-Id: I479b8d22fb08575bebde220a6b67ce1c2d4654cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77933 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Torben Hansen authored
The rarely used and undocumented configuration declarations * `$GLOBALS['TBE_STYLES']['stylesheet']` * `$GLOBALS['TBE_STYLES']['stylesheet2']` have been added with Kasper's "Initial revision" in 2003 and are problematic, when two extensions use the same configuration declaration. Since TYPO3 4.4 it is possible to include CSS stylesheets for the TYPO3 backend using a custom skin configuration as shown below: `$GLOBALS['TBE_STYLES']['skins']['my_extension']['stylesheetDirectories'][]` The configuration declarations `$GLOBALS['TBE_STYLES']['stylesheet']` and `$GLOBALS['TBE_STYLES']['stylesheet2']` have therefore been marked as deprecated and will be removed in TYPO3 13. Resolves: #100033 Releases: main Signed-off-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Georg Ringer authored
Showing the result count can help users to understand the quality of the search query. Additionally the example is changed to work out of the box. Resolves: #100029 Releases: main Change-Id: I8460e24af2ea86dd5cf711c9b34768628d81e1c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77944 Reviewed-by:
Thomas Hohn <tho@gyldendal.dk> Reviewed-by:
-
- Feb 25, 2023
-
-
Benjamin Kott authored
This patch enables drag-and-drop for resources within the file list. It is now possible to transfer files and folders with drag operations to folders visible in the current view. Resolves: #100027 Releases: main Change-Id: Ie46e68e637dad69ae2a49e0b8d80c5bc91b39fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77931 Reviewed-by:
-
calien666 authored
This change ensures that the original language record diff source (usually in the field l10n_diffsource as configured by transOrigDiffSourceField) is set correctly as soon as a localized record is created. To guard this, an additional test for pages is added, and several DataHandler tests are adjusted. TYPO3 displays the source language value of a field for a translated record. This information field can display a diff, if the source record value was changed. To accomplish this a shadow copy of localizable fields from the source language record is saved in the configurable language diff source field. Localization of a record creates a new record, adding the values of localizable fields value with a prefix and setting needed system fields like parent record id, language id and so on. This is updated if a localized field is changed in the localized language. `\TYPO3\CMS\Core\DataHandling\DataHandler` as the main actor in the backend is responsible for maintaining this source diff field along with other tasks. Due to an oversight, the source language record data was not set during record localization. Because of this, the field source display did not work until the localized record was saved again. This probably went undetected because in normal editorial work the record would be changed straight away. Extension authors using DataHandler hooks can influence which data is written, for example using translation tools and databases to localize records automatically during the translation process. Therefore, it is not really mandatory to change the value afterwards. In the past, that practice lead to a broken and invalid source diff field. The issue existed for pages and other records in the same way. Resolves: #99985 Releases: main, 11.5 Change-Id: I47d5262dfbcaaa1fa5108e950308f72319c41b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77895 Tested-by:
-
- Feb 24, 2023
-
-
Thomas Hohn authored
Added a coalescing operator before accessing the value of $wrapper['showResultsNumbersWrap']. Resolves: #100024 Releases: main, 11.5 Change-Id: I166d8e300cc931f8d1788ef19954b55eab66f7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77942 Tested-by:
-
Thomas Hohn authored
Added string cast before trimming $typoLink. Changed annotation to be string|null. With TYPO3 v13 string should be added to the methods signature and cast removed. In addition fixed some potential calls that could have sent null to the method, prophylactically. Resolves: #99975 Releases: main, 11.5 Change-Id: I8cbafa51d96e3ab35d39855831803897b4ff0035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77887 Tested-by:
Marc Willmann <mw@f7.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
-
Benjamin Kott authored
This patch drops the dedicated resource rename view and moves it to a modal view instead. Resolves: #100001 Releases: main Change-Id: I9d0ca07ddb6cdfda72cb9aaf15a6a0d52e543d35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77849 Reviewed-by:
-
Thomas Hohn authored
In the method getWordPairsForLineBreak, there is a missing coalescing operator around $wordsArray[$index + 1]. In the last iteration for uneven values of $wordsCount it will be undefined. Resolves: #100006 Releases: main, 11.5 Change-Id: I624bf444b10a595c99bfc0cd19cd4f72692155cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77924 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Feb 23, 2023
-
-
Andreas Fernandez authored
The eslint plugins `eslint-plugin-lit` and `eslint-plugin-wc` are installed and configured to help avoiding common issues when developing web components. These rules already revealed issues in our codebase that are now fixed. The most important ones are listed below: `lit/no-native-attributes`: Using native HTML attributes as web component attributes may cause side-effects, like `title` which renders a tooltip on hover. `lit/prefer-nothing`: It's preferred to return `nothing` instead of empty templates for performance reasons. `wc/require-listener-teardown`: To avoid memory leaks, any attached event listener in a web component must be detached again once the element is destroyed. Resolves: #100018 Releases: main Change-Id: I4a1197d5ca741a5683b4d21f84a87bdaf43241db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77937 Tested-by:
-
Markus Klein authored
Move the file_exists checks around to execute those only if really needed. The bootstrap methods are executed whenever the Core does any action, so its footprint should be as slim as possible. Resolves: #100013 Related: #99744 Releases: main Change-Id: I7d947c5d5b5aab52fec2610a7e6f9a030d1080c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77929 Tested-by:
-
Markus Klein authored
If, for whatever reason, the avatar image is not available, its publicUrl is null. This value can't be processed in the avatar environment. Resolves: #100020 Releases: main, 11.5 Change-Id: I111ec90af23208c69d76eac6ff17ad05db0d687f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77938 Tested-by:
-
Benjamin Kott authored
Resolves: #99983 Releases: main Change-Id: I160292295b0be648c1882bd58a5e504a1d10e5d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77892 Reviewed-by:
-
Thomas Hohn authored
Only set X-Mailer header if not already set. Resolves: #100016 Releases: main, 11.5 Change-Id: I78b1fcc6769420ccfd3f6a31cdf73374a0805c45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77934 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #99994 Releases: main, 11.5 Change-Id: I82955eae0675820355798df99e698db692f7d8ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77932 Reviewed-by:
-
Andreas Fernandez authored
The configuration for interactjs used in the page module is adjusted to allow dragging only with a content element's header as previously done in TYPO3 <12. Resolves: #99313 Releases: main Change-Id: I77d421fd541f3a46548d50bd89173b7f43fb08a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77918 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #100014 Releases: main Change-Id: If42d5b06fb239f9c3c69316d381d2323dfe64d91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77930 Tested-by:
-
Oliver Hader authored
Using an HTTP header like `Cookie: 1=string` results in having a numeric key in the super-global $_COOKIE array. Resolves: #100012 Releases: main Change-Id: Ie50d8176e48796ef46dfd79d328c7ccd75a03ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77927 Tested-by:
-
