- Nov 02, 2023
-
-
Timon Grützmacher authored
Releases: main Resolves: #102306 Change-Id: I4c12548d08efdfcfe7ba57ea55e2c56a3ceba8ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81648 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Even though ResourceCompressor is not used in BE context anymore, the check for HTML5 doctype is now based on PageRenderer instead of TSFE as it is available as a singleton and not as a global dependency. In addition, this reduces a cross-dependency between EXT:frontend and EXT:core. Introducing DI etc. for ResourceCompressor can follow at a later stage. Resolves: #102297 Releases: main Change-Id: I45c73e59456552e35bfa700990124d45389edb09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81636 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Jasmina Ließmann authored
> composer update --lock > Build/Scripts/runTests.sh -s buildJavascript > Build/Scripts/runTests.sh -s buildCss Resolves: #102235 Releases: main Change-Id: I02edf44492e742cebaed8900b9cdfc006389820d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81511 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Benjamin Franzke authored
Commands executed: mkdir -p tmp git clone https://github.com/TYPO3/styleguide tmp/styleguide cat <<EOT > tmp/replacements.txt regex:(\[[A-Z]+\])==>\1 styleguide: regex:(\[[A-Z]+\].*) \(#([0-9]+)\)==>\1\n\nhttps://github.com/TYPO3-CMS/styleguide/pull/\2 regex: #([0-9]+)==> https://github.com/TYPO3-CMS/styleguide/issues/\1 EOT cd tmp/styleguide git checkout -b main-moved git filter-repo --to-subdirectory-filter typo3/sysext/styleguide --replace-message ../replacements.txt --refs main-moved --force cd ../.. git remote add -f styleguide tmp/styleguide git fetch styleguide git merge --allow-unrelated-histories styleguide/main-moved Releases: main Resolves: #102235 Change-Id: I205b8397e748a0c84d99868664b4d0dd8c5fa99c
-
Benni Mack authored
This change the concept of the Processed File API, which was introduced back in TYPO3 v6 in 2012 (commit #66c204f0), and was almost not touched since then. The "TaskInterface" was hardly extended for purposes other than "ImagePreview" (BE) and "ImageCropScaleMask" (FE). In order to accommodate for what is / was useful in the past years, the TaskInterface's interface signature was adapted, next to typed methods and arguments, the method "sanitizeConfiguration" is added, allowing to reduce logic in the "LocalPreviewHelper". The AbstractGraphicalTask was removed as it extended from AbstractTask and had little value over the concrete implementations, and wasn't even abstract. The AbstractTask now has two abstract methods "getName" and "getType" in order to be extended in its subclasses. All in all, the main goal for this patch is to make the structure of this functionality easier to understand: * A task holds the configuration of a file * A ProcessedFile object is the instance of a file that was or is about to be processed file * A processor can be used to do the actual action Resolves: #102165 Releases: main Change-Id: Ica3ffcfc9c2fee5b5344f5e8b968989fd4371eb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81618 Reviewed-by:
-
-
- Nov 01, 2023
-
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/475 As a last patch in styleguide standalone repo before monorepo merge, we remove the CI infrastructure since it will be handled by core monorepo.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/474 Styleguide is not API.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/473 Gives that .css file a more unique name indicating it belongs to ext:styleguide.
-
-
Christian Kuhn authored
When ext:styleguide is merged into core monorepo, there will be no more "casual" extensions in typo3conf/ext. The "Scan extension files" check in the install tool is then grayed out. The acceptance test working on this is marked skipped for now. Resolves: #102301 Related: #102235 Releases: main Change-Id: I1f20406c7829587b7218e55f41d10f7d9ddf3e4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81641 Reviewed-by:
-
Benjamin Franzke authored
https://github.com/TYPO3-CMS/styleguide/pull/471 Use thje common-js file suffix as preparation for the merge into typo3/typo3 where all .js files need .ts (TypeScript) counterpart.
-
Christian Kuhn authored
ext:styleguide is a main module in the 'system' section now. An acceptance test has to be adapted. > composer u typo3/cms-styleguide Resolves: #102300 Releases: main Change-Id: I0b15d261a65e9fe320db3e2565bb72f610b85a17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81640 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/470 Move header comment to correct position.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/469 The third argument on SystemEnvironmentBuilder::run() is obsolete.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/468 Update a series of files that are executable but shouldn't.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/467 The core monorepo runs tests based on styleguide data. The acceptance tests of the backend module will fail when styleguide is merged into core monorepo since the backend acceptance test setup creates styleguide data already. We'll remove the ac test together with a related functional test for now.
-
Jasmina Ließmann authored
https://github.com/TYPO3-CMS/styleguide/pull/466 Update backend labels shown in "About TYPO3 CMS" module. Move backend module to group "System".
-
- Oct 31, 2023
-
-
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/464 Have a unique BE css id to restrict any declared CSS to the styleguide module.
-
Benjamin Franzke authored
AjaxRequest uses an own AbortController instance in order to provide the abort() method. It therefore passes the corresponding AbortSignal instance as a forced option to fetch(), and overwrites any custom signal that is passed as request options. In order to support custom AbortSignal's passed as fetch option, the abort event of the custom AbortSignal is now forwarded to the internal AbortController instance. Resolves: #102286 Releases: main, 12.4 Change-Id: I8011c1794acc22a6d9d2e874a02c1a8c97e532dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81597 Tested-by:
-
Benni Mack authored
Since PHP 8.1, GDImage can create lossless webp images. However, in #102177 this wasn't checked for properly. This change adapts the RST and also fixes some minor documentation parts. Resolves: #102293 Related: #102177 Releases: main Change-Id: Ib0799429b4b23f6904cac768b53cb9b4f3b24655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81619 Reviewed-by:
-
Benjamin Franzke authored
Lit v3 is a new major release and contains breaking changes, but they do not affect us: It mainly drops IE11 support (which we already dropped) and switches to ES2021 modules (which we already use as well): https://lit.dev/blog/2023-10-10-lit-3.0/#breaking-changes npm install --save \ lit@^3.0 \ lit-html@^3.0 \ lit-element@^4.0 \ @lit/reactive-element@^2.0 npm run build Resolves: #101515 Releases: main, 12.4 Change-Id: I83878b0f78fb42d737f28c5c338759e1869b0181 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80289 Reviewed-by:
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to the latest version and fixes one quirk in our code in order to make our nightly test runs happy again. Executed command: composer require --dev phpstan/phpstan:^1.10.40 -W Resolves: #102294 Releases: main, 12.4 Change-Id: I22b691fbdab5a17cf1328b7613d9c97a98eae861 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81632 Tested-by:
-
- Oct 30, 2023
-
-
Jasmina Ließmann authored
-
-
Christian Kuhn authored
-
Jasmina Ließmann authored
-
Benjamin Franzke authored
Use a string literal to automatically apply escaping to variables via selector``. The is essentially a formatted string with integrated escaping. Resolves: #102207 Releases: main, 12.4 Change-Id: Ieaa45e2efc8c14812ab281ca14b4a0a09cfc957b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81477 Tested-by:
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/460 Shorten README.md to relevant text valid when styleguide is merged into core monorepo. Also remove the 'legal' note of the tree icon since it was meanwhile changed by us to a different one.
-
-
Stephan Großberndt authored
Remove leftover code from the IMGMENU removal, which has been deprecated in v9 and removed in v10. Resolves: #102289 Related: #101979 Releases: main Change-Id: I30f7b12b639f22ee359635865fffc5abd6030cda Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81615 Tested-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/458 This is actually most likely a phpstan bug. We add an @var hint to circumvent.
-
Chris Müller authored
The lists were displayed as fluent text as the empty line between the upper paragraph and the first list item was missing. Resolves: #102288 Related: #101941 Releases: main Change-Id: I38d9df56cc3e576efca4b680d32dedfa5a322a7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81614 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/456 To prepare a monorepo merge of the styleguide extension, we're for now removing the code example syntax highlighting of the module to avoid a JS dependency. We may later add something again.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/454 Resource\Enum\DuplicationBehavior instead of Resource\DuplicationBehavior, see https://review.typo3.org/c/Packages/TYPO3.CMS/+/79568
-
Christian Kuhn authored
Minor CGL streamlinings from latest php-cs-fixer. > composer req --dev friendsofphp/php-cs-fixer:^3.37.1 > Build/Scripts/runTests.sh -s cgl Resolves: #102285 Releases: main, 12.4, 11.5 Change-Id: I0cc1fe3c0f81f62a49df00d62d57ef3c593c57df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81609 Tested-by:
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/453 * Align rules with core * php-cs-fixer 3.37.1 and don't allow updates to be in line with core > composer req --dev friendsofphp/php-cs-fixer:3.37.1 > Build/Scripts/runTests.sh -s cgl
-
Torben Hansen authored
Several classes in ext:install do not use constructor property promotion. This change introduces constructor property promotion where suitable. Resolves: #102281 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Icf857a65d8562bcab4ebff8638e47dbf2031d72a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81606 Tested-by:
-
