- Sep 07, 2021
-
-
Benni Mack authored
Change-Id: Ibae91e9f44a65697321611f49eef10ddb1a39ba9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70952 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Jochen Roth authored
Sometimes during testing the imported page 404 can't be found. The import acceptance test has been improved using the given "getPageXPathByPageName" method so it will hopefully behave in the future. Resolves: #95116 Releases: master Change-Id: Ic37d5afa014ee1c823b34f1a3700338d78c8a3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70912 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
Composer command: composer u 'doctrine/annotations' --with-all-dependencies; \ composer u 'doctrine/event-manager' --with-all-dependencies Output: - Upgrading doctrine/annotations (1.12.1 => 1.13.2) - Upgrading doctrine/event-manager (v1.0.0 => 1.1.1) Resolves: #95129 Releases: master Change-Id: I0f0ba6221ed28b38e388cdc66e49d87ce1869b01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70923 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Hader authored
Composer command: composer update 'symfony/*' 'guzzlehttp/*' --with-all-dependencies Output: - Removing symfony/intl (v5.0.7) - Upgrading guzzlehttp/promises (1.4.0 => 1.4.1) - Upgrading symfony/cache (v5.3.0 => v5.3.7) - Upgrading symfony/config (v5.3.0 => v5.3.4) - Upgrading symfony/console (v5.3.6 => v5.3.7) - Upgrading symfony/dependency-injection (v5.3.0 => v5.3.7) - Upgrading symfony/event-dispatcher (v5.3.4 => v5.3.7) - Upgrading symfony/expression-language (v5.3.0 => v5.3.7) - Upgrading symfony/finder (v5.3.4 => v5.3.7) - Upgrading symfony/http-foundation (v5.3.1 => v5.3.7) - Upgrading symfony/lock (v5.3.2 => v5.3.4) - Upgrading symfony/mailer (v5.3.0 => v5.3.4) - Upgrading symfony/mime (v5.3.0 => v5.3.7) - Upgrading symfony/options-resolver (v5.2.1 => v5.3.7) - Upgrading symfony/polyfill-intl-icu (v1.15.0 => v1.23.0) - Upgrading symfony/process (v5.2.1 => v5.3.7) - Upgrading symfony/property-access (v5.3.0 => v5.3.7) - Upgrading symfony/property-info (v5.3.1 => v5.3.7) - Upgrading symfony/rate-limiter (v5.3.0 => v5.3.4) - Upgrading symfony/routing (v5.3.0 => v5.3.7) - Upgrading symfony/stopwatch (v5.2.1 => v5.3.4) - Upgrading symfony/string (v5.3.3 => v5.3.7) - Upgrading symfony/var-dumper (v5.3.0 => v5.3.7) - Upgrading symfony/var-exporter (v5.3.0 => v5.3.7) Resolves: #95126 Releases: master Change-Id: I9cdfee15dbcdf6c07813cdacff03dccf7b061308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70921 Tested-by:
-
- Sep 06, 2021
-
-
Oliver Hader authored
Update to CKEditor v4.16.2 which addressed browser compatibility issues and known security vulnerabilities: https://ckeditor.com/blog/ckeditor-4.16.2-with-browser-improvements-and-security-fixes/ Commands: cd Build yarn add 'ckeditor4@^4.16.2' yarn build Resolves: #95128 Releases: master, 10.4, 9.5 Change-Id: Ic0c10f2d72bb7d107f53c58dbc0668d19275914b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70917 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
The RST file used the review ID instead of correct issue #94861. For convience, all breaking changes were collected for TYPO3 v11.0, and this RST is moved accordingly - the behavior has been deprected correctly in TYPO3 v10, however actually removing it in v11.0 was forgotten. Related: #94861 Releases: master Change-Id: I03c9d3062dcd640cce9396805f99873d4be14d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70920 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #95124 Related: #95009 Releases: master Change-Id: I41319bd20432a55a668e10b62634c82839677ea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70915 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Hader authored
Composer commands: composer req 'christian-riesen/base32:^1.6'; \ composer update 'bacon/bacon-qr-code' --with-all-dependencies Output: - Upgrading christian-riesen/base32 (1.5.2 => 1.6.0) - Upgrading bacon/bacon-qr-code (2.0.3 => 2.0.4) References: * https://github.com/ChristianRiesen/base32/releases/tag/1.6.0 "Major bugfix [...] please require at a minimum ^1.6 in your project" Resolves: #95127 Releases: master Change-Id: Iccd3681a278667cb0438cd04c15af4ac828b7be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70916 Tested-by:
-
Wouter Wolters authored
In #89736 hoa/core was marked as conflicting with TYPO3. This is package is not used anymore with codeception/codeception and can therefore be removed. Resolves: #95109 Related: #89736 Releases: master Change-Id: If817126c1c8098a63ceb2fd0139f145459a73776 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70893 Tested-by:
-
Jochen Roth authored
When creating a new task using PHP8 a undefined key warning is thrown. To fix this issue a fallback for "task_group" has been added. Also extended createASchedulerTask test to check for expected output in case nom settings (defaults) are given. Resolves: #95088 Releases: master Change-Id: I47a480e635eaffbad2e1a1d03426a7acc04cc494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70871 Tested-by:
-
Stefan Bürk authored
Missing deterministic orderBy for database queries leads to different records retrieved across dbms and dbms version. Some major dbms tends to order by primary key implictly, where in newer versions it behaves differently. Even if the database structure and data seems to look identically, dbms tends to handle it in different ways. Test fixtures for CategeoryCollectionTests do not provide any values for sorting. Inserting the data to the database is done through plain database inserts through the testing framework, not taking care of table specific sorting fields if test data missing them, which DataHandler and RelationHandler takes care of in the core. There can be instances with extensions omitting the usage of datahandler and as such inserting nondeterministic datasets, deterministic queries must be implemented. Retrieving related records for categories has been missing the required sorting field, so sorting was unreliable. Ensuring deterministic record retrieval by adding 'uid_foreign' as last orderBy to kick in if two records have the same sorting value. This allows activation of a CategoryCollection related functional test with postgres. Even though the test data misses proper sorting field values, this is not changed to ensure deterministic sorting does not break again. This patch acts as follow up for #95061. $ Build/Scripts/runTests.sh -s functional -d postgres \ typo3/sysext/core/Tests/Functional/Category/Collection/\ CategoryCollectionTest.php Resolves: #95091 Related: #95061 Releases: master, 10.4 Change-Id: I9feec421ff9628aabe100fbab9a69c570b9dd029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70877 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Stefan Bürk authored
A functional test has been disabled for postgres because the test was flaky (what ever this meant exactly) and has been leading to occassional test run failure. Using git bisect the first working commit has been way back before v11.0.0 release tag 27c7de8a [!!!][TASK] Remove move placeholders #92497 as the commit before has been failing 64542d62 [TASK] Decouple Dependency logic and domain models in EM As the patch which has been fixed the related stuff for the flaky test is not an easy area (or at least I'm not in ) it is really hard to identify which exactly in that commit has fixed it. Anyway, as proven through a lot of checkouts sinces this commit and even current master (run through nightly) passed all green thus this test is activated again. Testcommands: (on different versions/commits + patch | as available ) Build/Scripts/runTests.sh -s functional -d postgres \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 10 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 11 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 12 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 13 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Resolves: #95108 Releases: master Change-Id: I74feb7ad85f5f8540e6b1bd3baccd639d4c89a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70892 Tested-by:
-
Stefan Bürk authored
A functional test has been skipped for postgres functional test execution because it exported relations in not expected order like other databases. Mainly younger postgres versions are unreliable when undetermistic queries are used. Undetermistic database query sorting may lead to unexpected and random data returns. Generally queries should implement determistic sortings to mitigate this issue across all dbms and dbms versions. The related query for this functional test has been already made determistic through #95032 and #95045 but missed to reactive this related functional test. This patch acts as follow-up for #95045. Commands: Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 10 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 11 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 12 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 13 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Resolves: #95107 Related: #95045 Related: #95032 Releases: master Change-Id: I49fa87a1dec1b3aaa61c9758e2b437c290046cd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70890 Tested-by:
-
Daniel Siepmann authored
The value fetched from database when using sqlite is of type string. The property page_id is typed to be integer. Assigning the string to integer would result in an TypeError. Resolves: #95078 Releases: master Change-Id: I2e961f3e3c71198c29b1ef6c288881dd28c7702b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70864 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
The ProductionExceptionHandler now uses the Context API for generating the access time string, which among others, is used in the error code. Therefore, the class is also refactored to use DI. This required to remove the previously passed $configuration argument from the constructor. It will now be set via a new `setConfiguration()` method. Passing the $configuration as constructor argument is marked as deprecated, affecting installations, using custom exception handler classes. Additionally, another regression, introduced in #94315, is fixed. A custom error message, configured in TypoScript, using the `%s` placeholder, was no longer be substituted with the actual error, making any mapping between frontend output and log entry impossible. This is fixed by replacing the `%s` with the new `{code}` placeholder. Resolves: #95009 Related: #94315 Releases: master Change-Id: I63bc0bfc74cd2bc33a761241f8392c1bcda90c04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70792 Tested-by: -
Benni Mack authored
If config.debug = 1 is added, and a page is loaded from cache, TYPO3 usually sent "<!-- Cached page generated 03-09-21 09:48. Expires 04-09-21 09:48 -->" at the end of the HTTP Response Body. This is especially painful when dealing with JSON output, where this breaks output if TYPO3 should return JSON (e.g. from a USER function). This change sends the same information as a HTTP Response Header named "X-TYPO3-Debug-Cache" including the same information, and not touching the actual rendering. Resolves: #95103 Releases: master Change-Id: I737081ae4ac4a079c038c61cc5d37b57e81ab045 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70885 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Anja Leichsenring authored
The changelog files for the version 11.4 must leave the master folder now and move to their final home in 11.4. Resolves: #95106 Releases: master Change-Id: Icc835750fb914e5ae27398be86bb70f1bfe80021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70888 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Andreas Fernandez authored
The pid resolving in the `AddRecord` fieldControl is not sufficient in all cases. To allow easier extension of the pid resolving without the need to override the whole `render` method, the resolving is extracted into an own method that can be extended in custom implementations. Resolves: #95001 Releases: master Change-Id: Ie71943aa6275e9d5e7a7e3295d968198f665d5ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70767 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
- Sep 04, 2021
-
-
Andreas Fernandez authored
PhpStorm has basic support for generics since version 2021.2 which comes in handy as since the same version the "Dynamic Return Type" plugin is broken. Providing the class-string annotation and a proper return generic supersedes this and recovers the built-in autocompletion. To have the same effect for both, 3rd party code not being under our control or methods having complex returns based on their input, a `.phpstorm.meta.php` file is provided extending PhpStorms code awareness capabilities. Tons of kudos to Alexander Schnitzler providing a boilerplate configuration here: https://github.com/alexanderschnitzler/phpstorm.meta.php-typo3 For more information about capability extension consult https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html Resolves: #95064 Releases: master, 10.4, 9.5 Change-Id: I4ea5115550ce7070de01c42c19ac3b93bf6ab4b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70872 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Anja Leichsenring authored
Used commands: composer require symfony/polyfill-php80:^1.16 composer require symfony/polyfill-php80:^1.16 \ -d typo3/sysext/form --no-update This fixes a composer min acceptance test failure, that chokes on the function str_ends_with() not being available in a PHP 7.4 environment. Resolves: #95110 Releases: master Change-Id: I54d410adc7ad813dc3c840c4292ee9ec3df6f76c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70894 Tested-by: -
Benjamin Franzke authored
This is a preparation in order to decouple LogManager and log attribute in future. Releases: master Resolves: #95099 Related: #85506 Change-Id: Ic3c864994440c690aed5e3825fd7e7b2b471d89c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70882 Tested-by:
-
Oliver Bartsch authored
Three new PSR-14 based events are introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/class.db_list_extra.inc']['actions'] hook, which is now marked as deprecated, along with its interface "RecordListHookInterface". Besides the obvious advantage of using PSR-14 events, the RecordListHookInterface also required to always implement all hook methods, even if only one of them was really used. The new events feature the same functionality, but improved and extended. The main subject, e.g. the record actions or the table header columns, is therefore equipped with extended CRUD methods, like adding a new action at a certain position. Resolves: #95105 Releases: master Change-Id: If3194474eca7c111be4d113fda04992c5bf5f16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70887 Tested-by:
-
- Sep 03, 2021
-
-
Benjamin Franzke authored
EventDispatcherInterface injection is easy here, therefore lets to so in order to avoid the discouraged global lookup via GeneralUtility. Also refactor to inject other dependencies. Resolves: #95101 Releases: master Change-Id: I4c6db4bbb5e0f10121b75cef5bd57956c093d2b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70883 Tested-by:
-
Benjamin Franzke authored
Services are now able to control the component name that an injected logger is created with. This allows to group logs of related classes and is basically a channel system as often used in monolog. Therefore and as preparation for future monolog logging, the attribute is named Channel. The Channel attribute is supported for constructor argument injection as a class and parameter specific attribute and for LoggerAwareInterface dependency injection services as a class attribute. This feature is only available with PHP 8. The channel attribute will be gracefully ignored in PHP 7, and the classic component name will be used instead. Releases: master Resolves: #95079 Related: #95044 Change-Id: I4b710677bc20c4200fc14b299865f4c7f95e4d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70849 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
11nd11 authored
The modals duplicate form and reference overview have been adapted to the new styling of the new form wizard. * Clean up markup and use common colors of TYPO3 v11 * Use new common styles and elements for better overview and modern look Resolves: #95085 Releases: master Change-Id: I6b1fc1332230c9bb966184d66944875ec7ebc4dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70878 Tested-by:
Tobias Siegler <siegler.tobias@googlemail.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
11nd11 authored
Streamline and optimize styling and markup of the new form wizard of form manager. * Clean up markup and use common colors of TYPO3 v11 * Optimize UX and Overview of the new form wizard * Use new common styles and elements for better overview and modern look Resolves: #94805 Releases: master Change-Id: I0be4753be8d414db848453a0e4db941a8b127676 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70681 Tested-by:
-
Oliver Bartsch authored
A new PSR-14 based event "ModifyClearCacheActionsEvent" is introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['additionalBackendItems']['cacheActions'] hook, which is now marked as deprecated, along with its interface "ClearCacheActionsHookInterface". The new event features the same functionality as the hook. Additionally a new convenience method `add` is available for the class properties, allowing extension authors to add their custom actions more easily. This might be the most common use case for using this event. Resolves: #95083 Releases: master Change-Id: I1e621a00b04cdf43978a6e982b66c397e9437a29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70870 Tested-by:
-
Oliver Bartsch authored
A new PSR-14 based event "AfterFileCommandProcessedEvent" is introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_extfilefunc.php']['processData'] hook, which is now marked as deprecated, along with its interface "ExtendedFileUtilityProcessDataHookInterface". The new event features the same data, however the way they can be accessed is improved. The previous `$action` and `$cmdArr` arguments are now available within the `getCommand()` method, while the action is the array key and the command data ($cmdArr) is the value. This is more in line with the actual request. The hooks `$result` argument always contained all results of previous operations, making it unnecessary complicated to find out the actual result for the current operation. This is now resolved. The new `getResult()` method only returns the result for the currently executed operation. Finally the "getConflictMode()" method just returns the conflict mode, used for the current operation. Resolves: #95089 Releases: master Change-Id: I9991eb73aed873da5987f88d2d0255764274e143 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70874 Tested-by:
-
Andreas Fernandez authored
A new TCA config `treeConfig/startingPoints` is introduced for selectTree and category to allow multiple "roots" for the rendered tree. This new settings superseds and deprecates `treeConfig/rootUid` being capable of rendering only one root node. To be able to re-use `AbstractItemProviderparseSiteConfiguration()` without the implicit quoting, the method is split into separate parts. Resolves: #95037 Releases: master Change-Id: I3361daeed10b0f1ac1f8fa879850f79f4a85e23a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70819 Tested-by:
-
Tomasz Woldański authored
Right now some properties returns empty string or null when value is empty. i.e. title (null when empty), target ('' string when "empty"). Patch makes all serialized properties behavior consistent (null on empty string values). Resolves: #95097 Related: #94889 Releases: master Change-Id: Ib9e6db04bfc165e8dd32bb5092f33f7862696941 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70881 Tested-by:Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Helmut Hummel authored
Also introduce internal PathUtility API to resolve the web path of extension resources and a helper public API method to check whether a path is an extension resource path. Start using the new API throughout the core. All checks of EXT prefix are replaced, further usages of getAbsoluteWebPath will be replaced in subsequent patches. Releases: master Resolves: #95022 Change-Id: I27994f309af8b35ad3822a5be59d81d164fa9cd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70805 Tested-by:
-
Jochen Roth authored
Some acceptance tests fail radomly due to speed/timing of the checked elements or unresolved promises. This should be avoided now by using "waitForElements" instead of "canSeeElement". This may cause longer test runs but makes sure tests won't fail on performane hiccups. On top of that Icon.getIcon in DocumentSaveActions will catch unresolved promise in case a new page or reload was triggered by the button to avoid Javascript errors. For example in Scheduler -> Add Task and hit save. Resolves: #95070 Releases: master Change-Id: I927876ecfd46cbc2edae03db249982fcb8a9d2f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70860 Tested-by:
-
Paul Hansen authored
Simplify the Form Management list view by showing the pagination widgets only when there are multiple pages of forms in the list. Resolves: #95081 Releases: master Change-Id: I752933fbc26233cbe484841734e0d30ea6d1a132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70873 Tested-by:
-
Benjamin Franzke authored
Logger instances may be required to be available during object construction, LoggerAwareInterface isn't an option in that case. Therefore LoggerInterface as constructor argument is now autowired (if the service is configured to use autowiring) and instantiated with an object-specific logger. We add a symfony compiler pass that prepares an inline factory which fetches the appropriate Logger instance from the LogManager. One of the TYPO3 core classes that require this is the Scheduler. Scheduler used to contain a safety net which fetches a logger instance from LogManager in case the logger is already needed during the constructor invocation. In that case the logger was not available, as it was injected via setter injection (setLogger) later (per LoggerAwareInterface). Releases: master Resolves: #95044 Change-Id: I57539a731a305da6abc092d2383e2d2f4c1d985c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65449 Tested-by:
-
- Sep 02, 2021
-
-
Tomasz Woldański authored
This change introduces a new immutable object "LinkResult" along with an interface, containing the base result of a generated link by TypoLink. This object contains all information needed to put together a <a> tag or return a pure URL. For the time being this new class is used to build links from the typolink link builders, and in addition should be able to be returned fully by typolink in the future. In addition, this object helps to build links needed for e.g. JSON responses to contain all information of the link to be serialized. Resolves: #94889 Releases: master Change-Id: Ic9383a1a0f0ec93ba3aa352235003268e00a2f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70590 Tested-by:
-
Benni Mack authored
A new PSR-14 based event "ModifyFileDumpEvent" is introduced in favor of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['FileDumpEID.php']['checkFileAccess'] hook, which is now marked as deprecated, along with its interface "FileDumpEIDHookInterface". In contrast to the hook, the new event also contains the PSR-7 Request and additionally allows to replace the file, being dumped. Resolves: #95080 Releases: master Change-Id: Idbb0f2f38678c12e752e2255aa71853362f8cc46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70865 Tested-by:
-
Nikita Hovratov authored
The original message got immediately overridden with the template representation. This is now fixed by using a different variable name. Resolves: #95084 Related: #94315 Releases: master Change-Id: I478ed832ca8944b3829a11640033882c3f50c546 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70869 Tested-by:
-
Benjamin Tammling authored
Add ViewHelperResolverFactoryInterface and use it for dependency injection. ViewHelperResolverFactoryInterface is specified via ServiceProvider.php since it is needed in FailsafeContainer (install tool). Since ServiceProdiver.php itself is not API, ViewHelperResolverFactoryInterface isn't either. This will evolve over time in core. For now, we still need this interface already for some extensions edge cases, though. ServiceProviderCompilationPass is adapted to avoid alias resolution when providing factories for interfaces. Otherwise the aliased service is configured instead of the interface itself. Resolves: #95076 Releases: master Change-Id: I882fb3d1bfee65dea44d9ee4f4d7bc39275ab10e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70831 Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Benjamin Tammling <benjamin.tammling@sitegeist.de> Tested-by:
-
Nikita Hovratov authored
Collection types of persistent domain objects are already resolved. This patch adds this feature to the normal ObjectConverter. This is especially useful when making use of DTOs. Resolves: #93197 Releases: master Change-Id: Ia21ba9e5870f3c17c6a4fad9e51335ed236ef239 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67320 Tested-by:
-
Benni Mack authored
A new PSR-14 based event "ProcessFileListActionsEvent" is introduced in favor of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['fileList']['editIconsHook'] hook, which is now marked as deprecated, along with its interface "FileListEditIconHookInterface" Resolves: #95077 Releases: master Change-Id: I24ea2a5871530c0e6a7b2316d3b574508e3e1687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70835 Tested-by:
-
