- Mar 01, 2021
-
-
Stephan Großberndt authored
This patch changes the behaviour when saving the backendfilter in extensionmanager list to not allow any class unserialize as TYPO3 Core does not put any classes in the UC and no other place in Core allows to unserialize stdClass for be_users.uc. Resolves: #93617 Releases: master, 10.4 Change-Id: I4b0ba03fb1ea02e97327e11fcd76486d3bd4cda6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68155 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Jigal van Hemert authored
If the hook is used to add TypoScript, information must also be added to the rowSum array in order to generate correct cache keys. Resolves: #93597 Releases: master, 10.4 Change-Id: I9d543872206333d02b8eb6b5cdd90a53e6c6accb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68153 Reviewed-by:
-
Alexander Schnitzler authored
Several reflection methods are deprecated for a while and throw errors with PHP8. - ReflectionParameter::getClass() - ReflectionParameter::isArray() Both need to be replaced with the new api: - ReflectionParameter::getType() Releases: master, 10.4 Resolves: #92946 Change-Id: I9391cd260f0d4dba5eb03f63c1f74f01bd97e7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66936 Tested-by:
-
Stephan Großberndt authored
This patch sets the type of be_users.uc to binary in order to avoid SQL errors when updating it on PostgreSQL installations. Resolves: #93616 Releases: master, 10.4 Change-Id: Ib30d4f8be566922c573c8a5f5e1144f283273f9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68154 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja Leichsenring authored
The Pagetree suite for acceptance tests was set up as a separate suite in the beginning due to a necessary fixture set of pages, that all the other tests don't need. The overhead of having separate suite is higher than the additional fixture set, so the suites are merged. Resolves: #93614 Releases: master, 10.4 Change-Id: I70a3f1dd68bb07c0dc505eaadb3d240e81639add Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68151 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
Benjamin Franzke authored
The component is provided as replacement for the current lit-helper `icon()` which cannot provide support for icon usage inside shadow dom elements. The component renders all icons as inline SVGs. FontawesomeIconProvider is therefore adapted to provide inline rendered SVGs for font-awesome icons. Not that these inline font-awesome SVGs will also be used in areas where 'inline' icons are requested (like information toolbar) but the fallback to 'default' was used before. The component supports all properties of the Icon API via HTML attributes. Colors and custom sizes can be applied to the component via CSS color/font-size property: typo3-backend-icon[identifier=status-dialog-information] { color:#6daae0; /* An explicit font-size will be used as icon width & height */ font-size: 1.2em; } Resolves: #93473 Releases: master Change-Id: I3044c325f122eb0085ecb3f45fb9502bfb314d5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67675 Tested-by: -
Christian Kuhn authored
composer req php:"^7.4 || ^8.0" Note this declares core master PHP 8 compatibility, even though core is not yet compatible in practice. The situation should settle until 11.2, though. Resolves: #93612 Releases: master Change-Id: Ibd428260ebd48936bb193b1df747283d3b35f410 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68150 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Feb 28, 2021
-
-
Christian Kuhn authored
Package handling with a php 8 and no platform.php composer config currently fails since various dependencies don't allow php 8, yet. Drop these test stages for the time being to have a green nigthly CI build. Resolves: #93611 Releases: master Change-Id: I7667d972679a3a125b699df034b04cb8800104c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68149 Tested-by:
-
Christian Kuhn authored
Resolves: #93604 Releases: master Change-Id: I36133bd50c85f572ea0dc9ba786c7ac6e1718adb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68146 Tested-by:
-
Nikita Hovratov authored
This example configuration was accidentally added by a later commit after it was already removed. Resolves: #93600 Related: #89645, #89740 Releases: master, 10.4 Change-Id: I79bbbf3210e67e0f5425563ba58765115db3cd12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68139 Tested-by:
-
Anja Leichsenring authored
Each jobs will have one more run in case it fails in the first. This will prevent pipeline failures due to recoverable test run failures. Resolves: #93603 Releases: master, 10.4, 9.5 Change-Id: Ia054973d1f2a336727ef9d483041f1f48147c375 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68140 Tested-by:
-
- Feb 27, 2021
-
-
Christian Kuhn authored
Fix some last PHP 8.0 related issues found by unit tests and enable their execution in CI. Resolves: #93601 Releases: master Change-Id: Ie2d2aebd5858361efa85a9491808c53bcbc06288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68138 Tested-by:
-
Christian Kuhn authored
Adapt testing related docker-compose.yml to properly work with xdebug 3.0. This is packaged in the testing container images already and is the only version compatible with PHP 8. To spice up developers life, xdebug 3.0 drops important config options in a non b/w compatible way, introduces new ones, where some of them overwrite others, and does further stuff like changing the default step debugger port for no apparent reason. Since xdebug can be such a pain, runTests.sh comes with -x option, so it (hopefully) 'just works' for devs using the script in testing context. The setup of course breaks with xdebug 3.0 and is fixed with the patch. As single advantage, it is now easier to disable xdebug, so the 'prepared php.ini file without xdebug' hack in the test container images can be dropped. Change-Id: Id5810a5a6d988bfe5e814a6781d12d93baa97972 Resolves: #93599 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68137 Tested-by:
-
Christian Kuhn authored
* Test relies on xdebug, which is not available on CI, this test is never executed there. * Since the low level API header() is tested, the test additionally needs to fork a php process to do it's thing. This is ugly for a unit test. * Turning the test into a functional test won't improve the situation since the response emitting is not done with functional sub requests. * The skip logic breaks with xdebug 3.0 using xdebug.mode=off. Resolves: #93598 Releases: master, 10.4, 9.5 Change-Id: Ibab9452bdcbc83228c1445db1a92b42db54dc192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68135 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Feb 26, 2021
-
-
Christian Kuhn authored
Resolves: #93592 Releases: master, 10.4, 9.5 Change-Id: If851b9264d7d9e3b2a18df49d2c445f034aa5a80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68133 Tested-by:
-
- Feb 25, 2021
-
-
Torben Hansen authored
Group assignment for a backend- and frontend user is currently limited to max. 20 groups per backend user and max. 50 groups per frontend user. The database field type for "usergroup" is now changed to "text" so the group limitation can be removed. Resolves: #93348 Releases: master Change-Id: I93329a8c186e13439d68cc6c36345842c4edd929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67577 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Dmitry Dulepov authored
This fix adds a check for the non-existing array member that is passed to a function that expects an array. In the debug configuration such missing check causes TypeError exception. Resolves: #93290 Releases: master Change-Id: I6d3c8cdc757349f09613a618ebe9309d96213bcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67446 Tested-by:
-
Benjamin Franzke authored
This is to avoid calling IconRegistry::setCache during early bootstrap. That hack was needed back when CacheManager was streamlined to only be usable after ext_localconf has been loaded (#86353). Since DI was not available back then, assets cache needed to injected statically. Now that DI is available, we can inject withing the factory. Resolves: #93475 Releases: master Change-Id: I97551ba7e60a6aaac832034b7df35f8c01d654c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67678 Tested-by:
-
Claus Due authored
Replaces an inefficient string parsing using strlen, for and ord, to use unpack instead. Saves one call to strlen per header, and potentially thousands of calls to ord per request. The same strategy is used in Message->filter, however, this method does not appear to be used so the unpack change is only applied in isValidHeaderValue. Releases: master, 10.4 Resolves: #92059 Change-Id: I6f485287eb6773accd8bd194ec998205479cec5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65396 Tested-by:
-
Oliver Bartsch authored
It's mandatory for HTML button elements to provide both, the starting and the ending tag, even if no phrasing content is provided. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button This is now enforced in the corresponding ViewHelper. Resolves: #93587 Releases: master, 10.4 Change-Id: Ie26716218be42ade8985dd13b222dfdebaaf2ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68109 Reviewed-by:
-
Tobias Wojtylak authored
The package @typo3/icons can be updated to version 2.2.2 which adds some new icons. Executed commands: cd Build yarn add "@typo3/icons@^2.2.2" yarn build Resolves: #93584 Releases: master Change-Id: I888594038c06f5db18c5ba5388ccdfeb29673938 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68096 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
Because the request object was not set for the FluidEmail variant of the EXT:form EmailFinisher, the TYPO3 logo as well as the website URL in the footer were not displayed when using the SystemEmail layout from Core. This is now fixed by setting the request, if available. Resolves: #93588 Releases: master, 10.4 Change-Id: Ie6450b1a7a5728f1384e8010f02868bc26479c32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68103 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Stephan Großberndt authored
This patch ensures columns of tables which have been removed from ext_tables.sql definitions are recognized on PostgreSQL so they are renamed by adding a "zzz_deleted_" prefix. It also enables the formerly excluded according test for SQLite which works without additional changes. Resolves: #93491 Releases: master, 10.4 Change-Id: I8b6b487fde7ccc5f023e86cfa331d60c9606a774 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68056 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
- Feb 24, 2021
-
-
Christian Kuhn authored
The acceptance and functional test splitter scripts from typo3/testing-framework are tailored for core specific needs and of rather little use for non-core. For the sake of a more clean typo3/testing-framework, the patch merges the scripts into core mono-repo. Change-Id: Iefb576bb52c238ccca7b618fa6f9ea0d5718d0f9 Resolves: #93586 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68098 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Richard Haeser authored
If you have a good reason to disable the default rendering of hreflang tags, you can now use a TypoScript setting. To disable the hreflang generation, you can add the following line to your TypoScript setup. .. code-block:: typoscript config.disableHrefLang = 1 Resolves: #93188 Releases: master Change-Id: I7678b395e4c2bfd6a62a87c928b3f8a44af381ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67930 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
This brings a recent chrome version. Some tests need minor adaptions to deal with changed exceptions and behaviour. Change-Id: I1644a90ee09c98721ad8246988709461248c66a4 Resolves: #93575 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67964 Tested-by:
-
Oliver Bartsch authored
The sudo mode, introduced in #92836, is required whenever the install tool is accessed in the backend. Especially in development context accessing the install tool is a frequent task, e.g. for clearing all caches, to test global configuration or to run the database analyzer. Therefore, the sudo mode is now not longer required while the installations application context is set to "Development". Resolves: #93160 Releases: master, 10.4, 9.5 Change-Id: If61fa08847181491c01417d301a6bc1f480bae1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68094 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
This change cleans up the tooltip initialization where done manually (e.g. in Recordlist it's its own class). Instead, the default initialization for the data-bs-toggle="tooltip" takes over sane delay settings, fixing flaky Acceptance tests (and real visibility bugs in Scheduler). In addition, the FileList module now also uses bootstrap-powered tooltips again. Resolves: #93583 Releases: master Change-Id: Ibff2aae38569caebab9cf45368dd44b03b451cff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68095 Tested-by:
-
- Feb 23, 2021
-
-
Jigal van Hemert authored
For plain arrays it's sometimes important that the items appear in the order in which they are imported. For example with the languages in the sites configuration where the first language is seen as the default language. Just like with Symfony Service Container imports come first and its settings are overwritten with the main file. To make sure that multiple imports are loaded in the order as they appear in the main file they must be processed in reverse order. This behaviour can now be controlled by a new feature toggle which defaults to `false` for existing and to `true` for new installations. Resolves: #92100 Releases: master, 10.4 Change-Id: I30ffba171606f3c62c15742eba3187af454aa5b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65458 Tested-by:
-
Benni Mack authored
Change-Id: I27ce98bf74121f0e30a39d5c078901a2ecdb9242 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68055 Tested-by:
-
Benni Mack authored
Change-Id: I88d5f2a08c28e121705be557dc3c9278902f69e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68054 Tested-by:
-
Benni Mack authored
This change reverts commit 154606e3 as this introduced some behavior related to DBMS (postgres, mssql) which our test suite found. Change-Id: I6513f76f537c04e4ebe06cae4a475c5d8d7fbbf8 Resolves: #93568 Reverts: #93491 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68072 Tested-by:
-
Oliver Bartsch authored
Resolves: #93567 Releases: master Change-Id: Ic9ed222fb6aaf58c1a29e1fa5df1f06d12300519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68053 Tested-by:
-
- Feb 22, 2021
-
-
Oliver Bartsch authored
Since there are use cases in which the internal state of a provider may have changed since the view was initially rendered (e.g. when using multiple tabs), the provider has to check internal state prior the execution of the requested operation. This patch furthermore performs some clean ups: * Fix some typos * Check if the requested action can be performed on the given provider * Add missing exception in case a non existent provider is being updated * Use existing isSystemMaintainer() method over manual evaluation * Prevent provider setup instructions to grow too large Resolves: #93558 Releases: master Change-Id: I8b954fe4e209f2cf9c431ef65f34fa022fbaaa88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67993 Tested-by:
-
Benni Mack authored
TYPO3 already ships with latest versions for our phpdocumentor dependencies, but in order to run our test suite, the dependency suite is bumped to use the latest versions that are compatible with PHP 7.2 - PHP 8.0. Used composer commands: - composer require "phpdocumentor/reflection-docblock:^5.2" \ "phpdocumentor/type-resolver:^1.3" -W - composer require "phpdocumentor/reflection-docblock:^5.2" \ "phpdocumentor/type-resolver:^1.3" \ --no-update -d typo3/sysext/extbase Resolves: #93563 Releases: master, 10.4 Change-Id: Id321ad8d7659dab21b176793e7bde571716d8313 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68032 Tested-by: -
Oliver Hader authored
Update previous dataset attribute selector from `data-target` to `data-bs-target` in Admin Panel preview. Resolves: #93559 Releases: master Change-Id: Id848a3f0309226c438622f72c572fdcb882f5642 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67992 Tested-by:
-
Benjamin Franzke authored
Inject dependencies as singleton lookup via GeneralUtility::makeInstance is to be avoid whenever possible. Releases: master Resolves: #93442 Change-Id: I67b23c800a9fc7a6b44d326564df38ed999cbd16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67648 Tested-by:
-
Benni Mack authored
This change fixes the table header in the Info module in the Localization Overview, and also now uses the Site Language Label for the default language. Resolves: #93554 Releases: master Change-Id: I7fc3867ff4e1aa2a0b9fc9bc7ad2048a3a31939f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67970 Tested-by:
-
Stephan Großberndt authored
This patch ensures columns of tables which have been removed from ext_tables.sql definitions are recognized on PostgreSQL so they are renamed by adding a "zzz_deleted_" prefix. It also enables the formerly excluded according test for SQLite and MSSQL which work without necessary changes. Resolves: #93491 Releases: master, 10.4 Change-Id: Ia892c69a506372f71d066fd707b5c8a27718d2b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67772 Tested-by:
-
Stefan Frömken authored
Releases: master, 10.4 Resolves: #93543 Change-Id: I5d35b1fd24ff94941cb59aecf082415fbe7ed246 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67966 Tested-by:
-
