- Apr 18, 2023
-
-
Oliver Bartsch authored
In case an export is created based on e.g. an invalid preset, no PHP TypeError should be occure. This is now fixed by properly typecasting the input data. Additionally, two possible undefined array key access warnings are fixed. Resolves: #97403 Releases: main, 11.5 Change-Id: I994391909b44247879099ce92d61911c56ca7e39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78723 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
It's now ensured that ResourceFileExtensionMatcher properly compares the file extensions using only lowercase chars. Additionally, the in_array checks are set to "strict". Resolves: #100250 Releases: main Change-Id: I687d69d1b2b550f45245ddeac5b09bf3581eff2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78726 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
This commit deprecates some methods in `DebugUtility`. `debugRows()` and :php:`printArray()` both have a duplicated method and `debugInPopUpWindow()` is discouraged with the same reasonings as with the removed of the Debug Console in #98069. Resolves: #100653 Releases: main Change-Id: I3bd986901435f4aa7a4e33fea5a614fe7a238264 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78719 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Oliver Bartsch authored
Due to the TYPO3\CMS\Core\Type\Map implementation, the key of a collection entry can also be an object. This is now handled properly in DebuggerUtility. Resolves: #100655 Releases: main Change-Id: I9d3a66e8cb08f369383297dcd80bc685ec03d6e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78724 Reviewed-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100646 Releases: main Change-Id: Id3c06d35a25177f9edf90ab0a9ca7fba8ce96361 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78713 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
In some scenarios, it may happen that the DOM isn't ready while the form editor is already booted, leading to JavaScript errors as DOM nodes are not available yet. The `dispatch*` methods in EXT:form's helper now wait for a ready state before booting the form editor. Resolves: #100651 Releases: main Change-Id: Ic3f331d58fd9ae74e1d7dc121b6ae51c89c89cfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78716 Tested-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100645 Releases: main Change-Id: I22f3aec7fd18eb20409dc0d8cd7af8d8bb2f822b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78695 Reviewed-by:
Christoph Lehmann <christoph.lehmann@networkteam.com> Reviewed-by:
-
Andreas Fernandez authored
The icon used to collapse / expand a node in the form editor tree is now streamlined with the other trees (SVG tree, "static" tree). Resolves: #100648 Releases: main Change-Id: I09ffa90996ba277c1f7dc72694d3b991a3e01c24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78715 Reviewed-by:
-
- Apr 17, 2023
-
-
Oliver Bartsch authored
Both EXT:felogin controller extended the AbstractLoginFormController class, which however only contained one single method. To simplify class abstraction, the abstract class is removed by moving corresponding functionality directly into the controllers. This also allows to properly inject the used PageRepository service. Resolves: #100640 Releases: main Change-Id: I8e43779293601356ab7691aee15fb9d3d9a41d32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78688 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Chris Müller authored
Additionally, remove outdated manuals from list in Settings.cfg. Resolves: #100641 Releases: main, 11.5 Change-Id: Idc09d4da5a0131ae9d4554790d6f782a87d8da5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78689 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #100606 Releases: main Change-Id: Ia53ba43a4668f2f6e06c02fb6be0137d510fcf56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78690 Reviewed-by:
-
Frank Naegler authored
Replace all `<a> ` tags having `href=“javascript:;“` as target with `<button>` tags of type `button` and appropriate classes. Resolves: #99917 Releases: main Change-Id: Ic46df405db3f52cb94b06632b638652ab98d50c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78663 Reviewed-by:
-
Chris Müller authored
Resolves: #97916 Related: #95456 Releases: main Change-Id: I5bf875d11fc91b687b9fba36c2d8c23f5eae1756 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78687 Reviewed-by:
-
Benjamin Kott authored
We are dropping the `.card-table` styling and adjusting `table-fit` to also work in cards the same way they work in panels. Instead of using Utility-CSS to give cards a state different, we now include card states like other components already have. Card containers now only introduce space to bottom. Cards now also have an increased border radius assigned, to match the other components in the backend. Resolves: #100636 Releases: main Change-Id: I17532e58d46e52210f42c5b3b9e333ce4611e50e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78683 Tested-by:
-
Oliver Bartsch authored
To simplify extension configuration and to fully follow the current conventions is the ext_icon.* file location now deprecated. Resolves: #98093 Releases: main Change-Id: I73bd81d31ffbc3db955b5d96511fa39ac56b9241 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78685 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Christian Kuhn authored
In addition to #98281 in TYPO3 v12.0, "pibase" AbstractPlugin now actively logs a deprecation message. Resolves: #100639 Related: #98281 Releases: main Change-Id: Ib8d17f745c9cefa7bfb76a9acfeac96c8a20234f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78686 Tested-by:
-
Christian Kuhn authored
There are two ways of handing over the current request to ContentObjectRenderer after instantiation: By calling setRequest() and by handing the request to start() as third argument. To further streamline request handling, the patch deprecates the second way. Change-Id: I4304e05924ac81a49ce0495bb8de91c70117e804 Resolves: #100637 Resolves: #98632 Related: #92984 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78684 Tested-by:
-
Christian Kuhn authored
EXT:core/Resources/Private/Language/locallang_wizards.xlf contains a series of labels that are not used anymore. Let's remove them. The file is loaded into JS at various places, keeping it smaller is better. Resolves: #100629 Related: #100626 Releases: main Change-Id: I5bc8a2e8827d44a4e4991727ded58532b8984e75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78677 Tested-by:
-
Benjamin Kott authored
With the migration from `text-muted` to `text-body-secondary` the descriptive text for clearing cache actions became unreadable in darkmode. The dropdown component is already respecting the preferred color scheme of the user. Since we have no global support for darkmode and only have some components react, we need to adjust these manually for now. Resolves: #100628 Releases: main Change-Id: Iffffdd7675dc28c026cb650a0897b921c2fbc30f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78676 Reviewed-by:
-
Christian Kuhn authored
The TypoScript parser has to load TypoScript from globals ($GLOBALS['TYPO3_CONF_VARS']['FE']['defaultTypoScript_') and TypoScript from extension static files (ext_typoscript_*.typoscript) at some point. It usually adds this before the first "root" sys_template row. This is fine in frontend. Extbase backend modules rely on frontend TypoScript for configuration as well. This decision from the dark ages hurts us plenty, but is very hard to get rid of. The extbase BackendConfigurationManager does a lot of guesswork to calculate such frontend TypoScript: There are various special cases, especially when an extbase backend module is not loaded within page context. The ext:form extension triggers such a special case: When there is only a single page marked as "is_siteroot" without a sys_template record, configuration from globals is not included. The configuration is then incomplete and the module fails. The old TypoScript parser had a dedicated hack and toggle for this, which forced it to still include global configuration. The new TypoScript parser does not contain this hack. Instead, the extbase BackendConfigurationManager "fakes" a sys_template row to trigger the global inclusion. This works if there is no "is_siteroot" page at all, but is not triggered when a page could be determined. The patch slightly changes the extbase logic to also add the fake row if a page could be determined, but no sys_template record exists. Additionally, the ext:form backend controllers now throw a dedicated exception if configuration is incomplete. Resolves: #99458 Related: #97816 Releases: main Change-Id: Ie48cd5c97704c9c4a0ad7a5e555f49f181f88006 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78650 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
-
linawolf authored
Resolves: #99394 Releases: main Change-Id: Ie1fabd4e86bd20dbcfb2bbce6e3431397614c119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78678 Reviewed-by:
-
Frank Naegler authored
The class MagicImageService is deprecated, since it's unused since version 10, due to removal of EXT:rtehtmlarea. Resolves: #99237 Releases: main Change-Id: I2d03315a06abaf618e7cd8544a0ee1d06b1c1100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78662 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
-
Christian Kuhn authored
The last business method of the abstract became unused when the table wizard has been moved to an element with #95036. It is not needed anymore, and is removed, thus the inheritance pattern can be avoided. Resolves: #100631 Related: #95036 Releases: main Change-Id: I9a8540521e771328ad2f57dbc0718021d08182f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78679 Tested-by:
-
Benni Mack authored
With CKeditor table elements are in RTE fields now for tables, however, they need to be added to parseFunc as well. Resolves: #98933 Relates: #99273 Releases: main Change-Id: I51e70a4f6380f2d32e6118e9b303ca46572bd065 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78646 Reviewed-by:
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100627 Releases: main Change-Id: Iaac8c84bd1bf951703a38176e9b634da44df42a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78674 Tested-by:
-
Albrecht Köhnlein authored
Set the variable `$linkParts['tableName']` even if the currently linked record could not be found. The variable is required in later step to show information, which also should be present for deleted records. Resolves: #100611 Releases: main, 11.5 Change-Id: I3f5d1e53d8c6889c8907af5ff56c76eb74efa5fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78654 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Anja Leichsenring authored
The extension does not use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100625 Releases: main Change-Id: I653b2d47efd0fe8ece707e0b362edd33790befd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78671 Tested-by:
-
Benni Mack authored
Resolves: #98985 Releases: main, 11.5 Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78675 Reviewed-by:
-
Anja Leichsenring authored
The wizards don't use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100626 Releases: main Change-Id: I317869dec080e8ce59c4a0903e9564bc5fe96ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78673 Reviewed-by:
-
- Apr 16, 2023
-
-
Albrecht Koehnlein authored
The HTML parser failed to correctly detect single tags with closing `/` and without white space, e.g. `<br/>`. The old tag name detection only splitted the tag content by white spaces, which is not enough to correctly find these valid tags. So the new way is to also remove trailing slashes from the tag name. Resolves: #96347 Related: #96307 Releases: main, 11.5 Change-Id: I3acefcbf046600bf118764b873f15b2a1678932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72641 Tested-by:
-
Albrecht Köhnlein authored
Set the array index `$linkDetails['typoLinkParameter']` in `\TYPO3\CMS\Redirects\Service\RedirectService` to pass it through. That information is needed for the LinkBuilder. For example, `DatabaseRecordLinkBuilder` would trigger an array key access error, in case the linked record cannot be found and no link can be generated. This array value is use there for the thrown exception message. The team play between `LinkService->resolve()` and the `LinkBuilder->build()` should be reviewed in a dedicated change. It may be useful, that the resolver directly adds this information to the result, making the manual adding at several placed through out the core obsolete. Comments are added to document this. Resolves: #100612 Releases: main, 11.5 Change-Id: I74cbf5cbb1b91e0045207873554aec4477986c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78656 Reviewed-by:
-
Christian Kuhn authored
Extbase has an own feature toggle system. This is based on TypoScript configuration and the awful ConfigurationManager. TYPO3 v10 introduces a core-based feature toggle system based on TYPO3_CONF_VARS, so extbase overlaps here, and we should get rid of it. Current extbase uses feature toggles for two ancient details, and one option that has been added with TYPO3 v12. The patch deprecates the PHP API and all toggles. In case extbase implements functionality again that needs to be toggled, it should be based on the core feature toggle API instead. Doing this per-extension can be done by prefixing them accordingly if needed. Resolves: #100622 Related: #97096 Releases: main Change-Id: I5776c57af85aa01c97bc0d7fe7eeaf148a3e5016 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78670 Tested-by:
-
Christian Kuhn authored
extensionmanager/ext_typoscript_setup.typoscript file is obsolete since it only sets an extbase feature toggle to the same value as the default value. Resolves: #100620 Releases: main Change-Id: Id05de448194f85adf887c0b4b9f5a7cdfc1077a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78667 Reviewed-by:
-
Benni Mack authored
When using TYPO3_PATH_ROOT and TYPO3_PATH_APP from apache/modules, the prefix is usually "REDIRECT_", so this also needs to be checked for both environment variables, as already done in TYPO3_CONTEXT. Typical use-case is by setting this via .htaccess rules. Resolves: #91798 Releases: main Change-Id: I6392860af8ff5d5016cb473ab6f47787beac39f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78496 Tested-by:
-
Stefan Bürk authored
The docker container image hub is slowly becoming more and more problematic for open source organisations, it's time to move to another container registry for core-testing images. Images are now build and published to both Docker HUB and GitHub Container Registry (`ghcr.io`). To test the ghcr.io images, the patch changes runTests.sh to use them them for local (non CI) execution already. We can not fully switch to ghcr.io yet, since CI uses the docker registry container as mirror for images to heavily reduce network load and increase performance. The registry container however can only mirror hub.docker.io images, so we need a different solution for CI first. When this is done, we'll stop uploading images to docker hub later. Resolves: #100617 Releases: main, 11.5, 10.4 Change-Id: Ia309826618696dc25b15527b73fa704235285479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78665 Reviewed-by:
-
Christian Kuhn authored
Feature #97096 introduced a toggle to skip namespaces in extbase backend modules to beautify backend links. The default is to enabled shortened links, but ext:form toggles this off. The patch removes the default override and adapts some ext:form links to make it work. Note the ext:form module currently suffers from a regression of #98604 - the form editor JS init logic seems to have a race condition and crashes "sometimes". This is not related to this patch and needs to be handled with another patch. Resolves: #100619 Related: #97096 Related: #98604 Releases: main Change-Id: I594df4fdc3fac325b345f0501bc4ef6f9e075733 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78666 Tested-by:
-
Oliver Hader authored
In case an empty array is passed to ContentObjectRenderer::cObjGet(), the process returns early, without invoking any array processing and variable assignments. Resolves: #100615 Releases: main Change-Id: I0c21bb02007a5e013861b62437cde40d7cc41fe5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78659 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 15, 2023
-
-
Jasmina Ließmann authored
The naming of the table headers has been updated, as well as label 'Page title' in the pages TCA itself. The spacing of the table cell containing the page title and icon has been corrected to match the appearance of other tables containing this information. Also, the context menu has been added back and the page title link has been removed. Resolves: #100613 Releases: main Change-Id: I404644f21acb23b3eea33636e9b979a2732c3666 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78657 Tested-by:
-
Jasmina Ließmann authored
With this patch we now stricly use .form-label as class for form field labels in both modules. The width of the option fields in both modules has been optimized for a responsive display. Some wrapping div's with no uses have also been removed. Resolves: #100610 Releases: main Change-Id: I1549b8f7d36000b5deb5cd0a345e18a66e86a9d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78653 Reviewed-by:
-
Jasmina Ließmann authored
The markup of the form to create multiple pages was updated to match the regular markup. After creation, the new and existing pages are now displayed in a table. The displayed page entries now contain a context menu and an edit button to provide a possibility to jump directly to the page settings. Resolves: #100604 Releases: main Change-Id: Ib4377c99f4d0a78de37df9c2f7cc56384f696f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78645 Reviewed-by:
-
