- Nov 15, 2017
-
-
Joshua Westerheide authored
Check for cases where the files array is nested more complex or keywords (e.g. "error") are used as field names. Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt" -F "error=@error_file.txt" localhost:8080` against a custom php script to generate the testing $_FILES array. Resolves: #82976 Releases: master, 8.7, 7.6 Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49 Reviewed-on: https://review.typo3.org/54619 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Benni Mack authored
When doing translations with pages and inline elements (e.g. pages.media), there is an inconsistency when an additional inline element is added to the TRANSLATED page (e.g. language=1). Current (wrong) when adding a translation to a page - localized IRRE children get pid = default page ID (correct) - localized IRRE children only localization get parentid = default page ID (should be translated page ID) Current (wrong) behaviour when adding a IRRE child only available in a translation: - parentid gets localized page => correct - pid gets set to localized page => must be default language The patch corrects this behaviour by always set - the relation (parentid) to the localized page ID - the page ID (pid) to the default language page ID Additionally, when adding an Inline element (IRRE) via AJAX on page properties, the PID gets resolved correctly to be sent to DataHandler. Resolves: #82983 Releases: master Change-Id: Id8bf39524ee608acf452e2b7103087d4299c1e28 Reviewed-on: https://review.typo3.org/54632 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Nov 14, 2017
-
-
Sascha Egerer authored
Exceptions in the ImageViewhelper are currently silently ignored. So you'll get no information if a wrong value has been passed to the src attribute or if there went something wrong. The exception is not rethrown as Fluid viewhelper exception so it will be catched and logged in Production Context by the AbstractViewhelper that calls the render method. Change-Id: I95124ebb945366d260b4351ccb85d61a399c50b5 Resolves: #82918 Releases: master Reviewed-on: https://review.typo3.org/54561 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Mathias Schreiber authored
Stabilize the acceptance tests to activate and deactivate a language by checking only for the alerts instead of the enabled/disabled rows. Additionally make the download a language test fail immediately if the language is enabled. Resolves: #82972 Releases: master, 8.7 Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e Reviewed-on: https://review.typo3.org/54631 Tested-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Susanne Moog authored
OrderBy does not make sense in a count only query and fails on SQL Server, hence it is removed. Change-Id: I676d1913f75c29dd71345dbc0f626e99df0d242f Resolves: #82994 Releases: master Reviewed-on: https://review.typo3.org/54638 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Mathias Brodala authored
Variadic arguments are optional but do not have a default value, thus properly check this. Also render the variadic operator ("...") in the output. Resolves: #82956 Releases: master, 8.7 Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775 Reviewed-on: https://review.typo3.org/54600 Tested-by:Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Georg Ringer authored
Add the missing label and adopt styling of the additional field which allows to link to a page by providing the page ID. Resolves: #82888 Releases: master, 8.7 Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933 Reviewed-on: https://review.typo3.org/54575 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
-
Alexander Schnitzler authored
When using private or protected properties for Dependency Injection via `@inject`, Extbase needs to use the object reflection API to make these properties settable from the outside, which is quite slow and cannot be cached in any way. Therefore property injection should only work for public properties. Releases: master Resolves: #82975 Change-Id: Ia9c6eb48c34c46634e626f7cd97a2e743a6aba7b Reviewed-on: https://review.typo3.org/54618 Reviewed-by:
-
- Nov 13, 2017
-
-
Andreas Fernandez authored
With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported by code completion. Resolves: #82967 Releases: master, 8.7 Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc Reviewed-on: https://review.typo3.org/54614 Tested-by:
-
Christian Kuhn authored
Use latest chromedriver to deal with youngest chrome in acceptance tests. Change-Id: I7d637022fa9e327e771198625943b11b986b5a04 Resolves: #82987 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54629 Tested-by:
-
Stephan Großberndt authored
Improve performance iterating local files by avoiding multiple calls to SplFileInfo. Releases: master, 8.7 Resolves: #82936 Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc Reviewed-on: https://review.typo3.org/54576 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Daniel Siepmann authored
Do not use frontend inclusion API for private template resource. Instead resolve to full absolute path for inclusion. Releases: master, 8.7 Resolves: #82978 Resolves: #82979 Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734 Reviewed-on: https://review.typo3.org/54622 Reviewed-by:
-
- Nov 12, 2017
-
-
Benni Mack authored
An additional SQL index is added to the database. Resolves: #82445 Releases: master Change-Id: I94d1eab5f492b465fafbf3620b0f532e1403be76 Reviewed-on: https://review.typo3.org/54591 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 11, 2017
-
-
Oliver Hader authored
If checkbox/radiobox values contain dots, these are falsely evaluated as array lookup paths. Fix this by passing in separate path segments instead which may contain dots. Resolves: #82210 Releases: master, 8.7 Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6 Reviewed-on: https://review.typo3.org/54007 Reviewed-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
-
- Nov 10, 2017
-
-
Frans Saris authored
Resolves: #82964 Releases: master, 8.7 Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233 Reviewed-on: https://review.typo3.org/54612 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Nov 09, 2017
-
-
Helmut Hummel authored
Because users have no access to deleted pages, the access check always fails, leading to delete page actions not being shown in the history despite being properly tracked. We now check this case and do a more lightweight check so that we still have the permissions checked, but can show deleted pages without disclosing unwanted information. Resolves: #45056 Releases: 7.6, 8.7, master Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c Reviewed-on: https://review.typo3.org/54580 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Alexander Opitz authored
Update the lock file to pull in the latest (1.4.5) release. This version is marked as PHP 7.2 compatible. composer command: composer update typo3/cms-composer-installers Releases: 8.7, master Resolves: #82898 Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7 Reviewed-on: https://review.typo3.org/54570 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Ralf Zimmermann authored
Cache the merged YAML settings into the assets cache to improve the performance. Resolves: #82373 Releases: master, 8.7 Change-Id: I601364d5957f26f1b369b513534936820f72b78e Reviewed-on: https://review.typo3.org/54106 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
Benni Mack authored
The TYPO3 Backend PageTree, built in TYPO3 4.5, has some strange quirks resolving DB records, doing a lot of queries for fetching a single page multiple times. This is unnecessary because this can be fetched with one query, which happens anyway. Additionally, the WSOL should only happen when a workspace is selected. Explicitly querying for "-1" pid etc. should be handled via SQL, and not explicitly implemented by the page tree. Bottom line: Remove one SQL-query per page which is loaded. As most of the PHP classes will be restructured with the upcoming ExtJS / ExtDirect removal, the removed methods will be part of the breaking change of ExtJS removal. Resolves: #82945 Releases: master Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e Reviewed-on: https://review.typo3.org/54574 Tested-by:
-
- Nov 08, 2017
-
-
Susanne Moog authored
Several times the install tool was using html() instead of text(). Use text() whenever possible. Resolves: #82949 Releases: master Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a Reviewed-on: https://review.typo3.org/54586 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Christian Kuhn authored
The v9/master branch of styleguide generates correct page localizations of styleguide demo data pages in table pages instead of pages_language_overlay. Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc Resolves: #82952 Related: #82445 Releases: master Reviewed-on: https://review.typo3.org/54592 Tested-by:
-
Christian Kuhn authored
This is probably the last version with v8 and v9 in sync before branching off styleguide v8. Styleguide introduced a new table with 8.0.13, one of the acceptance tests that uses a rather hard coded xpath now needs a slightly different selector to cope with that. Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0 Resolves: #82951 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54588 Tested-by:
-
Andreas Fernandez authored
Ensure that jQuery is available in NewRecordController. Resolves: #75676 Releases: master Change-Id: Idf437554fb136e8e4ae18ce0d229d6b3ed8a58e4 Reviewed-on: https://review.typo3.org/54587 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Cybercraft authored
Instead of having the new content element wizard in a separate module page it will be opened in a modal now. Resolves: #75676 Releases: master Change-Id: If117fe3f2d55a4163bcb5c153b47938953050348 Reviewed-on: https://review.typo3.org/52999 Tested-by:
-
Benni Mack authored
The patch migrates all data from pages_language_overlay into pages, and moves all API calls to overlay pages. The following restrictions are set: * Backend is always showing pages only for "sys_language_uid=0" for the page tree, element browser (e.g. "linking to default language page"), except where explicitly requested like the Page Module => Languages view. * pid and sorting are always the same for all translations and their default language page * Elements on a page are always keeping the field "pid" to the default language page (no change) * Permission checks for Backend users are always made against the default language page (perms_* fields and webmounts) Resolves: #82445 Releases: master Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260 Reviewed-on: https://review.typo3.org/51272 Tested-by:
-
Benni Mack authored
The DB setting "sys_domain.forced" is confusing and does not make sense nowadays, especially with nested domain records - where the rootline is now correctly traversed with the RootLine utility. Resolves: #82926 Releases: master Change-Id: I874c54aeb03c0b62c9a1cebc9d629cee7550ec0b Reviewed-on: https://review.typo3.org/54540 Tested-by:
-
Georg Ringer authored
The title of a translated page must be overlayed with the workspace version. Resolves: #65607 Releases: master, 8.7, 7.6 Change-Id: If10260f196776a16a53968b78542827ecbc145fe Reviewed-on: https://review.typo3.org/54583 Reviewed-by:
-
- Nov 07, 2017
-
-
Malte Koitka authored
If an overideChildTca key is already added by a TYPO3 core function like ExtensionManagementUtility::getFileFieldTCAConfig() the TCA migration should not be skipped. Otherwise the config will be incomplete and result in missing fields. The migration is changed that old "foreign_types", "foreign_selector_fieldTcaOverride" and "foreign_record_defaults" are merged into new "overrideChildTca", but the new settings are keps (take precedence) if given. Resolves: #80719 Resolves: #81045 Releases: master, 8.7 Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505 Reviewed-on: https://review.typo3.org/52693 Tested-by:
-
Benni Mack authored
This patch unifies the Backend module registration for Extbase modules like it has already been done for all other Backend modules using PSR-7 entry-points. This way backend route dispatching and module registration has been simplified. The entrypoint for Extbase Backend modules is now \TYPO3\CMS\Extbase\Core\Bootstrap->handleBackendRequest() which returns a PSR-7 response object. The following functionality has been marked as deprecated as it was solely built to handle Extbase modules when conf.php and index.php were still in style: ExtensionManagementUtility::configureModule() $GLOBALS['TBE_MODULES']['_configuration'][$name]['configureModuleFunction'] Releases: master Resolves: #82902 Related: #58621 Change-Id: I7956b350d650ed52bc7b5d83db20df386d79eb65 Reviewed-on: https://review.typo3.org/54531 Tested-by:
-
Benjamin Rannow authored
under the right condition multiple duplicate cache commands are executed for Example: save a record in Backend can course multiple 'pages' commands will be executed, if the record has inline records. flushing '20' times the 'pages' cache is unnecessary. Resolves: #82930 Releases: master, 8.7 Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4 Reviewed-on: https://review.typo3.org/54569 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Tymoteusz Motylewski authored
In order to make page tree smaller and easier to review, this patch applies new JS CGLs on SvgTree related files. Releases: master Resolves: #82935 Change-Id: I5c9b8b889b21e77b4bcd7add2236eb849d204356 Reviewed-on: https://review.typo3.org/54572 Tested-by:
-
Claus Due authored
This patch moves a previously hardcoded list of Fluid implementations from the RenderingContext constructor, to TYPO3_CONF_VARS. Extensions and site administrators can then add their own implementations to this array and have them be used in every RenderingContext. See included RST file for further information on usage. Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417 Resolves: #82763 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54395 Tested-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Christian Kuhn authored
The type=input, renderType=inputLink field control has an option "allowedExtensions" to restrict the file element browser to specific file endings. This option is now correctly considered in file browser. Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018 Resolves: #82861 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54520 Tested-by:
-
- Nov 06, 2017
-
-
Tymoteusz Motylewski authored
Fixes missing labels in the svg category tree toolbar. Releases: master Resolves: #82934 Change-Id: Iac29bc35b40894630599b3fbec48daf870a8777a Reviewed-on: https://review.typo3.org/54571 Reviewed-by:
-
Dandy Umlauft authored
Added default and inline usage for the optional attribute "allowedTags" Maybe you have to think about the name, cause in http://php.net/manual/de/function.strip-tags.php the second parameter is called "allowableTags", and not "allowedTags" This can lead to a quick overlooked error ;) Releases: master Resolves: #82912 Change-Id: Icc3cab9a931790e621f5593ea487c9b23b779e30 Reviewed-on: https://review.typo3.org/54546 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Helmut Hummel authored
Update the lock file to pull in the latest release. composer command: composer update typo3/cms-composer-installers Releases: 8.7, master Resolves: #82898 Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981 Reviewed-on: https://review.typo3.org/54568 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benni Mack authored
The following pageTSconfig options are removed: - options.pageTree.excludeDoktypes No doktypes are exclueded anymore in search. - options.pageTree.disableIconLinkToContextmenu Icon Links are always selected (option had no effect anymore). - options.pageTree.searchInAlias Alias is now always searched for. - options.pageTree.hideFilter The filter is always shown, this feature should not be available on a per-user basis. Resolves: #82919 Releases: master Change-Id: Ie0031fef9948bf758e880b04662210d74e27688b Reviewed-on: https://review.typo3.org/54560 Reviewed-by:
Eugene Kenah Djomo <kdeugene@yahoo.fr> Reviewed-by:
-
Georg Ringer authored
The parameter 'gclid' is used as click identifier for Google AdWords and must not be used during the cHash generation. Resolves: #82927 Releases: master, 8.7 Change-Id: Id279238738550cfbd0b86e6decf94a86230535ee Reviewed-on: https://review.typo3.org/54562 Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #82920 Releases: master, 8.7 Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a Reviewed-on: https://review.typo3.org/54557 Tested-by:
-
Wouter Wolters authored
With #69884 the new button API was introduced but the back button in DatabaseRecordList was forgotten. The button is now done with the new API. Resolves: #82056 Releases: master Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d Reviewed-on: https://review.typo3.org/53722 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Reviewed-by:
-
