- Feb 25, 2020
-
-
Benjamin Kott authored
Widget footer is now only rendered if the optional footer section for widgets is used and contains content. In addition, minor styling issues were resolved. Templates were cleaned up again. Some extra conditions were added to prevent empty tags. Resolves: #90530 Releases: master Change-Id: Idb4a6858395622a62448041fec3d510bec6fb271 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63410 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Anja Leichsenring authored
The upcoming release of TYPO3 10.3 requires all documentation to be placed into the version folder. Resolves: #90510 Releases: master Change-Id: Ieccc5fa1c71a3f2d0513a4a1e6d2f053a0bb0c3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63393 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
With #78450 the StandardContentPreviewRenderer creates an instance of the `PageLayoutView` to keep the existing hooks alive. However 2 more properties need to be filled to improve the compatibility. Resolves: #90528 Releases: master Change-Id: I0c56988bdc9d524f1cfa411ae0c62d00ad1789dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63408 Reviewed-by:
Claus Due <claus@phpmind.net> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
ochorocho authored
Add example for elements of type RadioButton/MultiCheckbox. Releases: master, 9.5 Resolves: #90520 Change-Id: Ifaeac0d2e3ef017aeb717aa52bc7c763ba16e8ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63409 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Before the final release of the dashboard some clean up is done. Among others following tasks are performed: * Add missing PHPDocs * Remove unused methods * Remove superfluous properties * Unify namespace format * Fix some typos * Fix some formatting * Make closures static * NoDashboardAvailableException is removed as it is never be thrown * Extend documentation for missing widget groups Resolves: #90524 Releases: master Change-Id: Ia0f7d71def358bf0ee8ab42d97f012c14cdede1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63407 Tested-by:
-
Claus Due authored
This introduces a new approach to registering and rendering previews; for content elements initially but possible to apply to any record type, and possible to call from other contexts than the PageLayoutView, e.g. AJAX-based preview rendering. Basically, this turns the old hook approach into a proper pattern where preview renderers are registered for a specific CType and must implement proper interfaces. A Resolver pattern is also introduced with a standard implementation and a standard renderer is registered for backwards compatibility. Resolves: #78450 Releases: master Change-Id: Ibf85d9b50b7bc6506d72c1ee63078373eaf9e433 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/50389 Tested-by:
-
Benni Mack authored
AssetCollector is a concept to allow custom CSS/JS code, inline or external, to be added multiple times in e.g. a Fluid template (via <f:script> or <f:css> ViewHelpers) and only be added once. It considers best practices by having a "priority" flag to be either be moved in the <head> area (for CSS useful in above-the-fold concepts) or at the bottom of the <body> tag contents. AssetCollector helps to work with content elements as components, reducing effectively the amount of CSS to be loaded and also incorporates the HTTP/2 power where it is not relevant to have all files compressed and concatenated in one file (although this could be added later-on). AssetCollector is implemented as singleton and should slowly replace the various existing options in TypoScript which seem to be confusing. AssetCollector also collects information about "imagesOnPage" effectively taking off pressure from PageRenderer and TSFE to store common data in FE - as this is now handled in AssetCollector, which can be used in cached and non-cached components. Resolves: #90522 Releases: master Change-Id: I6ce8141ad8891a7a8ee6d4f8a7377d93a894c3b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63327 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Daniel Gohlke <daniel.gohlke@extco.de> Tested-by:
-
- Feb 24, 2020
-
-
Daniel Gohlke authored
The resolveControllerAliasFromControllerClassName returns an alias respecting subfolders in controller namespace to avoid same aliases for different controllers and to load the templates from corresponding directories. Resolves: #90480 Releases: master Change-Id: I3ed691e126579a4cfcc35f9589beb017b06a2f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63361 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Oliver Bartsch authored
A new widget is added which displays a list of security advisories from the typo3.org RSS feed. Resolves: #90512 Releases: master Change-Id: Ie01eb859c8f434efea7383e43134aafa251fdc10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63397 Tested-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Stefan Froemken authored
- Add possibility to use records of sys_file_reference - Add possibility to resize images - Add possibility to apply cropVariants Resolves: #90068 Releases: master Change-Id: Ib80021dc25b42e7021cf5429b2df8029aac1fd8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62834 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Susanne Moog authored
This reverts commit a848ba4f. While the feature works well on fully configured sites, in case of errors this is currently too unstable and may result in infinite recursions when a page is not configured (for example if no TS Template is present). When reimplementing we should add more tests and recursion prevention in order to stabilize the behaviour. Change-Id: I9f6f5155a78e7d515107f8b6b8d16dc55b78b7dd Resolves: #90523 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63308 Tested-by:
-
Georg Ringer authored
GeneralUtility::validEmail uses now Egulias\EmailValidator instead of the method `filter_var` for validating an email address. This allows more email addresses to be valid. Resolves: #90370 Releases: master Change-Id: I29bf4c994d730c789828cdecc247080dd669d9fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63235 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Sybille Peters authored
Linkvalidator should show broken links only in the list of broken links, if current backend user has edit access to the field. This way the editor will no longer get an error message on trying to edit records he has no permission to edit. Whether the editor has access depends on a number of factors. We check the following: * The current permissions of the page. For editing the page, the editor must have Permission::PAGE_EDIT, for editing content Permission::CONTENT_EDIT must be available * The user has write access to the table. We check if the table is in 'tables_modify' for the group(s) * The user has write access to the field. We check if the field is an exclude field. If yes, it must be included in 'non_exclude_fields' for the group(s). * The user has write permission for the language of the record * For all tables with type fields: The type is in list of explicitly allowed values for authMode (or not explicitly denied depending on the setting). Resolves: #84214 Releases: master Change-Id: Iade53d0452e0a5dec98e9d5b7b149d137f170949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61786 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Claus Due authored
Fixes a couple of issues: * Missing button text for "new content" button * Two cases of access to undefined variables * Add missing f:format.raw in record footer * Add missing paste-after icon Resolves: #90506 Releases: master Change-Id: I9facb46ecaf6dfb7ebc76a2733a4a8c6e2cb3c93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63390 Tested-by:
-
Oliver Bartsch authored
A new widget is added which displays the number of failed logins during the last 24 hours. Resolves: #90355 Releases: master Change-Id: I24e9e40fd7ed567f97867910d6988d8662fd7a14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63364 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
-
Daniel Siepmann authored
Include current day when collecting data and labels for sys log widget. Resolves: #90517 Releases: master Change-Id: Idc65d03df0e6d115450cc080c479b52759636123 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63400 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Daniel Siepmann authored
sqlite3 doesn't return casted values right now, everything is a string. Some methods require integers, e.g. uid of a record. In order to prevent TypeError due to mismatch, values are casted to integer. Resolves: #90515 Releases: master Change-Id: Ibb1654a412f94b5bd511dac5bed75a1af0683fe9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63399 Reviewed-by:
-
Christian Eßl authored
The PageContentErrorHandler provided by the core can take in either a URL or a page uid for resolving an error page in the frontend. In both cases, the class would then start a Guzzle/cURL request to fetch the error page content. This has now been changed for internal pages, where a page uid has been given. In this case, the PageContentErrorHandler will now dispatch an internal SubRequest instead, to avoid an unnecessary cURL call. In staging environments, the website would often be access protected with basic auth options (for example a .htpasswd auth file on Apache Webservers). In such a case, error pages with the default PageContentErrorHandler would have failed before, as the internal cURL call for fetching the error page was lacking these required basic auth options. For internal pages, a sub request is now used, bypassing the need for an external cURL call. This solution is mostly based on Benni Mack's LocalPageContentErrorHandler with his approval. Resolves: #90505 Releases: master Change-Id: I9da835cd42503d7a52f9050ae5658eae53336a56 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63389 Reviewed-by:
-
Oliver Bartsch authored
All widgets should be registered the same way to increase consistency in the core file. The second registration variant is documented in the corresponding rst file anyway. Resolves: #90502 Releases: master Change-Id: I3e12890cecb130f4ea6815e01501691c5081735b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63387 Tested-by:
-
- Feb 23, 2020
-
-
Christian Eßl authored
In the new fluidbased page module view, if a previously configured BackendLayout has been removed. (For instance, the extension providing it has been removed), the module would throw an uncaught error, because the script would try to call a method on a non-existing BackendLayout. This patch fixes this problem by automatically falling back to the "default" BackendLayout, if the requested one couldn't be provided. This is the same way as the old PageLayoutView would have reacted to this problem. Resolves: #90479 Releases: master Change-Id: I76127e9b53bcb0ac55875857ca11262a323c6013 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63370 Tested-by:
-
Daniel Siepmann authored
Prior only an warning was logged, and a fallback rendering jumped in. With this change an error is rendered in addition to logging. No fallback will be triggered anymore. This should raise awareness and ease integration for integrators. Please note that already broken elements might now show an error instead of fallback preview. This is only activated for admin users and enabled BE|debug system setting. Resolves: #90427 Releases: master Change-Id: I1f24a1e775ba4f12917ed26dc29b0ea78ab81a1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63318 Reviewed-by:
Ingo Fabbri <ingo.fabbri@gmail.com> Reviewed-by:
-
Christian Eßl authored
The changes made to the ElementInformationController in #88901 had a few problems and regressions: - A lot of information for files and folders, that has previously been shown, was now missing. - Metadata for files was missing as well, because this information is saved in a separate table. (sys_file_metadata) This patch brings back all the lost information. Also, the Metadata of a file can now be viewed in the ElementInformation window as well. Resolves: #90441 Related: #88901 Releases: master Change-Id: Idb710c83b74845e6ec8b6e2dc7c3d906841ea6ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63332 Tested-by:
-
Benjamin Kott authored
Resolves: #90497 Releases: master Change-Id: I5cddd6be004f49d2c44076f5a2a5733401f52235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63380 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Daniel Goerz authored
Resolves: #90499 Relates: #90491 Releases: master Change-Id: Ib2a3f53b88f4a19da0ca2d115114278ddd628f60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63383 Tested-by:
-
Daniel Goerz authored
Resolves: #90500 Releases: master Change-Id: Ieaecff065dcc60c4e8e7c7a19d87fe5a8d18cd40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63384 Reviewed-by:
-
Oliver Bartsch authored
Using the example registration of a custom widget would lead to an ArgumentCountError respectively an RuntimeException as the `arguments` key is missing. Therefore the key is added to the configuration examples. Resolves: #90501 Releases: master Change-Id: Ib6666169fda610dd6393f4869f476d0a29edd56e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63386 Tested-by:
-
- Feb 22, 2020
-
-
Oliver Bartsch authored
In #88901 the `showRecordFieldList` field was removed from all core tables and won't be evaluated anymore. A corresponing TcaMigration is therefore added. Resolves: #90498 Related: #88901 Releases: master Change-Id: Ife2ce2374e16bd981c9d77da285506542a1b1168 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63381 Tested-by:
-
Andreas Fernandez authored
In order to fix most known vulnerabilities in development-related npm packages, all packages have been updated to their respective latest version. Executed commands: yarn upgrade yarn build Since packages related to minification and publicly used packages like CodeMirror have been updated, this patch contains some more changed files. Resolves: #90496 Releases: master Change-Id: I65a307dae58224c75b8d0fc8a34c28fc1db465f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63379 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Alexander Schnitzler authored
Class \TYPO3\CMS\Form\Mvc\Property\Exception\TypeConverterException provides a factory method fromError to instantiate new instance of itself. It's done via new static(...) which is unsafe if the class is not final as the implementation cannot know if constructors of sub classes have the same method signature like itself. One solution to this issue is to make a class final, another is to use new self() instead of new static(). In this case, the class is made final as this is a very specific Exception already and unlikely to be extended. Releases: master Resolves: #90401 Change-Id: I4f1127cc423cb1c865b8f422a3047ad5888d00f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63275 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
Executed commands: yarn add --dev typescript@~3.8.2 yarn upgrade --pattern "^@types" grunt build Resolves: #90495 Releases: master Change-Id: Ie60cc8dd2bdc971f1e904865cc616ed384b9fc10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63377 Tested-by:
-
Oliver Bartsch authored
The TCA configuration `showRecordFieldList` inside the `interface` section won't be evaluated anymore since #88901 and is therefore removed. Resolves: #90493 Related: #88901 Releases: master Change-Id: I3290da15fe44d57735087725bd881604cf530e9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63375 Tested-by:
-
Sybille Peters authored
Fix changelog for BrokenLinkRepository::getNumberOfBrokenLinks() in linkvaildator Resolves: #90494 Releases: master Change-Id: Id94026971af93e8d0be0b2bd97ab5e783458a148 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63376 Tested-by:
-
Sebastian Klein authored
The softhyphen button in RTE CKEditor separates HTML inline elements. If the softhyphen is inserted inside a link, it results in two individual links with the ­ entity between. This can already be examined in the source view of the RTE. Furthermore, a ­ entity between two HTML tags will prevent the browser to insert a hyphen at the position of the linebreak. Setting the optional mode 'text' to the insertHtml event will prevent this behaviour, as the inserted content will then inherit the styles which are applied in the selected position. Resolves: #88727 Releases: master, 9.5, 8.7 Change-Id: I4a398b02aba306016da12f290dab958b2e9ccf2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61251 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Felix P. <f.pachowsky@neusta.de> Reviewed-by:
-
Andreas Fernandez authored
This patch removes some dependencies that are not used at all in TYPO3. Executed command: yarn remove grunt-npm-install anymatch request Resolves: #90492 Releases: master, 9.5 Change-Id: I4150fb526b673b8cc91d85137170ce0e44dff930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63374 Tested-by:
-
Benjamin Kott authored
This patch cleans up stylings across various modules and streamlines the used markup as well as the folder structure. Resolves: #90491 Releases: master Change-Id: I7cf564da3e981f455c466dbc24a33858145525b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63362 Tested-by:
-
Oliver Bartsch authored
Fixes several typos and improves readability of PHPDoc comments through ext:dashboard classes. Resolves: #90486 Releases: master Change-Id: I27cd1c0c2dd3c3b18bade0b50af41aa8d8bfd06e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63368 Tested-by:
-
Oliver Hader authored
Parameters being generated internally by TypoLink using `<f:link.typolink parts-as="typoLinkParts">` view helper are exposed as variable and can be used in Fluid templates again, which are: * url * target * class * title * additionalParams Resolves: #90026 Releases: master Change-Id: I6c3386ed1f177aeb98171056f5d8bd2991d6cf46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62769 Tested-by:
-
Gerrit Mohrmann authored
This adds Argon2id to the password hash algorithms. It should be available since PHP 7.3. Resolves: #90262 Releases: master Change-Id: I3810ca11330b7c7079408cd5a7f504e514a3262e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63077 Tested-by:
-
Benjamin Kott authored
Resolves: #90490 Releases: master Change-Id: Idc9c1d2fb2990116933e6cc0e1700daa46778847 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63373 Tested-by:
-
Daniel Goerz authored
This patch restores the possibility to enable backend users in the compare view again. It also reinstalls the check for online users to prevent disabling a currently logged in user. Resolves: #90488 Relates: #90298 Releases: master Change-Id: I0919403a41de136c7461e0d9367b3795bbf68358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63371 Tested-by:
-
