Skip to content
Snippets Groups Projects
Commit a848ba4f authored by Christian Eßl's avatar Christian Eßl Committed by Georg Ringer
Browse files

[FEATURE] Allow PageContentErrorHandler to resolve pages with sub requests

The PageContentErrorHandler provided by the core can take in either a
URL or a page uid for resolving an error page in the frontend. In both
cases, the class would then start a Guzzle/cURL request to fetch the
error page content.
This has now been changed for internal pages, where a page uid has been
given. In this case, the PageContentErrorHandler will now dispatch an
internal SubRequest instead, to avoid an unnecessary cURL call.

In staging environments, the website would often be access protected
with basic auth options (for example a .htpasswd auth file on Apache
Webservers). In such a case, error pages with the default
PageContentErrorHandler would have failed before, as the internal cURL
call for fetching the error page was lacking these required basic auth
options.
For internal pages, a sub request is now used, bypassing the need for
an external cURL call.

This solution is mostly based on Benni Mack's
LocalPageContentErrorHandler with his approval.

Resolves: #90505
Releases: master
Change-Id: I9da835cd42503d7a52f9050ae5658eae53336a56
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63389


Reviewed-by: default avatarBjörn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: default avatarSusanne Moog <look@susi.dev>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarSusanne Moog <look@susi.dev>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
parent 6c4d73f5
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment