- Jan 18, 2023
-
-
Jasmina Ließmann authored
To reduce the size of the list and improve clarity, the individual list entries can now be expanded and collapsed. Resolves: #99577 Releases: main Change-Id: I0703955f6ec171b69b371c4b08aa76e2d2a12cc9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77453 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Torben Hansen authored
Resolves: #99595 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I57e085abc685ba918754de3be25ad0eef906f725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77463 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
This change reduces all logic where "fallback to default language" is outside of LanguageService, allowing LanguageService to deal with such functionality now. Resolves: #99587 Releases: main Change-Id: I01717d229d5f61ef6ab67886a30b9b73ccb4e193 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77421 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Gordon Brüggemann authored
This change enables functionality of every content to use the fallback chain to loop over each fallback language to check for a fallback content in a different language ID. This is now in line with the page resolving fallback handling and finally completes the options within site configuration "fallbackChain". This works in Extbase and TypoScript environments. Resolves: #88137 Releases: main Change-Id: I987a296c6e483967d497bf59e71b8c5cbcd54938 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67893 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jan 17, 2023
-
-
Oliver Bartsch authored
A new PHP Attribute "UpgradeWizard" is added, which is used to auto-configure and auto-register upgrade wizards. This replaces the registration via $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/install']['update'], which has therefore been deprecated together with the getIdentifier() method in the UpgradeWizardInterface. An upgrade wizards' unique identifier is now defined as first constructor argument of the new PHP attribute. Resolves: #99586 Releases: main Change-Id: Id93ed4c980f9057bb297853354ddcc9c4c23860e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77452 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Torben Hansen authored
The field `realName` has been added to the "Create Administrative User" modal in ext:install, so it is possible to provide the name of a new admin user. The notice in the header of the model has been removed, since it is superfluous now. Resolves: #99584 Releases: main Signed-off-by:
-
Oliver Hader authored
Using CSP directive `style-src 'unsafe-inline'` seems to be fine for directly requested SVG files, since corresponding definitions are bound to the corresponding resource. Loading styles from any other external resource is still denied. Resolves: #93884 Releases: main, 11.5, 10.4 Change-Id: Ifddf8782ecaa81bf26026ae8850d8c53b7977bd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75594 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
This change cleans up some tests, and also streamlines some usages (not all of them) of $TYPO3_CONF_VARS['EXTCONF']['lang']['availableLanguages']. Resolves: #99578 Releases: main Change-Id: I52b6f43260d08abf59d6078498511084469b2308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77423 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Oliver Bartsch authored
This reverts commit abd887a1. Reason for revert: Multiple places are broken now. See comment from Nikita in the original patch. Change-Id: Ib9970eb0b5b449899adc2b5b082283948349a1f5 Reverts: #99580 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77433 Tested-by:
-
Benjamin Franzke authored
Increase the target area height from 13px to 48px and let the anchor tag cover the entire panel heading size. Releases: main Resolves: #99580 Change-Id: I859db3f96f2f819ec4b272dd98e61b44a79c4eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77428 Tested-by:
-
Torben Hansen authored
The password for a new administrative backend user created using the install extension does now consider the configurable password policy introduced in #97388 Resolves: #97392 Releases: main Change-Id: I711071acdd7c8bcf10b04a1ca46b7d486c742f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77233 Tested-by:
-
Nikita Hovratov authored
Since the introduction of always absolute (web) paths inside the TYPO3 backend, the TCA ctrl option `selicon_field` didn't work anymore since relative web paths like `fileadmin/file.png` changed to `/fileadmin/file.png`, which were not handled and resulted in a missing icon. This patch extends the condition for checking for absolute paths and prevents the GU:getFileAbsFileName method from turning web paths into empty strings. Resolves: #95572 Resolves: #97442 Related: #95027 Releases: main, 11.5 Change-Id: I1b82f71fe4f0636bd786d102f361ca60c1294af9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77208 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Kuhn authored
Resolves: #99582 Releases: main, 11.5 Change-Id: Ib7a0f546f025eed37bac6b494f29865494841787 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77429 Reviewed-by:
-
Torben Hansen authored
The web components for the following TCA types had a wrong closing tag: * `\TYPO3\CMS\Backend\Form\Element\ColorElement` * `\TYPO3\CMS\Backend\Form\Element\FolderElement` * `\TYPO3\CMS\Backend\Form\Element\TextElement` Resolves: #99581 Releases: main Change-Id: I9c98d2ff82eef9f5fcf205ef6527f99ffcbf99d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77427 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Georg Ringer authored
Set the argument `muted` if autoplay is enabled for vimeo and local videos - just as done for YouTube videos in #96320 Resolves: #99301 Resolves: #99461 Related: #96320 Releases: main, 11.5 Change-Id: I81848a724dc736b49c4c98c4c2f59627be169f8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77288 Tested-by:
-
Benjamin Kott authored
CKEditor4 had several ways of defining toolbars - Basic, Advanced, Toolbar Groups, and Toolbar References. All these cases are now covered in the migration and updated to the CKEditor5 format. There can only be one `toolbar` or a `toolbarGroups` definition. The preference is `toolbarGroups` since we assume it only exists on an incomplete migration. Instead of mapping groups to new definitions, we are now resolving each main and subgroup to the CKEditor4 defaults. Each item is migrated to the CKEditor5 equivalent if one exists. CKEditor5 allows buttons to appear multiple times in a configuration. The migration now ensures that buttons exist once. Duplicates are removed during the migration to reproduce the behavior of CKEditor4. Resolves: #99556 Releases: main Change-Id: Ib403f377895cc0f8020b7f0070a969088a9eec28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77358 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Anja Leichsenring authored
Resolves: #99564 Releases: main Change-Id: I64b1adaec854a565b73e60455dc731b9d6d5053f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77404 Reviewed-by:
-
Oliver Klee authored
The new version finds some more potential problems. > composer req --dev phpstan/phpstan:^1.9.12 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99573 Releases: main, 11.5 Change-Id: Ieee3a5881a854946cb180965e4f182b27ea05aaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77419 Reviewed-by:
-
Christoph Lehmann authored
This introduces less but bigger queries. Queries are also chunked to avoid hitting platform/driver placeholder limit, if `doctrine/dbal` transform eventually unsupported named query params to positional ones. Releases: main Resolves: #99555 Change-Id: I7af6060781ddaeabae34f2c4544046e3ab926b5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77392 Tested-by:
-
Benni Mack authored
LanguageService can also be used for overriding labels via TypoScript. For this reason, TranslationService from EXT:form can be slimmed down similar to how Extbase's TranslationUtility was migrated in: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77399 Because TranslationService does not have an input for alternative language keys, the dependency functionality from LanguageService can be used. Resolves: #99566 Releases: main Change-Id: I76536087d2210bbd4d47fc9119abd86af3348a9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77412 Reviewed-by:
-
Christian Kuhn authored
Resolves: #99572 Releases: main, 11.5 Change-Id: I65fe76b733b6b0fce9ebb7dd54759ae673ab1755 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77417 Tested-by:
-
Oliver Bartsch authored
To simplify working with the UpgradeWizardService, the patch cleans up the following: * Extract database related tasks into an own service * Fetch UpgradeWizardService via container Resolves: #99570 Releases: main Change-Id: Ia18aa19cea8743890a4e85629b7e720ee73a7220 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77416 Reviewed-by:
-
Christian Kuhn authored
Just another sanitation in lowlevel QueryGenerator. Resolves: #99568 Related: #98536 Releases: main, 11.5 Change-Id: Id7d8aa9856e7e148964bff0ef66e7c7b69bd6aaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77413 Reviewed-by:
-
Benni Mack authored
The functionality to handle TypoScript overrides for Labels is now moved from Extbase LocalizationUtility to LanguageService. All tests now use proper XLF files and also real TypoScript values, in order to make the tests easier to understand. Instead of magic $LOCALLANG and $LOCALLANG_UNSET properties, LocalizationUtility now keeps the actual LanguageService objects in its storage. The LanguageService->overrideLabels() method should be used with care, as other instances of the object might not have the overrides stored. Resolves: #99559 Releases: main Change-Id: I3e83695baebec545b5e6c5d8504df95950a543cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77399 Tested-by:
-
Jasmina Ließmann authored
The submodule "TSconfig page" is to be streamlined. Therefore some options in the function menu have been removed. We will continue to work on this module. Resolves: #99565 Releases: main Change-Id: I2ca41d9a029f0f26878137228a9d84a96179b132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77406 Reviewed-by:
-
Jasmina Ließmann authored
Move PageTsConfig tree rendering from a PHP method to Fluid as a cleanup of the controller. Resolves: #99562 Releases: main Change-Id: I31afce9a9f74a1e728b97a2a2bb324b9005be7d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77398 Tested-by:
-
Georg Ringer authored
Relax the usage of the attribute approved added with #97729 by allowed translations without the approved attribute Resolves: #99265 Related: #97729 Releases: main Change-Id: I7802b597c746d885e458f13d351ce0c2a9be6034 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77032 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
Resolves: #99561 Releases: main Change-Id: I3f8a5e4d89c31f28703e91cbd02840ecfc7df9a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77403 Tested-by:
-
- Jan 16, 2023
-
-
Sybille Peters authored
Checking for duplicate slugs in DataHandler will now make sure that no two fields with the same slug exist, where one of them has a language of -1. Existing records are not migrated. This could be done in a followup patch or with a community extension. When new records are created or changed which have a field of type "slug", a unique handling ensures that no records exists with the same slug (depending on the additional settings "unique", "uniqueInSite" and "uniqueInPid"). The language is considered as well: Records with the same slug can exist if the language differs. But language -1 was not considered previously. Since -1 means all language, no other record with the same slug should exist in ANY language if a record with language -1 exists. Resolves: #99529 Releases: main, 11.5 Change-Id: I919c3a3954df02cd55c701c480f6c1a8c87d84d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77383 Tested-by:
-
Benni Mack authored
PageRepository->getExtURL() is a pretty upgly public helper method that has a depedency to $GLOBALS['TYPO3_REQUEST']. It is used only once. The patch moves the method body to the consuming class and deprecates it. Resolves: #99558 Releases: main Change-Id: I7c1e8d6b1a454950de6fa7469d13fbab81ee2962 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77330 Reviewed-by:
-
Oliver Bartsch authored
The file mount identifier, introduced in #97922 might be invalid, e.g. in case the upgrade wizard was not executed yet. To prevent an undefined array key warning, the identifier is now properly checked, like already done in the StoragePermissionsAspect. Resolves: #99560 Related: #97922 Releases: main Change-Id: Iba75d2a6792a5e619a5ea51d9664e511c8ad46ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77400 Tested-by:
-
Oliver Bartsch authored
Resolves: #99557 Releases: main Change-Id: Idf145a98aa3fd386ff9906a4ee9cf5f0593fe8a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77397 Tested-by:
-
Torben Hansen authored
The `redirectMode=referer` configuration allows to process a redirect after a successful login to an evaluated referer value. For the legacy version of the felogin plugin, the referer value has been evaluated using the GET/POST parameter `referer` and the `HTTP_REFERER` as fallback. The extbase version of the felogin plugin currently only evaluates the GET/POST parameter `referer`. This patch adds the missing `HTTP_REFERER` fallback evaluation of the referer. Resolves: #91844 Releases: main, 11.5 Signed-off-by:
-
Georg Ringer authored
As the selection "explain" only works for Mysql, it should also only be displayed then. Resolves: #99512 Releases: main, 11.5 Change-Id: I93ddf86d1f63ef124feb2b72e86f32d8260ad99f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77324 Reviewed-by:
-
linawolf authored
Resolves: #99542 Releases: main, 11.5 Change-Id: Ifa05cc27825bc4c89dd9b08f66c03505270fd815 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77388 Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Benni Mack authored
Avoid heavy mocking in tests by utilizing Functionals incl. PackageManager and Caching Framework. Resolves: #99553 Releases: main Change-Id: Ie569e87c0710a50ce09cc60f3d9a1773d39d4b4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77391 Tested-by:
-
Elias Häußler authored
When authenticating and fetching user records, appropriate methods normally pass around either the full database record or `false` in case the user does not exist or could not be authenticated. The expected types are now added to all relevant methods in authentication services. Resolves: #99544 Releases: main, 11.5 Change-Id: Ib45440a39e64b5ac5a1f1c4799e2f59cb13526bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77385 Tested-by:
-
Benni Mack authored
PageRenderer has some speciality but also code duplication from LanguageService and can be simplified this way, avoid additional parsing states. This way, LanguageService can be used more instead of handling language dependencies manually as before. Resolves: #99540 Releases: main Change-Id: I4416b349351ee629012bee8ad518c20b9efd7ed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77378 Reviewed-by:
-
Georg Ringer authored
The text about the time restriction inside the logging module can be removed because: - if no time filter is used, it takes place in the UI by giving the information that the search starts 1970 - if the filter is used, the information can be found inside the filter, just like for all other filter options Resolves: #99539 Releases: main Change-Id: Iccdf83f5a607b0260baa44603fef0b80c57fcec4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77382 Reviewed-by:
-
Christian Kuhn authored
The patch comes with a couple of changes for the TypoScript IncludeTree construct: * Identifiers are now unique within a tree. This is needed especially in the Backend TypoScript -> Included Template files rendering: Before, showing content of single segments did not work due to duplicate identifiers. * getIdentifier() is hardened to throw an exception if not initialized: This detail is only needed for non-cache analysis purposes and identifiers don't exist when getting trees from cache in Frontend. * To allow file includes relative to a parent file include, they now have a "path" property that is properly hand over to child includes. Relative child includes now work with include_static sys_template includes as well. * RootInclude now has an identifier as well to seed child includes which include the parent identifier in their hash. * Identifier hashes and cache identifiers are built with fast xxh3 hash in favor of sha1() and json_encode() is used in favor of serialize() when hashing structures, if possible. * Identifier hashes are created in the setter instead of calling hash() in the caller. * [end] and [global] lines are now parts of the previous condition segment and don't create one-line segments anymore. * Tests are adapted to be a bit less noisy on properties we're not interested in by using another custom comparator. Change-Id: I9c03edfcf29e2887c0ef70ce1692582524333bdf Resolves: #99537 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77369 Reviewed-by:
-
