- Apr 20, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 19, 2020
-
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by:Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
- Apr 18, 2020
-
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
-
- Apr 17, 2020
-
-
Andreas Fernandez authored
The page module now doesn't try to update the flag icon of a dragged record if the page module is not in "language" mode as the required information is not available. Resolves: #91096 Related: #90693 Releases: master Change-Id: I1c796a6f4b00761f3310335cf45256d75a7e3bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64218 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Apr 16, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
-
- Apr 15, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Andreas Fernandez authored
Resolves: #90941 Releases: master Change-Id: If205ab5308c0f1bb7e935a53bebee41e7b9e2fd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64061 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
- Apr 14, 2020
-
-
Andreas Fernandez authored
To improve the user experience, the search filter in the "New Content Element" wizard is automatically focussed when the modal appears. Resolves: #91014 Releases: master Change-Id: I3e0f18bd454955af63cd797138de7b2118d9d2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64129 Tested-by:
-
- Apr 02, 2020
-
-
Andreas Fernandez authored
To improve the UX of null placeholder checkboxes (e.g. used in sys_file_reference) its assigned text field is now automatically focused if such checkbox gets disabled. Resolves: #90879 Releases: master Change-Id: I5228f49d58276d3c6fc1d19275ca9e92cbdb2f91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64001 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Mar 28, 2020
-
-
Susanne Moog authored
To allow the dashboard to be positioned out of the "Web" main module, we rebuilt the module menu to allow direct top level modules. Additionally, the styling for the module menu was adjusted to allow mobile and keyboard friendly navigation and layout. Resolves: #90862 Releases: master Change-Id: I1005bac37a214530fb9e304fec2406799fe92240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63718 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Mar 27, 2020
-
-
Christian Eßl authored
Do not show the inline edit form, when double clicking the title in the pagetree, if the editor has no access permissions to the default language or is not allowed to modify a page. Resolves: #90855 Releases: master, 9.5 Change-Id: I51b34451043ce7abeb73250ea050bc084c23647b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63952 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Mar 26, 2020
-
-
Andreas Fernandez authored
This patch introduces a filter in the "New Content Element" wizard which enables a backend user to search for their wanted content element respecting the CE name and description. If a query leads to the situation that a tab has no results, that very tab becomes unavailable to the user. If the current active tab has no results, the next available tab is made active. Resolves: #83128 Releases: master Change-Id: I8cff939933fd895d986047c170cd9816776474bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63888 Tested-by:
-
- Mar 25, 2020
-
-
Susanne Moog authored
The buttons on top of the page tree behave like a button group and should be styled as such. Resolves: #86916 Releases: master Change-Id: I04e4f65cda19d6e1ed808ebdaecb942e21b202fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63915 Tested-by:
-
- Mar 24, 2020
-
-
Andreas Fernandez authored
Deleting flexform sections now removes the fields from DOM as DataHandler only cares for the "action" being sent. This commit also fixes a strange condition that checks whether the action array has empty values. To have at least one similarity with IRRE, deleting a section now also fades the container. Resolves: #71607 Releases: master Change-Id: Ib696385ff4bdd3daed323a94c5dd7fdd3a74f640 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63830 Tested-by:
-
- Mar 23, 2020
-
-
Andreas Fernandez authored
This patch debounced or throttles some `scroll` or `resize` events to improve the client performance a bit, as the event listeners aren't executed anymore everytime the event is triggered. Resolves: #90810 Releases: master Change-Id: Id5262eebd004ee4d10d87a83cc17e3f517aca1a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63844 Tested-by:
-
Andreas Fernandez authored
If assets get imported via mass selection in the Element Browser, the order of the items is now kept. Since this requires interframe communication, the Inline Control Container now sends a postMessage to the Element Browser. When the import process starts, the first asset of the selection gets imported. After the import, the postMessage is intercepted and the next asset get imported, until the queue is empty. As this could be a rather lenghty process, a progress bar is rendered at the top of the file table. To get a more fitting naming, all previously used action names used in postMessages have been renamed from `typo3:foreignRelation:inserted` to `typo3:foreignRelation:insert`. As a drive-by fix, the server is not spammed with n request anymore due to queueing. Resolves: #86362 Resolves: #59341 Releases: master Change-Id: Ib9e3ee8d943582874a0a73632968f8660b169b42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63838 Tested-by:
-
- Mar 21, 2020
-
-
Andreas Fernandez authored
If a record gets deleted via context menu no further handling could be added as the promise returned by AjaxDataHandler is available in an encapsulated scope only. To bypass this issue, the AjaxDataHandler now optionally emits events to listen on. This patch implements event listeners for the record list and the information module of "Template tools". Resolves: #90791 Releases: master Change-Id: I0b659e695f31b2f3ab40adc17421f8b036d5aab6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63811 Tested-by:
-
- Mar 20, 2020
-
-
Andreas Fernandez authored
With `DragDrop.ajaxAction()` returning a promise now, the flag icon can get updated after dropping a content element into another language. Resolves: #90693 Releases: master Change-Id: Iff0a819e69194f0302ea97ce096500e0144704c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63799 Tested-by:
-
Andreas Fernandez authored
The event listener for collapsing and expanding IRRE nodes is now less greedy and ignores the div containing all control buttons which makes the buttons without click event (e.g. "Edit metadata") functional again. Resolves: #90796 Releases: master Change-Id: Ie19547bc5fbf21124f4a658ffc3a28b157242d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63817 Tested-by:
-
Andreas Fernandez authored
Define the `hideDropzone` event listener via assignment to keep the binding of `this` to the DragUploader class. Resolves: #90792 Releases: master, 9.5 Change-Id: I21c52da477349e77a52f2c6701fd75abc3b5b074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63805 Tested-by:
-
Frank Naegler authored
Since Firefox 72 a user interaction is required to prompt the user for native browser notification permissions. This should prevent the user for notification SPAM. This patch introduces a modal confirmation, to get this user interaction. The user is asked only once (as before), this is possible because the modal is triggered only if a UC setting is not present. Resolves: #90666 Releases: master, 9.5 Change-Id: I031a2addee9894db7e345f46d1e5e5d0d62316d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63567 Tested-by:
-
- Mar 15, 2020
-
-
Oliver Bartsch authored
The reasons why the translation wizard can't be used are: * Mixed mode in translated page * Disabled via Page TSConfig This adds the second reason (Page TSConfig) to the message. Also the label key was renamed to proper describe its content. Resolves: #90684 Releases: master Change-Id: Ib58de71f717e1ec32f91a8b60bf30840a7f70a76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63631 Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
- Mar 13, 2020
-
-
Christian Eßl authored
When dragging a page in the page tree, users would always see the red delete area, even if they do not have the permissions to delete the page. This is fixed now. Resolves: #83694 Releases: master, 9.5 Change-Id: Ibd8de52d529405ab57b022e854e361da69e4d3bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63596 Reviewed-by:
-
- Mar 11, 2020
-
-
Andreas Fernandez authored
When a FormEngine document gets closed, the spinner now isn't rendered anymore. Resolves: #90723 Releases: master, 9.5 Change-Id: Id62c842335685a010bfbd918755b92fcd348f16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63677 Tested-by:
-
- Mar 10, 2020
-
-
Andreas Fernandez authored
This patch changes the behavior of the FormEngine internal ValueSlider by creating a new instance per occurrence of the slider to solve event stacking issues. Due to the new structure of the module, it's moved into FormEngine/FieldWizard. Resolves: #90673 Releases: master, 9.5 Change-Id: I80f2f2faeb37fb793b19cede7b629d8c415072d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63597 Tested-by:
-
Andreas Fernandez authored
To avoid issues with slow internet connections in combination with the "Refresh required" modal the save button of the FormEngine is now disabled on submit. Resolves: #88637 Releases: master, 9.5 Change-Id: Ib89753350992eb135276cac21995acd81a64f1ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63623 Reviewed-by:
-
- Mar 06, 2020
-
-
Andreas Fernandez authored
This patch removes all occurrences of bootstrap-slider in Core with the native `range` input type. To ensure a consistent styling across all platforms, new CSS is in place. However, we can't recover the same styling as used with the bootstrap-slider either due to inconsistent browser support of selectors or missing features. In the `ValueSlider` module, which is only used by FormEngine, any usage of jQuery has been removed as well. Resolves: #90649 Releases: master Change-Id: Ic2e0cb7aa9305159c33f14130d3fe6e62d2fd1da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63523 Tested-by:
-
- Mar 03, 2020
-
-
Andreas Fernandez authored
The property `actionName` is added to the window message to allow adding media from the "Add media by URL" again. To prevent such issues in future, a new interface is introduced which renders `actionName` mandatory. Resolves: #90626 Releases: master Change-Id: I925da0476f2f29bd9394c723369b68429e59b545 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63538 Tested-by:
-
- Mar 02, 2020
-
-
Christian Eßl authored
On larger pagetrees, the svg pagetree cut off too many elements at the bottom and the scrollbar was activated much too late. This was because the calculated css height of the pagetree could become larger than the height of the html body itself. Also redraw the height when the page doktype icon list gets updated. Resolves: #90555 Resolves: #89193 Releases: master, 9.5 Change-Id: Ice8c46110e2e8c92469a3d2ab12a7744bd6fc7de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63511 Tested-by:
-
- Feb 29, 2020
-
-
Christian Eßl authored
Before, editors could always use drag and drop to move pages in the page tree, even if they were lacking the permissions to modify pages. After trying to move a page, an error message would then be shown. The following permission checks have now been added: - Check if the editor is allowed to modify pages. - Check if the editor is allowed to access the default language The drag and drop feature is now only enabled, if these restrictions are met. Admin users can use drag and drop in any cases. Resolves: #25433 Releases: master, 9.5 Change-Id: If104dafa0e5293d698b384b05984642a188d1166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63514 Tested-by:
-
Andreas Fernandez authored
This patch replaces $.ajax() in EXT:backend either with our AJAX API or with native XMLHttpRequest. The latter is required in the DragUploader as we need to listen to the progress event which isn't supported by fetch(). This patch skips Storage/Persistent, as this one needs some refactoring due to the usage of synchronous(!) AJAX requests. Resolves: #90597 Releases: master Change-Id: Ifdf41c133929740f3e766ae992848ab99ca1f283 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63502 Tested-by:
-
Christian Eßl authored
Resolves: #90582 Releases: master Change-Id: I456dd0b04947c838f125d49ca686a40d289c2fe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63487 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Feb 28, 2020
-
-
Elias Häußler authored
This patch addds a basic keyboard navigation inside the multi-step wizard for new forms in backend. This improves handling forms with the multiple steps in this wizard. Additionally, most useful input elements, such as input fields and next step/finalize buttons are now focused by default when going to the next slide. Also the focus styles were added to these elements. Resolves: #90132 Releases: master Change-Id: Ia668b727bf4cdba0e04ae409484dc44492360a33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63154 Tested-by:
-
Andreas Fernandez authored
This patch replaces jquery-ui/sortable with Sortable.js which has been introduced with the refactoring of the IRRE component. Additionally, some styling is added to improve the visual indication of a current sorting in progress. Resolves: #90561 Releases: master Change-Id: If2c15b16aa21ff9abbc91bdb00544a16b383a591 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63477 Reviewed-by:
-
- Feb 26, 2020
-
-
Andreas Fernandez authored
The postMessage sent to IRRE when uploading a file via drag & drop missed the actionName, which resulted in ignoring the message. The actionName is now used and also streamlined to match the actual behavior. Resolves: #90534 Releases: master Change-Id: Ic56059762a6822e27ac64ea6fc07b5d37fc34c9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63434 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
- Feb 23, 2020
-
-
Benjamin Kott authored
Resolves: #90497 Releases: master Change-Id: I5cddd6be004f49d2c44076f5a2a5733401f52235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63380 Tested-by:
-
- Feb 22, 2020
-
-
Andreas Fernandez authored
In order to fix most known vulnerabilities in development-related npm packages, all packages have been updated to their respective latest version. Executed commands: yarn upgrade yarn build Since packages related to minification and publicly used packages like CodeMirror have been updated, this patch contains some more changed files. Resolves: #90496 Releases: master Change-Id: I65a307dae58224c75b8d0fc8a34c28fc1db465f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63379 Tested-by:
-
Andreas Fernandez authored
This patch adds API for event handling in JavaScript. The goal is to have an easy-to-use event handling and delegation by shipping several event strategies. Debounce: Debounces an event listener that is executed after the event happened, either at the start or at the end. A debounced event listener is not executed again until a certain amount of time has passed without it being called. RequestAnimationFrame: Traps an event listener into the browser's native rAF API. Throttle: Throttles the event listener to be called only after a defined time during the event's execution over time. Resolves: #90471 Releases: master Change-Id: I407f9b98a13f998bbf0879614002223b304389b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63336 Reviewed-by:
-
- Feb 03, 2020
-
-
Elias Häußler authored
If slugs are generated within Backend forms, the visual output (= label below slug field) of the generated slug proposal might be broken if no slash is prepended to the generated slug. This might be the case in custom database tables where custom slug fields are defined with the configuration "prependSlash" set to "false" (which is the default value). It can also be the case if the configuration "prefixParentPageSlug" is set to "false". In order to ensure a clean visual output for those labels, the slug proposalwithin them will now always be prepended by a slash. This makes sure that the resulting url which is shown within those labels is always valid. Note that this only effects visual output and is not meant to modify any slug proposal generated by the SlugHelper class. Resolves: #90222 Releases: master, 9.5 Change-Id: I93587cfec0db6c3d889fdce60a4515ef47decc82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63051 Tested-by:
theline <typo3@theline.capella.uberspace.de> Tested-by:
-
