- Apr 20, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Xavier Perseguers authored
Resolves: #91130 Related: #82990 Releases: master, 9.5 Change-Id: I8337f8d24fff67ac2c8f05f16de642f46e86cfd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64250 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Christian Eßl authored
If a requested page in the view module is missing a site configuration, catch the related exception and show a meaningful flash message instead. Resolves: #91088 Releases: master Change-Id: I07e35c204ed3198530d57dd97e228fb950baf85c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64211 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Gerrit Mohrmann authored
To fire the LoginConfirmedEvent and LogoutConfirmedEvent even when redirects are active the redirect handling are moved after the events. Resolves: #91023 Releases: master Change-Id: I11fd2aba206edb68426039de7dbfa6e92d79c8a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64165 Tested-by:
-
Andreas Fernandez authored
The backend already provides the possibility for a backend user to use the first available module as "start module". However, if the UC of backend user is empty, its start module is set to "help_AboutAbout" explicitly, which contradicts the mentioned feature. Additionally, EXT:about is an optional dependency which may break the backend at this point. Because of the listed reasons, explicitly setting "help_AboutAbout" has been removed as well as the override by EXT:dashboard. Resolves: #91127 Releases: master Change-Id: I04fb79f8b59f7e8a07736ffc0d328979075f09a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Andreas Fernandez authored
Command executed: composer require --dev typo3/testing-framework:^6.2.3 Resolves: #91138 Releases: master Change-Id: I7047698dccc8b6bafbcb61b81f4723a1b9bba2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64254 Reviewed-by:
-
Josef Glatz authored
This change adds a human readable and meaningful main title for the documentation of ext:rte_ckeditor. Resolves: #91136 Releases: master, 9.5 Change-Id: I01804d2d4c700af6c2a72d74596cf20b04505eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64253 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Apr 19, 2020
-
-
Oliver Hader authored
Dynamically created class instances using a variable name cannot be resolved in extension scanner - given the fact that a class member variable can change at any time and the scanner would have to keep that state - which is too much for static code analysis. Thus, the following source code is not analyzed. $className = SomeClass::class; $object = GeneralUtility($className); Resolves: #91128 Releases: master, 9.5 Change-Id: I7f87e7c88e9e62efb85ee54f32625c531266cbba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64251 Tested-by:
Ghanshyam Bhava <ghanshyambhava@yahoo.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. Resolves: #91109 Releases: master Change-Id: I1cd0f6bc1b69e600f62d00c614119c825ae02a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64228 Tested-by:
-
Oliver Bartsch authored
Also simplify doktype check by using `in_array` instead of comparing each doktype on its own. Furthermore the check for the page row is superflous because it is checked implicit by fetching the doktype. Resolves: #91126 Releases: master Change-Id: Ic9d39aacb4eaa663a03fcbff907a8d4c21fc5278 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64245 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Chris Müller authored
In the "Add widget" dialog the id of the group tab was not unique. This interfered with other ids in the backend. A prefix was added to make it unique. Resolves: #91129 Releases: master Change-Id: Icf528c6ff8d755470d3158e94b1916a5ce028981 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64248 Tested-by:
-
Andreas Fernandez authored
Since #91080, TemplateService tries to fetch a site configuration from TSFE. As EXT:recycler uses the f:format.html ViewHelper, a TSFE is mocked which breaks the request. This bugfix makes use of f:format.raw instead, as 1. this fixes the issue 2. f:format.html is not required at all Resolves: #91131 Related: #91080 Releases: master Change-Id: Ic2b1de9aa2b419641509e755ab4d179f69178651 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64249 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Oliver Hader authored
Fluid variable `previewUrl` is generated, but never used in templates. Resolves: #91120 Releases: master Change-Id: Ia5397f9ef63700fda2a84aee245ed2ba2bf8bc55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64240 Tested-by:
-
Benjamin Franzke authored
With the introduction of a custom DI cache in #90418, the container was used to lookup its own cache and the cache identifier. This results in bugs if the container cache is stale: Loading from the cache and flushing the cache will work, but code that runs after the cache has been flushed (ext_localconf loading) will still use the a stale container (configuration), as the instance has been created too early (to be able to clear itself). Therefore we do now avoid instantiating the symfony container before the container cache has been cleared. A positive side effect of this change is that the container cache is warmed up after the flush. Releases: master Resolves: #91114 Related: #90418 Change-Id: I5f10474ab3fab2d17cfdca6cd514b0a95f10bbbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64234 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Klee authored
Having PHPDoc parameter and return type annotations like "string[]" instead of the generic "array" will help both static code analysers as well as human readers. Resolves: #91065 Releases: master, 9.5 Change-Id: I7d39241d81ce607e9ca6050cc82126420e1e756e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64203 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by: -
Josef Glatz authored
This patch takes the changes of the new documentation theme into account. Releases: master, 9.5 Resolves: #91102 Change-Id: I3308819227dc4a66f0571e4b5afdc49939f19026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64223 Tested-by:
-
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
-
- Apr 18, 2020
-
-
Richard Haeser authored
No additional classes are needed anymore to initialise the graphs in Dashboard Widgets. If a graphConfig is given the chart will be initialised. Resolves: #91100 Releases: master Change-Id: Id25d272e4287a0248d982b600f792e5e32e76445 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64220 Reviewed-by:
-
Benjamin Franzke authored
The installtool sends a mail when a login happens when TYPO3_CONF_VARS.BE.warning_email_addr is set. When TYPO3_CONF_VARS.EXTENSIONS.backend.loginLogo is set to provide a custom backend logo, that logo is used by the FluidEmail template via f:image viewhelper. Therefore we need to provide MetaDataRepository, as the f:image viewhelper will use that service. The (implicit) dependency chain is: <f:image> -> Resource\File -> MetaDataAspect -> MetaDataRepository Releases: master Resolves: #91107 Related: #89892 Change-Id: If4e73d607d2a6e21646ea91bd8f0a39742f133d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64236 Tested-by: -
Oliver Hader authored
Superfluous inline events have been removed or replaced with native HTML functionality (location.href -> anchor). Resolves: #91110 Releases: master Change-Id: I594fe2df3c71234de096e437b5662867469ffbb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64229 Reviewed-by:
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #91112 Releases: master Change-Id: I6fef3f196afd44a11fbd5d688bec45457a28aad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64231 Reviewed-by:
-
Richard Haeser authored
Corrected way of accessing the AJAX urls by using the dot notation. Resolves: #91113 Releases: master Change-Id: I6c3fd48707f3d45c5432ac1e11f77b0c33d577ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64232 Tested-by:
-
Benni Mack authored
Made sure EXT:dashboard follows the guidelines for usage of ext_localconf and ext_tables and some other changed to make the code more consistent with other system extensions. Resolves: #91108 Releases: master Change-Id: I82d957a9e13aee8504b6bf8df6a3145b8fb6a5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64221 Tested-by:
-
Anja Leichsenring authored
The changelog files for the version 10.4 must leave the master folder now and move to their final home in 10.4. Resolves: #91106 Releases: master Change-Id: Ia2a97ef805653c2179426da9c228b052b6801472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64226 Tested-by:
-
Oliver Hader authored
Using HTML form elements without actually making use of typical consumers (input, textarea, select, ...) seems to be superfluous. Resolves: #91101 Releases: master Change-Id: I37a6647f162a8b1f3f8394ad04458830abca0e26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64222 Tested-by:
-
Benni Mack authored
YAML configuration set in a site configuration under the main key "settings:" are now available as TypoScript constants in templates and as constants in page TSconfig. This feature is a replacement for the former page TSconfig functionality "TSFE.constants", which has been removed. A former replacement approach had to be reverted in v10.1. Resolves: #91080 Resolves: #91081 Releases: master Change-Id: Ia5cd4e94049a359a23418c1fdb122a0d5f8c7311 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64128 Tested-by:
-
Tobi Kretschmann authored
Resolves: #90729 Resolves: #90578 Releases: master Change-Id: I9ce6b678addcc9e65e7e4e7b70e3187d91b7456a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63886 Reviewed-by:
-
Benni Mack authored
Resolves: #91091 Releases: master Change-Id: I88c8c7c7119d7dae485eb6013ce05aaee42145d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64213 Tested-by:
-
- Apr 17, 2020
-
-
Andreas Fernandez authored
Resolves: #91099 Releases: master, 9.5 Change-Id: I08ea8ecfc7096a21b0ffddee0b4e3976363fffd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64219 Tested-by:
-
Benni Mack authored
In order to build a stronger Permission Handling system and a stronger API for TCA resolving in TYPO3 v11, several methods and public properties have been marked as "internal". These continue to be working as is for TYPO3 v10 LTS, but are now marked as internal - most of the code has been coming from PHP4 where no visibility restrictions have been available back then. Resolves: #91095 Releases: master Change-Id: Ibb47739a0cdec5eae19fafa2e376eeb609aa6c53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64162 Tested-by:
-
Helmut Hummel authored
All commands that are added via Configuration/Commands.php are instantiated and prepared when the "scheduler:run" command is executed. This preparation includes setting the Application object. If this Application object is present in an Command object, calling the run method of the command will cause a merge of the application's arguments with command arguments. Since command objects in symfony/console and TYPO3 are more or less singletons, these merged arguments will stay merged on a second "instantiation" of the command through when scheduler executes the second task with the same command. Therefore we must SKIP the validation of the new Input object we create and pass to the command's run method, so that this validation does not fail due to the missing command argument. It also does not matter that we skip validation, because validation happens implicitly when calling the run method on the command object. Only Symfony code is "smart" enough to set the command argument, when it was not present before. Resolves: #87312 Releases: master,9.5 Change-Id: I75677493216961fd7559a923e94e7831e07921bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Andreas Fernandez authored
The page module now doesn't try to update the flag icon of a dragged record if the page module is not in "language" mode as the required information is not available. Resolves: #91096 Related: #90693 Releases: master Change-Id: I1c796a6f4b00761f3310335cf45256d75a7e3bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64218 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer Releases: master Resolves: #91092 Change-Id: I80956bc210237169034acd86ef26c1e8f9725ddb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64212 Tested-by:
-
Helmut Hummel authored
It is now possible to limit restrictions to a given set of table aliases by using the introduced \TYPO3\CMS\Core\Database\Query\Restriction\LimitToTablesRestrictionContainer. Example: $queryBuilder->getRestrictions() ->removeByType(HiddenRestriction::class) ->add( GeneralUtility::makeInstance(LimitToTablesRestrictionContainer::class) ->addForTables( GeneralUtility::makeInstance(HiddenRestriction::class), ['sys_language'] ); Resolves: #87776 Releases: master Change-Id: I7fc7108ccac93d50cfab6fa8a74809f1dfe2bd89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60781 Tested-by: -
Richard Haeser authored
Most classes used in EXT:dashboard are internal classes and are now marked as internal and therefor not part of the public API. Resolves: #91093 Releases: master Change-Id: Idd9ccf423b6330908487fd1278163f51b64f50d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64216 Tested-by:
-
Benni Mack authored
Some code related to templating / cached TypoScript, inclusion of CSS/JS and internals like "indexedDocTitle" which has now a proper PageTitle API, is marked as internal now, so further refactorings can happen in the next major release. As all replacements are in place for this functionality, extension authors can and should already use new APIs instead of relying on TSFE for this logic. Resolves: #91079 Releases: master Change-Id: Ic24c607dd620d1cfe7966484d5272491aa5f429a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64199 Tested-by:
-
Oliver Hader authored
Change https://review.typo3.org/c/Packages/TYPO3.CMS/+/61223 (v10 only) modified Extbase referring argument handling. This change reintroduces `$internalArguments['__referrer']['arguments']` to be used when redirecting back to original request action in case some validation errors occurred - otherwise those arguments are lost. This basically reverts commit 19b5ee0f (adjusted for code clean up and refactorings that happened in between) Resolves: #89434 Releases: master Change-Id: Id83f38d20ecd482b517c37c4244d871a40ff0a89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63152 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Benjamin Franzke authored
This will allow both, dependency injection for these services (manually wired in service providers), and usage in install/maintenance tool (where we do not use the caching symfony container for basic tasks). The move to DI is possible thanks to the failsafe container and the service providers which can fed the failsafe container with service factories. These factories are used to wire services manually. Notes: * The definition in a service provider means we are required to use manual wiring and are forced to define the dependencies in the service provider when we add new depenencies to services that are being used by the install.. With that approach we can assure that we do not accidentally add new dependencies to services which would become available in symfony DI due to autowiring, but would be unavailable in the install tool. * The install tool has operations that require a booted symfony container which is provided by the LateBootService. Services that are used in that mode do not need to be listed in service providers. Therefore we do only add core services to service providers if they are used in a context without a fully booted symfony DI container. * GLOBALS['LANG'] mocks in Core\Tests\Unit\DataHandling\DataHandlerTest have been removed as the code under test does no longer use $GLOBALS['LANG']->csConvObj->substr() but mb_substr. The test had been introduced with #68602 but the tested code was adapted in #78670. * We got a bit ugly constructs now, where a unit(!) test previously used $GLOBALS['LANG'] = new LanguageService(); …we now have to encode the dependency structure: $GLOBALS['LANG'] = new LanguageService(new Locales, new LocalizationFactory( new LanguageStore, $cacheManagerProphecy->reveal() ) ); This isn't nice, but this change reveals that the affected unit tests should either be adapted, removed or be moved to a functional test. Such adaption are out of scope for this change. * loadExtLocalconfDatabaseAndExtTables() is removed from the EXT:install AbstractController, as it hides the implicit dependency to LateBootService * Nullable constructor arguments have been changed to be non-nullable whenever possible. That results in some more test adaptions, but reveals, where unit tests rely on implicit dependencies and offers better readability and less possible codepaths. Releases: master Resolves: #89892 Resolves: #89891 Change-Id: Ib72d6440f81b2c0d05279e8768697c3b48aecfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62575 Tested-by:
-
