Skip to content
Snippets Groups Projects
  1. Sep 06, 2024
  2. Sep 05, 2024
  3. Sep 04, 2024
  4. Sep 03, 2024
    • Simon Praetorius's avatar
      [TASK] Update Fluid to 2.15 · 51a0329c
      Simon Praetorius authored
      This release contains important pre-patches for the upgrade to
      Fluid v4 in the next step. Apart from soft deprecations of code that
      will log deprecation level errors with Fluid v4, it backports a
      feature from Fluid v4 to Fluid v2 to deliver a smoother migration
      path from Fluid v2 to v4 in 3rd party code. The necessary changes
      to TYPO3's ViewHelpers will be applied in a follow-up patch.
      
      Similarly to the previous update to 2.14.0, this patch adds RST
      files that describe both new features and deprecations
      that were introduced in this version.
      
      Noteworthy changes:
      
      * The functionality of `CompileWithContentArgumentAndRenderStatic`
      has been integrated into `AbstractViewHelper` and can thus be used
      with non-static ViewHelpers from now on.
      * `renderStatic()` and both associated traits
      `CompileWithContentArgumentAndRenderStatic` and
      `CompileWithRenderStatic` are deprecated
      * Methods deprecated with the introduction of the
      ViewFactoryInterface in #104773 have been deprecated in Fluid
      as well
      * `true`, `false` and `null` can no longer be used as variable names,
      as these will become proper language keywords in Fluid v4
      
      Executed composer commands:
      
      > composer req typo3fluid/fluid
      > composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid
      > composer req -d typo3/sysext/core --no-update typo3fluid/fluid
      > composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid
      > composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid
      
      Resolves: #104789
      Related: #104463
      Related: #104773
      Releases: main
      Change-Id: I32a465e327cf84975c45e86580c54d060d688cd6
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85837
      
      
      Tested-by: default avatarJochen Roth <rothjochen@gmail.com>
      Reviewed-by: default avatarSimon Praetorius <simon@praetorius.me>
      Tested-by: default avatarGarvin Hicking <gh@faktor-e.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarJochen Roth <rothjochen@gmail.com>
      Tested-by: default avatarSimon Praetorius <simon@praetorius.me>
      Reviewed-by: default avatarGarvin Hicking <gh@faktor-e.de>
      51a0329c
  5. Sep 02, 2024
  6. Sep 01, 2024
  7. Aug 31, 2024
  8. Aug 30, 2024
  9. Aug 29, 2024
    • Garvin Hicking's avatar
      [BUGFIX] Allow to use CKEditor style definitions with an empty class · 9b1ef298
      Garvin Hicking authored
      The CKEditor default YAML configuration for the Full and Default
      presets contained code like:
      
      ```
      - { name: 'Orange title H2', element: 'h2', classes: [],
          styles: { color: 'orange', background: 'blue' } }
      - { name: 'Orange title H3', element: 'h3', classes: [],
          styles: { color: 'orange', background: 'blue' } }
      - { name: 'Quote / Citation', element: 'blockquote', classes: [],  }
      - { name: 'Code block', element: 'code', classes: [],  }
      - { name: 'Yellow marker', element: 'span', classes: [],
          styles: { background-color: 'yellow' } }
      ```
      
      and
      
      ```
      - { name: "Lead", element: "p", classes: ['lead'] }
      - { name: "Small", element: "small", classes: [] }
      - { name: "Muted", element: "span", classes: ['text-muted'] }
      ```
      
      CKEditor 5 expects the "classes" attribute to contain an array of
      strings (or just a string) and not an empty array. Otherwise
      choosing such a style  will have no effect in the CKEditor instance.
      
      The CKEditor5Migrator class has been enhanced to convert these
      empty or absent arrays to a `['']` definition on the fly. This allows
      integrators to continue using their hard-earned CKEditor
      YAML configurations without further change.
      
      The default YAML presets have been changed to omit the classes
      attribute, as that's what the intention of the configuration is.
      While this is a proprietary TYPO3 modification, we need this
      because of limited CKEditor5 functionality regarding classes handling.
      Also, the no longer valid "styles:" definitions have been removed.
      
      Resolves: #103979
      Resolves: #103499
      Releases: main, 12.4
      Change-Id: Iad6f1a25c071ac70b51db2a3344b7c3bcd9f9687
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84679
      
      
      Reviewed-by: default avatarGarvin Hicking <gh@faktor-e.de>
      Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      Tested-by: default avatarGarvin Hicking <gh@faktor-e.de>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
      9b1ef298
    • Christian Kuhn's avatar
      [TASK] Declare minor ext:form RendererInterface change · 878625ad
      Christian Kuhn authored
      ext:form RendererInterface->setFormRuntime() now declares
      to return void. Strictly speaking this would be a breaking
      change, but it is not in practice, since extensions
      typically do not implement the interface directly, but
      extend AbstractElementRenderer, which follows this interface
      change. Also, existing extensions could easily declare :void
      (if they don't do so already), and be v13 and <v13 compatible
      without problems.
      
      Resolves: #104768
      Releases: main
      Change-Id: I6d012946f84212c42235346fb8abae1651a37440
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85820
      
      
      Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
      878625ad