[TASK] Avoid renderStatic() in ViewHelpers
With Fluid v4, renderStatic() and the associated traits are deprecated. ViewHelpers should use render() as their primary rendering method from now on. [1] Consequently we switch all ViewHelpers in the Core from renderStatic() to render(). This has been done in this patch. The following steps have been performed: 1. Use custom rector rule to perform changes (Patchset 1) > git clone git@github.com:s2b/fluid-rector.git > cd fluid-rector/ > composer install > vendor/bin/rector process ../typo3/ 2. Apply cgl fixes (Patchset 2) > Build/Scripts/runTests.sh -s cglGit 3. Manually migrate phpstan annotations (Patchset 3, partially reverted in Patchset 5) If `$arguments` is annotated in the ViewHelper class, that annotation is removed (either right in Patchset 3 or later in Patchset 5). 4. Manually migrate ViewHelpers that are not covered by rector rule (Patchset 4) [1] https://github.com/TYPO3/Fluid/commit/97aa45a6ed0fa3959cfa7d790077a4a5a9cef53f Resolves: #104786 Releases: main Change-Id: I503c3ba34d5926dd1e5818cd4114f0356bc68d89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85834 Reviewed-by:Garvin Hicking <gh@faktor-e.de> Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php 2 additions, 6 deletions...sext/adminpanel/Classes/ViewHelpers/IsArrayViewHelper.php
- typo3/sysext/adminpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php 3 additions, 9 deletions...inpanel/Classes/ViewHelpers/SubModuleRenderViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php 4 additions, 10 deletions...3/sysext/backend/Classes/ViewHelpers/AvatarViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php 10 additions, 16 deletions...sext/backend/Classes/ViewHelpers/ModuleLinkViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php 2 additions, 11 deletions...kend/Classes/ViewHelpers/Toolbar/AttributesViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php 2 additions, 4 deletions...end/Classes/ViewHelpers/TypoScript/FineDiffViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php 10 additions, 17 deletions.../backend/Classes/ViewHelpers/Uri/EditRecordViewHelper.php
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php 11 additions, 21 deletions...t/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php 1 addition, 14 deletions...ysext/belog/Classes/ViewHelpers/Be/PagePathViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php 2 additions, 7 deletions...ext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php 2 additions, 8 deletions...3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php
- typo3/sysext/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php 2 additions, 7 deletions...xt/belog/Classes/ViewHelpers/WorkspaceTitleViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php 4 additions, 9 deletions...ext/beuser/Classes/ViewHelpers/ArrayElementViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/IsArrayViewHelper.php 2 additions, 6 deletions...3/sysext/beuser/Classes/ViewHelpers/IsArrayViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php 6 additions, 15 deletions...sext/beuser/Classes/ViewHelpers/PermissionsViewHelper.php
- typo3/sysext/beuser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php 2 additions, 11 deletions...ser/Classes/ViewHelpers/SpriteIconForRecordViewHelper.php
- typo3/sysext/core/Classes/ViewHelpers/IconForRecordViewHelper.php 5 additions, 9 deletions...sext/core/Classes/ViewHelpers/IconForRecordViewHelper.php
- typo3/sysext/core/Classes/ViewHelpers/IconForResourceViewHelper.php 5 additions, 9 deletions...xt/core/Classes/ViewHelpers/IconForResourceViewHelper.php
- typo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php 8 additions, 12 deletionstypo3/sysext/core/Classes/ViewHelpers/IconViewHelper.php
- typo3/sysext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php 3 additions, 7 deletions...sext/core/Classes/ViewHelpers/NormalizedUrlViewHelper.php
Please register or sign in to comment