- Sep 21, 2021
-
-
Wouter Wolters authored
Update the following packages from TYPO3 itself to their latest version: typo3/cms-cli typo3/cms-composer-installers typo3/symfony-psr-event-dispatcher-adapter Composer commands used: composer req typo3/cms-cli:^3.1 composer req typo3/cms-cli:^3.1 -d typo3/sysext/core --no-update composer u typo3/cms-composer-installers composer u typo3/symfony-psr-event-dispatcher-adapter Resolves: #95304 Releases: master Change-Id: Icf3d4f3d8a577e01fbdbe1402170349282149aed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71170 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The clipboard component still suffers a lot of problems, due to its static integration in the list modules. For example, when clearing the clipboard, it's no longer possible to copy / cut a record via context menu, since the the previous GET parameters are included in the return URL, directly reverting the operation. The list modules should therefore not longer handle any clipboard logic directly, especially not via GET. This patch does the first step towards this goal and introduces a dedicated endpoint, only available via POST. The clipboard panel, used in recordlist and filelist is furthermore now integrated as a web component, making any form submit in the main module superfluous. Additionally some related bugs are fixed: * Elements moved to clipboard via context menu can now be remvoed from clipboard again * Non related elements are now always properly styled * File elements now correctly link to their parent folder in filelist * Buttons are only shown...
-
Helmut Hummel authored
Environment::getFrameworkBasePath() API was created under the assumption that TYPO3 core extensions are always installed in a dedicated but fixed folder (typo3/sysext). Additionally this folder is assumed to be publicly accessible through a web server. Therefore this API is used in two contexts. 1. To resolve and check file system paths 2. To create URLs to public resources To at some point achieve the goal to allow all TYPO3 extensions to be installed in arbitrary locations (a configurable vendor folder), usage of such API must be removed. As a first step all usages are removed, that reference files within the boundaries of one extensions. Relative paths (relative to the file that references) are used instead, or, where possible EXT: syntax Releases: master Resolves: #95250 Change-Id: Ie7291b71d5d85d75add9bc5b352a4bd1cf065499 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71102 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io>
-
Benni Mack authored
With PHP 8.0 and symfony/polyfill-php80 it is possible to use native str_starts_with() and str_ends_with() methods. This way, the methods * StringUtility::beginsWith() * StringUtility::endsWith() are marked as deprecated. Resolves: #95293 Releases: master Change-Id: I46d15c2f8b93c5f8b487966b2015ebefb1711348 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71135 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Communication patch for an upcoming v12 change. We've had the situation a couple of times that core changed Fluid Viewhelpers to adapt them to current needs, keeping the template arguments, but changing internal handling and method signatures. It happened that developers then stepped up with "This broke my own Viewhelper!" and we had to act upon. The ImageViewHelper for instance has been a victim of this. From a framework point of view, Viewhelpers are specific implementations tailored for specific use. In most cases, they're small codewise. Extending these classes and changing their scope should not be supported. Developers should extend a matching abstract instead of extending specific VH's. The patch brings an Important.rst to pitch an upcoming v12 change that will declare all Viewhelpers final. The core currently of course also extends a couple of VH's itself, but this is too late for v11 now to change and adapt. Instead, we'll take the time in v12 to resolve these cases and will have a look at the abstract classes as well to see which VH functionality should be included in abstracts to simplify re-use and transition for extension authors and to sharpen core API. Resolves: #95298 Releases: master Change-Id: Ia3312829fad94e7429c0989f3aa3554c3cf944ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71164 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
This change removes the language title and flag from each CE, and instead adds only the flag if the content element is set to "All Languages" (-1). In addition, the header is now based on flex-box instead of floats. Resolves: #95302 Releases: master Change-Id: I6d1a180915fba9f2ccf8df3979a2256134d18379 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71116 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Rachel Foucard <rfoucard@w-seils.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Rachel Foucard <rfoucard@w-seils.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Francois Suter authored
In the workspaces module, hide the mass action selector when no actions are available. In particular, this is the case when options.workspaces.enableMassActions = 0 has been set in User TSconfig. Releases: master Resolves: #95295 Change-Id: I81b5aa62ec5496b37dc70f042e4e3d779d84f874 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71165 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Jochen Roth authored
Links without a target are actually buttons. Previously, the "Update extension" link in the reports module was furthermore removed while parsing, due to the missing target. Therefore this patch transforms the "link", which is using the ActionDispatcher, to be a button. Resolves: #95169 Releases: master Change-Id: I89847e1e1ec45fb7f5c797b2c25646f113905508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70985 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Francois Suter authored
The setting options.workspaces.enableMassActions is described in the extension manual as being a Page TSconfig option, whereas it is a User TSconfig option. Releases: master Resolves: #95296 Change-Id: Id0fc6a1c47323fddff018676bc52934f01cf2f13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71162 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Robert Kärner authored
Fix PHP8 related "undefined array key" warnings which occur in the backend by adding the required fallbacks. Resolves: #95239 Releases: master Change-Id: Id1477c95ac00e90b9d449271fb461f2b4dc34235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71100 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
When publishing workspace records with connected "true" MM relations (uid_local / uid_foreign columns and no TCA for that table), DataHandler triggers bugs: * It updates uid_local or uid_foreign rows to negative uids during the process as intermediate DB state. * It leaves "dangling" MM rows of the workspace record that has been pushed live. The involved code is relatively well encapsulated, it only kicks in for this "publish MM relations" scenario, the impact of this patch is limited to this area. The patch rewrites MM workspace publish handling: * Avoid parking state in a DataHandler class property only used in this scenario. * Avoid moving a list of stateful RelationHandler instances around and dynamically calling methods on those instances. * Avoid recursive flex form MM publish handling with indirect callback methods that change class state. * Obsolete a RelationHandler method used only in this scenario. * Reduce number of queries. The result is a simplified, better encapsulated and well commented solution. On a testing side, the patch brings a scenario to verify flex form MM relation handling. An according styleguide example is pending, too. This patch allows us to change auto created MM table definitions to unsigned uid_local and uid_foreign columns, which is of course the right way to go. Change-Id: I0d24f31cbd356f19937c2f8c18d432424e127b97 Resolves: #95275 Resolves: #81718 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71097 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
A functional test has been disabled for postgres execution due duplicate key issues using `setupFrontendRootPage` in functional testcases. As setUpFrontendRootPage has been fixed in the testing framework, this test is enabled again. Commands to test: $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 9.6 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 10 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 11 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 12 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 7.4 -d postgres -k 13 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 9.6 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 10 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 11 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 12 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php $ Build/Scripts/runTests.sh -s functional -p 8.0 -d postgres -k 13 \ typo3/sysext/frontend/Tests/Functional/SiteHandling/MountPointTest.php Resolves: #95114 Releases: master Change-Id: I85d74f05e7ef347cd217843c0384d460194fac24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70897 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
https://github.com/TYPO3/html-sanitizer/releases/tag/v2.0.11 composer req typo3/html-sanitizer:^2.0.11; \ composer req typo3/html-sanitizer:^2.0.11 \ -d typo3/sysext/core --no-update Resolves: #95289 Releases: master, 10.4, 9.5 Change-Id: I3a294c788f25ca5a1068f9eb79c924f65e21244d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71152 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Sep 20, 2021
-
-
Benni Mack authored
One of our main utility methods "GeneralUtility::isFirstPartOfStr" can now replaced by PHP's native "str_starts_with()" function (see https://www.php.net/manual/en/function.str-starts-with.php) which is also available for PHP 7.4 thanks to Symfony's polyfill package. This way, we can a) slim down our own code base in favor of native PHP calls b) add a bit of performance due to native PHP calls c) move towards type-safety to ensure that we hand over strings to these methods, as our own method was a bit more "lax" on things Resolves: #95257 Releases: master Change-Id: I70617ab4419849353a72a10dfed31a2d96f58072 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70444 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Hader authored
https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.7 composer req typo3/phar-stream-wrapper:^3.1.7; \ composer req typo3/phar-stream-wrapper:^3.1.7 \ -d typo3/sysext/core --no-update Resolves: #95286 Releases: master, 10.4, 9.5 Change-Id: I077aca99a5fbcf44c957a808c072b69906e02cf9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71129 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
With #88921 new events were introduced, which allowed to add additional markup to the columns in page layout. Those events however were never implemented in the fluid based page module. Making them useless in v11, since PageLayoutView can no longer be used. This patch therefore adds the events to the fluid based page module. Due to the changed functionality in the new code base, the events are extended and some methods are deprecated. A side effect from the fluid based page module is, that the events do now take effect in both modes, columns mode and languages mode, as well as for defLangBinding. Resolves: #95261 Related: #88921 Releases: master Change-Id: Icbf10f29f6a3bb9f3ce1b591ceccfde966380cb1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71118 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Jochen Roth authored
The language switch in FormEngine allows to either switch to an existing translation of the current record, or to create such a translation. This however currently does only work in case a default language record exists. Therefore, in case no default record exists, the "localize" option is skipped for the record, preventing PHP warnings. Resolves: #95160 Releases: master Change-Id: I01211b16fc51c8a18a7f97f5d5c8fa316a34ae49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70979 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
* cleans up code, to avoid using "onclick" in variable name * adds deprecation comments to simplify removing snippets in TYPO3 v12.0 Resolves: #95276 Releases: master Change-Id: Ica1e9b24f831728d072a6ec12c48e4cfea2ce96a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71125 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Simon Gilli authored
ext:frontend uses the function mb_ord which is available since symfony/polyfill-mbstring v1.16 and to avoid issue this dependency is properly increased and also added to ext:frontend. Composer commands used: * composer require "symfony/polyfill-mbstring:^1.16" * composer require --no-update -d typo3/sysext/core "symfony/polyfill-mbstring:^1.16" * composer require --no-update -d typo3/sysext/frontend "symfony/polyfill-mbstring:^1.16" Resolves: #95279 Releases: master, 10.4, 9.5 Change-Id: I31aa9affa936ae96d5a02ad846aa011fb89af75d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71127 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The navFrameScript / navigationFrameModule functionality, which adds an iFrame for the navigation frame for a specific module has now been deprecated in favor of native custom HTML tags / web components. Resolves: #94094 Releases: master Change-Id: Ieb89f9f87efe0f2f12dd6abe4a8111edda0cd24b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68923 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Hader authored
Resolves: #95274 Releases: master Change-Id: If60f410ff1e1ed6a8f52e30df32900a4be73ad27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71124 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
This change allows using internal URIs (like t3://) in components of the backend user interface like * system news show below the backend login form * rich text details of system reports HTML sanitization is applied to mentioned components as well. Resolves: #95179 Related: #67556 Releases: master Change-Id: I94c91fbb27380b26b136eba604e5c1552061eab2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71020 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
Substitutes inline `onclick` events for `ShortcutMenu` invocations in the backend user interface with corresponding HTML attributes handled by `ActionDispatcher.ts`. Resolves: #95260 Releases: master Change-Id: I8ca787056635aeff30ae3f4b1142f472fa5e1aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71119 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Introduces `<f:transform.html>` view-helper, providing capabilities to resolves system internal links, like `t3://`. Example: <f:transform.html selector="a.href,div.data-uri"> <a href="t3://page?uid=1" class="page">visit</a> <div data-uri="t3://page?uid=1" class="page trigger">visit</div> </f:transform.html> ... will be resolved and transformed to the following markup ... <a href="https://typo3.localhost/" class="page">visit</a> <div data-uri="https://typo3.localhost/" class="page trigger"> visit</div> Following Composer dependency is made explicit: composer req masterminds/html5:'^2.7' ext-dom:'*' Resolves: #95176 Releases: master Change-Id: Ib0101fbe120343dc404f0816da6d38946df0d931 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70977 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Sep 19, 2021
-
-
Christian Kuhn authored
Variable $uploadedFiles is carried around in DataHandler through various methods, but is in fact never used since TCA type=group with internal_type=file has been dropped in v10. The patch drops that argument. All method changes are detail implementations within DataHandler and either protected or marked @internal, the change does not raise backwards compatibility issues. Change-Id: I4ca56005d9e52255d3168358d16bbb66347d8974 Resolves: #95264 Related: #87428 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71115 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Sep 17, 2021
-
-
Nikita Hovratov authored
Since commit e09082f7 (v10 release) the possibility to override the preview header was gone. This patch moves the drawItem hook out of the renderPageModulePreviewContent method to be able to pass the before rendered previewHeader to it. Resolves: #91760 Relates: #90906 Releases: master Change-Id: Ia7d29333543d764f4ebaec0330df1817032dc8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68953 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Removes inline JavaScript from installer step "Create Administrative User & Specify Site Name". Also mark button as type="button" to avoid intercepting the form submit due to the toggling event handler. Resolves: #95266 Resolves: #95241 Releases: master Change-Id: I002fabc185bf8fdf88793abfdf6ca89b61847e3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71121 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Hader authored
Remaining individual inline JavaScript in `onclick` handler to open an URI in a new window is replaced with default frontend JavaScript (see #95041) in `AbstractPlugin::pi_openAtagHrefInJSwindow()`. Resolves: #95151 Releases: master Change-Id: I90e12d521efaf1a0ac0be0890c940f20b832aa21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70968 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Christian Kuhn authored
Methods FlexFormTools->getArrayValueByPath() and FlexFormTools->setArrayValueByPath() have well test covered counterparts in ArrayUtility since v7. Usages can be adapted easily and the outdated implementations can be deprecated. Change-Id: Ieb40369c883b95f6c7cc398cfdab3a9a08054b8f Resolves: #95254 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71112 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
The variable $log_data does not always have 5 entries. Use the array spread operator to provide all available entries. Resolves: #95066 Releases: master Change-Id: Iead57b5d6c6bd43cfe8c9f3abaf5bfc1cd8ecd9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70858 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The method "GeneralUtility::minifyJavaScript()" was introduced back in 2007 when TYPO3 used "jsmin". Then, the hook was introduced, and "jsmin" was removed from TYPO3 Core again. TYPO3 Core also added - in parallel - the concept of the PageRenderer, which also contains a hook for extensions (such as EXT:min), or then calls the ResourceCompressor, which takes care of compressing and concatenating resources. The hook is now moved from GeneralUtility and executed within the ResourceCompressor, so extensions can still use the hook to compress inline JavaScript. However, the method is completely mis-placed nowadays and is moved to the according place in ResourceCompressor. Resolves: #94791 Releases: master Change-Id: Ia7b7534ea2fbd44258a191b8a4b16144adaa0c7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70236 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Rachel Foucard authored
The drop zones added space when they appear during a drag and drop action and it changed the mouse position. Also each content had a “new content” button relative to it and this button was dragged with it. This fixes both problems. Resolves: #95231 Releases: master Change-Id: I03f2219726ce1b7563409198449ed20dfc681a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71105 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
In the fluid based page module, when in columns mode and having a L>0 language selected, the context always contained L=0 as the current site language. Since this value is used in the fluid templates for data attributes and similar, it might lead to unintended outcome. This is now fixed by cloning the context for the currently selected language before forwarding it to grid creation, as it's already done in languages mode and for the special "defLangBinding" view. Resolves: #95255 Releases: master Change-Id: I3f6f6213e90123ab74f2b4e04985909986df9534 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71113 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Rudy Gnodde authored
Resolves: #94655 Releases: master, 10.4 Change-Id: I91b671d4dea58f022c1b5cb9f1c9f4c5c91bb38c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70122 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Busemann <stefan.busemann@in2code.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Stefan Busemann <stefan.busemann@in2code.de> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Jochen Roth authored
For PHP8 in the frontend there are still undefined key warnings. This is fixed by adding fallbacks. Resolves: #95082 Releases: master Change-Id: I4ef512366aeb3b53adba4e96b07869657415b55d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70867 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Jochen Roth authored
EXT:recycler and EXT:workspaces use nearly the same code for their custom JavaScript based pagination. Therefore, both are adjusted accordingly. All buttons are now always equal height, since the "page-link" class now uses the full parent container space. The prev / next buttons now use the TYPO3 icon element instead of font awesome, making additional classes superfluous. All buttons are now "buttons", since they do not contain a target. This also brings previously missing user agent styles, such as cursor:pointer. Also the full area is now clickable. Additionally, a left over code block from #81086 is removed in the Recycler JavaScript module. Resolves: #95251 Releases: master Change-Id: I5456d0edd566cdc6dc3fb3a8e26d7dc959bd27f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71104 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Sep 16, 2021
-
-
Benjamin Franzke authored
LanguagePackService is supposed to dispatch events that third party extensions can handle. The service instance therefore needs to be factored thorugh the late-booted symfony container, in order for event handlers to be associated. Releases: master, 10.4 Resolves: #93889 Related: #89813 Change-Id: Ia252fbe1b28d55f0944d5cc51801d01b41b008a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68754 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Georg Ringer authored
The record information element displayed the records' table name as "record type", while the actual record row already contains a "record type" column, displaying the TCA defined title for the table. This is now streamlined. The "record type" column is removed from both, the actual row and the information element. All records are now grouped by their record type. The grouping is visualized by a dedicated "header" row, showing the TCA defined title and if debug enabled and admin user, also the table name in brackets (as known from FormEngine). In case the listing is filtered by record type, the additional "header" row is not displayed. Resolves: #95227 Releases: master Change-Id: Ieed145a183cd140b2af0dff6e37b1e7273368022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71093 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Simon Schaufelberger authored
With the introduction of #94402 error pages are fetched via a sub-request. Manual "page not found" ErrorController invocations within an extbase action then resulted in rendering the originally requested page instead of the defined 404 page. This happened because the PrepareTypoScriptFrontendRendering middleware hold a reference to the outer TSFE instance which contains the original page id. Instead of injecting the stateful TSFE (which is generally discouraged), TSFE in now passed as request attribute. The container will log an according warning message from now on. Resolves: #95174 Releases: master Change-Id: Ieda58e2bef8f08762fcba06b76df03aff7b10d5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71084 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Larry Garfield authored
We can re-enable them by default when we're much more certain that stateful services have been removed or properly handled. Resolves: #95253 Related: #95174 Related: #94402 Releases: master Change-Id: I820f48797a21ded4ce49b74ce11b9c1eb164b353 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71107 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-