- Apr 17, 2020
-
-
Benjamin Franzke authored
This will allow both, dependency injection for these services (manually wired in service providers), and usage in install/maintenance tool (where we do not use the caching symfony container for basic tasks). The move to DI is possible thanks to the failsafe container and the service providers which can fed the failsafe container with service factories. These factories are used to wire services manually. Notes: * The definition in a service provider means we are required to use manual wiring and are forced to define the dependencies in the service provider when we add new depenencies to services that are being used by the install.. With that approach we can assure that we do not accidentally add new dependencies to services which would become available in symfony DI due to autowiring, but would be unavailable in the install tool. * The install tool has operations that require a booted symfony container which is provided by the LateBootService. Services that are used in that mode do not need to be listed in service providers. Therefore we do only add core services to service providers if they are used in a context without a fully booted symfony DI container. * GLOBALS['LANG'] mocks in Core\Tests\Unit\DataHandling\DataHandlerTest have been removed as the code under test does no longer use $GLOBALS['LANG']->csConvObj->substr() but mb_substr. The test had been introduced with #68602 but the tested code was adapted in #78670. * We got a bit ugly constructs now, where a unit(!) test previously used $GLOBALS['LANG'] = new LanguageService(); …we now have to encode the dependency structure: $GLOBALS['LANG'] = new LanguageService(new Locales, new LocalizationFactory( new LanguageStore, $cacheManagerProphecy->reveal() ) ); This isn't nice, but this change reveals that the affected unit tests should either be adapted, removed or be moved to a functional test. Such adaption are out of scope for this change. * loadExtLocalconfDatabaseAndExtTables() is removed from the EXT:install AbstractController, as it hides the implicit dependency to LateBootService * Nullable constructor arguments have been changed to be non-nullable whenever possible. That results in some more test adaptions, but reveals, where unit tests rely on implicit dependencies and offers better readability and less possible codepaths. Releases: master Resolves: #89892 Resolves: #89891 Change-Id: Ib72d6440f81b2c0d05279e8768697c3b48aecfe4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62575 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Richard Haeser authored
For proper animations during drag / drop of the widgets at the Dashboard, we need a Web Animations API polyfill for some browsers. This patch replaces the current polyfill with a lightweight MIT-licensed library. Resolves: #91072 Releases: master Change-Id: Ic04d97ab1d1a16a99aa92522552b4b060ced31e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64206 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Hader authored
Arrow functions keep using their own `thisArg` on invocation. To be able to avoid unscoped `function()` call and still retrieving `targetElement` it is passed explicitly as 2nd callback argument. Resolves: #91084 Releases: master Change-Id: I3f1087713827605ac8b59f18eb4a59becd67e460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64209 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/backend/Classes bin/rector process --set=php53 typo3/sysext/backend/Tests Releases: master Resolves: #91064 Change-Id: I9e91882ab233b0e34bc991fd348fceba197a91ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64187 Tested-by:Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Eßl authored
The changes made in #90135 introduced a regression, that made the PageContentErrorHandler ignore the enabled flag of the requested language. Resolves: #91013 Related: #90135 Related: #87865 Releases: master, 9.5 Change-Id: I23504caab2f060c49f112d7bc529e71d02939486 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64131 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Benjamin Franzke authored
PackageManager can not have DI tags assigned as it is a early container instance (injected from core Bootstrap). That caused the 'packagesMayHaveChanged' event to never be executed. We rather need to hookup the event listener using a service provider that extends the ListenerProvider. (That's pretty much the same, what the DI tags do in the background as well.) Notes: 1) To avoid similar future mistakes we also remove the unneeded `autoconfigure: false` from Configuration.yaml 2) This restriction (no DI tag configuration) does only apply to early instance services, which is a static list of core TYPO3 services. 3) We additionally drop the currently unused event callback PackageManager::beforeInstallationEventListener. It was not fully migrated to a PSR-14 event callback in #90249, which revealed that it is actually unneeded. The signal callback was introduced with #52766 in EXT:extensionmanager/ext_localconf.php, but became obsolete with later fixes: #71071 and #71455 ExtensionManagementService now calls (through Install/ListUtility) directly into packageManager instead of (mis-)using a signal/event. Resolves: #90955 Related: #90249 Releases: master Change-Id: I8943e6149743d527c9e1157e425eed3afa98b0d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64156 Tested-by:Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Daniel Siepmann authored
Initial documentation covering basic editor, integrator and developer tasks. Resolves: #90340 Releases: master Change-Id: Ib4917b8f618062ec2f6566415bee7fdf611a2dcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63754 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Tymoteusz Motylewski authored
Do not calculate permissions for every page, as we're limiting the pages through SQL query constraints. Fetch sys_language_uid and l10n_parent from db as they are required for isInWebMount to prevent it from fetching row from db again. Pass full row to isInWebMount in calcPerms instead of just uid. isInWebMount has logic to handle translated records. Resolves: #91037 Related: #90105 Releases: 9.5, master Change-Id: I56dbaf3daa15aa8b6f0fc5e09b212aa34203a0b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64175 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Christian Eßl authored
Add checks to use proper permissions in the DataHandler class, as in some cases, where the record is not a page, the PAGE_DELETE permissions were used instead of CONTENT_EDIT. Resolves: #90878 Related: #90019 Releases: master Change-Id: Ic10dc132391044ae0c98b93316d877053a091b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63999 Reviewed-by:
-
Benjamin Franzke authored
A booted symfony container is needed as ext_localconf.php is loaded since #89713 for the "Check TCA" action. ext_localconf.php files may depend on a fully-booted symfony container, therefore we need to provide it in this case as well – or ext_localconf.php loading may fail. Adapt the LateBootService to allow to reset to a previously backuped container (even if it has been reset in the meantime by another method). Currently affected extensions were EXT:news before commit ac0cb20c (which added a workaround for this case). Thus the bugfix can be verified against the parent of that commit: georgringer/news:205cb3e Releases: master Resolves: #91073 Related: #89713 Change-Id: Iaceb5efae26c1ae2e08e0db31ff2c223cc803ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64190 Tested-by:
-
- Apr 16, 2020
-
-
Susanne Moog authored
The interfaces of the dashboard have been moved out of the interfaces folder to be consistent with the overall TYPO3 structure. Additionally, the superfluous button utility has been removed. Releases: master Resolves: #91066 Change-Id: Iaad0c1d8d046b467ee44d8cbbe32f8803c737fae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64201 Tested-by:
-
Benjamin Franzke authored
Since #90266 install tool E-Mails are templated and custom logos, viewhelpers or services may be loaded. A custom backend login logo caused the usage of the f:image ViewHelper which triggered the FileIndexRepository which wasn't configured for the install tool context. Therefore we need to provide a fully booted symfony container in order for dependency injection to work for all core and third party extensions, especially when using a customized SystemEmail template. Resolves: #91067 Releases: master Change-Id: Ia2cb06dfecd7bb9bd757b37849c1345e538dfffc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64205 Tested-by:
Martin Hotmann <martinhotmann@gmail.com> Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/frontend/Classes bin/rector process --set=php53 typo3/sysext/frontend/Tests Releases: master Resolves: #91063 Change-Id: Ia6a547ec40c1da2c80cabb8a3e0581d628f51c92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64200 Tested-by: -
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Chris Müller authored
In the dependency injection examples for defining a console command a colon is missing after the class name. Resolves: #91068 Related: #89139 Releases: master Change-Id: Ieea67cfb3f906037a4fad7da49d3d91613a12855 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64202 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Benni Mack authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/core/Classes bin/rector process --set=php53 typo3/sysext/core/Tests Resolves: #91054 Releases: master Change-Id: Ie27503980812581103a5d12581a80a7e8fe474f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64192 Tested-by:Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Patrick Broens authored
When having a multisite setup using the same slugs pointing to the same or other different mounted pages, the PageSlugCandidateProvider will always fetch the information of the first page found in the database which complies with the slug. In some cases this will be the right page, but in other cases will be a page which is not part of the requested website. In the last case this will result in a 404. This patch fixes this by checking if the slug is from the site being called. Resolves: #90469 Releases: master, 9.5 Change-Id: I333bfdfeb37ffa13b86697c4597cbda6e315b590 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63349 Tested-by:
Patrick Broens <patrick@patrickbroens.nl> Tested-by:
Dirk Koritnik <koritnik@werkraum-media.de> Tested-by:
-
Benni Mack authored
ExtensionService (internal API) is a random place for some methods used only in one specific parts of Extbase. Some parts in Extbase internal code regarding request building and determining if an action is cacheable is moved to the places where it is needed. The EnvironmentService class has a method to determine a HTTP-relevant request, which is only relevent for the RequestBuilder where it is now moved to, and uses PSR-7 handling if available. Resolves: #91019 Releases: master Change-Id: Ie6ca0c751bc7453de1d123665b7fe6ce51b37c62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64157 Tested-by:
-
Oliver Bartsch authored
Adds the missing footer section, including the button definition, which can be set in the configuration, to the widget template. Resolves: #91056 Releases: master Change-Id: I2ec3c954e0ac8fec0814848fdb0d4bea897b48d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64195 Tested-by:
-
Benni Mack authored
Resolves: #91053 Releases: master Change-Id: I96108a509c7e9d95e9bd88b9c6b53dbfc37acd5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64193 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Benjamin Franzke authored
rectors `auto_import_names` causes relative class names to be transformed into `use` statements. This reduces the readability of the grouped getFactories array as used in ServiceProviders, we rather used to define all external dependencies in use statements and to include local dependencies using relative class names. Also revert the change in TYPO3\CMS\Extbase\ServiceProvider which has already been applied in #91047 using: git checkout 682873dd^ -- \ typo3/sysext/extbase/Classes/ServiceProvider.php Releases: master Resolves: #91059 Related: #91047 Change-Id: I16c4b0d264b2acc5149da375967d862c879f2958 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64198 Tested-by:
-
Anja Leichsenring authored
command: composer require --dev php-webdriver/webdriver:^1.8 This version of webdriver contains the newly recommended UnknownErrorException, that replaces the deprecated UnknownServerExecption we used before. command: composer require --dev codeception/module-webdriver:^1.0.1 The webdriver package underwent a namechange from "facebook/webdriver" to "php-webdriver/webdriver". Only "codeception/module-webdriver" requires this package, so in order to get rid of the old one, also this dependency needs a raise. Resolves: #91011 Resolves: #91010 Releases: master Change-Id: Ia7283105a8307887073b77a697a3f244ac1ba4c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64127 Tested-by:
-
Andreas Fernandez authored
Resolves: #91057 Related: #91008 Releases: master Change-Id: I448a7b2364996f55c98dfe92c3c566acdf3df3e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64196 Tested-by:
-
Oliver Bartsch authored
This adds the closing html tag to some widget templates which missed it. Resolves: #91055 Releases: master Change-Id: I1905cc601b942c52061eed3d0dc8f0519eba4057 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64194 Tested-by:
-
- Apr 15, 2020
-
-
Oliver Bartsch authored
Removed duplicated code fragments by using the ButtonUtility consistently also for ListWidget and RssWidget. Resolves: #91051 Releases: master Change-Id: Id7b323d16d74e07ff1b68fce73a52110dbdc03d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64189 Tested-by:
-
Alexander Schnitzler authored
This patch has been created with rector and php-cs-fixer bin/rector process --set=php53 typo3/sysext/extbase/Classes bin/rector process --set=php53 typo3/sysext/extbase/Tests Releases: master Resolves: #91047 Change-Id: Idcd1e10e5bf6dd5fa504873e450e31a980fab9db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64180 Tested-by: -
Oliver Hader authored
See https://review.typo3.org/c/Packages/TYPO3.CMS/+/43870/ + typo3/sysext/beuser/Resources/Private/Layouts/Default.html + module import was accidentally removed in #70360 Resolves: #91046 Releases: master, 9.5 Change-Id: I04e0be82c4f16b84b951a157c5618722cdf7577f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64184 Tested-by:
-
Alexander Schnitzler authored
GeneralUtility is a class with only static methods and a class comment stated for years not to instantiate it. Since there is a possibility to prevent instantiations of classes with private constructors, one has added to this class and on top is has been marked final. Releases: master Resolves: #91043 Change-Id: I15e2dfa98b2a30149f9f0efed31281d5d01d4efa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64181 Reviewed-by:
-
Alexander Schnitzler authored
composer remove rector/rector Package operations: 0 installs, 8 updates, 4 removals - Removing tracy/tracy (v2.7.2) - Removing rector/rector (v0.7.0) - Removing phpstan/phpstan-phpunit (0.12.6) - Removing ondram/ci-detector (3.1.1) - Updating composer/xdebug-handler (1.4.0 => 1.4.1) - Updating nette/robot-loader (v3.2.1 => v3.2.3) - Updating symplify/package-builder (v7.2.2 => v7.2.12) - Updating symplify/auto-bind-parameter (v7.2.2 => v7.2.12) - Updating nette/http (v3.0.3 => v3.0.4) - Updating symplify/autowire-array-parameter (v7.2.2 => v7.2.12) - Updating symplify/smart-file-system (v7.2.2 => v7.2.12) - Updating symplify/set-config-resolver (v7.2.2 => v7.2.12) composer require rector/rector:"^0.7.14" --dev Package operations: 5 installs, 0 updates, 0 removals - Installing tracy/tracy (v2.7.4) - Installing phpstan/phpstan-phpunit (0.12.7) - Installing ondram/ci-detector (3.3.0) - Installing jetbrains/phpstorm-stubs (v2019.3) - Installing rector/rector (v0.7.14) Releases: master Resolves: #91048 Change-Id: I45be2ba76b2bd909a28bd391fd2d9d774cbbe0e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64186 Reviewed-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Benni Mack authored
Due to the deprecation of "switchable controller actions", list_type items can now be grouped in FormEngine - as well as all other "select" fields defined in TCA. A new TCA option in TCA type=select is added, called "itemGroups". In addition, all "items" now have four parts (fourth being optional) 0 => label 1 => value 2 => icon 3 => groupID where the group belongs to an item group (defined explicitly) or taken from a --div-- element, which then turns into an optgroup. In order then to avoid the "itemProcFunc" of tt_content.list_type which is used to sort items, a "sortOrders" option is added to sort items (within a group, if grouping is enabled) by label or value. When registering a new plugin, the groupId can be added as well as an additional parameter, which falls back to the "default" group. A new method ExtensionManagementUtility::addTcaSelectItemGroup() allows to add item groups via API. When registering extbase Plugins or pibase plugins, it is possible to add a registered "group ID" to make use of this feature. Resolves: #91008 Resolves: #82352 Releases: master Change-Id: I8ad215b5cbc16f332e7c129d762fc020ade5ceeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63889 Tested-by:
-
Markus Klein authored
Fix the condition whether a page is linkable in the requested language or not. Resolves: #90850 Releases: master, 9.5, 8.7 Change-Id: I720c09cc1f938b5000980bcba20786a5cf41f98d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63946 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Oliver Hader authored
Files that just have been deleted in filelist module need to be removed from current clipboard state - otherwise the rendering process will throw ResourceDoesNotExistException due to obviously missing files. Resolves: #91039 Releases: master, 9.5 Change-Id: Ic03cd8775ee4db40996e1152f4f0b1660323780f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64177 Tested-by:
-
Benni Mack authored
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
-
Michael Schams authored
This patch updates the Changelog documentation and suggests to use one of the keywords "small", "medium", or "large" (instead of numeric values) when registering dashboard widgets. Resolves: #91041 Releases: master Change-Id: I9b1ac49d8586ab058cd7278eadaba42df4fc05fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64179 Tested-by:
-
Benni Mack authored
This change adds proper "language" attributes to ViewHelpers just as the typolink property now allows an additional "language" parameter, in order to allow a language menu with TypoLink. See https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Functions/Typolink.html#language Resolves: #90613 Relate: #89686 Releases: master Change-Id: I63492b6ee99e72ca747e3d74b7991db7be52e48e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63827 Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
-
Josef Glatz authored
The icon path of an extension is only returned if the icon can be found. This prevents the JavaScript from rendering a broken extension icon. Resolves: #91038 Releases: master, 9.5 Change-Id: Ic0a4fb874215408c1781b3acb29e9ec4769150fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64176 Tested-by:
-
Alexander Schnitzler authored
With https://review.typo3.org/c/Packages/TYPO3.CMS/+/59514/ all possibilities have been taken to define which view class to use based on the current plugin environment parameters like controller name, action name and format. Since this is used a lot in user land code, this functionality has been re-enabled for version 10. But still, the main flaw of the original code, i.e. checking for possibly defined classes, is avoided. Instead, users can implement a deterministic view resolver which ensures view objects that implement the ViewInterface. Releases: master Resolves: #90892 Change-Id: Ide2919a6d86b2904087d3d7aa8dfece1abee4658 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64017 Tested-by:
-
Manuel Selbach authored
With this change the method DataHandler::getAutoVersionId will return null or a proper integer value to reduce the complexity at other places to bring it in the right format. Resolves: #91022 Releases: master Change-Id: I3e05e7f31314bebcac5c5d47e88c381f85a399d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64160 Tested-by:
-
