- Jan 25, 2020
-
-
Benni Mack authored
ContextMenuActions has the field "hidden" hard-coded which does not work in e.g. backend user module, where the field is called "disabled". The RecordProvider now evaluates this and adds this as a separate data attribute which is evaluated in JavaScript now. Resolves: #89939 Releases: master, 9.5 Change-Id: Ife22f229805d9bc06bd57b503f1131a815fb0691 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62953 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jan 24, 2020
-
-
Markus Klein authored
This patch adds more sanity checks to the SplitButton when rendering its items. Specifically the existence of getters is checked if those are not part of the AbstractButton already. Resolves: #89729 Releases: master, 9.5 Change-Id: I654238e1c9d606596348119374ac283dda1c1713 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62360 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Andreas Fernandez authored
Resolves: #90193 Releases: master Change-Id: I6e263dabffc3172ec48d55e2148e7d5b087b6b29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63023 Reviewed-by:
-
Benni Mack authored
The extension manager now extracts an uploaded file + folder and sets the configured permissions again. Resolves: #90118 Releases: master, 9.5, 8.7 Change-Id: Ic71380cb5227e7cab651877f9033f48f445aca3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62999 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Dmytro Nozdrin authored
Checkboxes that are placed in sections in BE forms have the same HTML identifiers. As a result it is not possible to check one checkbox in one section without affecting the same checkboxes in other sections. The fix makes identifiers unique. Resolves: #87429 Releases: master, 9.5 Change-Id: Ia5cd88aecb2af12a83f40d39a8b450f5cde09060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60362 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
Resolves: #90192 Releases: master Change-Id: I57c0bc9343ca9a203bb8839c823ccf25ee423f25 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63022 Tested-by:
-
Andreas Fernandez authored
This patch makes use of the AJAX API in the slug update revert handling. This also fixes a bug where the notification box disappears directly once a revert action has been clicked. Resolves: #90173 Releases: master Change-Id: I731ad2ac2ea6b649a1a9ab4dfcef2022c6ca7e19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63015 Reviewed-by:
-
Elias Häußler authored
The TypoScript condition matcher is now able to match pages up in the root line as the old "PIDupinRootline" behavior was. By using the new "tree.rootLineParentIds" expression, one can check if a given page is part of the root line but not currently on the requested page. Example: [30 in tree.rootLineParentIds] ... [end] This is basically the same as: [30 in tree.rootLineIds && page["uid"] != 30] ... [end] Resolves: #88962 Releases: master Change-Id: I15311b39db5d03ad2541377426898c228c86ae53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61500 Tested-by: -
Markus Klösges authored
When searching cache-identifiers by tag, the Typo3DatabaseBackend now utilizes DBMS functions for de-duplication of identifiers instead of fetching all records and de-duplicate them afterwards in php space. This dramatically reduces memory usage, when many duplicated identifiers are in a cache table for any given tag. Note that there is no noticable impact whenever there are no duplicates at all, as the DBMS handles the de-duplication. Releases: master, 9.5 Resolves: #89997 Change-Id: Ia28deee1e02eec9792dc4b0d4ce41e2177fcadf4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62749 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Susanne Moog authored
- in frontend tests: match the root line to the actual TSFE root line - in backend condition matcher: sort the root line similar to frontend (in ts config the root line was already manually sorted, this change has no impact on core code) Resolves: #90196 Releases: master, 9.5 Change-Id: Icff65a649f467a82a85ae454585643b978f17e30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63024 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Andreas Fernandez authored
This patch adjusts the polyfill for $.Deferred.fail() to call the jQuery-based error handling with the correct arguments. Since we don't XHR in this context, we have to fake that object as good as possible. Resolves: #90191 Releases: master Change-Id: Icd9bc82c0fe81ae6326f1804802bd244afc32eb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63021 Tested-by:
-
Andreas Fernandez authored
If an object contains a simple array as value, the query string is now generated in an array-like form. Resolves: #90174 Releases: master Change-Id: Ic19573e406ab3130065e8f2f96b75879e060dc6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63014 Tested-by:
-
Volker Kemeter authored
Two new PSR-14 events are added in the PageLayoutView class. Those events can be used to add content into any column of a BackendLayout. You can use this for example to show some content in a column without a colPos assigned. Releases: master Resolves: #88921 Change-Id: I9271a85220d725f5cfcdf5ce99adf871a50f6032 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61442 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Andreas Fernandez authored
To improve the consecutive build experience, several caches now kick in to only lint and compile files that are necessary. Following changes are done in this patch: - added cache for eslint - build TypeScript incremental - don't mangle TypeScript twice in a full build To be able to utilize the `--incremental` feature of TypeScript, generated files are not removed anymore before a build, since TypeScript needs the previously compiled files for comparision. The `tsclean` grunt task has been renamed to `clear-build` and is now executed right before any *full* build. Side note: on the patch authors machine, the command `grunt scripts` went from ~30 seconds to ~8 seconds after second invokation. Resolves: #90187 Releases: master Change-Id: I2a6cc204aa059411b4d0b26e2e153ff944d190ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63019 Tested-by:
-
Elias Häußler authored
Resolves: #90189 Releases: master Change-Id: I512678ca95fc0b836a26fc91712853ddd88cb78e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63020 Tested-by:
-
- Jan 23, 2020
-
-
Andreas Fernandez authored
Resolves: #90154 Releases: master Change-Id: I6619fd09859586649514544c4181d183b6bed53d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63000 Tested-by:
-
- Jan 22, 2020
-
-
Daniel Goerz authored
Resolves: #90172 Releases: master Change-Id: Iada5d83a36c6777aa9dc4733afcec89dc989a1d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63012 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
If a multi-site setup contains a page with slug "/products" as DOKTYPE=7 and "/products" in another site which is the Mounted Page the PageRouter goes in an endless-loop as there is no context in the recursive call. In addition, some other changes that have been adapted in the previous 9.5 backport are addressed now. On top, there is now a MountPointScenario which serves as a basis for adding more functionality in multi-lingual setups. The next step is also to remove the redirect of the MountPoint page with mount_pid_ol=1. Resolves: #90166 Related: #86331 Releases: master, 9.5 Change-Id: If5c67ac813430f54737192341e22b58c9c275cf6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63007 Tested-by:
-
Johannes Schlier authored
This patch allows linebreaks within the TcaDescription element to make longer description texts easier to read. Resolves: #89650 Releases: master Change-Id: Ifab539efa42522d68e0a248c7bf4e718bfc2327d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62301 Tested-by:
-
Alexander Schnitzler authored
composer require phpdocumentor/reflection-docblock:"^4.3.2" composer require phpdocumentor/type-resolver:"~0.5" Upating phpdocumentor/reflection-docblock to at least 4.3.2 allows updating phpdocumentor/type-resolver to a version higher than 0.4 which is needed to get support for resolving collection types in doc blocks which enables the removal of the custom type resolving via extbase/Classes/Reflection/DocBlock/Tags/Var_.php. Releases: master Resolves: #89795 Change-Id: I2126dd9362e51f6dae9e6103c219295c5c3d679b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62438 Tested-by: -
Oliver Hader authored
* introduce `routeParameter` variable (default `{value}`) * introduce ExceptionExpectation applicable in test cases * adjust TestSet::getSingleApplicable($type) to consider ApplicableConjunction as well * adjust configuration/declaration merges Resolves: #90153 Releases: master, 9.5 Change-Id: Ic0e84ac91bb3a9f7a1d8b004052b8d93867a39e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63005 Tested-by:Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Susanne Moog authored
Resolves: #90169 Releases: master Change-Id: Icf102d434ae6540ebacb4a5103271b86a03f9148 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63010 Tested-by:
-
Timo Poppinga authored
Adjust the IP validation to avoid a warning in case the IP stack used by the current user has changed. Resolves: #90047 Releases: master, 9.5 Change-Id: I814e72648c7b404acc5eaf0b2270685dbab16abe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63001 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jan 20, 2020
-
-
Oliver Hader authored
Symfony route modifiers like `{!parameter}` were not encapsulated when preparing TYPO3 specific enhancer data for route processing. Internal static MD5 hashing is reduced by 4 bits (one character when hex encoded) to keep route modifier in deflated values. Resolves: #90149 Releases: master, 9.5 Change-Id: I040e24b2b49d76ad2a67deb9da43d70be4305722 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62994 Tested-by: -
Oliver Hader authored
+ introduces ApplicableConjunction and corresponding handling + introduces defined state check on variables (not-null variables) + adds possibility to merge with existing enhancer declaration + adjusts VariableItem to support scalar values as well + adds human readable output for empty string and null values Resolves: #90153 Releases: master, 9.5 Change-Id: I248238daced063cf91de93f7527477d13064dca2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62997 Tested-by:
-
Andreas Fernandez authored
POST, PUT and DELETE requests sent by the AJAX API now also support string payloads, e.g. by using `JSON.stringify()`. Resolves: #90152 Releases: master Change-Id: I4e5fa49a4ede2388bdfdc777a5cee92a6a94c3ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62996 Tested-by:
Rodger Rüdiger <spike-shape@protonmail.com> Tested-by:
-
Oliver Hader authored
Resolves: #90156 Releases: master, 9.5 Change-Id: I237ffab4b22351d5244ee54d9bdad5068db3a2c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63002 Tested-by:
-
Guido Schmechel authored
Pages that have slugs that end with the configured index are now no longer matched falsely by the PageTypeDecorator. Resolves: #88633 Releases: master, 9.5 Change-Id: I3af91d65bfbb8ef285bba6c00b6cfe85e0b78f6e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61965 Tested-by:
Felix P. <f.pachowsky@neusta.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Jigal van Hemert authored
It's now possible again to process items from foreign_table configuration with the itemsProcFunc. After that pageTSconfig settings can influence the items once again. AbstractItemProvider->getStaticValues() is removed as it is not used anymore. Releases: master, 9.5 Resolves: #85142 Change-Id: I1d548ad72872d78360c7093e4d6e3cdca8780fc0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57185 Tested-by:
-
- Jan 18, 2020
-
-
Benni Mack authored
DataHandler creates new dataHandler instances in itself which do not hand over the custom parameters used in the outermost instance. The change adds the two parameter which were added in a performance sprint for TYPO3 v8 initially. Resolves: #76215 Releases: master, 9.5 Change-Id: I5560055e6c314cd136ab818241b1558f9718358a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62931 Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Daniel Goerz authored
Resolves: #90137 Relates: #90114 Releases: master Change-Id: I09404a3553632298174f13bc758883bdd8f03e0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62952 Tested-by:
-
Daniel Windloff authored
* Replace _GP with psr-7 request calls * Declare internal public properties as protected * Minor code cleanups as the removal of unneeded properties Resolves: #88757 Releases: master Change-Id: I7a8919d1f333783e7772a2257741c56a6f213e70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61297 Tested-by:
-
- Jan 17, 2020
-
-
Benni Mack authored
The backend user aspect must be set before BE_USER->fetchGroups is called and the TypoScript parser needs a proper ConditionMatcher object for the Symfony-based UserTSconfig conditions like [backend.user.isAdmin] to be working. Note to future self: The reason why the original change was reverted was that: - before workspace-related conditions did not work. - then workspaces worked, but conditions in userTSconfig bricked partially - the patch was reverted and left for dead for 1 year as it's a chicken-egg problem The main issue is that fetchGroup() is doing too much. - A valid user record exists, but the right workspace haven't been "set" which always returns workspace=0 for workspace-related conditions - So the workspace must be initialized earlier, and not at the end of the fetchGroups() call. - workspaceInit() - and some other code within fetchGroups() relies on finished TSconfig (that is the actual chicken-egg problem) So we'll just set the aspects before, but BEFORE setting the aspects, we'll evaluate the selected workspace of a user in a "plain" way. The reason why the backend context aspect now works (again) is because the context contains a "real" BE user object and fetches the data from the object, where as the workspace aspect just contains a static property. Resolves: #90075 Resolves: #86923 Related: #86229 Reverts: #86856 Releases: master, 9.5 Change-Id: I326d92a860a806ff13748cf13ef6b71b7a77089e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62887 Reviewed-by:
-
Eric Chavaillaz authored
If config.fileTarget is set, per example to "_blank", the target is set as fallbak on file link. The target is also added on click enlarge link but it is not wanted if lightbox is enabled. This patch ensure that the target attribute is not printed when lightbox is enabled. Resolves: #89613 Releases: master, 9.5 Change-Id: Ib40359939a7d8689f43b3418b7b5865794046f1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62248 Tested-by:
-
Sebastian Hofer authored
In case of the first mount point of a storage in file list \TYPO3\CMS\Core\Resource\ResourceStorage::getRootLevelFolder() returns always the first mount point folder and not the real root folder. This causes, that the condition is always true in case of first mount point. If the condition is true, no folder restriction is added. If no folder restriction is added the search is done in the whole storage and not only in the selected folder. With disrespecting the mount points this method always returns the real root folder and the condition is only true if the selected folder is the storage root folder. This means a folder restriction is added in other cases. Resolves: #88175 Releases: master, 9.5 Change-Id: I2e9d52fac71f7f37784a05656574d0a9267d28f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62872 Tested-by:
-
Sybille Peters authored
PopulatePageSlug is an upgrade wizard which migrates existing slugs from realurl tables to the table pages.slug. In realurl, when the page title changed, the realurl slug changed (if not fixed). Realurl handled this by adding temporary entries to its tables which would be used to redirect the URL to its new location. These entries had a fixed expiration date (expire > 0). The final slug had no expiration date (expire = 0) The previous behaviour in PopulatePageSlug preferred entries from tx_realurl_pathdata with an expiration date (expire > 0) over entries without (expire = 0). This would prefer (temporary) entries that were only used for the redirects over the final slug. This patch uses the 'uid' for sorting in descending order, which will always use the latest entry for a specific page / language combinations. Resolves: #89194 Related: #89964 Releases: master, 9.5 Change-Id: Ica18bf5c6df9d101ccfce7712eae9c979e558a11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61719 Tested-by:
Albrecht Koehnlein <ak@koehnlein.eu> Tested-by:
-
Alexander Schnitzler authored
This commit introduces a development requirement to phpstan/phpstan to enable static code analysis. A basic configuration file has been added as well to identify most basic errors in the TYPO3 code base. Releases: master Resolves: #90097 Change-Id: I87e11eca6296864fdd7ba8cd109a23b82c27f641 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62851 Tested-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
This patch replaces the usages of `$.ajax()` and its friends with the AJAX API provided by TYPO3 Core. Resolves: #90038 Releases: master Change-Id: Ief3767dd5a5256dca269b8dfb496f37a9bcdbe69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62790 Tested-by:
-
Christian Eßl authored
If multiple functions are present, that call the hook $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['postProcContent'], only the changes of the last executed hook would be present, as each hook in the loop will be executed with the initial value of $content, . not the last written $content. To fix this behaviour, the $_params must be initialized inside the loop. Resolves: #89679 Releases: master, 9.5 Change-Id: Ie54c45d9126acd01637c19c289c9942d0452fdae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62325 Tested-by:
-
Toben Schmidt authored
This change adds a real life example to section "Overriding Configuration via Page TSconfig". Releases: master,9.5,8.7 Resolves: #90128 Change-Id: Ibb434bc3ec7ff3766186fd26a839fa16cd40ea43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62928 Tested-by:
-
