- Mar 11, 2020
-
-
Andreas Fernandez authored
When a FormEngine document gets closed, the spinner now isn't rendered anymore. Resolves: #90723 Releases: master, 9.5 Change-Id: Id62c842335685a010bfbd918755b92fcd348f16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63677 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Hader authored
Handling constructor arguments in extension scanner did not work since constructors are not directly called like a method would be called. Constructors are invoked instead using the `new` statement. Besides that `GeneratorClassResolver` only supported string class names (like `'Example\\MyClass'`) when being invoked using `GeneralUtility::makeInstance`. Scanner configurations related to `__construct` invocation (in terms of creating a new class instance) are now handled in a dedicated new `ConstructorArgumentMatcher`. Besides that, `GeneratorClassResolver` now supports `GeneralUtility::makeInstance(Example\MyClass::class, 123)` as well. `NameResolver` and `GeneratorClassesResolver` are executed in two consecutive `NodeTraverser` instances - otherwise class names cannot be resolved in a reliable way. Resolves: #90722 Releases: master, 9.5 Change-Id: I0154b04674d2637fda817d39a1136c2c8fa389d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63676 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Susanne Moog authored
The string "N/A" was hardcoded in BackendUtility and has now been made translatable. Resolves: #76361 Releases: master Change-Id: I465956999fbbbcdc45175b59c42a5f1a2b31d4dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63672 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Georg Ringer authored
The test `getParseTimeReturnsTotalParseTimeInMilliseconds` fails regularly and needs some improvement. Resolves: #90730 Releases: master Change-Id: I9fb0ce30180da03e633c764c33282ddf7fe83f7c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63679 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Georg Ringer authored
If a new site is created from the Install Tool, the base of the default language should be changed from '/en/' to '/' to have a shorter url. Resolves: #90718 Releases: master Change-Id: Ied58d18136b0e587588425bf119c0e4573836690 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63650 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Mar 10, 2020
-
-
Andreas Fernandez authored
This patch changes the behavior of the FormEngine internal ValueSlider by creating a new instance per occurrence of the slider to solve event stacking issues. Due to the new structure of the module, it's moved into FormEngine/FieldWizard. Resolves: #90673 Releases: master, 9.5 Change-Id: I80f2f2faeb37fb793b19cede7b629d8c415072d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63597 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Fernandez authored
To avoid issues with slow internet connections in combination with the "Refresh required" modal the save button of the FormEngine is now disabled on submit. Resolves: #88637 Releases: master, 9.5 Change-Id: Ib89753350992eb135276cac21995acd81a64f1ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63623 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Christian Eßl authored
The changes made in #87623 made it impossible to resolve the "recordType" of extbase objects in the php persistence configuration. Resolves: #90560 Releases: master Change-Id: If309a8e0f3156902a02af1d98909d79ad248cb02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63604 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Georg Ringer authored
* Wrap filename of 'FIRST_INSTALL' into code instead of strong tag * Move info text about secure password to the password field Resolves: #90720 Releases: master Change-Id: I4c275bfbb11f401cc982efcb815397b472ea9b1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63651 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Jan Delius authored
This patch provides support for nested public paths in the TYPO3 installer. The DefaultFactory iterates backwards through the components of the path to build a correct array. To keep the source code as simple as possible, the substructure is already built and passed to the function. Thus references in the code can be avoided. Resolves: #90690 Releases: master Change-Id: Ib3bb3f265f0e0dc90a56fa2275f12e6cc1e602b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63640 Tested-by:
Rico Drexler <rico.drexler@gmx.de> Tested-by:
-
Susanne Moog authored
The core updater has been adjusted to not only check file write rights, but also the ability to create symbolic links before attempting to run the updater. Resolves: #78300 Releases: master, 9.5 Change-Id: If14f41d5c0e3a73c883ec49ef601d9d19684f4ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63617 Reviewed-by:
David Bruchmann <davidbruchmann@gmail.com> Reviewed-by:
-
Christian Eßl authored
The changes made in #86895 broke previous behaviour in page routing by disallowing the use of the "requirements" option for a route when aspects are present - "aspects now take precedence over requirements". While the reasoning behind this change is valid, the requirements in the Symfony Routing package would now always default to '[^/]++' (every character except "/") for routes that use aspects. Before, it was possible to manually set the requirements to '.+' to allow slashes in an argument value. Instead of purging requirements for variable names having an aspect definition as well, thoese requirements are set to `.+` to relax the default Symfony constraints on default delimiter `/` in this case. Resolves: #90531 Resolves: #88291 Resolves: #87333 Related: #86895 Releases: master, 9.5 Change-Id: I27076aa0425d050e729db84d8e3461a329321342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63529 Tested-by:
-
Georg Ringer authored
The Extbase model `FileMount` has never been used and there is also no need to have a model for every table. To streamline the codebase, the class has been marked as deprecated. Resolves: #90686 Releases: master Change-Id: I141a3171dd9f8c2b7d961541753653886f787d41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63639 Tested-by:
-
- Mar 09, 2020
-
-
Frank Naegler authored
For over 4 years a todo marker exists in the code. It looks like this is no issue and we should remove the marker. Resolves: #69008 Releases: master Change-Id: Ic4f45f1232048a69ee2cea1c55e2952656a303be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63647 Tested-by:
-
Florian Wessels authored
PersistedAliasMapper and PersistedPatternMapper did not take hidden records into account. The Context object used when resolving and generating routes is forwarded to corresponding mapper aspects which are applying this information in their FrontendRestrictionContainer. Only the visibility aspect is considered for HiddenRestriction, FrontendGroupRestriction, StartTimeRestriction, EndTimeRestriction are not taking the Context object into account, yet. Resolves: #88307 Releases: master, 9.5 Change-Id: Iebddb32ba534002a19f458cb69947e4a2d44e990 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60720 Tested-by:
-
Oliver Hader authored
Tests making use of SiteLanguage are adjusted to have a valid parent Site object. This way the implicit aggregate root approach of Site is kept and hanging SiteLanguage instances are avoided. Resolves: #90695 Releases: master, 9.5 Change-Id: I0d377f511854e3bf9acb364f8b23171007cd847d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63645 Tested-by:
-
Frank Naegler authored
This patch allows external references to be rendered. The AssetCollector allows the registration of external references, now the AssetRenderer also renders the output correctly. Resolves: #90694 Releases: master Change-Id: Ib1d63c05a1d81f20cc7e4d7567b825695f4c0224 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63643 Tested-by:
-
Christoph Lehmann authored
A record may be deleted already by an earlier call of deleteRecord() which can occur by deleting records with tt_content IRRE elements what is done by the gridelements extension. This prevents the error "Attempt to delete record without delete-permissions" which occurs in the second attempt where $hasEditAccess is false (as normal editor). Resolves: #87351 Releases: master, 9.5 Change-Id: Ic697dcfe74f12a66d843deef5ae21d74b6209b69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59281 Tested-by:
-
Georg Ringer authored
The suggest receiver can be configured to search only in provided page ids and a provided depth. Fix the calculation of those pages by using `PageTreeView`. Resolves: #81779 Releases: master, 9.5 Change-Id: I13a6c860982036b8f47c4817994d7b1077499a6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63632 Tested-by:
-
Daniel Goerz authored
Resolves: #90688 Releases: master Change-Id: Ia8aad82a1c7a92891644786cd4d76d8a720bd0fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63638 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Richard Haeser authored
As the database column for the field configuration is missing and the field is not used anymore, the TCA configuration for this field is removed. Resolves: #90687 Releases: master Change-Id: I4510419deebf1183eaaabcc2a6078f126a8d58f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63636 Tested-by:
-
Christian Eßl authored
Parts of the cshmanual were never shown, because a language variable contained a <title> tag, that made the browser hide all of the manual content after that tag. Resolves: #90675 Releases: master, 9.5 Change-Id: I2d9cf15153f80bd5d0d8ed8cd0864807f30d31f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63607 Tested-by:
-
Oliver Bartsch authored
This fixes some missing or faulty checks related to the display and behaviour of the fluid based page module to bring it into alignment with the old PageLayoutView. * Correctly consider localization TSConfig settings * Add checks for content-editing allowed for user * Add check for presence of untranslated records * Pass all variables to record header/footer partial * Do not link preview content if user has no content edit access Resolves: #90559 Resolves: #90605 Related: #90608 Releases: master Change-Id: Ie2f200a280f60ed08b5850ead81644ee52508c1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63615 Tested-by:
-
Georg Ringer authored
The statistic of EXT:indexed_search must be sorted by the count to avoid stripping of the most used search words. Resolves: #83062 Releases: master, 9.5 Change-Id: Id8008e0dc3a1ed2a837474fb954930395c80cc12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63630 Tested-by:
-
Susanne Moog authored
DatabaseRecordList adds an additionalWhereClause with an `OR` which may be extended by a hook. Usually, the hook is used to add additional clauses. As the `OR` part is not wrapped in braces, this may result in wrong priorities in the resulting query. As there might be pre-existing work-arounds handling the situation, the fix is done only on master. Resolves: #82283 Releases: master Change-Id: Id60d02cf671db2fffc2635764ebda809ae7cb1af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63620 Tested-by:
-
Markus Klein authored
Resolves: #90685 Releases: master, 9.5 Change-Id: Iae5d9242745a9dd5a1558d19cf84496dc128f557 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63633 Tested-by:
-
- Mar 08, 2020
-
-
Benni Mack authored
Resolves: #90165 Releases: master, 9.5 Change-Id: I6cd1f202c0293902b6444ccd23b30f0f92dbf748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63628 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Benni Mack authored
When having e.g. a composer-based installation in TYPO3 Core, the install tool still generates the "wrong" folder structure in TYPO3. When having e.g. "public" as subfolder where everything will be installed, then the DefaultFactory should actually create a /var/ folder (incl. /var/labels) and not keep the existing folder structure (e.g. typo3temp/l10n). Resolves: #89903 Releases: master, 9.5 Change-Id: Iaada837009be9e31dcb6969b1d424bf322841077 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63609 Tested-by:
-
Susanne Moog authored
TCA select fields have the capabilities for replacing ###CURRENT_PID### with the parent page ID of the current record. This should always be <table>.pid. In case of pages the wrong ID was used. This was now changed to always use the parent page ID indepentent of the current record. In case there is no parent page row, 0 is given. Resolves: #90645 Releases: master, 9.5 Change-Id: I8bc04891a009011f4c0d7fd9e59ab306d650b4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63603 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90668 Change-Id: I92cc4942f9f06d587a7957a94f006d157143e55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63569 Tested-by:
-
Andreas Fernandez authored
The change of #88665 aimed to centralize the onchange behavior for all FormEngine fields. The result of this change is that this didn't work for all field types. Due to the fact the FormEngine rendering is rather cluttered (e.g. sometimes there are hidden fields that hold the actual value) and it's not possible to bind a global event delegation to such fields right now, this patch now uses the onchange handling again which was tried to be replaced. Resolves: #90672 Related: #88665 Releases: master Change-Id: I17d54edfc45dd39735bcc53ed0fd92e9fa061f13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63621 Tested-by:
-
Benni Mack authored
GeneralUtility::makeInstance() stores singleton instances in their overridden class names, however, when using setSingletonInstance (which is used in TSFE) this is not connected, making a setSingletonInstance break with another makeInstance call afterwards - returning a new, non XCLASSED object. Resolves: #73671 Resolves: #80399 Releases: master, 9.5 Change-Id: Ibb0005575db3fec55149a0624929c941c1491ed8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63618 Tested-by:
-
Georg Ringer authored
If ExtensionUtility::registerModule is called with a module configuration only containing an icon identifier the default icon of extbase is unset. Resolves: #80844 Releases: master, 9.5 Change-Id: I879b4fad2c6881fface0d64581c031b6ac7589eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63612 Tested-by:
-
Oliver Hader authored
When using a CGI wrapper to dispatch the PHP process `ORIG_SCRIPT_NAME` contains the name of the wrapper script (which is most probably outside the TYPO3's project root) and leads to invalid prefixes, e.g. resolving the `siteUrl` incorrectly as `http://ip10.local/fcgi/` instead of actual `http://ip10.local/`. Resolves: #89312 Releases: master, 9.5 Change-Id: Ib0732344deb0f2e71e06a4a1929bb712cd4f2239 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63602 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Christian Eßl authored
Since "free mode" has been introduced in #86762 for site languages, the previous onChange="reload" mechanism, when a fallbackType was changed, is now unnecessary and is now removed. Resolves: #90642 Relates: #86762 Releases: master, 9.5 Change-Id: I8bbf9a224dc47c14e4b4ec06961244b6903fbc69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63606 Tested-by:
-
- Mar 07, 2020
-
-
Georg Ringer authored
As the element `style` is listed in the removeTags section, there is no need to have it in the allowTags section as well. Resolves: #88561 Releases: master Change-Id: If0848c2c7533e876e500f2d7378c733f54e1f352 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63608 Reviewed-by:
-
Kevin Ditscheid authored
This commit fixes the setting of the select-attribute for menu items, that have a different arguments-array given to them, but the same controller => action combination as other menu items. Resolves: #87182 Releases: master, 9.5 Change-Id: I7f82be3fd3af73959f671aad781d88e4b0362fc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59176 Tested-by:
-
As the preferred and future-proof way of creating commands is using symfony commands (as a base for scheduler tasks), the documentation has been adjusted to reflect that, by avoiding promoting the scheduler's own tasks. Resolves: #86089 Releases: master Change-Id: I12e385aaf433ad8caf5d4d43ecf41cf2ff7ceee6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63600 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Georg Ringer authored
The variable ###SITEROOT### can only be correctly substituted if the DatabasePageRootline provider is used. There it is added to the flexFormSegment as well. Resolves: #81022 Releases: master, 9.5 Change-Id: I49ecc8cb3c98b7436a013c090618960368f2b37a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63594 Tested-by:
-
Andreas Fernandez authored
This patch replaces jQuery in the ClearCache module used in RecordList with Core APIs in regards of AJAX and event handling. Resolves: #90663 Releases: master Change-Id: I526a2136462c3cd494a8d3191b87f64257114b1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63562 Tested-by:
Roland Golla <rolandgolla@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
