[BUGFIX] Allow slashes in enhanced routes having aspects definitions
The changes made in #86895 broke previous behaviour in page routing by disallowing the use of the "requirements" option for a route when aspects are present - "aspects now take precedence over requirements". While the reasoning behind this change is valid, the requirements in the Symfony Routing package would now always default to '[^/]++' (every character except "/") for routes that use aspects. Before, it was possible to manually set the requirements to '.+' to allow slashes in an argument value. Instead of purging requirements for variable names having an aspect definition as well, thoese requirements are set to `.+` to relax the default Symfony constraints on default delimiter `/` in this case. Resolves: #90531 Resolves: #88291 Resolves: #87333 Related: #86895 Releases: master, 9.5 Change-Id: I27076aa0425d050e729db84d8e3461a329321342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63529 Tested-by:Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php 22 additions, 12 deletions...sysext/core/Classes/Routing/Enhancer/AbstractEnhancer.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerLinkGeneratorTest.php 65 additions, 0 deletions...sts/Functional/SiteHandling/EnhancerLinkGeneratorTest.php
- typo3/sysext/frontend/Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php 12 additions, 2 deletions...Tests/Functional/SiteHandling/EnhancerSiteRequestTest.php
Please register or sign in to comment