- Jul 19, 2024
-
-
Oliver Bartsch authored
To prevent using the renderType for checking whether a column of SelectRelationFieldType is a single reference, we set the maxitems option to 1. This allows to keep existing functionality unmodified. Resolves: #104424 Releases: main Change-Id: I1190f6957e7351c79e23f2a313b3f4775ee130d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85286 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Stefan Bürk authored
This change adds the predefined GitLab CI/CD variable `CI_JOB_ID` value to the suffix, used for containerized network and container names, with the goal to increase uniqueness in CI runs. Additionally, the value is now displayed in execution and the container cleanup notes at least the network name further information source to investage unusually container shutdowns. [1] https://docs.gitlab.com/ee/ci/variables/predefined_variables.html Resolves: #103928 Releases: main, 12.4, 11.5 Change-Id: I6cf8dddefd2b45ed6f5c8cca8aa5521319cc8c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84417 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Hader authored
Fixes an array key warning in $backendUser->groupData['webmounts']. Resolves: #104430 Releases: main, 12.4, 11.5 Change-Id: I077c59c67067f6221288ca4a73589dcc9c69bd07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85296 Reviewed-by:
Sven Juergens <typo3@blue-side.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Martin Adler authored
'RecordData' is already a stateless service and partially injected using DI. The remaining cases could easily be refactored to eliminate these 'makeInstance' calls. Resolves: #104426 Releases: main Change-Id: I938259f22cc13839662fa903d6e9f7be72f1c558 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85289 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Garvin Hicking authored
The Changelog mistakenly referred to "PageRenderer::loadJavaScriptModules" (even though the example code itself was right). To avoid confusion of the method not being static, the notation is also changed from "::" to "->" to indicate a non-static class member method. Resolves: #104428 Releases: main, 12.4 Change-Id: I82827590ea2c852522b487986ff95159204b5b70 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85290 Tested-by:
-
- Jul 18, 2024
-
-
Oliver Bartsch authored
All fields, defined in the sub schema should be added to the Record object, especially the record type value. Resolves: #104418 Releases: main Change-Id: I49c13fac0ee8c09cae31dcc733e2451135af2187 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85284 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
$required defaults to 'false' and does not need to be set explicitly when there are no further non-default arguments. Resolves: #104411 Releases: main Change-Id: If8884ccce95481f0f239cace13fa24c60215ca5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85275 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Oliver Bartsch authored
This also removed a duplicated check for the element's type. Resolves: #104354 Releases: main Change-Id: Ied1cb75ad556efee5a942cb89c6a65f9a8290c19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85218 Reviewed-by:
-
Oliver Bartsch authored
TextPreviewRenderer and TextpicPreviewRenderer extend the StandardContentPreviewRenderer while not implementing any custom functionality and are therefore now removed. Resolves: #104417 Releases: main Change-Id: Ia99c3751405f038dbdc57b531650d7657e4a83fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85283 Reviewed-by:
-
Markus Klein authored
Referencing xmlns namespaces in Fluid using https://typo3.org/ns/... does not work. Fluid only searches for http://typo3.org/ns/. While this is not critical for the default "f" namespace, the core should serve as a good example. Resolves: #104416 Releases: main, 12.4 Change-Id: I698347c3cb6a2b89fd9b3de9dd24e5dabf373be0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85281 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Ayke Halder authored
This patch corrects the missusage of anchor elements instead of buttons for controlling sortable selects. In addition we are adding the existing labels to the buttons to support visually impaired users. Resolves: #104414 Related: #102783 Releases: main, 12.4 Change-Id: If80f62db06bda61250d09bc4727a7ec708f02757 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85279 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benjamin Kott authored
Resolves: #104409 Releases: main Change-Id: I018a839f1c27997448b44f886dbb2b779fbcfc05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85274 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benjamin Franzke authored
Update the acceptance testing selenium image to include google-chrome version 124. The bundled chrome version (115) of the old image (4.11) did not support CSS color-mixing, which is required for #104409. Releases: main Resolves: #104415 Related: #104409 Change-Id: I76be069c4607d62bebd8accd6b7397d4c6f07ff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85278 Reviewed-by:
-
- Jul 17, 2024
-
-
Benjamin Kott authored
- Ensure correct markup structure checkboxes - Add indeterminate state to `.form-check-type-icon-toggle` - Add indeterminate state to `.form-check-type-toggle` - Add indeterminate state to `.form-switch` - Adjust alignment for `.form-check-type-toggle` - Restore btn-check behaviour - Introduce btn-block-vertical - Make checkboxes focusable in localization wizard - Add checkbox styling in localization wizard - Add checkbox overview to styleguide - Add `<UNIQUEID>` marker to styleguide code viewhelper Resolves: #104404 Releases: main Change-Id: I82399727cf47a387a4c63c9c475d58db5bc4e130 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85269 Tested-by:
-
Benjamin Kott authored
Resolves: #104408 Releases: main Change-Id: Ife71c4f3e901d934db26a46d1b910431c73dc21e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85273 Tested-by:
-
- Jul 16, 2024
-
-
Christian Kuhn authored
Get rid of a static class property by substituting it with 'cache.runtime'. IconFactory is used in ext:install and in early TCA building, a bit of DI trickery is needed to to have 'cache.runtime' available early. Other class properties are general DI modernization, two further properties are just indirect access to TYPO3_CONF_VARS and now inlined. Have some minor method signature type additions along the way. Those are not considered breaking since consumers not feeding correct types would already trigger errors in many cases from detail code of the method implementations. Resolves: #104399 Releases: main Change-Id: I9672944cc64a8c9fcf1745bccd9faa8904844050 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85264 Reviewed-by:
-
Christian Kuhn authored
Resolves: #104400 Releases: main Change-Id: I29d1639cb96acbc1c19823d39e5d7233d3854184 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85266 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Georg Ringer authored
Remove the usage of the RawViewHelper in the list view of distributions as also the single view doesn't allow any HTML. Resolves: #97930 Releases: main, 12.4 Change-Id: I6b4fceb7adcb6c7e396140a28d2a50a9dd136029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85260 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
The ArrayFormFactory and underlying functionality requires a PSR-7 Request object. In backend context, when rendering the form element preview, the request is now properly passed. Additionally, the `RenderContentElementPreviewViewHelper`, used in the preview mode to render the content element preview initializes the PageLayoutContext, which since #103326 also requires a PSR-7 Request. Both places are adjusted accordingly, resolving the TypeErrors and making the form preview working again. Resolves: #104375 Releases: main Change-Id: Ib0e07b8a38cca1bb0d78f72b35525e36814e2521 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85242 Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de>
-
- Jul 15, 2024
-
-
Andreas Kienast authored
FormEngine CSS contains a hack for IE(!) making the click on the date picker icon functional. Since this code is pretty old and not required anymore, it is now removed. Resolves: #104392 Releases: main Change-Id: I6e3146bf7c039c776f16f4ad66cff64387afc139 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85261 Reviewed-by:
-
Georg Ringer authored
Remove the spread operator when merging page ids for generating a constraint on the pids in the suggestOptions. Resolves: #102846 Releases: main, 12.4 Change-Id: Id0a55cc9c02473faf3efe48192e86e97b6d76785 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84629 Reviewed-by:
-
Andreas Kienast authored
Historically, FormEngine UI mangles dates from one format to another and feeds the result back to the date picker, crossing fingers nothing goes wrong. This bites hard when it comes to non-standard date formats, basically everything but `d-m-Y`. To lay the groundwork on tackling the date format issue, FormEngine now always works with ISO8601 dates internally, allowing to get rid of some helper methods. Resolves: #104309 Releases: main, 12.4 Change-Id: Iafac126f8f02b6dba6f2623f1e7790c6c6fb9bb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84902 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #104385 Related: #104367 Releases: main Change-Id: I3584b57fb021bc8e90d945250a00ad2968afafad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85250 Tested-by:
-
Simon Praetorius authored
Releases: main Resolves: #104391 Change-Id: I0a1b76a1884fb8d5bf07112ed176fef6e65b2c6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85259 Reviewed-by:
-
Benjamin Franzke authored
Do not listen on the livereload port, as we do not ship the client-side[1] livereload integration anyway. This allows multiple grunt-watch (e.g. main and 12.4) to run in parallel instead of blocking each other because they try to allocate the same port. [1] https://github.com/gruntjs/grunt-contrib-watch/blob/main/docs/watch-examples.md#enabling-live-reload-in-your-html Resolves: #104390 Releases: main, 12.4, 11.5 Change-Id: I36f37178e1752015033d5b0f2746c49b2477c1a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85258 Tested-by:
-
- Jul 13, 2024
-
-
Nikita Hovratov authored
This may happen if the CType is not defined via TCA but rather through page TSConfig or itemsProcFunc. This is really an edge-case, which was found during experiments on backend previews for something else than tt_content records. Still, the above scenario may theoretically happen and can easily be reproduced. Resolves: #102823 Releases: main, 12.4 Change-Id: I7ed54ef339578fc6646c4baeacae7db6fe4c1048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82440 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
- Jul 12, 2024
-
-
Georg Ringer authored
If the TCA setting `opacity` of a color element is set to true, an editor can now select a color and its opacity using the color notation RRGGBBAA. Resolves: #103576 Releases: main Change-Id: Id9b4f8963e4e267a201c70007a5474cded9b91f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85255 Tested-by:
-
Garvin Hicking authored
With #103898 the handling of `handleRootPackage()` was streamlined. This lead to root packages' paths not being set to the base dir of the composer installation any more. The missing code is now added again. Resolves: #104345 Related: #103898 Releases: main, 12.4 Change-Id: I8c66d88ffcacddc2c825964d393d7446db551e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85212 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Christian Kuhn authored
PHP 8.4 linting is fine already. Let's add it to CI jobs. Resolves: #104386 Releases: main, 12.4, 11.5 Change-Id: Ie64f602aace5d816ae80ce502bdf054dde7b787a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85251 Tested-by:
-
Nikita Hovratov authored
The maximum value for "cols" is 50. Using higher values has no effect. See AbstractFormElement->maxInputWidth Resolves: #104381 Releases: main Change-Id: Ifd1a5931706f75ec438794b92fb3fe0dcc3c426e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85246 Tested-by:
-
Christian Kuhn authored
Brings PHP 8.4 fixes. Hard raise in v13, "composer u" in v12 and v11. > composer req psr/http-factory:^1.1.0 > composer req -d typo3/sysext/core --no-update psr/http-factory:^1.1.0 Resolves: #104384 Releases: main, 12.4, 11.5 Change-Id: I65b5955379e30c4f889ed76d0b211ae25c83057d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85247 Tested-by:
-
Christian Kuhn authored
Brings fixes for PHP 8.4. > composer req typo3fluid/fluid:^2.13.0 > composer req -d typo3/sysext/adminpanel --no-update typo3fluid/fluid:^2.13.0 > composer req -d typo3/sysext/core --no-update typo3fluid/fluid:^2.13.0 > composer req -d typo3/sysext/fluid --no-update typo3fluid/fluid:^2.13.0 > composer req -d typo3/sysext/redirects --no-update typo3fluid/fluid:^2.13.0 Note v12 only updates composer.lock to latest fluid version and does not hard raise the dependency. For v11, we can neither hard raise nor 'composer u' since younger fluid versions don't support PHP 7.4 anymore. We're still striving for PHP 8.4 support for composer instances, though: Instances with raised dependencies should be able to run v11 with PHP 8.4 if all other things sort out well. Resolves: #104380 Releases: main, 12.4 Change-Id: I39af60e8d68f2086c1af349717da003267d380d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85244 Tested-by:
-
Jasmina Ließmann authored
Naturally, ViewHelpers convert their contents immediately, which means that in the examples of the "Styleguide" backend module, developers only see the converted code and not the ViewHelper actually used. To avoid this, code examples must use "non-intact" ViewHelpers. With this patch, the CodeViewHelper is extended to decode transmitted entities. As an example, the code examples on the "Avatar" component page have been adapted accordingly. In addition, the standard height in the CodeViewHelper's code mirror configuration has been reduced. Furthermore, new styling has been introduced for example uses and code examples. This has also been adapted as an example on the "Avatar" component page. Finally, the texts on the "Avatar" component page have been updated. Further adjustments to the other example pages in the "Styleguide" backend module will follow. Resolves: #104371 Releases: main Change-Id: I030e12cb144befb267dea1c3d5770787c8480c35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85231 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Garvin Hicking authored
When a CType content element is registered with an empty label, the page preview of that element showed a warning: INVALID VALUE ("myPlugin") which is actually misleading, because not the value itself is wrong, but the label is missing. A new language variable is introduced to distinguish the difference of this misconfiguration issue, and now emits: MISSING LABEL ("myPlugin") Resolves: #104299 Releases: main, 12.4 Change-Id: I7fedaaa017c37f65841c0f00bafa42dd78fc91ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85098 Tested-by:Karsten Nowak <captnnowi@gmx.de> Tested-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for alerts to have more control about the styling of the alerts. From now on we are shipping custom css adapted to our needs. The new alert styling is context aware and adapts to light and dark color schemes. Resolves: #104374 Releases: main Change-Id: I3d2f06a638eccb42acef19ff760f5c453627a484 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85225 Tested-by:
-
Mathias Bolt Lesniak authored
Replaces execution of PHP's `exec()` function with Symfony's Process component within `TYPO3\CMS\Core\Utility\CommandUtility` while maintaining compatibility with the previous implementation. Migrating to Symfony Process implements a more widely compatible solution to command execution, simplifying installation in more limited environments. Because it is recommended best practice when using Symfony Process, this patch also adds the possibility to supply an array to the `$command` argument `TYPO3\CMS\Core\Utility\CommandUtility::exec()`. This patch also adds `symfony/process` as a direct dependency of `typo3/cms-core`. Resolves: #104045 Releases: main Change-Id: I4982d55ec03e3e36f96f23a331421dc5e14d6b14 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84609 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Garvin Hicking authored
Resolves: #90503 Releases: main, 12.4 Change-Id: I3aa078bf231211580aa8f29c11860e002e7be2d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84618 Tested-by:
-
Christian Kuhn authored
BcryptPasswordHash has an option to set a cost value. The lower barrier used to be identical to PHP constant PASSWORD_BCRYPT_DEFAULT_COST. Tests use the lower barrier to speed up tests. With PHP <8.4, PASSWORD_BCRYPT_DEFAULT_COST is 10, it has been raised to 12 with PHP 8.4. The patch frees our code from access to this constant and hard codes 10 as lower barrier check. This keeps the API as is, and this hash is by default set to 12 already in default options if none are provided. Resolves: #104373 Releases: main, 12.4, 11.5 Change-Id: I4c1e94fdc50aa3075570549ccdd3b81a2de2e98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85235 Reviewed-by:
-
Christian Kuhn authored
As a PHP 8.4 preparation, phpunit is raised to latest version of current major version. > composer req --dev phpunit/phpunit:^11.2.7 -w Resolves: #104372 Releases: main, 12.4, 11.5 Change-Id: I395b8487bc3aca2dc34d4b7fe86c03d58a7a8709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85232 Tested-by:
-
Garvin Hicking authored
With the removal of the old hook `$GLOBALS['TYPO3_CONF_VARS'] ['SC_OPTIONS']['t3lib/class.t3lib_parsehtml_proc.php']['transformation']` there was only a limited way to handle RTE/persistence HTML transformations. With the introduction of four new PSR-14 events, the transformation logic can now also be influenced by extensions: * `TYPO3\CMS\Core\Html\Event\BeforeTransformTextForPersistenceEvent` * `TYPO3\CMS\Core\Html\Event\AfterTransformTextForPersistenceEvent` * `TYPO3\CMS\Core\Html\Event\BeforeTransformTextForRichTextEditorEvent` * `TYPO3\CMS\Core\Html\Event\AfterTransformTextForRichTextEditorEvent` Resolves: #104221 Related: #92992 Releases: main Change-Id: Id305ac526f4e63f1c585f101573c6d417fbfc476 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85079 Tested-by:
Stephan Kellermayr <quellenform@gmail.com> Tested-by:
-
