- Nov 07, 2023
-
-
Benjamin Franzke authored
Symfony's AsCommand attribute encodes `hidden = true` into a trailing `|` for the name attribute. Drop that for our command list and mark the command as hidden in the command registry. Resolves: #102292 Related: #101567 Releases: main, 12.4 Change-Id: I6415e3f5525764aab336bab20432c032e0665632 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81617 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Nov 06, 2023
-
-
Imko Schumacher authored
Special characters (e.g. ") in argument labels of console commands are no longer displayed as HTML entity ("). Resolves: #102317 Releases: main, 12.4 Change-Id: Icd3c19e94002113823117f1666503ae277283d40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81685 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #102307 Releases: main Change-Id: Ie123eb853c34ad6bc451e29a73788787bffaf862 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81672 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Torben Hansen authored
Function arguments for `addErrorForProperty()` in Extbase `AbstractValidator` do use PHP native types, so several typecasts in the function are not required any more. Resolves: #102321 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Iecd9999735bdb9f7ca9b7bdc2432de6c30f1f98e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81692 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Fabio Norbutat authored
This change use the correct variable to assign view variables in one example in WidgetImplementation.rst. Releases: main, 12.4 Resolves: #102318 Change-Id: I601d2589ec3a44ab77d8548d507b20969d4e11b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81688 Tested-by:
-
Fabio Norbutat authored
Invalid char encoding has slipped into an yaml example snippet for ext:dashboard. This change use the correct quoting to fix this. Releases: main, 12.4, 11.5 Resolves: #102319 Change-Id: I3dd2fd7a1aec51ad3f1ace7c6b914371e9e12342 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81689 Tested-by:
-
Chris Müller authored
Resolves: #102284 Resolves: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/297 Related: #99308 Releases: main, 12.4 Change-Id: Ia6035bce975eab7978348f4a027e8e1af21c30b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81608 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to the latest version and fixes one issue within `RedisSessionBackend` where the Redis API claims to return a `\Redis` object when calling `->del()`. This indicates a usage of multi mode, where the delete state cannot get determined. Also, multi mode is not supported by our session backend, therefore we handle this case as "not successful" now. Executed command: composer require --dev phpstan/phpstan:^1.10.41 -W Resolves: #102320 Releases: main, 12.4 Change-Id: I6f4edb746c6e23d92d5147cc7c711d8da0309f0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81690 Tested-by: -
Jonas Eberle authored
This adds a line break between concatenated "inline" JavaScripts in order to keep JavaScript without trailing ';' valid. Resolves: #99503 Releases: main, 12.4, 11.5 Change-Id: Icf902679c715687c5be2e5f572526608ce31f882 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77320 Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Andreas Kienast authored
Resolves: #102305 Releases: main Change-Id: I3ce5dec038c93e8d0b8aa690396ece0adca875e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81647 Tested-by:
-
Andreas Kienast authored
The FormEngine feature that shows the amount of remaining characters that fit in a field has been extracted from the `@typo3/backend/form-engine` god module into a separate Lit element. Also, the `badge-*` classes are migrated to `text-*` to have a lot less "bulky" UI. Resolves: #102273 Releases: main Change-Id: I2f87d656ded8f31d9569762d3d68d2f46d861b69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81596 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Nov 05, 2023
-
-
Justus Moroni authored
Resolves: #102192 Releases: main, 12.4, 11.5 Change-Id: I0cc48e27d32b6d6164d9d580121968610a9333b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81446 Tested-by:
-
- Nov 04, 2023
-
-
Josef Glatz authored
This patch fixes some typos and adds a missing quotation mark in the code example. Resolves: #102316 Releases: main, 12.4 Change-Id: I4f234b028a6cb8ca7b6b151366cf575dfc86a90e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81681 Tested-by:
-
Benjamin Franzke authored
@lit/task graduated from a 2-year @lit-labs phase, to an officially supported helper library for lit elements. We want to start using it as it embraces a tri-state model for async operations: * pending * complete * error …which is important in order to always handle error cases instead of silently ignoring them. Also existing or currently running requests are aborted and/or ignored when a newer state has already been activated. The icon-library deduplication caching strategy is refactored into a reusable helper instance that is a bit more generic and allows to abort (ref counted across duplicate requests) async operations. Commands executed: npm install --save @lit/task npm run build Resolves: #102308 Releases: main, 12.4 Change-Id: If068145a8bc87ae386af38aa6a63e4f19062345f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81598 Reviewed-by:
-
Benjamin Franzke authored
Use JavaScript object destructuring to "remove" all options from the configuration object, that are consumed by our CKEditor5 wrapper. Also cleanup RTE resource and config handling to not write unused options into the configuration array and to avoid resolving legacy (CKEditor4) resource paths which are dropped anyway. As a drive-by, dots are now substituted with '_' in RTE field IDs to avoid the following hassle: Dots are interpreted as CSS classes when the ID value is used in combination with a number sign (#) to create a CSS selector for the respective field ID. That means the selector will not match. The class selector additionally becomes invalid once there is a digit after the dot, as CSS classes need to start with strings. (Example: EXT:styleguide in_flex » tab » rte.2). Resolves: #100784 Resolves: #101437 Releases: main, 12.4 Change-Id: I076b838c03588ad6eb8ad075a9df58501f146376 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81406 Tested-by:
-
- Nov 03, 2023
-
-
Andreas Kienast authored
This commit updates bootstrap to version 5.3.2. Executed commands: npm install --save bootstrap@^5.3.2 npm run build Resolves: #102311 Releases: main, 12.4 Change-Id: I9aac1214c6f6024a61a317fe5b7576e8c03f7fd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81676 Reviewed-by:Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Since #94977, the record icon's markup is rendered in JavaScript, using the icon-element component. To display a possible overlay icon, the corresponding identifier is now also forwarded and passed to the element. Resolves: #102167 Relates: #94977 Releases: main, 12.4 Change-Id: I648112b8bd66efcd9935c0b32c987c1e7477ab90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81673 Tested-by:
-
Andreas Kienast authored
EXT:styleguide is not fully compatible to dark mode environments. For the time being, light mode is enforce in examples until further groundwork is done. Resolves: #102310 Releases: main Change-Id: I098929883fbab6969e7bdd3d4af8c9fd487f8556 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81675 Tested-by:
-
Benjamin Franzke authored
The extension key setting was accidentally dropped in one of the monorepo merge preparation changes: https://github.com/TYPO3-CMS/styleguide/pull/475 Also reformat to use tabs as in other composer.json files. Resolves: #102309 Releases: main Change-Id: I97f6864551b524b27e770a5a046a77744fedf5e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81674 Reviewed-by:
-
Andreas Kienast authored
This patch removes jQuery from the `@typo3/backend/module-menu` module. Collapsing/expanding of the module groups is now done by Bootstrap's `Collapse` module. The usage of `$.Deferred()` has been removed without replacement, this looks like a weird hack required back then. Resolves: #102304 Releases: main Change-Id: I0e1f9468e4487a1ef17b12b913d6a4f978c42dc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81643 Reviewed-by:
-
- Nov 02, 2023
-
-
Achim Fritz authored
To prevents sql errors when inherit from SuggestWizardDefaultReceiver and adding a JOIN statement, the fields are now prefixed with the table name. Resolves: #102298 Releases: main, 12.4, 11.5 Change-Id: I608bd30df1b878aec8dbf611e70049c1be88778a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81637 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de>
-
Christian Kuhn authored
Some left over usages pointing to typo3conf/ext/styleguide. Resolves: #102235 Releases: main Change-Id: Ib7e1050bc63fdafa15bb344a145735644c4985c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81649 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Julian Mair authored
The new v12 TypoScript parser removed one undocumented feature of the old parser in particular: Nested constants. The core does not implement this anymore since it is extremely hard to find a solution that scales well. The problem becomes complicated with recursive usage combined with values that may change at any point. There are however a couple of instances that need this feature and can't migrate away easily or at least not without giving them a longer transition timeframe. For this reason, the patch introduces an event in the Frontend rendering chain that allows listeners to manipulate the calculated constants AST structure. This gives event listeners a chance to traverse the calculated FE constants AST before it is cached and further processed. Implementing a resolver of nested constants should be possible this way, even though extensions probably restrict their implementation to limited scenarios. This event is essentially a "last resort" solution: It works in an environment where the AST is still marked internal, and where the dispatching may still be moved around to other places. As such, this event is *not* marked as official feature. It does not come with a ReST file, and it may change or vanish in future major versions in case it becomes a headache during further development. It is tailored for developers who can't move away from nested constants and need an intermediate solution right now. Resolves: #101752 Releases: main, 12.4 Change-Id: Idd6fb12e0bf53ae48d0f3f790f792655ab217b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81078 Tested-by:
Julian Mair <julian.mair94@gmail.com> Reviewed-by:
-
Timon Grützmacher authored
Releases: main Resolves: #102306 Change-Id: I4c12548d08efdfcfe7ba57ea55e2c56a3ceba8ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81648 Tested-by:
-
Benni Mack authored
Even though ResourceCompressor is not used in BE context anymore, the check for HTML5 doctype is now based on PageRenderer instead of TSFE as it is available as a singleton and not as a global dependency. In addition, this reduces a cross-dependency between EXT:frontend and EXT:core. Introducing DI etc. for ResourceCompressor can follow at a later stage. Resolves: #102297 Releases: main Change-Id: I45c73e59456552e35bfa700990124d45389edb09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81636 Tested-by:
-
Jasmina Ließmann authored
> composer update --lock > Build/Scripts/runTests.sh -s buildJavascript > Build/Scripts/runTests.sh -s buildCss Resolves: #102235 Releases: main Change-Id: I02edf44492e742cebaed8900b9cdfc006389820d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81511 Tested-by:
-
Benjamin Franzke authored
Commands executed: mkdir -p tmp git clone https://github.com/TYPO3/styleguide tmp/styleguide cat <<EOT > tmp/replacements.txt regex:(\[[A-Z]+\])==>\1 styleguide: regex:(\[[A-Z]+\].*) \(#([0-9]+)\)==>\1\n\nhttps://github.com/TYPO3-CMS/styleguide/pull/\2 regex: #([0-9]+)==> https://github.com/TYPO3-CMS/styleguide/issues/\1 EOT cd tmp/styleguide git checkout -b main-moved git filter-repo --to-subdirectory-filter typo3/sysext/styleguide --replace-message ../replacements.txt --refs main-moved --force cd ../.. git remote add -f styleguide tmp/styleguide git fetch styleguide git merge --allow-unrelated-histories styleguide/main-moved Releases: main Resolves: #102235 Change-Id: I205b8397e748a0c84d99868664b4d0dd8c5fa99c
-
Benni Mack authored
This change the concept of the Processed File API, which was introduced back in TYPO3 v6 in 2012 (commit #66c204f0), and was almost not touched since then. The "TaskInterface" was hardly extended for purposes other than "ImagePreview" (BE) and "ImageCropScaleMask" (FE). In order to accommodate for what is / was useful in the past years, the TaskInterface's interface signature was adapted, next to typed methods and arguments, the method "sanitizeConfiguration" is added, allowing to reduce logic in the "LocalPreviewHelper". The AbstractGraphicalTask was removed as it extended from AbstractTask and had little value over the concrete implementations, and wasn't even abstract. The AbstractTask now has two abstract methods "getName" and "getType" in order to be extended in its subclasses. All in all, the main goal for this patch is to make the structure of this functionality easier to understand: * A task holds the configuration of a file * A ProcessedFile object is the instance of a file that was or is about to be processed file * A processor can be used to do the actual action Resolves: #102165 Releases: main Change-Id: Ica3ffcfc9c2fee5b5344f5e8b968989fd4371eb4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81618 Reviewed-by:
-
-
- Nov 01, 2023
-
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/475 As a last patch in styleguide standalone repo before monorepo merge, we remove the CI infrastructure since it will be handled by core monorepo.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/474 Styleguide is not API.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/473 Gives that .css file a more unique name indicating it belongs to ext:styleguide.
-
-
Christian Kuhn authored
When ext:styleguide is merged into core monorepo, there will be no more "casual" extensions in typo3conf/ext. The "Scan extension files" check in the install tool is then grayed out. The acceptance test working on this is marked skipped for now. Resolves: #102301 Related: #102235 Releases: main Change-Id: I1f20406c7829587b7218e55f41d10f7d9ddf3e4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81641 Reviewed-by:
-
Benjamin Franzke authored
https://github.com/TYPO3-CMS/styleguide/pull/471 Use thje common-js file suffix as preparation for the merge into typo3/typo3 where all .js files need .ts (TypeScript) counterpart.
-
Christian Kuhn authored
ext:styleguide is a main module in the 'system' section now. An acceptance test has to be adapted. > composer u typo3/cms-styleguide Resolves: #102300 Releases: main Change-Id: I0b15d261a65e9fe320db3e2565bb72f610b85a17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81640 Tested-by:
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/470 Move header comment to correct position.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/469 The third argument on SystemEnvironmentBuilder::run() is obsolete.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/468 Update a series of files that are executable but shouldn't.
-
Christian Kuhn authored
https://github.com/TYPO3-CMS/styleguide/pull/467 The core monorepo runs tests based on styleguide data. The acceptance tests of the backend module will fail when styleguide is merged into core monorepo since the backend acceptance test setup creates styleguide data already. We'll remove the ac test together with a related functional test for now.
-
