- Jun 05, 2019
-
-
Benni Mack authored
Due to non-site handling, setting the locale was built on top of TypoScript settings. This was the reason, this was encapsulated within "$TSFE->settingLocale()". However, as the locale is now always available once SiteLanguage has been resolved, this can be handled very early. On top, the functionaltiy can be extracted from TSFE completely, and be universally used within "Locales". The method $TSFE->settingLocale() is now deprecated. Resolves: #88473 Releases: master Change-Id: I28c057ecc6d6ba37153a09812a61e5827cdb7bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60863 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Neufeind authored
Command used: composer update symfony/* --with-dependencies Following dependencies changed: - Installing symfony/polyfill-php73 (v1.11.0) - Updating symfony/polyfill-mbstring (v1.10.0 => v1.11.0) - Updating symfony/console (v4.2.3 => v4.3.0) - Installing symfony/var-exporter (v4.3.0) - Updating symfony/cache (v4.1.4 => v4.3.0) - Updating symfony/expression-language (v4.1.4 => v4.3.0) - Updating symfony/finder (v4.2.3 => v4.3.0) - Updating symfony/polyfill-php72 (v1.10.0 => v1.11.0) - Updating symfony/polyfill-intl-idn (v1.10.0 => v1.11.0) - Updating symfony/inflector (v4.2.2 => v4.3.0) - Updating symfony/property-access (v4.2.2 => v4.3.0) - Updating symfony/property-info (v4.2.2 => v4.3.0) - Updating symfony/routing (v4.1.4 => v4.3.0) - Updating symfony/yaml (v4.1.4 => v4.3.0) - Updating symfony/filesystem (v4.2.3 => v4.3.0) - Updating symfony/options-resolver (v4.2.3 => v4.3.0) - Updating symfony/polyfill-php70 (v1.10.0 => v1.11.0) - Updating symfony/stopwatch (v4.2.3 => v4.3.0) - Updating symfony/intl (v4.1.4 => v4.3.0) - Updating symfony/polyfill-intl-icu (v1.9.0 => v1.11.0) Resolves: #87050 Releases: master Change-Id: I3556d4cddb3863a26bddd5ac5d84f313d8a2793b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60411 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The check if the pages table is accessible is removed. In TYPO3 v9 this was right after the TSFE creation due to 100% backwards-compatibility in terms of previous code which has now vanished (a legacy hook). This change removes the database initialization check as it is done already anyway earlier in Bootstrap. Resolves: #88481 Releases: master Change-Id: I7ca0c068ece433e9c545163121373b0de2af086d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60866 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
- Jun 04, 2019
-
-
Benni Mack authored
Cache Timeout, configured via config.cache_period can be configured when TypoScript is available. The functionality $TSFE->generatePage_preProcessing() has been thinned out further, as custom PHP Scripts are now handled via custom RequestHandlers anyway, which now rely on this information being set earlier (and also when a page should not be generated). Resolves: #88475 Releases: master Change-Id: Id9b6b0921c797e2b9de8d7b4302c515e59b0217e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60864 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benni Mack authored
This reverts commit 1683f107. Reason for revert: This breaks existing code, as multiple headers are now sent to the client which were previously overridden. As long as there is existing code in TYPO3 where header() is sent, this change can only be done as a breaking change. Change-Id: Id7444b1455855702143b3fde5629203f252ba07e Reverts: #88420 Resolves: #88457 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60839 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Markus Poerschke <markus@poerschke.nrw> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Andreas Fernandez authored
Error pages in site configurations don't need to point to an absolute URI. When such error pages get resolved, the scheme, host and port of the request get attached to the resolved page. Resolves: #86935 Releases: master, 9.5 Change-Id: I1b29b7e7ec51c67e6630ed0f2de5f7e3276e8e7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60630 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Tizian Schmidlin <st@cabag.ch> Reviewed-by:
-
Anja Leichsenring authored
The class typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest manipulates the locale setting of the environment without restoring it. So following tests might get affected by this change and are not independent anymore. Resolves: #88484 Releases: master, 9.5 Change-Id: I02617a34bff08606866e9015111496d75bb6dcd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60869 Tested-by:
-
- Jun 03, 2019
-
-
Anja Leichsenring authored
With #88388, the composer.json file was adjusted to the required versions of phpunit/phpunit ^8.1 codeception/codeception ^3 but the composer.lock file did not reflect these changes. Resolves: #88483 Relates: #88388 Releases: master Change-Id: Idc7d4a63d0d9fb427e2c1b63f62e2b4da057b8e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60868 Tested-by:
-
Benni Mack authored
Due to site handling, the TypoScript properties config.language and config.language_alt have no effect anymore and can be removed. This patch removes the last forgotten occurrences. Resolves: #88459 Releases: master Change-Id: Ic4793035264cc00fe1e5d22b6b1c7cafdbdc49ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60842 Tested-by:
-
Benni Mack authored
The SiteMatcher object now always returns a Site / NullSite, so there will never be an exception "SiteNotFoundException" thrown. This dead code, which is never executed, can be removed. Resolves: #88461 Releases: master Change-Id: I458b46f3beea2ea7934a4557acac67453a819784 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60843 Tested-by:
-
- May 31, 2019
-
-
Benjamin Kott authored
Executed tasks: cd Build yarn add @typo3/icons@1.9.0 --dev yarn grunt copy:core_icons yarn grunt copy:extension_icons yarn grunt copy:install_icons yarn grunt copy:module_icons Resolves: #88467 Releases: master, 9.5 Change-Id: Ib04a694d5f68e5543a674bca4da7f957ae20ace3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60858 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
c.essl authored
There is a "Images on this page" feature in the info module of the adminpanel. This patch adds a simple link icon for each listed image to easily open and view the images in a new tab. Resolves: #88438 Releases: master, 9.5 Change-Id: I150a44e40496f5d525094df7eb940c85e863ba90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60822 Tested-by:
-
c.essl authored
For IRRE relations with a "foreign_selector" relation set to a field of type "group" and internal_type "db", the backend wrongly rendered the message "Allowed file extensions". Instead "Allowed relations" is now shown for table relations. Resolves: #87747 Releases: master, 9.5, 8.7 Change-Id: I8a3b7686af14821ece0f727601c1a1bc0d5e1953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60830 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Andreas Fernandez authored
This patch adds the missing copyright header of the original md5 JavaScript library. To achieve this, the Grunt configuration must be adjusted to keep comments beginning in a special format. Resolves: #88465 Related: #88432 Releases: master Change-Id: I35e5a07793273491f839e415d4deda27d1307ffb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60852 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Rémy DANIEL authored
CKEDITOR.timestamp now contains also a hash of the configuration. This is appended to uri when CKeditor loads resources. This mitigates issues with browser caching when CKeditor plugins are updated. Resolves: #88369 Releases: master,9.5,8.7 Change-Id: I9f4a8f611683db93c47b62d22871eac23f3a8819 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60819 Tested-by:
-
c.essl authored
In order to avoid RuntimeExceptions, the "simulateDate" TSConfig setting for the adminpanel has to be at least 60 seconds. Otherwise $GLOBALS['SIM_ACCESS_TIME'] will be set to 0. Resolves: #88437 Releases: master, 9.5 Change-Id: I0377eb4e1d96636367529d185181f61affed44fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60821 Tested-by:
-
mkoitka authored
Since PHP 5.4 it's possible to disable escaping for unicode characters and slashes, which results in a much cleaner, leaner and most importantly readable TYPO3 log output. Releases: master, 9.5 Resolves: #88120 Related: #77274 Change-Id: I5b331e29e0f036d3d95b0f1045c269a28fec6abb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60431 Reviewed-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Reviewed-by:
-
c.essl authored
Ensure the uid fields in the SeparateSysHistoryFromSysLogUpdate that are passed to RecordHistoryStore::addRecord() and RecordHistoryStore::deleteRecord() are type casted to integers. Resolves: #88270 Releases: master, 9.5 Change-Id: I941f5a82d73b9d76b26355fe126ba8d4a2a15d26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60827 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
c.essl authored
There is a "document size" row in the info module of the adminpanel. Currently the value is outputted as integer, which strips out its unit. This patch fixes that. Resolves: #88439 Releases: master, 9.5 Change-Id: I97591bd1799923e5da5604992cd77546bccb1f51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60823 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
- May 30, 2019
-
-
Benni Mack authored
The functionality "ftu" ("Frontend Track User"), which allows to send the session through GET parameter within the site has been removed. It was used to hand in a session via `config.ftu = 1` and the GET parameter "ftu=a-32-character-string", which then started a session which was added to any link generated. This way, sessions could _have_ been transferred across domains but only if cookies would not be activated by the browser, which is unreliable. In order to pave the way to modern standards (OTP or JWT), this functionality is removed, as the ftu functionality has some flaws, conceptually and security wise. Removed public properties * AbstractUserAuthentication->get_name * AbstractUserAuthentication->getFallBack * AbstractUserAuthentication->getMethodEnabled * AbstractUserAuthentication->get_URL_ID * TypoScriptFrontendController->getMethodUrlIdToken Removed TypoScript: * config.ftu = 1 Removed TYPO3_CONF_VARS * $TYPO3_CONF_VARS[FE][get_url_id_token] GET Parameter "ftu" has no special meaning anymore. Resolves: #88458 Releases: master Change-Id: I664be44228b2180909f6abfda8acfcd5fe36aa5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60840 Tested-by:
-
- May 29, 2019
-
-
Anja Leichsenring authored
phpunit/phpunit changed in their latest release the handling of interface constructor mocking. Some of the tests reacted to this change and needed to be adjusted. Resolves: #88453 Releases: master, 9.5 Change-Id: Ie4c42bdfe93a9b092d118e3010a22db5b088c720 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60835 Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
-
- May 27, 2019
-
-
c.essl authored
Fix a few typos in comments with the word "exits". Resolves: #88396 Releases: master, 9.5 Change-Id: Ie1bff70e9f451c41e537c0637d63fe55999363fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60829 Tested-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Reviewed-by:
aslam idrisov <aslambek.idrisov1@swisscom.com> Reviewed-by:
-
Susanne Moog authored
The link browser now respects the sys_language_uid of the active page record when selecting content elements to link to instead of showing all content elements on that pid. Resolves: #88382 Releases: master, 9.5 Change-Id: I3f292f7af3bdfb746811f8f3937216b18a777520 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60775 Tested-by:
-
- May 24, 2019
-
-
Andreas Fernandez authored
The file `md5.js` used to generate a MD5 hash in JavaScript is deprecated and replaced by an AMD module `TYPO3/CMS/Backend/Hashing/Md5`. Resolves: #88432 Releases: master Change-Id: Ibc4db2af011e79f304cee5bd9de91e6505a9c138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60790 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Markus Poerschke authored
HTTP allows to send multiple headers with the same name. Espacially this is needed for the "Set-Cookie" header to send more than one cookie at the same response. Resolves: #88420 Releases: master, 9.5 Change-Id: I4fd3573424e2ebf954cc5ebd043bd710226897fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60800 Tested-by:
-
Tomas Norre Mikkelsen authored
The Scheduler system extension requires a valid cron command or seconds between scheduler runs. With this commit, the Scheduler now allows "15 2 * * *" as well as "15 02 * * *". The latter one was not accepted till now. The "02" for the hours or minutes are valid cron times, and therefore it should also be allowed in the Scheduler. Resolves: #88371 Releases: master, 9.5 Change-Id: I2ed3d6c4cf445bf0692726c49b5c9207af2e9628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60770 Reviewed-by:
-
Andreas Fernandez authored
The global JavaScript function `top.openUrlInWindow()` has been marked as deprecated. This method was used to open links in a full size popup. Resolves: #88433 Releases: master Change-Id: Ia2bfafff2a3144a3a7fac5356e6cb26085fd182d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60810 Tested-by:
-
Frank Naegler authored
The js module „TYPO3/CMS/Backend/Wizard/Colorpicker“ is not used anymore. The PHP code was removed with #80913. This leftover will now get deleted. Resolves: #85401 Related: #80913 Change-Id: I07da7ac84ee88a36e87ac537ce83464c4d3ebf16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60809 Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible - Use strict type comparison for in_array Releases: master Resolves: #87598 Change-Id: I639fbe1edd291af1a183171d59b0bf42988a0613 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59593 Tested-by:
-
Andreas Fernandez authored
The global JavaScript functions `top.rawurlencode()` and `top.str_replace()` were introduced in 2009 and have been marked as deprecated now. The code is not required and some special handling used in these functions may get achieved with native JavaScript functions. Resolves: #88428 Releases: master Change-Id: Ie2c2fd42da89b00e3c9a0137231b16c2cbd21396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60805 Tested-by:
-
Andreas Fernandez authored
In rare cases it might occur that jquery is not available on ckeditor initialization, but it's used already. Interesting is that jquery is explicitly required two lines later. The code is now changed to require jquery before using its document.ready() handling. Resolves: #88429 Releases: master, 9.5, 8.7 Change-Id: I52d5a381f6415dc7680acb5d23138858dc4e96a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60806 Tested-by:
-
Benni Mack authored
The TypoScript option config.defaultGetVars is not evaluated anymore, as this conflicts with TypoScript logic itself: After TypoScript parsing and condition evaluation in a Frontend Request, config.defaultGetVars is set, this would effectively mean that TypoScript parsing should be re-done in order to meet new possible matches in Conditions. As this logic is flawed and should now easily be handled via a custom middleware (previously this was helpful for setting e.g. L=0 for default pages with RealURL), it is now removed from Core. Resolves: #88419 Releases: master Change-Id: Ic286c96f71953062d7649d71abb72f8f0f20f1a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60799 Tested-by:
-
Andreas Fernandez authored
The file `jsfunc.evalfield.js` responsible for form value evaluation and validation has been removed. This job is now done by `TYPO3/CMS/Backend/FormEngineValidation` since TYPO3 7.4. Resolves: #88427 Releases: master Change-Id: Ib366ccbc5795b9c428743f52098c0a6fbca47735 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60792 Tested-by:
-
Andreas Fernandez authored
This patch refactors the IRRE handling on client side, the JavaScript land has been rewritten to have a better structure and do less repeating on-the-fly calculations. Each IRRE container is represented by a independent instance of InlineControlContainer. Most of the internally used `scriptCall` directives have been removed. Currently, `scriptCall` can't get removed completely, as further refactorings in different areas are required. All of the "external" communication via `inline.foobar()` has been replaced by a event-driven approach. This also affects ElementBrowser windows, those use a minimalistic API based on postMessage. Some code that was never evaluated in ElementBrowser is considered dead and has been removed regarding inserting multiple items. A new sorting library has been added in order to replace jqueryui piece by piece. Executed command: yarn add --dev sortablejs On PHP side, some code has been removed as well since the rewritten client code is event-based and doesn't depend on external calls anymore. Resolves: #88182 Releases: master Change-Id: I4176483d2882cef49fbaddb5e2e1914c1f76c908 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59324 Tested-by: -
Stefan Frömken authored
Releases: master Resolves: #88409 Change-Id: Iff722b6b6f4206e4912fd2d2f7bc8e55d860133f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60788 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Frank Naegler authored
This commit also removes superfluous code and streamlines the search template. Resolves: #88333 Releases: master Change-Id: Id6761796dd8e774497223fe7de6f811b4610e245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60730 Tested-by:
-
GeraSchneider authored
The documentation had no information where to create custom workspaces in the backend. That information has been added. Releases: master, 9.5 Resolves: #88378 Change-Id: I8bd6d7ad2ac291e3576b89d39f9698ce16a5572c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60772 Tested-by:
-
Frank Naegler authored
Resolves: #88345 Releases: master Change-Id: I1da8e97558b0a4697db8aae6b1a098e2628fa519 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60315 Tested-by:
-
Andreas Fernandez authored
This patch removes the TBE_EDITOR.typo3form object, which is unused for a long time now. This "API" was used to either get or set values of form fields in a very old iteration of the FormEngine. Resolves: #88411 Releases: master Change-Id: If7d6e1d13c89944383d06c42d63f2f3a3b40d999 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60791 Tested-by:
-
- May 22, 2019
-
-
Benni Mack authored
Having Site Handling in place, the option "useCacheHash" rendered useless as it is added by TYPO3 Core automatically when necessary with SiteHandling. Any Fluid Arguments haven't been deprecated as this was part of the the legacy functionality. Now the options are still available, but trigger a deprecation message that the option is superfluous and should be removed. Calling typolink.useCacheHash will now trigger a deprecation message. Resolves: #88406 Releases: master Change-Id: I2243a335188c3466b8f8f59e8d3e417f13bf854d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60774 Tested-by:
-
