Skip to content
Snippets Groups Projects
Select Git revision
  • 12.4
  • main default
  • 11.5
  • 13.3
  • l10n_main
  • 13.1
  • 13.0
  • l10n_12.4
  • 10.4
  • 12.1
  • 9.5
  • 11.3
  • master
  • 11.1
  • TYPO3_8-7
  • 10.2
  • 9.3
  • 9.2
  • TYPO3_7-6
  • TYPO3_7-0
  • v13.3.1
  • v12.4.21
  • v11.5.40
  • v13.3.0
  • v12.4.20
  • v12.4.19
  • v12.4.18
  • v11.5.39
  • v12.4.17
  • v13.2.1
  • v13.2.0
  • v12.4.16
  • v11.5.38
  • v13.1.1
  • v12.4.15
  • v11.5.37
  • v13.1.0
  • v12.4.14
  • v12.4.13
  • v12.4.12
40 results
Search by author
  • Any Author
  • Daniel Hürtgen Daniel Hürtgen higidi
  • Jenkins Jenkins jenkins
  • **** **** project_53_bot
3 authors
  1. Feb 07, 2024
  3. Feb 05, 2024
  5. Feb 04, 2024
  7. Feb 03, 2024
  9. Feb 02, 2024
  11. Jan 31, 2024
    • Stefan Bürk's avatar
      [TASK] Unblock argument passing in `Build/Scripts/runTests.sh` · 4971b100
      Stefan Bürk authored 
      The first argument after processing defined options has been
stored into the variable `TEST_FILE`. This value was passed
to PHPUnit based commands as last argument, defining the test
case to execute (or a subset).

Removing this workaround and directly passing remaining options
to the command makes special arguments like `-e` obsolete and
unblocks more generic command passing.

This change removes this variable and passes all remaining
arguments after option processing directly to the PHPUnit
command and paves the way for future command improvements.

Note:   This makes the `-e` option basically obsolete, but
        is kept for now to minimize muscle memory issues.
        Using it will display a `deprecation` notice at the
        end of the script - so it gets recognized.

Resolves: #102769
Releases: main, 12.4, 11.5
Change-Id: I9a85206330a7e1b58d81dc5a2c97a13831af29a1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82728


Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      4971b100
  13. Jan 30, 2024
  15. Jan 23, 2024
  17. Jan 22, 2024
  19. Jan 21, 2024
  21. Jan 11, 2024
  23. Jan 09, 2024
  25. Jan 08, 2024
  27. Jan 06, 2024
  29. Jan 05, 2024
  31. Jan 04, 2024
  33. Jan 03, 2024
    • Andreas Kienast's avatar
      [TASK] Update `@codemirror` and friends · d6ab2e28
      Andreas Kienast authored 
      This commit updates `@codemirror` and its friend packages to their most
recent version. Due to changes within `@lezer/javascript` and
`@lezer/highlight`, our Gruntfile needs minor adjustments.

Executed commands:

    npm install --save \
        @lezer/lr@^1.3.14 \
        @codemirror/autocomplete@^6.11.0 \
        @codemirror/commands@^6.3.3 \
        @codemirror/lang-css@^6.2.1 \
        @codemirror/lang-html@^6.4.7 \
        @codemirror/lang-javascript@^6.2.1 \
        @codemirror/lang-sql@^6.5.5 \
        @codemirror/language@^6.10.0 \
        @codemirror/lint@^6.4.2 \
        @codemirror/search@^6.5.5 \
        @codemirror/state@^6.4.0 \
        @codemirror/view@^6.23.0
    npm update @lezer/javascript
    npm run build

Resolves: #102732
Releases: main, 12.4

Change-Id: I92f81a8dfb8f64e09005f0a332b557ffdc532654
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82302


Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
Tested-by: default avatarcore-ci <typo3@b13.com>
      d6ab2e28
  35. Dec 30, 2023
  37. Dec 21, 2023
  39. Dec 19, 2023
    • Stefan Bürk's avatar
      [TASK] Ensure removing dangling images works with podman · 9fa175c0
      Stefan Bürk authored 
      The TYPO3 core `runTests.sh` contains the `-u` option to
update the images and remove dangling images. Providing
an image name and a `--filter` option is not supported
by podman:
 > Error: cannot specify an image and a filter(s)
 and has not been discovered yet in the TYPO3
core implementation yet.

Both container runtimes `docker` and `podman` support filtering images
using the `reference` filter option. Therefore, this change modifies
the dangling image removal to use multiple filters

To verify that filtering with two `--filter` options can be used with
podman and docker, the following commands can be executed to list the
set of local non-dangling images.

Note: This example uses `dangling=false` instead of
	  `dangling=true` (as in `runTests.sh`), since we expect
      most developers don't have dangling images yet.

> podman images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

> docker images \
    --filter "reference=ghcr.io/typo3/core-testing-*" \
    --filter "dangling=false" --format "{{.ID}}"

Resolves: #102697
Releases: main, 12.4, 11.5
Change-Id: I717d1aa229bdfb73c63aa5b2d46e1aff665544cb
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82235


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      9fa175c0
    • Stefan Bürk's avatar
      [BUGFIX] Avoid type errors in `ResourceFactory` methods · 48d746eb
      Stefan Bürk authored 
      With #92289 logic has been decoupled from `ResourceFactory`
into the `StorageRepository`. As a side change, native php
types have been added to a couple of methods.

`StorageRepository->findByUid()` parameter type has been set
to integer, which breaks the `null` fallback and retrieving
the default storage `uid: 0` in `ResourceFactory` method
`getStorageObjectFromCombinedIdentifier()`. Even worse is
the fact that `getObjectFromCombinedIdentifier()` does not
even try to cope with a invalid identifier provided.

This change modifies `getObjectFromCombinedIdentifier()` and
`getStorageObjectFromCombinedIdentifier` of `ResourceFactory`
to cope with missing storage identifier by falling back to
the default storage (`0`) with a shuffle of the exploded values.

As a side-effect two PHPStan ignore patterns can be removed
from the PHPStan baseline file.

Used command(s):

  Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Resolves: #102692
Related: #92289
Releases: main, 12.4, 11.5
Change-Id: I8ee9736839f59db7917cb49dd0d62af17ee28cda
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82232


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
      48d746eb
  41. Dec 18, 2023
  43. Dec 16, 2023
  45. Dec 14, 2023
  47. Dec 12, 2023
    • Andreas Kienast's avatar
      [TASK] Update ckeditor5 to v40.2 · 14f16d9b
      Andreas Kienast authored 
      This commit updates ckeditor5 to v40. See changelog at
https://github.com/ckeditor/ckeditor5/releases/tag/v40.2.0.

Executed commands:

    npm i --save \
        @ckeditor/ckeditor5-alignment@^40.2.0 \
        @ckeditor/ckeditor5-autoformat@^40.2.0 \
        @ckeditor/ckeditor5-basic-styles@^40.2.0 \
        @ckeditor/ckeditor5-block-quote@^40.2.0 \
        @ckeditor/ckeditor5-clipboard@^40.2.0 \
        @ckeditor/ckeditor5-code-block@^40.2.0 \
        @ckeditor/ckeditor5-core@^40.2.0 \
        @ckeditor/ckeditor5-editor-classic@^40.2.0 \
        @ckeditor/ckeditor5-engine@^40.2.0 \
        @ckeditor/ckeditor5-essentials@^40.2.0 \
        @ckeditor/ckeditor5-find-and-replace@^40.2.0 \
        @ckeditor/ckeditor5-heading@^40.2.0 \
        @ckeditor/ckeditor5-horizontal-line@^40.2.0 \
        @ckeditor/ckeditor5-html-support@^40.2.0 \
        @ckeditor/ckeditor5-indent@^40.2.0 \
        @ckeditor/ckeditor5-link@^40.2.0 \
        @ckeditor/ckeditor5-list@^40.2.0 \
        @ckeditor/ckeditor5-paragraph@^40.2.0 \
        @ckeditor/ckeditor5-paste-from-office@^40.2.0 \
        @ckeditor/ckeditor5-remove-format@^40.2.0 \
        @ckeditor/ckeditor5-show-blocks@^40.2.0 \
        @ckeditor/ckeditor5-source-editing@^40.2.0 \
        @ckeditor/ckeditor5-special-characters@^40.2.0 \
        @ckeditor/ckeditor5-style@^40.2.0 \
        @ckeditor/ckeditor5-table@^40.2.0 \
        @ckeditor/ckeditor5-theme-lark@^40.2.0 \
        @ckeditor/ckeditor5-ui@^40.2.0 \
        @ckeditor/ckeditor5-undo@^40.2.0 \
        @ckeditor/ckeditor5-utils@^40.2.0 \
        @ckeditor/ckeditor5-word-count@^40.2.0
    npm run build

Resolves: #102654
Releases: main, 12.4
Change-Id: I4a7a7596897cd346583bcca5d64824a437d8a710
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82173


Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
Tested-by: default avatarcore-ci <typo3@b13.com>
      14f16d9b
  49. Dec 11, 2023
    • Benjamin Franzke's avatar
      [BUGFIX] Fix link-element initialization race condition · 1f5e344b
      Benjamin Franzke authored 
      Children of custom elements are not guaranteed to be available by the
time the element is added to the DOM — i.e. when the connectedCallback()
is triggered by the browser. That means we can not assume that all
child elements will already be available. See #102550 for details.

To circumvent this race we make use of HTML event bubbling. That means
we register our event handlers on the wrapper element and will
receive events that are triggered on one of the children elements.
To circumvent the initialization race conditions in connectedCallback()
we shift the stateful initialization to the server-side rendering.

Note that we either need to render html components server or client-side
in order to avoid such race conditions or nasty workarounds (like adding
mutation observs and keeping track whether all elements have already
been added or not). Ideally the link-element component would be rendered
fully client-side at some point, but that's out of scope for now.

Resolves: #102603
Related: #102550
Releases: main, 12.4
Change-Id: I54715fd671f717e4253ee41e8ac33a1ca5960eae
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82169


Reviewed-by: default avatarBenjamin Franzke <ben@bnf.dev>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBenjamin Franzke <ben@bnf.dev>
      1f5e344b
  51. Dec 06, 2023
  53. Dec 05, 2023
  55. Dec 01, 2023