- Sep 10, 2024
-
-
Benni Mack authored
Resolves: #104884 Related: #104844 Releases: main Change-Id: I6361b841eededc837702f9fbe61c236c7502abd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85994 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
Benjamin Franzke authored
Executed commands: npm install @typo3/icons@4.3.1 npm run build Resolves: #104883 Releases: main, 12.4 Change-Id: Ib7b903322a566fbdeee5c336c1a755d8ba638ae0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85993 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
ullio authored
This patch adds a new widget for EXT:dashboard, which shows a list of the latest changed pages inside the TYPO3 system. Resolves: #104878 Releases: main Change-Id: I33f86e1cc8d4a546136bb179f19f6338e2e734f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85987 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Philipp Kuhlmay authored
This adds some widgets for EXT:dashboard, which shows a list of the corresponding sys_notes inside the TYPO3 system. The widgets are copied from EXT:treupo_sys_note_widgets which will not be developed further, as all the widgets are now inside the TYPO3 core. Resolves: #104844 Releases: main Change-Id: Iec0a1bef30919d96db282904885d8084ac02ac2c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85899 Tested-by:
-
Benjamin Kott authored
Resolves: #104881 Releases: main Change-Id: I9547fb7c2ef3e1c78856ace3577121388cb7720b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85991 Tested-by:
-
Benjamin Kott authored
Resolves: #104880 Releases: main Change-Id: Ibd6cf85648d6c6642281d9a879d8a314c8bbc097 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85990 Tested-by:
-
Benjamin Kott authored
Resolves: #104879 Releases: main Change-Id: I849c23627ad2d8e0579d99690fa1da623d44b606 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85989 Tested-by:
-
Markus Klein authored
Adds the possibility to configure Redis key prefixes for cache and session backends, which allows to use the same Redis database for multiple caches and/or TYPO3 instances. Resolves: #104451 Releases: main Change-Id: Id6aa2f7ba9a4a0dbfb2335150602aeb836e09b90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85324 Tested-by:
-
Oliver Bartsch authored
Because the Localization\State does currently not support columnsOverrides, the localization state selector wizard throws an exception when setting allowLanguageSynchronization via columnsOverrides. This is now mitigated by removing the non working option from TCA via TcaMigration and informing the integrator about it. Additionally is the Localization\State checked in the wizard and an early return is done to prevent null pointer exceptions. Resolves: #104693 Resolves: #104403 Releases: main, 12.4 Change-Id: Ice719b2b198a6bc26abf0866ecae6c11da20cbea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85721 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
André Buchmann authored
The viewhelpers f:asset.css and f:asset.script are great but missed an option to render referenced files inline. A boolean option "inline" is now added to load the file contents as inline styles or scripts. This is especially useful for content elements which are used first in a page and need some custom css to improve the Cumulative Layout Shift (CLS). Resolves: #99510 Releases: main Change-Id: Ic4282cd4a6ff00594a0aa0cbdf51f49d80806489 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84424 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
-
Thomas Hohn authored
If the 'contentSecurityPolicies' value is not filled properly in the site configuration, the call to $site->getConfiguration()['contentSecurityPolicies'] will fail. The access should we guarded with a null coalescing operator. Resolves: #104873 Releases: main, 12.4 Change-Id: Ie49a25d8ca9a194629c4a389b17b299091d44031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85977 Reviewed-by:
-
Benjamin Franzke authored
Labels for site sets and site settings – as added in #104831 - are now verified for completenes. The script checkIntegritySetLabels.php checks for required and optional labels to ensure labels.xlf and settings.definitions.yaml are in sync. Resolves: #104867 Related: #104831 Releases: main Change-Id: I7c91d9ce1fe79ac3137a06b53010fe36418cc896 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85931 Reviewed-by:
-
Ayke Halder authored
This changes disabled record-action-buttons in workspace-review to use a `button`-tag with `disabled`-attribute. Thereby screenreaders can announce that a button is disabled. Before this a disabled record-action-button was rendered as `span`-tag with `class="disabled"`. Resolves: #104820 Releases: main Change-Id: I87214050361101ac85807c471ec41f362617fe05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85871 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
The package `mime-db` received some updates since its introduction, hence it is now updated to its latest version. Executed commands: cd Build npm install --save-dev mime-db@^1.53.0 ./Scripts/generateMimeTypes.php Resolves: #104743 Releases: main, 12.4, 11.5 Change-Id: I756eed3e8d1a6b02f7b2f855dc63623a0c97245e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85788 Reviewed-by:Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benjamin Kott authored
We are removing the misused has-changed class for new records and replacing it with a dedicated is-new class. This class is used only to check if a record needs to be persisted before certain actions, such as closing or previewing a record, can be executed. Resolves: #104690 Related: #87890 Related: #104676 Releases: main, 12.4 Change-Id: Ie0ddd119de860f9539acc9d1353428529afa7f83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85975 Tested-by:
-
Ayke Halder authored
This changes the `disabled`-attribute of the recycler's search-submit-button. Thereby screen- readers can announce that the button is disabled. Before this there was toggling implemented for `class="disabled"`. Thereby the 'disabled' button was still active and could be activated by keyboard. Resolves: #104817 Releases: main Change-Id: Ifb99481624c5cc24f590c7e9d0f3a61ab9f997aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85870 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
Ayke Halder authored
This changes the `disabled`-attribute of the multi-record-selection buttons. Thereby screenreaders can announce that a button is disabled. Before this there was toggling implemented for `class="disabled"`. Thereby a 'disabled' button was still active and could be activated by keyboard. Multi-record-selection buttons are implemented in these sections: * TCA: SelectCheckboxElement * TCA: TablePermissionElement * backend: record-list * filelist: list * recycler: list * redirects: overview * scheduler: task-list * webhooks: overview * workspaces: record-table Resolves: #104703 Releases: main Change-Id: I178d430ea9b0da7c7aa43f9b203375eb56052f00 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85731 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Benjamin Kott authored
We are dropping the Bootstrap CSS definitions for all navs to have more control about the styling of the nav elements. From now on we are shipping custom css adapted to our needs. The new nav element styling is context aware and adapts to light and dark color schemes. Resolves: #104865 Releases: main Change-Id: I8632b33c48162cbb407dc2b2a99eaab00518c635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85936 Tested-by:
-
Oliver Bartsch authored
The `AsController` has been added to v12 next to the `Controller` attribute. Later has been deprecated in v13 and will be removed in v14. Resolves: #104871 Related: #102631 Releases: main Change-Id: I4cdaff914faaff8f7eb8d4706ec226374c694142 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85972 Reviewed-by:
-
Oliver Bartsch authored
Clean up of field types for TcaSchema. In detail: * Removes duplicate interface implementation * Move __set_state() to abstract * Introduces FieldFormat enum * Extends some FieldType's for convenience methods * Extends TcaSchema::getFields() to support list of fields * Adds styleguide example for type=none with format configuration Resolves: #104741 Releases: main Change-Id: I06afc6d52eb0f5fa299ffef5701f178378f7c942 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85786 Tested-by:
-
Oliver Bartsch authored
Move TypolinkParameter to EXT:core and therefore remove a dependency from EXT:core to EXT:frontend. Resolves: #104869 Related: #104615 Releases: main Change-Id: I7474d31a722a4e27438461b8812e25299f0a72cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85937 Tested-by:
-
Oliver Hader authored
Since AccessLifetime is allowed to be use in any module/route configuration, it should not be marked `@internal`. Resolves: #104870 Releases: main, 12.4 Change-Id: I7614f537e07d5d4c762bf1dc1ac42b0d5c91de87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85938 Tested-by:
-
- Sep 09, 2024
-
-
Stefan Bürk authored
PHPStan released a new version containing a bug starting to report an error if a class extends the native PHP `\SplObjectStorage` class [1]: Non-abstract class ... contains abstract method seek() from interface SeekableIterator. Sadly, this is a not-ignorable error and cannot be added to the baseline. This change upgrades the version to the faulty version and excludes the one file meanwhile. Not good, but the only suitable solution for now. Used command(s): > Build/Scripts/runTests.sh -s composer -- \ require --dev "phpstan/phpstan":"^1.12.3" [1] https://github.com/phpstan/phpstan/issues/11665 Resolves: #104866 Releases: main, 12.4 Change-Id: I8241b02310e6da3cff0292d1d37c8e69862ffb9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85932 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Christian Kuhn authored
Let's raise min versions of dependencies as much as we can in preparation of a good baseline for LTS. > composer req psr/log:^3.0.1 > composer req psr/log:^3.0.1 -d typo3/sysext/core --no-update > composer req psr/log:^3.0.1 -d typo3/sysext/redirects --no-update > composer req psr/http-client:^1.0.3 > composer req psr/http-client:^1.0.3 -d typo3/sysext/core --no-update > composer req typo3/cms-composer-installers:^5.0.1 > composer req typo3/cms-composer-installers:^5.0.1 -d typo3/sysext/core --no-update > composer req typo3/cms-cli:^3.1.1 > composer req typo3/cms-cli:^3.1.1 -d typo3/sysext/core --no-update > composer req nikic/php-parser:^5.1.0 > composer req nikic/php-parser:^5.1.0 -d typo3/sysext/install --no-update > composer req doctrine/annotations:^2.0.2 > composer req doctrine/annotations:^2.0.2 -d typo3/sysext/core --no-update > composer req doctrine/dbal:^4.1.1 > composer req doctrine/dbal:^4.1.1 -d typo3/sysext/core --no-update > composer req doctrine/dbal:^4.1.1 -d typo3/sysext/install --no-update > composer req doctrine/dbal:^4.1.1 -d typo3/sysext/redirects --no-update > composer req doctrine/event-manager:^2.0.1 > composer req doctrine/event-manager:^2.0.1 -d typo3/sysext/core --no-update > composer req doctrine/lexer:^3.0.1 > composer req doctrine/lexer:^3.0.1 -d typo3/sysext/core --no-update > composer req masterminds/html5:^2.9.0 > composer req masterminds/html5:^2.9.0 -d typo3/sysext/core --no-update > composer req phpdocumentor/reflection-docblock:^5.4.1 > composer req phpdocumentor/reflection-docblock:^5.4.1 -d typo3/sysext/extbase --no-update > composer req phpdocumentor/type-resolver:^1.8.2 > composer req phpdocumentor/type-resolver:^1.8.2 -d typo3/sysext/extbase --no-update > composer req symfony/console:^7.1.4 symfony/dependency-injection:^7.1.4 \ symfony/doctrine-messenger:^7.1.4 symfony/expression-language:^7.1.4 \ symfony/filesystem:^7.1.2 symfony/finder:^7.1.4 \ symfony/http-foundation:^7.1.3 symfony/mailer:^7.1.2 \ symfony/messenger:^7.1.4 symfony/mime:^7.1.4 symfony/process:^7.1.3 \ symfony/property-access:^7.1.4 symfony/property-info:^7.1.3 \ symfony/routing:^7.1.4 symfony/uid:^7.1.4 \ symfony/var-dumper:^7.1.4 symfony/yaml:^7.1.4 \ -w > composer req symfony/var-dumper:^7.1.4 -d typo3/sysext/adminpanel --no-update > composer req symfony/console:^7.1.4 symfony/dependency-injection:^7.1.4 \ symfony/doctrine-messenger:^7.1.4 symfony/expression-language:^7.1.4 \ symfony/filesystem:^7.1.2 symfony/finder:^7.1.4 \ symfony/http-foundation:^7.1.3 symfony/mailer:^7.1.2 \ symfony/messenger:^7.1.4 symfony/mime:^7.1.4 symfony/process:^7.1.3 \ symfony/routing:^7.1.4 symfony/uid:^7.1.4 \ symfony/yaml:^7.1.4 \ -d typo3/sysext/core --no-update > composer req symfony/dependency-injection:^7.1.4 \ symfony/property-access:^7.1.4 symfony/property-info:^7.1.3 \ -d typo3/sysext/extbase --no-update > composer req symfony/dependency-injection:^7.1.4 -d typo3/sysext/fluid --no-update > composer req symfony/expression-language:^7.1.4 -d typo3/sysext/form --no-update > composer req symfony/finder:^7.1.4 symfony/http-foundation:^7.1.3 \ -d typo3/sysext/install --no-update > composer req symfony/console:^7.1.4 -d typo3/sysext/redirects --no-update > composer req symfony/uid:^7.1.4 -d typo3/sysext/webhooks --no-update > composer req --dev composer/composer:^2.7.8 -w > composer req --dev phpunit/phpunit:^11.3.1 -w > composer req --dev friendsofphp/php-cs-fixer:^3.64.0 -w > composer req --dev phpstan/phpdoc-parser:^1.30.0 > composer req --dev symfony/translation:^7.1.3 > composer u dasprid/enum phpunit/php-code-coverage Resolves: #104788 Releases: main Change-Id: If4ee0a93483e5ff854a4d893304406b7d9bf1490 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85836 Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #104864 Change-Id: I0c5ee461bb9ea124c9e2931386e1b301b8d1f5f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85930 Tested-by:
-
Simon Praetorius authored
A previous patch already avoided calls to the constructor of `TemplatePaths`, which is deprecated if called with an argument since Fluid v2.15. This follow-up covers remaining places. Furthermore, both usages of `GeneralUtility::makeInstance()` are converted to `new` to harmonize the creation of those objects in the Core. Now every occurrences use `new`. `ksort()` is removed because this is done internally in `TemplatePaths` setters. It was necessary before because of the merging behavior of `extractPathArrays()`, which is no longer used now (and is also deprecated in Fluid). Resolves: #104860 Related: #104823 Releases: main Change-Id: Ic16638e8512f6272dbd52bbf0f65fb405b8483cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85926 Tested-by:
-
Christian Kuhn authored
This obsoletes one manual PHP 8.4 related patch. > composer req enshrined/svg-sanitize:^0.20.0 > composer req enshrined/svg-sanitize:^0.20.0 -d typo3/sysext/core --no-update Resolves: #104863 Related: #104604 Releases: main Change-Id: I28b0ed578c76eeef227f59456c8dfc2b1980f6d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85929 Reviewed-by:
-
Simon Praetorius authored
In preparation for a refactoring, test coverage is added to the existing path merging code. Resolves: #104862 Releases: main Change-Id: I9f92108d565b01e3177341ef7cd0b3f25529bf91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85928 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #104857 Releases: main Change-Id: Ic4cc5c951fa262c58804890a09114e3e11380557 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85923 Tested-by:
-
Hannes Lau authored
By allowing `en` as language key and not falling back to `default` automatically, integrators can get back an edge case to use a different language in default XLF files and provide an english translation in `en.locallang.xlf` files by registering English as another language. This is not the suggested way but has worked in 11.5 and is a valid use case if clients use a different language as basis for e.g. translation agencies. Resolves: #104468 Releases: main, 12.4 Change-Id: Id35c7fd1e3a6b50d2b19eaa418fa4a2ba8c46024 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85447 Tested-by:
-
Benjamin Kott authored
The new panel treelist styling is context aware and adapts to light and dark color schemes. This patch also restores the visibility of treelines in Pagetree overview and Localization overview. Resolves: #104845 Releases: main Change-Id: I82785daec2de46e259eca757206e502798922069 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85914 Reviewed-by:
-
Benjamin Franzke authored
If settings definitions are configured to use the type `stringlist`, it is expected that `SiteSettings->get('setting.key')` returns the array of strings, but failed for namespaced keys (separated by at least one dot) because of array-flattening. Array-flattening does only provide access to concrete array values, as `ArrayUtility::flattenPlain` transform a settings tree like ``` [ 'foo' => [ 'bar' => ['a', 'b'], ], ], ``` …into a flat list like: ``` [ 'foo.bar.0' => 'a', 'foo.bar.1' => 'b', ] ``` That means the key `foo.bar` is considered as not existent. To provide access to actively defined settings key, a new settings map is composed from the list of active setting definition keys. For compatibility reasons the old array flattening is still used for: a) undefined settings b) access to sub-values (as it worked before) Releases: main Resolves: #104858 Change-Id: Id3304d4673f778ef8a78381dd317816c0e8f1a13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85924 Reviewed-by: -
Simon Praetorius authored
The constructor of Fluid's `TemplatePath` class allowed both a package name and a configuration array (containing `templateRootPaths`, `layoutRootPaths`, `partialRootPaths` and a `format`). It also tried to set defaults for TYPO3, without the base `TemplatePaths` class being part of TYPO3. To streamline Fluid's API and to untangle Fluid's configuration from TYPO3, both constructor variants have been soft-deprecated with Fluid v2.15 and will log deprecation notices with Fluid v4. In preparation of the switch to Fluid v4, all usages of the constructor are removed from the core. A lot of this work has already been done in previous patches. The remaining usages are related to the `FluidEmail` class, which unfortunately uses Fluid's `TemplatePaths` class as API. In all cases, the default mailer configuration is extended, which is part of the system configuration: from DefaultConfiguration.php: ``` 'MAIL' => [ // Mail configurations to tune how \TYPO3\CMS\Core\Mail\ classes will send their mails. //… 'format' => 'both', 'layoutRootPaths' => [ 0 => 'EXT:core/Resources/Private/Layouts/', 10 => 'EXT:backend/Resources/Private/Layouts/', ], 'partialRootPaths' => [ 0 => 'EXT:core/Resources/Private/Partials/', 10 => 'EXT:backend/Resources/Private/Partials/', ], 'templateRootPaths' => [ 0 => 'EXT:core/Resources/Private/Templates/Email/', 10 => 'EXT:backend/Resources/Private/Templates/Email/', ], ``` `format` is already problematic, because `both` is not a valid value to Fluid. So that value is *not* set in this patch because `FluidEmail` overwrites the value internally anyways once `txt`, `html` or `both` are rendered for an email. The three path arrays are set by using the appropriate setter methods of the `TemplatePaths` object and thus avoiding the deprecated constructor. Merges with additional paths are performed in the same way they were before. Due to slightly different implementations, changes to tests are necessary. The new implementation preserves numeric array keys, while the old implementation didn't. However, the order of the templates stays the same and overriding by key is still possible. Resolves: #104823 Releases: main Change-Id: Iee9e08e3320657bfffa4c069da94efcf0f9ebd2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85832 Reviewed-by:Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
The method is unused in core and also is considered bad API, e.g. because of a couple of method arguments are unused, while other have been added over time to change behaviour. Resolves: #104662 Releases: main Change-Id: Ibe9057dcd7d86995c8bb664cb47be4f3ea043b03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85680 Reviewed-by:
-
Mathias Brodala authored
Resolves: #104643 Releases: main, 12.4 Change-Id: I32a5a46e9cee321673afe760f18578f35af49f4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85659 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Simon Praetorius authored
In preparation for changes on `AssetRenderer`, most of the unit tests are converted to functional tests. The test cases are preserved, but duplicated to cover both the new functional and the old unit tests. Resolves: #104854 Releases: main Change-Id: I3ab5bad81d7554061ca4d2ef61946e8282dc8f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85921 Reviewed-by:
-
Benjamin Kott authored
The new panel element styling is context aware and adapts to light and dark color schemes. The markup was streamlined, workarounds dropped and now features improved focus and hover styles. Resolves: #104818 Resolves: #104798 Releases: main Change-Id: I9cf2b1c203b8a38c0c0675ff26a08131b0277923 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85725 Tested-by:
-
Benjamin Franzke authored
The set language files introduced in #104831 are now auto-loaded from labels.xlf within the sets folder, if the file is provided and the set configuration does not reference an explicit labels xlf file. TYPO3 documentation is adapted to understand this change via: https://github.com/TYPO3-Documentation/render-guides/pull/737 Releases: main Resolves: #104840 Related: #104831 Change-Id: If00ae72da97b65768d925de48f7850e80bc44b3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85907 Reviewed-by:
-
- Sep 07, 2024
-
-
Lina Wolf authored
These directives are currently causing errors in opening rst files in PHP storm. Also it is best practice to only use explicit code blocks or literalincludes. Resolves: #104848 Releases: main, 12.4 Change-Id: I1271b6e4f5e032a1f0d5835e141334e263b30169 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85916 Reviewed-by:
-
- Sep 06, 2024
-
-
Thomas Hohn authored
`LogDataTrait::formatLogDetailsStatic()` simple used `vsprintf()` in case that the string contains any `%` characters and throws either a `\ValueError` or `\ArgumentCountError` depending if no value exists or the count does not match. It is not reliable and implement additional lexing here to avoid the exception by not calling `vsprintf()` upfront. This change calls `vsprintf()` and handles the mentioned exceptions and use the fallback handling in case exception has been thrown as a simplefied approach. Tests are added to cover legacy, mixed and new log format option along with static and instanced method calls. Note that a minor inline PHP DocBlock annotation has been added in `LogDataTrait` to mitigate detection issues of PHPStan, which allows now to remove baseline ignore patterns in the same run. Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #103711 Releases: main, 12.4 Change-Id: I7b23eccdc944d2cb068f584b01b52835aca938e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84004 Tested-by:
-
