- Dec 03, 2019
-
-
Benni Mack authored
Change-Id: I0e8abdb62a45326896fc75d9872eead478615dce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62525 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Change-Id: I09bb29716abb1a7b1f4c8010c1d98c15ae90d808 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62523 Tested-by:
-
Andreas Fernandez authored
Resolves: #89837 Related: #89813 Releases: master Change-Id: Idfb9274c7a5415e6bef7dee61a6ca65728d96674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62522 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Reviewed-by:
-
Benni Mack authored
Some changes were made: - Upgrade Wizard works - Visibility on RedirectHandler is sorted out - TreeUidListProvider is removed - cObject does everything already, less dependencies - PasswordChangeEvent is actually executed now (and works!) - RedirectConfiguration now has a factory - Do not use ConnectionPool as dependency as it contains state - Most "final" and "private" were put back to "protected" (as the rest of core) - except events - Additional hmac check in Repository - Add lifetime validation of hash in changePassword action as well Resolves: #89828 Related: #84262 Releases: master Change-Id: I813a2fc86c8e4f61fd923467aa761246187af901 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62516 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Building reflection cache in ClassSchema on static class properties will lead to side-effects. For instance when ConnectionPool is analyzed for being used with Extbase dependency injection and has been used already during runtime - which is very likely - static property $connections is going to hold all runtime connections. https://www.php.net/manual/en/reflectionclass.getdefaultproperties.php: > This method only works for static properties when used on internal > classes. The default value of a static class property can not be > tracked when using this method on user defined classes. That's why default values of static properties are not resolved anymore. Resolves: #89830 Releases: master Change-Id: I0040c3e4327d084b3192017874154ab5d8466508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62518 Tested-by:
-
Susanne Moog authored
composer require --dev typo3/testing-framework:~6.1.0 Also reverts changes to tests for phpunit 8.3 only. Resolves: #89833 Releases: master Change-Id: I834f70452775ea18960da162bb2affe459b8556a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62519 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Georg Ringer authored
Simplify the UI of the toolbar by hiding the select field if there is only one option to choose from which doesn't make sense. Resolves: #89829 Releases: master Change-Id: I6e58aae1bab25777bca21f058524e447f569d73a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62517 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
Susanne Moog authored
The testing framework has been reworked and slimmed down. To make use of it, tests had to be adjusted. composer require --dev typo3/testing-framework:"~6.0.0" Resolves: #89815 Releases: master Change-Id: Ib0a8d7436070ef17be96a5f4011f796dd15b09fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62502 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Dec 02, 2019
-
-
Andreas Fernandez authored
In case an old installation still has empty values stored in `EXTCONF/lang/availableLanguages` (which has been fixed in #63546), e.g. the language matrix in the "Manage Language Packs" is unusable. This patch therefore removes empty values from the mentioned configuration, as similar solved in the old issue. Resolves: #89772 Related: #63546 Releases: master, 9.5 Change-Id: Id7473e5f17878d84914fec4df629ac6617256b55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62497 Tested-by:
-
Michael Telgkamp authored
- Pagetree is focusable via tab key - Keyboard navigation with arrow keys inside pagetree is enabled - Implement accessible tree structure for tree nodes (role=tree) Resolves: #86818 Releases: master Change-Id: Ic948fb0de8461a8c5b4b5297b94e5cb94465ec42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62051 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Susanne Moog authored
Some change log entries should be documented in extension manuals or in ViewHelpers. The missing docs have been added. Resolves: #89827 Releases: master Change-Id: I6c76dc2d532b151275c60e85feb44f227ca80919 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62515 Tested-by:
-
Daniel Siepmann authored
There were some minor syntax issues within changelog that are now fixed. They prevented: * Rendering of lists * Rendering of code blocks * Rendering of inline code Resolves: #89825 Releases: master Change-Id: Ic272e989e7841eac8c6f04f4819354b0926cd6df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62510 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
Extbase's old signal slot dispatcher / core should not use classes that are not explicitly required for the miminum packages. Resolves: #89823 Releases: master Change-Id: I41f7e378ed3d99e62daebfdd5631ef0234761772 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62508 Tested-by:
-
Andreas Fernandez authored
The issue #89687 introduced a smaller response for page tree nodes by moving sane default attributes to JavaScript and overriding with the actual result. However, this is also done if a new page is created via drag&drop, the attribute get in a mixed state and page tree hurts itself in confusion. The default attributes are now applied only if no DataHandler command is invoked. Additionally, some variables in TreeController were wrongly used, which has been fixed as well. Resolves: #89822 Related: #89687 Releases: master, 9.5 Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Andreas Fernandez authored
docker-compose is updated to use the latest cumulative update (cu) of MSSQL 2017. Since mssql is probably still eager to fail, its stages are executed at last in the nightly builds now. Resolves: #89826 Releases: master, 9.5, 8.7 Change-Id: Ic1e8195f9b4f90747b5843d03630fd453ebe0bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62511 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
There are numereous places where reflection is used in our test cases to inject dependencies, however there are methods available doing so, so the tests can be adapted, which will speed up tests. In addition, the $callInaccessibleMethod() function is also replaced by the accessible mock functionality, resulting in faster results than reflection. Resolves: #89824 Releases: master Change-Id: Ia2fc8a8ee4d3b5fc7b0d2de8759a7e5e9ceb7b87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62503 Tested-by:
-
Benni Mack authored
Using the freshly released version 2.6.8 in our packages adds PHP 7.4 support for Fluid Standalone. composer req "typo3fluid/fluid:^2.6.8" Resolves: #89819 Releases: master, 9.5, 8.7 Change-Id: I986b3f8e73e3114af3aef9f65b42c3bf109f9f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62504 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #89820 Related: #89813 Change-Id: I165dbb813079fbb0f25ac7b1c8ab57f292f73b16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62506 Tested-by:
-
Benni Mack authored
The following new PSR-14 events are added: TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent TYPO3\CMS\Impexp\Event\BeforeImportEvent TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent They replace the following "old" signals with a deprecation layer: TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss Relates: #89733 Resolves: #89813 Releases: master Change-Id: I13f2454fd8f4efb5f4c5248d0b839634b77578db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62422 Tested-by:
-
Jo Hasenau authored
Due to deprecations (in v9) and marking properties from public to protected, some hooks are not as powerful anymore, so special getter methods are provided to overcome this issue. Resolves: #87064 Releases: master, 9.5 Change-Id: I5a05bb8b31c2a9df2801092bd9ead60061bbd15f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62480 Tested-by:
-
Benni Mack authored
Tests should be consistent and reflect the way we do things in Core. However, testing framework offers too many different ways to do things, and "_callRef" is one of that. Resolves: #89817 Releases: master Change-Id: I44759df255365d0f90e0928f3f5726b66ecf9f3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62493 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
- Nov 29, 2019
-
-
Patrick Broens authored
In some versions of PHP there is a PCRE bug, which will be triggered when using an unquoted array syntax in Fluid templates, leading to an error and possibly not able to display the rendered template. This is solved by using the quoted array syntax where it is not used yet. Resolves: #87970 Releases: master, 9.5 Change-Id: I36f4ee86765fae24f7daa0e7e59ff9fc6741144f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62450 Reviewed-by:
Rens Admiraal <rens@simplyadmire.com> Reviewed-by:
-
Benni Mack authored
TYPO3 Core now requires at least doctrine/annotations 1.7, effectively helping to upgrade to PHP 7.4. Resolves: #89812 Releases: master, 9.5 Change-Id: I8ca951711bbcb19d935baad67ff69705d8e51aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62498 Tested-by:
-
Benni Mack authored
The normalizedparams middleware is not executed in the install tool anymore, which is added by the NormalizedParamsAttribute middleware. In addition, the NormalizedParams class now contains factory methods for building up NormalizedParams based on $_SERVER or a PSR-7 request object. Resolves: #89808 Releases: master Change-Id: I1b3713ba22f100f652d746ae15f58f9024808ef1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62494 Reviewed-by:
-
Tymoteusz Motylewski authored
In order to lower response size (by 40-50%) of the page tree controller several page tree item properties are only sent when they have non-default values. Resolves: #89687 Releases: master, 9.5 Change-Id: I65ef2b21c71041994ea86d09d1b989b4515e2e42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329 Tested-by:
-
Susanne Moog authored
Resolves: #89373 Releases: master Change-Id: I5ee8789c43c681d1bed310a74e5947a78130f82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62492 Tested-by:
-
Andreas Fernandez authored
If a preview is opened via the TYPO3 backend, the opened window has the name `newTYPO3frontendWindow` to ensure only one preview window is open. However, if somebody changes in such window into the TYPO3 backend, the window name is not changed, causing that such preview links are opened in the same window again. This patch resets the window name before a preview is opened to ensure that previews are always opened in a new window. Resolves: #89805 Releases: master, 9.5 Change-Id: Ib4b31e78da21befc27c50ea3d49762f2a81fe029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62491 Tested-by:
-
Susanne Moog authored
Resolves: #89806 Releases: master Change-Id: I587bda0e8101d963e6e8c2bfc72f7f1cb3632243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62490 Tested-by:
-
Andreas Fernandez authored
Adds parsing of link to ensure correct order of query params and anchor. Resolves: #88095 Releases: master, 9.5 Change-Id: Ic0bb13ca3f5664e514fe523d96a0bd017fab6b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60409 Tested-by:
-
Alexander Schnitzler authored
php bin/rector process Both sets php54 and php55 have been applied at the same time because set php54 didn't result in any changes. Releases: master Resolves: #89789 Change-Id: Idddc487b34abceb300a237bd458659a10db54469 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62439 Tested-by:
-
Anja Leichsenring authored
A common abstract for both pre-merge and security-pre-merge test runs eases the adaption in case of need, for example adding PHP versions. Resolves: #89803 Releases: master, 9.5, 8.7 Change-Id: I85279ec09bac3baaca94ec517e4a69f3abf830d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62484 Tested-by:
-
Andreas Fernandez authored
Executed command: yarn upgrade codemirror Resolves: #89801 Releases: master, 9.5 Change-Id: Ib47a110c85c15a2b1fcc663804c060e67663cbdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62479 Tested-by:
-
Andreas Fernandez authored
Resolves: #89802 Related: #87688 Releases: master Change-Id: Idad44540f71fb8befac7014e6c7979d102fd486d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62481 Tested-by:
-
Susanne Moog authored
Punctuation at the end of a link will no longer be automatically included in the link. It is valid as part of a link, but has been removed from links if it is the last char. Resolves: #89786 Releases: master, 9.5 Change-Id: I6dc239ddbee71eb2ef6dc26cd11ae444421a2a9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62478 Tested-by:
-
Benjamin Franzke authored
Symfony 4.4 deprecated support for non-object services: https://github.com/symfony/dependency-injection/commit/6f11b359ab9 The usage of `array` as service is therefore no longer officially supported in Symfony 5.0. It still works, but in order to make sure that a possibly introduced type declaration in a 5.x release doesnt causes a type error, we migrate the middleware service from array to ArrayObject. Change-Id: Ie544014b4aa0217b84b0c9d2cc69efde352bef27 Releases: master Resolves: #89766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62429 Tested-by:
-
Benni Mack authored
Some "methods" used in ViewHelpers to mock a class (RenderingContext) which only uses a fixture to avoid constructor calls can be achieved by using phpunit's getMockBuilder() logic itself, making this class in the testing framework useless. TYPO3 Core should not depend on this, but rather use native phpunit logic. Some other things are moved to the specific classes where they are needed, so setUp() will be much faster for other ViewHelper test classes. Resolves: #89793 Releases: master Change-Id: Ia2b2d9e3d4a7bd9a6eabd254259ff24ff3565e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62451 Tested-by:
-
Mathias Brodala authored
This ensures that the target of translated "shortcut" pages is properly available. Normally this value is lost due to language overlay thus the original page record needs to be retrieved to restore the original shortcut target. Now it is possible to e.g. mark shortcut menu items as active on translated pages. Resolves: #67047 Related: #36822 Releases: master, 9.5 Change-Id: I2cabc252ba1936763d6cbe1fe0a093aa74f5a4e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/39630 Tested-by:
-
Benjamin Franzke authored
Upgrade wizars may contain legacy code that requires services using makeInstance. As makeInstance needs to use the PSR-11 container for services that require dependency injection, we need to provide the global container intance during upgrade wizard execution. Also ensure that only *one* (singleton) PackageManager instance is used: ProviderConfigurationLoader used to create a second PackageManager instance. It passed a constructor argument which caused GU::makeInstance to bypass the symfony (PSR-11) container and to create a new instance (on its own). This new instance was then cached as singleton instance and all subsequent makeInstance calls returned this instance instead of the global instance. Therefore we now ensure that new singleton instances will not be cached if the singleton is known by the PSR-11 container. This inconsistency caused the Typo3DbExtractionUpdate to fail because some codepaths used one PackageManager instance (through DI) and some codepaths another instance (through makeInstance). Change-Id: I947310d1c2e46f7ded6399ad48d94efa9854f347 Releases: master Resolves: #89504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62425 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
This change allows to change to "Copy Mode" in the clipboard without having items on the clipboard. However, switching to a different clipboard will have this selection vanish again (before and after the change). Changing this behavior is considered out of scope for this patch. Resolves: #89726 Releases: master, 9.5 Change-Id: I83483c631915b390dfb0c9584c29f0f86a44d051 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62369 Tested-by:
-
- Nov 28, 2019
-
-
Susanne Moog authored
We can use vfs stream directly nowadays. Resolves: #89798 Releases: master Change-Id: Ie41eccb21dff70c6587bfd1380488697c4f6aca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62473 Tested-by:
-
