- Nov 16, 2021
-
-
Benni Mack authored
In recent TYPO3 v11.5.x versions, the error handling for Frontend pages did cache the external PSR-7 Response (by guzzle) in the pages cache. However, if the error page was fetched the second time, the Response object from the cache did not have a valid stream anymore, thus resulting in an array. This change now caches the body + headers for the page (still, only when a 200 response code was returned), and re-builds a clean Response object. Resolves: #95940 Related: #95586 Related: #94402 Releases: master Change-Id: I27aaffe8acda275fd3450f9479e19a3f21d22df6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72184 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Nov 15, 2021
-
-
Oliver Hader authored
Reduces amount of `requireJsModules` and `scriptCall` invocations in AJAX response handling and migrates to new `scriptItems` which is forwarded to JavaScriptHandler.js. Resolves: #95954 Releases: master Change-Id: I258da49fef46ccc36c602e0fd7c9a14ddb3cec1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72154 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Brings a patch for extension testing, so they don't inherit the composer flag for test instances anymore. composer req --dev typo3/testing-framework:^6.14.0 Change-Id: Ic0490cc888d08596cd7babfa7bd0247a885e29b9 Resolves: #95988 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72183 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
André Buchmann authored
In TYPO3 v8, new page translations within pages_language_overlay were visible by default when using plain DataHandler. In TYPO3 v9, due to the merge into "pages" for translations, the default value for "hidden" is used. Every new page translation was hidden by default - this was a different behavior. Issue #88248 changed this and restored the behaviour how it was in TYPO3 v8, this translated pages where always visible. This patch consider TCA configuration 'hideAtCopy' and TSconfig setting 'TCEMAIN.table.pages.disableHideAtCopy' options for page translations if source page is not already hidden. Further datahandler tests are added to cover these cases and prevent regressions on that. As the patch for #88248 already has been stating: For future TYPO3 major versions, the hidden field could be migrated into a 'allowLanguageSynchronization' once the Context API is used throughout Core properly. Resolves: #89622 Related: #88248 Releases: master Change-Id: Iff0488c559201fa51071cb6f364edec8e148a05a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71556 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
Resolves: #95987 Releases: master Change-Id: Icd868d64e0414fa295f1d03c7cbe102b388ff978 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72182 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Simon Gilli authored
Storing the package artifact in the var/build folder raised questions how this folder shall be treated in general and during deployment. Since the Package Artifact is built in a `composer install` process, it should be treated the same as other build artifacts like all files in the vendor folder. To make this more clear, the package artifact is now also stored in the vendor folder. Accessing the vendor folder during runtime is now possible with using Composer 2.1 runtime API, which is required anyway already. The path to the vendor folder is determined indirectly, by using the path to the typo3/cms-composer-installers package. This means, this package must not be replaced by another package with a different name. Since no public replacements for this package exist and there are no benefits for a private replacement of this package over having a private fork with the same package name, this should not be an impediment. To ease the required related changes in the testing framework, late static binding is used for calling SystemEnvironmentBuilder::usesComposerClassLoading Resolves: #95897 Releases: master Change-Id: I3cfc982c289b312d22f59d2704d7e7932efc8cc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72071 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nicole Cordes authored
The ConditionMatcher tries to resolve the current page id from global variables. One of this possibilities uses the cmdMap that is sent to the DataHandler. This patch ensures that the correct target uid is used to resolve the page id. Resolves: #95967 Releases: master, 10.4 Change-Id: I0fb7968c3118f2ab78c1cbb1dda3643e9f2f450e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72163 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Bootstrap 5 ships with "text-end" which is semantically more correct than "text-right". This change adapts the needed places in TYPO3 Core to use "text-end". Resolves: #95974 Releases: master Change-Id: I9c72b5004594ef46faba79e0ea78fe24025a93a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72172 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Christian Eßl authored
Previously, when creating a translated content element of type `shortcut`, the preview in the page module would always show the title of the reference from the original language. In case the referenced record has been translated as well, the preview now shows the translated title instead. Resolves: #92523 Releases: master Change-Id: I5dd5de3a63db916311ede94a07bb7fb3209795f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66090 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
empty() returns true if a record contains 0 as value. Therefore isset() needs to be used instead. The corresponding fix that was introduced with #91145 to workaround this flaw is removed again. Resolves: #95972 Related: #91145 Releases: master, 10.4 Change-Id: Idfea91b84d8391d680900966f57b406c28a616ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72170 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Stefan Bürk authored
The big win with this patch: All core now run tests with E_ALL error handling (unit, functional, acceptance). This means, they will also fail when PHP deprecations are raised. This improves PHP compatibility and makes sure new PHP versions can be integrated more quickly since we'll find deprecated PHP code calls early. Additionally, the acceptance tests are extended to run with PHP 8.1. As a result, the entire testing is now done with PHP 8.1 and green, we can claim PHP 8.1 compatibility for core now. Resolves: #95981 Releases: master Change-Id: I1eece6d2faec6453ada9731fc4064076dc8d5d97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72151 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Anja Leichsenring authored
To further separate concerns from ext:irre_tutorial, the configuration of JsonRenderer looses all parts that only concern the 1ncsv scenario. Ext:test_irre_csv receives a dedicated JsonRenderer, that is used by related test scenarios. Resolves: #95982 Releases: master Change-Id: Id83fbbd0133b56c6d1069b385298d6db56fd7142 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72180 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Resolves: #95973 Releases: master Change-Id: I6f0358cfdc38aff55ce8e0ef4343cd50104d93c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72171 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Achim Fritz <af@achimfritz.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Simon Gilli authored
This patch applies the current recommendations for BASH scripts see https://github.com/koalaman/shellcheck#readme. Resolves: #95964 Releases: master, 10.4 Change-Id: I21ba18cb151acc0ff8f33a2135ef289669d15bab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71981 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Brings especially a series of core v11 relevant PHP 8.1 bug fixes. composer req typo3fluid/fluid:^2.7.1 composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/core/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/adminpanel/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/fluid/ --no-update composer req typo3fluid/fluid:^2.7.1 -d typo3/sysext/redirects/ --no-update Resolves: #95980 Releases: master Change-Id: I5aae8fa275d80b2322bb526a8b6a1856194ec786 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72178 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Brings a series of core v11 relevant PHP 8.1 E_ALL preparations and a couple of minor details. composer req --dev typo3/testing-framework:^6.13.0 Change-Id: I140866e8fb7014efbc33b7c1f25b2f840bd19ce2 Resolves: #95979 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72176 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
If extension authors don't provide a type for their extension configuration options, they will now fall back to "string" and prevent later undefined array key access warnings. Resolves: #95977 Releases: master Change-Id: Icd77c4d130d2fc7d0b4f127dbeb2926c4057b81c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72175 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
There was a skipped unit test due to a PHP 8.1 bug. Latest rc6 fixed the issue, the test can be activated again. Resolves: #95976 Related: #95501 Releases: master Change-Id: Ib5cebf9edd544ca1aa3b91474c6032bf5721176e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72174 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
Used commands: > yarn add "bootstrap@^5.1.3" > yarn add "@popperjs/core" > grunt build Resolves: #95975 Releases: master Change-Id: Icacbf8d51c4e3345b9c549433c5ae28ba88848d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72173 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Anja Leichsenring authored
For easier testing, ext:irre_tutorial "csv" setup is extracted to a dedicated extension. Tests concerning these tables can now load the smaller test extension, which reduces system load and simplifies maintenance. Resolves: #95951 Releases: master Change-Id: Ib2040107929d795dd5b2606bff170a23435e541a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72165 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
During testing to activate E_ALL and PHP 8.1 testing with activated E_ALL, nightly 'composerMin' tests for PHP8.1 are failing with several E_DEPRECATED warnings, which was not discoverd in composerLock tests. Several composer packages, ex. 'symfony/finder' and 'symfony/routing', are required with different min versions than written in composer.lock file, thus downgrading these components which emits E_DEPRECATED PHP8.1 warnings in nightly composerMin tests execeuted with PHP 8.1. 'symfony/options-resolver' needs to be added directly, as this has been installed as dependency with different lower version constraints for 'friendsofphp/php-cs-fixer' and 'symfony/rate-limiter', thus we need to add it directly with the locked version as min requirement as there are no newer versions of these packages with needed min version as required version. 'bacon/bacon-qr-code' needs to be raised to avoid a float to int PHP8.1 conversion warning. This patch acts as pre-patch to activate E_ALL and PHP 8.1 testing and thus raise version of these components to the currently locked version in 'composer.lock' file, to be conservative. Used composer commands: composer req bacon/bacon-qr-code:^2.0.4 composer req bacon/bacon-qr-code:^2.0.4 \ -d typo3/sysext/core --no-update composer req masterminds/html5:^2.7.5 composer req masterminds/html5:^2.7.5 \ -d typo3/sysext/core --no-update composer req symfony/config:^5.3.4 composer req symfony/config:^5.3.4 \ -d typo3/sysext/core --no-update composer req symfony/console:^5.3.7 composer req symfony/console:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/console:^5.3.7 \ -d typo3/sysext/redirects --no-update composer req symfony/dependency-injection:^5.3.7 composer req symfony/dependency-injection:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/dependency-injection:^5.3.7 \ -d typo3/sysext/extbase --no-update composer req symfony/dependency-injection:^5.3.7 \ -d typo3/sysext/fluid --no-update composer req symfony/expression-language:^5.3.7 composer req symfony/expression-language:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/expression-language:^5.3.7 \ -d typo3/sysext/form --no-update composer req symfony/filesystem:^5.3.4 composer req symfony/filesystem:^5.3.4 \ -d typo3/sysext/core --no-update composer req symfony/finder:^5.3.7 composer req symfony/finder:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/finder:^5.3.7 \ -d typo3/sysext/install --no-update composer req symfony/http-foundation:^5.3.7 composer req symfony/http-foundation:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/http-foundation:^5.3.7 \ -d typo3/sysext/install --no-update composer req symfony/mailer:^5.3.4 composer req symfony/mailer:^5.3.4 \ -d typo3/sysext/core --no-update composer req symfony/mime:^5.3.7 composer req symfony/mime:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/polyfill-intl-normalizer:^1.23.0 composer req symfony/polyfill-intl-normalizer:^1.23.0 \ -d typo3/sysext/core --no-update composer req symfony/polyfill-intl-icu:^1.23.0 composer req symfony/polyfill-intl-icu:^1.23.0 \ -d typo3/sysext/core --no-update composer req symfony/polyfill-intl-idn:^1.23.0 composer req symfony/polyfill-intl-idn:^1.23.0 \ -d typo3/sysext/core --no-update composer req symfony/polyfill-mbstring:^1.23.1 composer req symfony/polyfill-mbstring:^1.23.1 \ -d typo3/sysext/core --no-update composer req symfony/polyfill-mbstring:^1.23.1 \ -d typo3/sysext/frontend --no-update composer req symfony/property-access:^5.3.7 composer req symfony/property-access:^5.3.7 \ -d typo3/sysext/extbase --no-update composer req symfony/property-info:^5.3.7 composer req symfony/property-info:^5.3.7 \ -d typo3/sysext/extbase --no-update composer req symfony/rate-limiter:^5.3.4 composer req symfony/rate-limiter:^5.3.4 \ -d typo3/sysext/core --no-update composer req symfony/routing:^5.3.7 composer req symfony/routing:^5.3.7 \ -d typo3/sysext/core --no-update composer req symfony/var-dumper:^5.3.7 composer req symfony/var-dumper:^5.3.7 \ -d typo3/sysext/adminpanel --no-update composer req symfony/yaml:^5.3.6 composer req symfony/yaml:^5.3.6 \ -d typo3/sysext/core --no-update Following are needed, but are new as direct requirements but locked: composer req symfony/options-resolver:^5.3.7 composer req symfony/options-resolver:^5.3.7 \ -d typo3/sysext/core --no-update Resolves: #95970 Releases: master Change-Id: I43441ff6ba260721026447c035d0f2a56902119b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72166 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Peter Kraume authored
Resolves: #95971 Releases: master Change-Id: I73f4d694d3a641c07c10b31c7e508f20836a955c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72169 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Christian Eßl authored
There were several problems with tooltips in the page tree: - htmlspecialchars was applied twice to the tooltip string. Once in BackendUtility::titleAttribForPages, once in TreeController. - When applying double or single quotes to a page title, the tooltips in the page tree would show these as html entities. Double and single quotes are now allowed, while any potential html tags in the title will be stripped from the tooltip. Any of those characters (", ', <, >) left in the tooltip are later escaped to unicode in the json view. Resolves: #91424 Releases: master Change-Id: I53b2ad6bbd4e4131535eb573422a8cbd5d002858 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64511 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Nov 13, 2021
-
-
Axel Seemann authored
If you use some mail relay servers for sending emails via SMTP, it is necessary to specify the domain name under which the emails are sent. This is especially important for the Gmail-Relay server smtp-relay.gmail.com but is not limited to this. Resolves: #93635 Releases: master Change-Id: If2fca7d02cc5c8017ae7eebcd616a165c4d9bb1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69652 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Nikita Hovratov authored
In #89871 (65dc0603) a fix was introduced, that forces the link generation to use the requested language of shortcuts instead of the current language of the frontend. In addition, another call to getPageOverlay was added. This is in fact not necessary, as overlaying is already done implicitly in getPageShortcut. This introduced a falsy behaviour, where shortcuts without the current language available would create a URL with the entry point of the fallback language. This can be fixed by simply using the request language from the original $menuItem variable before processing. Resolves: #94677 Related: #89871 Releases: master, 10.4 Change-Id: I5c9bd0439d821d5516a5cb58cdf53df6b63c3aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70836 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Nov 12, 2021
-
-
Nikita Hovratov authored
The added tests for #89871 do not prove the correctness of the patch. They go green, without the fix being applied. This is a blocker for another regression bugfix, which depends on these tests. The issue lied in the language menu, not the normal menu. For this, a new method createLanguageMenu has been added to AbstractLocalizedPagesTestCase.php. It is now used to assure the generated links always point to the target language and not to the current one. Resolves: #95966 Related: #89871 Related: #94677 Releases: master Change-Id: I20d202c2eae58597ee59312ef0896debb2f93d39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72162 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
doctrine/dbal driver for postgres has been feeding null to preg_match() in some constellations, which emits E_DEPRECATED warning in PHP8.1 with E_ALL. doctrine/dbal:2.13.5 includes the bugfix for this issue and more. This patch acts as pre-patch to activate E_ALL and more PHP81 testing and thus raise the min version to ^2.13.5 to avoid these warnings and make functional tests for postgres with E_ALL happy. Used composer commands: composer req doctrine/dbal:^2.13.5 composer req doctrine/dbal:^2.13.5 -d typo3/sysext/core --no-update composer req doctrine/dbal:^2.13.5 -d typo3/sysext/install --no-update composer req doctrine/dbal:^2.13.5 -d typo3/sysext/redirects --no-update Resolves: #95968 Releases: master Change-Id: Iba44ac6ccfcf7f7286d6d4e5843e25fefd0a607a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72161 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Simon Gilli authored
Change #95839 introduced a regression that causes TranslateViewHelper to fail when an invalid extension key is specified. This patch restores the previous behavior and avoids more regressions by a new test. Resolves: #95957 Releases: master Change-Id: I98675f94cf367b43f4123bb981f60c35286ace7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72158 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Nikita Hovratov authored
Resolves: #95960 Releases: master Change-Id: I5853d135ce20b1e9b53806a16fb734ab87c41b2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72159 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Nov 11, 2021
-
-
Gabe Troyan authored
Currently, the value of `USdateFormat` is disregarded because the corresponding property, `FormEngineValidation.USmode`, is set to zero regardless in `FormEngineValidation.initialize()`. This change will ensure that `USmode` will remain 1 without conflicting with core functionality that relies on `USmode` being set *before* `initialize()` is called. Resolves: #86679 Releases: master, 10.4 Related-to: #91105 Change-Id: I5584ca7fe92742e28147f9883fedf53e0556f1b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72034 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
With this change JavaScriptHandler.js is not only an immediately invoked function expression (IIFE) like before but is extended to be used as asynchronous module definition (AMD) as well. This way it can be used in internal TypeScript implementations as well. Resolves: #95953 Releases: master Change-Id: I7aa37ba707298eaa8ea151358c985a2e857cfb0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72153 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
When dealing with 3rd-party authentication services, which might return other values than arrays or without UIDs. This change fixes the relevant places. Resolves: #95958 Releases: master Change-Id: Idd50e3dceea079086a98225727ef7733a9b432c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72157 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Benni Mack authored
This reverts commit 48e4e495 as this has some side-effects with absolute paths. Change-Id: Ieb696908e5226d57eedeef7cb5fa8cd7b7ec4ea6 Reverts: #95379 Resolves: #95959 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72114 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benjamin Franzke authored
Fetch services from the DI container and perform post-creations checks instead of checking class_exists and therefore exclude possible service aliases defined in DI. Releases: master Resolves: #95855 Resolves: #92910 Change-Id: Ic85485edc7604a92bdf72d147ad47fe79954500e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72029 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Robert Kärner authored
Two undefined array key warnings are fixed, which occurred on PHP 8 when accessing the MagicImageService. Resolves: #95942 Releases: master Change-Id: Ifc7c64a7e14b600e88154c82ae575a1c23f9f87c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72138 Tested-by:
core-ci <typo3@b13.com> Tested-by:
physikbuddha <r.kaerner@oranto.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
physikbuddha <r.kaerner@oranto.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Hader authored
Introduces new `\TYPO3\CMS\Dashboard\Widgets\JavaScriptInterface`, based on explicit `\TYPO3\CMS\Core\Page\JavaScriptModuleInstruction` model - to reduce (and avoid) inline JavaScript in the TYPO3 backend. Resolves: #95873 Releases: master Change-Id: I92f0c9d37a16658cac10c6b0c98085b7b670c42f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72061 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Nov 10, 2021
-
-
Andreas Wolf authored
TCA config property 'localizeReferencesAtParentLocalization' for database relations is only handled with type=select having a 'foreign_table' defined. With the similar type=group, this is only handled if 'foreign_table' is set, which is odd since group is based on 'allowed' over 'foreign_table'. The change adapts DataHandler to consider 'allowed' with type=group tables and checks whether at least one of them is localizable. This solves an @todo from #94570 in the group DataHandling tests. The test set is completed by adding a similar set for type=select. Resolves: #41713 Related: #94570 Releases: master Change-Id: I33df58fd4c9bdf31e27f64532c371c74b3f52627 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72102 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
TableController was removed in #95036. The corresponding service registration is now removed, too. Resolves: #95955 Related: #95036 Releases: master Change-Id: I9e55be091fd911f8f4d3d99f72fd4a30af505390 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72156 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Imko Schumacher authored
Native time fields (dbtype) in the record list are now displayed independent from the server timezone. Resolves: #92962 Releases: master, 10.4 Change-Id: Ie9075378e67d0c302b126db78751992789fae29c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66953 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Anja Leichsenring authored
All functional tests in DataHandling category (both workspaces and core) used to load the ext:irre_tutorial test extension in the uppermost abstract class. Not all of the tests use it though, and even declare additional test extensions. In order to clean up and provide test cases only with data they need and use, as a first step each abstract class below the highest level abstract declare their test extensions individually. Resolves: #95950 Releases: master Change-Id: If7922f16def8a0bde1de034f224bcd2b838f0d8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72150 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-