- May 04, 2022
-
-
Oliver Bartsch authored
Namespaces in the extension scanner files must not contain a leading backslash. Resolves: #97547 Releases: main, 11.5 Change-Id: Idb608b3e02c8901972a068c531ee681e8b2dd49e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74511 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
The introduced LinkResult object and its functionality has had a fallback built via ArrayAccess for the LinkBuilderInterface to be compatible with array-ish LinkResult objects to access the previously returned array until TYPO3 v11 LTS. This change now removes the legacy layer, as TYPO3 only works with the LinkResult object directly everywhere. Resolves: #97546 Related: #96107 Related: #96317 Releases: main Change-Id: I733c85359b2f8b5886626a67fe106806f5405c7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74509 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org>
-
Chris Müller authored
Switchable controller actions are removed with TYPO3 12.0. The deprecation note is adjusted to reflect it. Resolves: #97523 Related: #89463 Related: #96282 Releases: main, 11.5, 10.4 Change-Id: Iad04bbb573f2b87ce87a8faabe25c97a8812f937 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74496 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Annett Jähnichen authored
The patch simplifies and optimizes the readability of the page module interface. It is based on the UX Team's concept of improving user experience for editors: https://typo3.org/article/structured-content-initiative-feedback-wanted Included changes: * refactored and optimised underlying CSS for future adaptions * visually simplified content element boxes and their header buttons * visually differenciated hidden content elements with better opacity and dotted border * placed the "new content element" buttons centered in preparation for further concept implementations in dedicated patches * added a new button for content element context menu in the content element header right button bar This patch was initiated by the UX Team and implemented by Benjamin Kott. Resolves: #97306 Resolves: #95247 Related: #94629 Releases: main Change-Id: I9b4e21a7fc68ebcb17d18f65bf00096f3a295cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74254 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
Annett Jähnichen <mcmietz@web.de>
-
- May 03, 2022
-
-
Benni Mack authored
When TSFE is fetching the $page record from PageRepository, it checks the $TSFE->id parameter, which was originally the GET parameter. In TYPO3 v9, when "pages_language_overlay" was merged into "pages", an intermediate step was added to access translated pages via the GET parameter as well. This concept however was never needed, as the page ID of the default language was always resolved with Site Handling already in the PageRouter. The double-check in TSFE can be removed, as site handling has taken over since TYPO3 v10, and was never accessed since its introduction in TYPO3 v9 (mainly because the code was added with the migration of "pages_language_overlay" into "pages" into TYPO3 v9.0, whereas site handling was only added in TYPO3 v9.2+). Resolves: #97533 Releases: main Change-Id: I290200f90b4d23589a4f7aec33a0516ecfab7739 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74500 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Hader authored
Calling a site using http://example.org/index.php/invalid/ leads to ~/index.php/whatever/ being used as internal script path, which causes errors or internal side-effects. This behavior seems to occur only on web-servers using Apache with PHP-CGI or PHP-FPM, using PHP setting `cgi.fix_pathinfo = 1`. In case `cgi.fix_pathinfo` is enabled, the current script name is retrieved from `$_SERVER['SCRIPT_FILENAME']` instead. Resolves: #97543 Releases: main, 11.5, 10.4 Change-Id: Ia5f6b705253d42d4fc409b90b21d0363c4b97974 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74504 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Hader authored
FileRepository::findByRelation does not apply any workspace context when invoked in backend context. Resolves: #59334 Releases: main, 11.5 Change-Id: I98f3f0640773c7d87879adb2b75cdb92a410bbc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74185 Tested-by:
André Kraus <info@andrekraus.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
André Kraus <info@andrekraus.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
The option searchSkipExtendToSubpagesChecking in Indexed search is removed in favor of using a better functionality of getTreeList() which has been implemented in TYPO3 Core, considering "extendToSubpages" at any times. Resolves: #97530 Releases: main Change-Id: Iabe82f2846aaa6d586ef30c0128e957b24531562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74377 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
Various methods can now use the Context API, making the dependency to TSFE less relevant for future changes. Resolves: #97531 Releases: main Change-Id: I3daaddd9684e36a5bf58343cd1fdc43d29713a3a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73910 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- May 02, 2022
-
-
Simon Schaufelberger authored
The method parseDataStructureByIdentifier defines that files can also be loaded with the "EXT:" prefix. This is currently not supported and not documented, thus should be removed. The only valid syntax is with "FILE:EXT:" Resolves: #92483 Releases: main, 11.5 Change-Id: I5156c40215753566251c56ca0cbd9b94b66ce4a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74441 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
rowCount() on result sets for SELECT queries are not reliable across all DBMS, which doctrine/dbal comments in the docblock. See: https://github.com/doctrine/dbal/blob/110ab13/src/Driver/Result.php#L77 Because of "rowCount()"'s unreliable behaviour for some dbms like sqlite, this should be avoided to ensure cross dbms support. '\TYPO3\CMS\IndexedSearch\Domain\Repository\IndexSearchRepository' uses 'rowCount()' in 'doSearch()' which fails on sqlite, making it impossible to get any result in the frontend search. Doing a count() query as replacement is not possible and needs a bigger architectural change, which is not feasable as bugfix. Thus fallback to retrieve the result into an array and counting the array is used as a intermediate solution to ensure index_search is working across all supported database systems. The architectural change will be done in a dedicated patch. Resolves: #97460 Releases: main, 11.5 Change-Id: Id7afa9f95fefbba07acb7c0dda1267dd2fce92db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74380 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Apr 29, 2022
-
-
11nd11 authored
Streamline the first step of the duplicate-form-wizard to the new layout of new-form-wizard. Resolves: #97506 Releases: main Change-Id: I31482b6cf8c188ece8821aa3a4b2e1cf0da4fe09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74480 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Tobias Siegler authored
If a field contains a label that is too long, this creates an ugly line break in the form element header. And also the label of the field is displayed redundantly below the header. So we output the field type instead of the label. Resolves: #97488 Releases: main Change-Id: Ia33b0b41697ecf4cb43bad51069596322fa4a704 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74489 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Andreas Steiger <typo3@andreassteiger.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Stefan Bürk authored
Core requirements have been changed and publicly announced with: https://typo3.org/article/new-system-requirements-for-upcoming-typo3-v12 This patch removes supportive code for MSSQL due dropped support for this dbmns. MSSQL specific report and status checks are removed with #97411. Resolves: #97462 Related: #96553 Related: #97411 Releases: main Change-Id: I131805157b7780a4de6d0f3ab8e9d0d6883b7872 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74382 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Gabe Troyan authored
This patch adds a new field called "fragment" to the EXT:form Redirect finisher. It will be appended to the redirect URL (e.g. #c127). The fragment can be either a content element identifier or a custom fragment such as `foo`. Resolves: #83912 Releases: main Change-Id: I724e378894782215cc7db21160daef930d0cfdb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73721 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Tobias Siegler authored
Adds a label to the delete button and improves the styling. Exceptions are the delete buttons in the validators and in the form finishers. As part of an upcoming patch the finishers will be expanded and the styling of the delete buttons will be adapted to the layout. Resolves: #97487 Releases: main Change-Id: I3d068cc883c7b74c3ceed1ab7a1d205ea795c53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74472 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Andreas Steiger <typo3@andreassteiger.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Elias Häußler authored
Form elements in the tree component are labelled with the label of the corresponding form element definition, whereas the stage component uses the form element's type. This has now been streamlined to always use the label of the form element definition, since editors might not be interested in (internal) types anyway. Resolves: #97507 Releases: main, 11.5 Change-Id: Ife4c52207957db3cfd1cfa1818ccc9628e36b91c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74487 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
11ND11 authored
Change browser default checkboxes to TYPO3 toggle buttons or TYPO3 checkboxes in the form editor. Resolves: #95086 Releases: main Change-Id: I94fe1c3930a640fdf180f239d2c9a60b38b2f3ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73720 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Torben Hansen authored
symfony/rate-limiter:5.4.8 has been released, so the failing tests commented out with #97298 can be included again. Raised symfony/rate-limiter:^5.4.8 to ensure that broken version is not used. Used commands: > composer req "symfony/rate-limiter":"^5.4.8" > composer req "symfony/rate-limiter":"^5.4.8" \ -d typo3/sysext/core --no-update Resolves: #97494 Related: #97298 Releases: main, 11.5 Change-Id: Idaa17f130a56f3e23c56243f24ecdccc14ac4b46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74451 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
Björn Jacob authored
The whole documentation about finishers has not been touched since ages. A lot of information are outdated. This patch fixes the mess. Also improve a language label to clarify the usage of the title field within the finishers "EmailToReceiver" and "EmailToSender". Resolves: #96048 Releases: main, 11.5 Change-Id: I3004194c37203993582e7f4687523ad766d3235d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74474 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Oliver Klee authored
Resolves: #97424 Releases: main, 11.5 Change-Id: I9ccac96427c71f65e1922fe7e6ffb376d06d7e02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74348 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Georg Ringer authored
Reports and Status of the reports module are now automatically tagged and registered, based on the implemented `ReportInterface` and `StatusProviderInterface`. The previous registration via `$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']` has been removed. Additionally, to be able to use autoconfiguration, the interfaces have been extended by additional methods. Resolves: #97320 Releases: main Change-Id: I5f640471bad8125267d1537bab3ab6b5a02baf7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74201 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Apr 28, 2022
-
-
Tymoteusz Motylewski authored
The new version finds some new possible bugs. Used commands: > composer require --dev phpstan/phpstan:^1.6.3 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97508 Releases: main, 11.5 Change-Id: I7a813c4f12258aad96b99cec3feb93ee10d55bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74481 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Elias Häußler <e.haeussler@familie-redlich.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Larry Garfield authored
Coding style guidelines say to favor single quotes unless we actually want YAML interpolation. This is a partner change with: https://github.com/TYPO3-Documentation/TYPO3CMS-Reference-CoreApi/pull/1813 Resolves: #86896 Releases: main Change-Id: I9c2596e2d1d9c551920a446fbbd95562fed93aeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74326 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Elias Häußler authored
Various form configuration was deprecated with #96568. This patch adds a notice about planned removal of those deprecations to the deprecation message. Resolves: #97497 Related: #96568 Releases: main Change-Id: I3e7f16c6bd1eafa1f7db8b23c8fc5cfc89d004c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74479 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Tobias Siegler authored
The markup of the field definitions has been optimized and aligned with the standard styling (e.g. in the page properties). Available info texts have also been adjusted. Resolves: #95087 Releases: main Change-Id: I83edbfde382bd03e56fa6c475137e5ee1ed088be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73695 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Elias Häußler <e.haeussler@familie-redlich.de> Reviewed-by:
Andreas Steiger <typo3@andreassteiger.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Stephan Großberndt authored
Releases: master, 11.5 Resolves: #97504 Change-Id: I26ff53cc81eefa550e86928a6db6fd6a982a6008 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74476 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Elias Häußler authored
Feature RSTs should not provide a tag for the extension scanner. However, a "NotScanned" tag was added to the RST file of #90919. This is now removed. Resolves: #97502 Related: #90919 Releases: main Change-Id: I293c5322c8c6fc53da5c11713b3b7419fb10b449 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74475 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Georg Ringer authored
The inclusion of 'include_static.txt' files within the TypoScript inclusion magic has been part of the extension 'statictemplates' back in the old days: It brought a database field 'include_static' together with a hook in TemplateService that took care of that field content. It then indirectly also handled these 'include_static.txt' file inclusions. Extension 'statictemplates' has been removed from core with TYPO3 6.2. Since then, 'include_static.txt' files had no effect anymore. The patch removes the dead code artifact from TemplateService and adapts some documentation accordingly. Resolves: #97501 Related: #46469 Releases: main Change-Id: I07bb118bc405c97da6810eca0061ab6968564fc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74434 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <bfr@qbus.de>
-
Larry Garfield authored
The "page" and "pages" translation keys are backwards. This patch makes them forwards. Resolves: #96795 Releases: main, 11.5 Change-Id: I3dde22d5a6f9ae7c62fe8c60156d6131f676a11c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74369 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Elias Häußler authored
If form finisher options are overridden via FlexForm, they must not be translated by the TranslationService. Otherwise, they would probably be overridden again by a localization from a translation file. A new translation option "propertiesExcludedFromTranslation" has been introduced to achieve this, skipping all those finisher options whose option value has been changed by a FlexForm. The translation option is only respected in `TranslationService::translateFinisherOption()`. Resolves: #90919 Releases: main Change-Id: Ia7ba11504f8634a8220cdbfe52c5b02140656765 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73683 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Stefan Bürk authored
sqlite basicly knows about two kind of autoincrement column definition. One which is an alias on the provided "row_id" field for an integer field which is also the single field of the primary key index. And the second one with a real autoincrement notation, which is not an alias like the first one. Basicly this differes in some behaviours, mainly that the second one will never reassign ids which has been deleted. The first one will eventually reassign deleted ids to fill up spaces in between. This counts for inserts where the column data has a null value. If a real value is provided, this will be used. "ext:indexed_search" defines some tables with integer columns which are the primary key, which are not flagged as autoincrement fields. This is not needed as the inserted data always uses pre calculated hash values. This works pretty fine on most dbms. sqlite automatically assumes the autoincrement field (row_id) alias type for creation, which works so far pretty well. doctrine/dbal uses 'PRAGMA table_info(<table-name>)' to read the table structure, which do not containts the information if the field is created with the AUTOINCREMENT keyword or not. Reading the table struncture from a sqlite database sets the "autoincrement: true" value for colums of type integer, if they are the only included column of an primary key. On the other side, reading/building the meta schema based on the TYPO3 "ext_tables.sql" files of extensions and using the default table definition building based on TCA, the column will get "autoincrement: false" if the auto_increment keyword is not used. This will popup these tables again and again, as it always will detect the column as changed, because of the not matching column autoincrement value. This patch adopts this assumptions from doctrine/dbal and set the autoincrement to true, if a table has one primary key colum of type integer without a autoincremet flag. This will create the real autoincrement column instead, which is a safer variant for it. doctrine/dbal added this detection based on these assumptions with: https://github.com/doctrine/dbal/commit/33555d36e7e7d07a5880e01 Resolves: #97447 Releases: main, 11.5 Change-Id: I410da0db7a8f0748e5a8ee099cd36ee121cafa60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74362 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
- Apr 27, 2022
-
-
Stefan Bürk authored
Recently from time to time phpstan ci runs are failing with following error message: > Reached internal errors count limit of 50, exiting... > Internal error: Child process timed out after 600.0 seconds. > Try making it longer with parallel.processTimeout setting. As a intermediate solution this timeout should be increased. Deeper investigation and maybe finding a solution to avoid such long subprocess run times is the more reasonable way - but to avoid a lot of test failes, better trade a longer runtime in ci than a linger time to find a proper fix for it as a first solution. Resolves: #97490 Releases: main, 11.5 Change-Id: I8f5a23f233024090de32ce4b3272d3800fc0c2ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74447 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Elias Häußler <e.haeussler@familie-redlich.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Stefan Bürk authored
composer v2 is no longer an experimental feature of Docker Desktop for MacOS/Windows. Broken composer v2 error message should be updated to give proper actual information how to disable it correctly. Resolves: #97489 Releases: main, 11.5, 10.4 Change-Id: I7c4199e5d3d3c47bbadba8210cc96b0385ab6fcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74448 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Elias Häußler authored
With #90385, two methods (`setDefaultValue()` and `setProperty()`) were added to AbstractRenderable. Those methods however only relate to form elements and the corresponding FormElementInterface and are not part of the RenderableInterface. All form elements already provide appropriate implementations. In order to separate methods of form elements from methods of generic renderables, the change #90385 has been reverted. Additionally, the implementation logic to call those methods has been separated from AbstractRenderable and re-implemented in the appropriate form elements, namely AbstractFormElement and Section. This is not considered breaking, because all logic is re-implemented in relevant and affected classes. Furthermore, it's not sufficient to provide and implement defaultValue and properties for renderables that do not represent a form element. Resolves: #90400 Related: #90385 Releases: main Change-Id: Id258233337c0e648a1459e537460cd02f96e7f29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74443 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Oliver Bartsch authored
When uploading new assets to the filelist, the metadata (e.g. width and height) are automatically extracted from the corresponding files. This does not work for online media files, e.g. a YouTube video. Therefore, the corresponding services' oembed API is used to retrieve the related metadata. YouTube however changed their oembed API recently to always set a width of "200" and a height of "113" by default. This is obviously far too small for any use case. Since YouTube is following the oembed specification (https://oembed.com/#section2.2), it's possible to provide the "maxwidth" and "maxheight" parameters to the oembed URL. This way YouTube returns meaningful values for width and height. Actually a similar change was already done to the Vimeo integration in #85176. Vimeo however supports the custom "width" parameter, which is not mentioned in the specification and also not supported by YouTube. Resolves: #97481 Related: #85176 Releases: main, 11.5, 10.4 Change-Id: If902cf17b12fc510592a48828d8304fad42e2bfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74439 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Elias Häußler authored
Each form definition loaded by FormPersistenceManager can be overridden by TypoScript. When forms are to be rendered by using the FormFrontend controller (which should be the default way), TypoScript overrides are applied correctly. In contrast, when using alternative ways of rendering, it's currently impossible to override form definitions via TypoScript. In order to streamline the form definition management and therefore allow a centralized way of TypoScript overriding, the appropriate code has been moved from the FormFrontend controller to FormPersistenceManager. This way every rendering mechanism can now make use of the FormPersistenceManager and expect a streamlined form definition. Resolves: #92408 Releases: main Change-Id: Ib5c132bcef2356c6d66d617f817654c2f6d0e440 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73678 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev>
-
Elias Häußler authored
Adding a new validator to a form element in form editor led to an error if the validator defines additionalElementPropertyPaths. This happened because the initial value of those property paths was not applied to the form element when the validator was added. Therefore, it was not possible to unset those values as they did not exist unless their initial value has changed. With this patch applied, the initial value of validator options is now passed to all properties of additionalElementPropertyPaths as well. Resolves: #97040 Releases: main, 11.5 Change-Id: Ife242a48276789fcad6a47679478b68d79e78e6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74444 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de>
-
Elias Häußler authored
In the form editor, backend users can currently insert any non-empty strings for patterns of regular expression validators. This can lead to situations where invalid pattern are inserted without getting immediate feedback. Rather, this generates an error to the user when rendering the form in the frontend. To avoid those situations, backend users will now get an immediate visual feedback if the inserted regex pattern is not valid. The underlying check is rather basic and does not support all features of PHP PCRE regular expressions. Since the RegularExpressionValidator will be removed from the UI in v13, the improvement is suitable in respect of the removal (see #97016). However, this is still a small progress in this area. Resolves: #90640 Releases: main Change-Id: Ifc4a8f63dcb870bb26bb1ef81218c49766ee6731 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73692 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Tobias Jungmann <tobias.jungmann@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Tobias Jungmann <tobias.jungmann@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev>
-
Larry Garfield authored
The object return on dispatch() is not a formal part of the interface for BC reasons, but is required by the spec, so thanks to LSP it's safe to add this way, and recommended. Resolves: #97484 Releases: main Change-Id: I01037753a0cc0cdb87c42900958edb2c1438233f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74440 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-