Skip to content
Snippets Groups Projects
Commit 49eea1d3 authored by Elias Häußler's avatar Elias Häußler Committed by waldhacker
Browse files

[TASK] Move form element-related methods out of AbstractRenderable

With #90385, two methods (`setDefaultValue()` and `setProperty()`) were
added to AbstractRenderable. Those methods however only relate to form
elements and the corresponding FormElementInterface and are not part of
the RenderableInterface. All form elements already provide appropriate
implementations.

In order to separate methods of form elements from methods of generic
renderables, the change #90385 has been reverted. Additionally, the
implementation logic to call those methods has been separated from
AbstractRenderable and re-implemented in the appropriate form elements,
namely AbstractFormElement and Section.

This is not considered breaking, because all logic is re-implemented in
relevant and affected classes. Furthermore, it's not sufficient to
provide and implement defaultValue and properties for renderables that
do not represent a form element.

Resolves: #90400
Related: #90385
Releases: main
Change-Id: Id258233337c0e648a1459e537460cd02f96e7f29
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74443


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarBjörn Jacob <bjoern.jacob@tritum.de>
Tested-by: default avatarwaldhacker <hello@waldhacker.dev>
Reviewed-by: default avatarBjörn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: default avatarwaldhacker <hello@waldhacker.dev>
parent 570dd743
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment