- Apr 08, 2022
-
-
Benjamin Franzke authored
This reverts commit a42649bd. Reasons for revert: * Missing commit message description: It deserves a description of the global scope/direction and a reference to the preparation by the UX initiative * The change was merged too quickly Resolves: #97319 Reverts: #97306 Releases: main Change-Id: I51eceefa913e13d169cafd69e9e04d08a77d1443 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74200 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Lidia Demin <typecat@gmx.net> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Franzke authored
All pagetree actions that use the "RecordCommit" endpoint (tce_db) (which is loaded in to the main list_frame) need to avoid requesting an explicit and too early page tree update from the server, as the page data may not have been updated at that point. The pagetree refresh actually is and needs to be triggered by an immediate action pushed by the RecordCommit endpoint. (in the list frame via <typo3-immediate-action> element) An early-refresh call – prior to the persistence of the record action – causes stale data to be fetched and displayed when that request ends up to be processed after the record commit request (that is the "race" that causes this to only happen sometimes). Example: Page icon sometimes doesn't change on deactivation. Affected page tree actions are: * disable/enable page * hide/show in menu * past into/after Note that these actions should ideally be migrated to AjaxDataHandler. Once that's done, the pagetree refresh can be added back. Resolves: #94393 Resolves: #95499 Releases: main, 11.5 Change-Id: I4e4059da78cf5b5bfebc5d67aacc89332a67d750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74224 Tested-by:
-
Susanne Moog authored
Thanks to backend routing, we are now able to provide a direct link to the currently rendered backend page via the admin panel. Releases: main Resolves: #97326 Change-Id: Ibfabcf56139cdfefdd4e8a8bc315d9622c00f939 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74212 Tested-by:
-
Georg Ringer authored
Check if the fileTarget is set before using it. Resolves: #97329 Releases: main, 11.5 Change-Id: Ibf5bf12600717acf1b705773655bf2d35c352502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74218 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
- 'eval=int' does not exist for type=group - Empty 'eval' is superfluous Resolves: #97335 Releases: main, 11.5 Change-Id: Id12c15fcc6465def1836ff6c5c435c8be75ac4ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74225 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Apr 07, 2022
-
-
Benjamin Franzke authored
The pagetree contextmenu click (right click) on node backgrounds must not trigger both, the system contextmenu and the TYPO3 context menu. This has already been done for node-texts, but the default event prevention was missing for node backgrounds. Therefore the native contextmenu is now also prevented whenever the custom context menu is triggered. Resolves: #97331 Releases: main, 11.5 Change-Id: I9a0ffcd6eb843fc2f13fa0da47480df2e99fdbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74220 Tested-by:
-
Oliver Bartsch authored
The SiteConfigurationController does its own evaluation of field values based on the "fake" TCA. With #97035, the required flag was added, which replaces the corresponding "eval" option. This patch adjusts the SiteConfigurationController to handle the new option accordingly. Resolves: #97332 Related: #97035 Releases: main Change-Id: I3d828f6318fc70b260d20d727bfc45cc60ec1164 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74221 Tested-by:
-
Oliver Bartsch authored
This migration was forgotten while introducing TCA type "number" in #97193. Resolves: #97333 Related: #97193 Releases: main Change-Id: I98a468a6938978969e79656cb3458f24faea90c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74222 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Fernandez authored
The clipboard component uses a Bootstrap panel and is also wrapped by row/col elements, whose are superfluous. This patch removes the superfluous divs. Resolves: #97328 Releases: main, 11.5 Change-Id: Ic7c93592b5c8c2dc3315014bc8484af8c10b0aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74216 Tested-by:
-
Oliver Bartsch authored
Modules can use static strings instead of locallang labels. Therefore, all usages must also define the value as "default" to prevent a RuntimeException. This is now fixed in the About module. Resolves: #97325 Releases: main Change-Id: Ie6c4ac0ce973c5647e588c778929b10896eec100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74213 Tested-by:
-
linawolf authored
Follow up on files not changed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/74128 Releases: main Resolves: #97327 Related: #97258 Change-Id: Ie2b8536c180847928a67e20e23eaf46f48af4022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74215 Tested-by:
-
Andreas Fernandez authored
The determination of the duration used in Notification.showMessage() now takes `SeverityEnum.error` into account and sets the duration to 0, which is the same behavior when using `Notification.error()`. Resolves: #97315 Releases: main, 11.5 Change-Id: I1d6f50cc81c8a92031a570eae4e0bffc2b5441a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74195 Tested-by:
-
Oliver Bartsch authored
Resolves: #97322 Releases: main Change-Id: I0565905201bd7456dae171d2435925c996bfb1b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74204 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Helmut Hummel authored
Adding a replace to a package semantically means, that this package replaces another one. This is not true for typo3/cms-core and therefore the replacement should not be declared. Additionally, composer fails when more than one dependency declare identical replaces. We thus can not declare them in typo3/cms-core since it would conflict as soon as any other dependency does that, too. It is fine for typo3/cms as this only serves as base for a bundled build for non Composer installations and for development. As such, the replacements are kept in monorepo root composer.json. Resolves: #97295 Related: #96980 Releases: main Change-Id: I7a65182975457d71f611bf102c2842c6972e4eba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74169 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Alexander Nitsche authored
- align README.rst, Index.rst, Includes.txt, Includes.rst.txt, Settings.cfg - add genindex.rst, Sitemap.rst - remove outdated Targets.rst - rename Includes.txt to Includes.rst.txt - reference manual's start page with :doc:`<manual>:Index` Adding the custom label `start` to the beginning of the manual's Index.rst is redundant. Use :doc:`<manual>:Index` instead of :ref:`<manual:start>` to refer to it. - replace :ts: with :typoscript: text role The ambiguous :ts: text role has been removed to not confuse the writer with typescript and typoscript. - fix rendering warnings of EXT:core - fix rendering warnings of EXT:dashboard - fix rendering warnings of EXT:fluid_styled_content - fix rendering warnings of EXT:form - fix rendering warnings of EXT:linkvalidator - remove outdated encoding note - align reST validator at Build/Scripts/validateRstFiles.php See https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/GeneralConventions/FileStructure.html for further details. Resolves: #97258 Releases: main, 11.5, 10.4 Change-Id: I791c905d294a1eb71bd30ff2260f68be2b22f41e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74128 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Michael Telgkamp authored
The context sensitive help (CSH) is not accessible and the information is often not useful or not updated for a long time. As the online documentation is now improved a lot, there is a link added in the main help menu. For short, but important additional information to explain the usage of a field the `description` field should be used. Resolves: #97312 Releases: main Change-Id: Ic0b7df90ef88c53f802bfb254023ba030ff01ee7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74191 Tested-by:
-
Georg Ringer authored
Extend BackendUtility::getDropdownMenu() for the possibility to add the "id" of the select element. This allows to connect a corresponding label, improving accessibility. This is done for the info and template module. Resolves: #97318 Releases: main Change-Id: I766e55b14e58f164c06d21f4490a22a33393b6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74199 Tested-by:
-
- Apr 06, 2022
-
-
Nikita Hovratov authored
Resolves: #97321 Releases: main Change-Id: Ifbbd0e4961ed2c17beebadb0d2eb732fdd05f6a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74202 Tested-by:
-
Torben Hansen authored
When nullable columns are shown in filelist module, an exception is thrown, because null may be passed to htmlspecialchars(). This change ensures that an empty string is passed to htmlspecialchars(), if the column value is null. Also the last parameter from the getProcessedValueExtra() function call is removed, since it equals the functions default value for the $forceResult parameter. Resolves: #97316 Releases: main, 11.5 Change-Id: I7d82aea0ed073f6f30944d53e0803ce848e30e53 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74198 Tested-by:
-
Andreas Fernandez authored
The contents of a field of type `flex` may be NULL if the field is empty. `BackendUtility::getProcessedValue()` handles the content of such `flex` fields now only if the value is an actual string to solve deprecations related to PHP 8.1. In the same run, the content is trimmed to get rid of lots of empty lines caused by multiline XML data. Resolves: #97297 Releases: main Change-Id: I4261d16bfa819fd1151bbe6905b97f2571701fee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74174 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Shehfinaz Kadavil authored
This makes the ExtensionUtility:registerPlugin() method return the plugin signature, which might be used for further TCA adjustments, e.g. definition of FlexForms. Resolves: #82809 Releases: main Change-Id: Ia88f0b798affe6e47b4c5a4f850022e6ace18169 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74175 Tested-by:
-
Stefan Bürk authored
The check for doing the functional test splitting script and running the selected chunk used similar but different minimum chunk value to check against. Thus the splitting script has not been executed in all chunk execution contexts. This patch uses now exactly the same check in the 'Build/Scripts/runTests.sh' like it is defined in the corresponding docker-compose service config. Furthermore all previous created functional split files are now removed to avoid leftovers, which occured if re-run has lower chunksize defined. Example which is now properly fixed: > Build/Scripts/runTests.sh -s functional -c 1/1 Example with partial part files from previous run: > Build/Scripts/runTests.sh -s functional -c 1/10 > Build/Scripts/runTests.sh -s functional -c 1/8 Resolves: #97283 Releases: main, 11.5, 10.4 Change-Id: Id3a0d1c85540b4e7e46aaea69cf2d96839e8e72e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74157 Tested-by:
-
Oliver Bartsch authored
used command: > composer u typo3/cms-styleguide Resolves: #97314 Releases: main Change-Id: Id5fe8f81e88348c3000953d5857cc40816f47482 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74190 Tested-by: -
Benjamin Kott authored
Releases: main Resolves: #97310 Change-Id: I8d85aa779fa82c8c8307f6e3187e1dcc701de7d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74187 Tested-by:
-
- Apr 05, 2022
-
-
Nikita Hovratov authored
Resolves: #97311 Releases: main Change-Id: I9edda1c4ff1c28d98187e0f954a1229a46e8463b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74188 Tested-by:
-
Uwe Trotzek authored
With this new option an editor is able to view all records on a page regardless of the start and end time. This is especially helpful if one has content on a page with different start and end times and an editor wants to have an overview of all elements on that page. For example if he wants to check if the layout and everything is okay. Without this option the editor has to simulate multiple dates to be able to see all records, because records which are visible on one date, can be invisible on another. Resolves: #91082 Releases: main Change-Id: If4bd4103615f17a17fac8cb003e439bee65301da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64208 Tested-by:
-
Oliver Bartsch authored
A couple of new TCA types have been introduced. To be able to merge duplicated code parts together, slight discrepancies are resolved first. This also includes the now cleaned up InputTextElement. Resolves: #97304 Releases: main Change-Id: I07657c63f7a0e96d7793cab951148b7319d089b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74184 Tested-by:
-
Benjamin Kott authored
Resolves: #97306 Releases: main Change-Id: I54c6e90bf8b63e7d24fd25d62332f97a79bbe0ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74182 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
André Kraus <info@andrekraus.com> Tested-by:
-
Nikita Hovratov authored
The new type "number" is a replacement for type "input" with "eval=int" or "eval=double2" set. With this, the type "input" field is now always a html "text" field and type "number" is always a html "number" field. With the new TCA option "format", a number type can be defined. Values can be either "integer" (default) or "decimal". The decimal format replaces the former "double2" eval value. In the future, a new option for precision might be added, in order to dynamically define how many decimal places should be possible. The valueSlider has been moved from InputTextElement to NumberElement, as it makes only sense with a type number field. Additionally, the JS module is migrated to a custom element. Note: There is still the eval="num" option for type "input" fields. This is solely for the purpose to ensure only numeric characters are used. Therefore, this option does not qualify anymore for the "range" option. The "range" option is now removed altogether for simple type "input" fields, as it now purely handles text values. Resolves: #97193 Releases: main Change-Id: Ia0888699f2c518917412e700e2681d9fea727340 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74067 Tested-by:
-
Andreas Fernandez authored
Textarea can be configured in TCA to be read only and to have a richtext editor enabled. If `readOnly` is enabled, ckeditor is now rendered in a read-only mode instead of rendering a plain textarea containing HTML markup. Resolves: #97296 Releases: main, 11.5 Change-Id: I9e457123811ef53ad4e3e355a68e3f1e5701dcfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74180 Tested-by:
-
Andreas Fernandez authored
`RenderPreviewImportPageAndRecordsByUpdateWithDiff.php` has HTML markup with line breaks and tab characters. With some IDEs this may break if lines containing a tab only will get trimmed. All such characters are now replaced by explicit control characters to make sure the expectation does not break anymore when saving this file. Resolves: #97300 Releases: main, 11.5 Change-Id: Ifc5d7e39d6d69176b111d3361f741a89866f008b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74177 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Simon Gilli authored
This patch applies the new documentation standards to the .editorconfig. Resolves: #97302 Releases: main, 11.5, 10.4 Change-Id: I798b355f71dfa7ba8ac20ad424105e99a5c870cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74179 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Reviewed-by:
-
Benjamin Kott authored
The "label" class was removed in bootstrap 5 and replaced through "badge". The "label" class was kept in place for a while to keep the compatibility as high as possible, but it's time to move on. Since bootstrap 5 also dropped support for severities on certain components, we are adding them again for the badge to keep the convenience as high as possible and avoid promoting the "utility css" approach that was introduced with these decisions as we try to keep markup changes as low as possible. This patch also reverts the SCSS includes back to relative paths. While it is possible to define additional lookup paths for the parser, so you can have shorter includes - it comes at a cost. The included sources are opaque to the user and the IDE, this means there is no support for auto-completion, quick navigation through included files and can lead to unintended overrides by the user. Resolves: #97291 Releases: main Change-Id: I9007af705a90db567353379146df1d76b2366a62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74163 Tested-by:
-
Benjamin Franzke authored
The global variable $ (window.$) has been removed with #97243. This caused the RTE link wizard to fail with a JavaScript error as $.isEmptyObject is used in typo3link.js. Resolves: #97301 Related: #97243 Releases: main Change-Id: Iaafb02fa52039f8443289c4b16123e67c25b39ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74178 Tested-by:
-
Oliver Bartsch authored
The creation and modification time of files is now displayed correctly again, using the file info instead of the file metadata values. Especially when sorting by those fields, this previously led to discrepancies since the driver (performing the sorting) always uses the file info. See related patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74158 Additionally, non-admins are now also able to select the creation and modification time "fields" in the column selector. Resolves: #97290 Releases: main, 11.5 Change-Id: Ie9b4b7dccce68efeaac20998af4eeca204710f3f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74161 Tested-by:
-
- Apr 04, 2022
-
-
Christian Kuhn authored
symfony/rate-limiter:5.4.7 has a bug [1] leading to E_DEPRECATED warnings in our functional rate limiting tests. This is mostly test related so it does not make much sense to set this version as conflict. We'll comment two tests while waiting for a patch level release 5.4.8. [1] https://github.com/symfony/symfony/issues/45924 Releases: main, 11.5 Resolves: #97298 Change-Id: Ifb80a631830bb7b50fdc7c9d58d28e0dbf208ad1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74170 Tested-by:
-
Nikita Hovratov authored
After the removal of the fourth parameter of the checkAuthMode method, the local variable $authMode has not been removed, too. In addition, the @todo is removed, as it is resolved now. Resolves: #97294 Related: #97265 Releases: main Change-Id: I0712927a8d414e9d16b4ac89f505fa7da7c81494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74168 Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #97293 Change-Id: I0f5f44fab866e54e117138d369584967da7c3655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74167 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Larry Garfield authored
Simple type additions. Nothing exciting. Resolves: #97205 Related: #97210 Releases: main Change-Id: Ic38274300b22f3ce9168e98c13239934c624069a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73987 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Georg Ringer authored
Implement missing sorting of files in the local driver. Resolves: #97261 Releases: main, 11.5 Change-Id: I94c04dfbd88b0f010c57ec68395f9edbc64c77c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74158 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
