- May 20, 2024
-
-
Torben Hansen authored
This change removes a superfluous typecast in `TypoScriptFrontendController`. Additionally, the function's doc comment has been revised and the `@param` comment has been removed, since the function parameter is self-explaining. Resolves: #103859 Releases: main Change-Id: I66bdfbbaf0854bff25a801849b253a607cc122b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84313 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev>
-
- May 18, 2024
-
-
Benni Mack authored
With TYPO3 v13.0 the new BeforePageIsRetrievedEvent was added, and the previous hook was removed. This way, it is not possible to manipulate $disableGroupAccessCheck anymore. This change re-adds the possibility to modify this flag in an EventListener. Resolves: #103855 Related: #102806 Releases: main Change-Id: Ic5fbd6c6932b7da5f01592126f1c406d4084103b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84291 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
When migrating to TYPO3 v13, the navigation component for rendering the page tree has been renamed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/81411 In TYPO3 v12: - "@typo3/backend/page-tree/page-tree-element" In TYPO3 v13.1: - "@typo3/backend/tree/page-tree-element" This change adds a proper deprecation message, and a RST file for it. Resolves: #103850 Related: #102125 Releases: main Change-Id: I9b704976030e93cbb0632b637b6f099759733ac3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84285 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Rafael Kähm <rafael.kaehm@dkd.de>
-
- May 17, 2024
-
-
Wouter Wolters authored
Use parallel runner to use more than 1 CPU. composer require --dev friendsofphp/php-cs-fixer:^3.57.1 Resolves: #103851 Releases: main, 12.4, 11.5 Change-Id: I59b5e2566a385792cad1b6c11b9b84b63fd21b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84284 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
markuskappe authored
The documentation of EXT:scheduler falsely referred to the Admin Panel extension, which is now corrected. Releases: main, 12.4 Resolves: #103854 Change-Id: I81fe65069bfe0309ba62a5e376e30da4e6f65075 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84288 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
This commit fixes an long standing typo in the `dataset` of the delete buttons in the record list. `l10parent` is now correctly named `l10nparent`. Resolves: #103852 Releases: main Change-Id: Ibd2bb8425ef502a9b8ca255a48359b8181222dba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84287 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com>
-
- May 16, 2024
-
-
Garvin Hicking authored
It has come up a few times that users face problems how to properly utilize the new `_assets/` hashed symlinks for `Resources/Public` assets of extensions. The current ChangeLog entry does not mention key searchwords like `_assets` or `Resources/Public`. Also, vital information is only available on external blog articles. This patch tries to provide a central entry point and may also be ported to the Core-API documentation once the mentioned concepts are approved by the core-team. ChangeLog entries are the vital source of truth for migration instructions and basis for the documentation, thus this is the first place to be addressed. Resolves: #103845 Releases: main, 12.4 Change-Id: Iadeae5de624027b5303a4240b36ca501ae29a31a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84282 Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev>
-
Anja Leichsenring authored
With one traverser class and several checkers all necessary checks can be executed within one CI job, which saves time and resources. By feeding all checkers with the same set of files, we can be safe not to lose any files that should be checked. Resolves: #103465 Releases: main Change-Id: I4a2f54c6fac37177c8387a999f5e60102951eba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83568 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- May 15, 2024
-
-
Nikita Hovratov authored
Resolves: #103835 Releases: main Change-Id: I78159e868390047735490a7d179f90adf3e2e83c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84276 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
Stefan Bürk authored
With #103692 remembering the sub-module route within the backend user module has been fixed to open the last opened module sub-route. Due to another splitting of composer acceptance tests, the backend user groups tests are executed before the backend user tests within the same instance - and thus staying on the backend user groups view. `ListUserCest` does not ensure to select the backend user lists like it is done for `ListGroupCest`. This change ensures to switch to the backend users sub-route, when the `backend user` module is selected in the `ListUserCest::_before()` similar to `ListGroupCest::_beore()`. Resolves: #103837 Related: #103692 Releases: main, 12.4 Change-Id: If54812a7bfc95e317f5e72737c3f88461da3fda2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84278 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Stefan Froemken authored
Resolves: #103836 Releases: main Change-Id: Ia74ab100142aa29c3a1a145c358e77e4eaaca804 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84277 Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
Lina Wolf <112@linawolf.de>
-
- May 14, 2024
-
-
Benni Mack authored
This new version drops support for PHP 8.0 and below https://github.com/Bacon/BaconQrCode/releases/tag/v3.0.0 Resolves: #103832 Releases: main Change-Id: I80f032e44c3ca8c712166a10f7115e1a38ad7a84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84233 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Andreas Kienast authored
The label for the delete action was encoded twice, leading to text issues in case special characters are involved. This commit makes use of `GeneralUtility::implodeAttributes()` to solve this issue properly. Resolves: #103827 Releases: main, 12.4, 11.5 Change-Id: Ia9f7ba5adf46b470a33b9065e49b8599a24fdfad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84253 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
Benni Mack authored
This patch consists of three aspects: 1. Record Object (internal) A new value object for records, which contains only the fields relevant for this specific Content Type. It decorates another RawRecord which holds the original raw database record. The RecordInterface, which both implement, allows for unified usage. 2. RecordFactory (internal) The factory for the Record object. Takes the table name and a raw record as input and builds the Record object from it. This class contains three more public methods, which relate to TCA schema. These will be moved to an appropriate place as soon as we have TCA schema at home. 3. RecordTransformationDataProcessor (feature) The actual feature of this patch. The new DataProcessor allows to utilize the Record object inside Fluid templates (only). It can be used in various ways. Most prominent use cases are for chaining the DatabaseQueryProcessor or transforming the current {data} variable of FLUIDTEMPLATE views. The PAGEVIEW does have an enhanced PageInformation object already. Example DatabaseQueryProcessor: page.10.dataProcessing.10 = database-query page.10.dataProcessing.10.as = mainContent page.10.dataProcessing.10.table = tt_content page.10.dataProcessing.10.select.where = colPos=0 page.10.dataProcessing.10.dataProcessing.10 = record-transformation Example FLUIDTEMPLATE: tt_content.text { templateName = Text dataProcessing { 10 = record-transformation 10 { as = data } } } Resolves: #103783 Releases: main Change-Id: I41a5ee3e9403ea5695661e197538e0dca2d207e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83747 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de>
-
Benni Mack authored
This change allows for search for UIDs of versioned records in the page tree, which have been created within the workspace. Resolves: #103237 Releases: main, 12.4 Change-Id: Ia836d6ff50a9a8dccce69666a1f3614e959a2b19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83167 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
The "frame" parameter is no longer evaluated in the showpic eID as it allowed uncontrolled resource consumption. This parameter was actually never used by ContentObjectRenderer and existed since the initial commit and is therefore put behind a feature flag. Resolves: #103306 Releases: main, 13.1, 12.4, 11.5 Change-Id: I87019e58c078c8ccafc0b7ce42fe28b49dc068e4 Security-Bulletin: TYPO3-CORE-SA-2024-010 Security-References: CVE-2024-34358 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84267 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
Resolves: #103303 Releases: main, 13.1, 12.4, 11.5 Change-Id: I2842cefd5dfc0aff920e61b5fd16f029db8ada4c Security-Bulletin: TYPO3-CORE-SA-2024-009 Security-References: CVE-2024-34357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84266 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Franzke authored
Encode non prepared output of BackendUtility::getRecordTitle. The string returned by getRecordTitle is only HTML encoded if the third parameter (`$prep`) is set to true, ensure that non-prepared usages are encoded on render. Resolves: #103782 Releases: main, 13.1, 12.4, 11.5 Change-Id: I96b9530d118a21163d6679ebf7120aa40c7ac7b6 Security-Bulletin: TYPO3-CORE-SA-2024-008 Security-References: CVE-2024-34356 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84265 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benjamin Franzke authored
Encode non prepared output of BackendUtility::getRecordTitle. The string returned by getRecordTitle is only HTML encoded if the third parameter (`$prep`) is set to true. ensure that non-prepared usages are encoded on render. Resolves: #103406 Releases: main, 13.1 Change-Id: I2aeefc20d526078ef905905b136dcd405fda337a Security-Bulletin: TYPO3-CORE-SA-2024-007 Security-References: CVE-2024-34355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84264 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
The last used action is now properly resolved again in the backend user module. Due to the fact that accessing the module, extbase always uses `index` as the selected action, the stored user state was never resolved. This is now fixed by using the index action as forward action, forwarding to either the stored default action or falling back the new "listAction" which now acts as the main entry point. Resolves: #103692 Releases: main, 12.4 Change-Id: I764d130dc1a53a8fed25dadfaecaab5dd4eb58de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83945 Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
With #94499 creating redirects on page slug changes has been enhanced to determine the source based on real url building, respecting available site configuration route enhancer options, for example PageTypeSuffix for page-type zero (`0`) in addition to plain slug replacement generation. The plain slug replacement does not take disabled state (`hidden`) or scheduled state `starttime/endtime` into account, the advanced url building using the PageRouter respected the context - which discards hidden pages or pages outside the scheduled range. To solve this issue, the `VisibilityAspect` in the context can be changed to allow hidden and scheduled records which also revealed a inconsistency between the option comment and the behaviour, and the fact that this option has been missed. This has been addressed with #103831 to enable this solution to work properly. This change introduces a new internal method `getAdjustedContext()` to `\TYPO3\CMS\Redirects\EventListener\AddPageTypeZeroSource` to ensure a context to build uris for hidden pages and/or pages which are scheduled and outside the constraint. The modified context is used in `createPageTypeZeroSource()` instead of the current index. Functional tests are added to cover this behaviour. Resolves: #103436 Resolves: #103798 Related: #103831 Related: #94499 Releases: main, 12.4 Change-Id: I05cf793eacb7fb2f39c1ceeb72fcbd0bd3b16719 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84229 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Garvin Hicking authored
Attributes passed via TypoScript like: ``` page { includeJSLibs { someIncludeFile = EXT:sitepackage/... someIncludeFile.forceOnTop = 1 } ``` were wrongly passed on to the `<script>` tag, resulting in: ``` <script src="/_assets/…" forceontop="1"></script> ``` This patch streamlines removing the specific `<script>` and `<link>` tag attributes with a central function to prevent further copy+paste differences, and better makes visible which TypoScript attributes are removable for which type. Tests are added to ensure this works, and can act as a regression check. All of the keys that are unset from `additionalAttribute`s are handled through their `addCssFile/addCssLibrary/addJsFile/addJsFooterLibrary()` methods, and thus would not be emitted again. Please note, this patch deals with one part of the issue. The other portion about whether "data." is a good TypoScript subkey or not is beyond scope, and was already fixed in documentation. Resolves: #100954 Releases: main, 12.4 Change-Id: Icd0f7e958387c985b7373623a0fba3656120a57a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84182 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 13, 2024
-
-
Lina Wolf authored
->expr() must be executed on QueryBuilder, not on Connection Releases: main Resolves: #103829 Change-Id: Ib3af65e266fd5a467087b23a24f04c1851be3e78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84232 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
With #94499 creating redirects on page slug changes has been enhanced to determine the source based on real url building respecting available site configuration route enhancer options, for example PageTypeSuffix for page-type zero (`0`) in addition to plain slug replacement generation. This included a check to drop the `PlainSlugReplacementSource` if they match - which should be the case as long as no suffix are defined for `page-type 0`. Sadly, a default pagetype suffix is configured as slash similar to: routeEnhancers: PageTypeSuffix: type: PageType default: '/' map: '/': 0, '.json': 123 the generated slugs differs by the tailing slash - and thus creating two similar redirects instead of one, which is expected. This change modifies the duplicate detection in the corresponding `\TYPO3\CMS\Redirects\EventListener\AddPageTypeZeroSource` method `sourceEqualsPageTypeZeroSource()` to ignore tailing slashes for the comparision. A functional test is added to ensure this behaviour. Resolves: #103806 Related: #94499 Releases: main, 12.4 Change-Id: I0c07aeb8c13643cfed74de69e52a3a6fceb196cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84228 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Albrecht Köhnlein <ak@koehnlein.eu> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Albrecht Köhnlein <ak@koehnlein.eu>
-
Stefan Bürk authored
Since #102793 the PageRepository respects `includeScheduledRecords` from the context `VisibilityAspect` setting in the `PageRepository` and added a runtime cache handling in the `init()` call. However, the cache identifier does not respect the same visibilty options for the cache identifier like it is used for preparing the property `where_hid_del` - and thus leads to invalid and unexpected record retrievement, depending on context switches in a request. This change extends the cache identifier to respect the scheduled record setting and removes the invalid page table except comment. Resolves: #103831 Related: #102793 Releases: main, 12.4 Change-Id: I2e7f038a04d957751bba1181c3d5324c6e0674b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84235 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Benni Mack authored
Ensure env variable from port is cast to integer when setting up TYPO3 with Environment variable TYPO3_INSTALL_DB_PORT. Resolves: #103826 Releases: main, 12.4 Change-Id: Ibd982690d3eec0527f452cd7353bdc0bf1a572c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84231 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by: Markus Friedrich
-
Georg Ringer authored
It might be that pages are still available which are outdated regarding its language. This can be when a site language has been removed from the configuration. Therefore those pages should be skipped when checking the integrity. Resolves: #103801 Releases: main, 12.4 Change-Id: Ic5ca071ff8d2b5956365a432fa0f99da5772595f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84180 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Benjamin Franzke authored
When a content element (CE) gets edited or the visibility is toggled, the page module is reloaded with an anchor in the URL to scroll to the content element that was updated. After #103381 it was not possible anymore to click the "+ Content" button above such CE. The reason is that a pseudo element `:target:before` is generated with a specific height and margin to overcome the height of the floating module docheader, overlaying the CE action button. In the patch mentioned before, `overflow: hidden` was removed to make the `box-shadow` of the CE visible, finally causing this bug. To solve this issue the pseudo element add it #97036 is replaced by the CSS option scroll-padding-top. It incorperates the maximum docheader size plus a slight margin that is slightly lower than the grid margin – but not equal to – to move shadows of adjacent elements out of sight. Resolves: #103672 Related: #103381 Related: #97036 Releases: main, 12.4 Change-Id: I8d5c9eadd45e5507e39b1fb728de65d31c1d6689 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83998 Tested-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Ayke Halder <mail@ayke-halder.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Ayke Halder <mail@ayke-halder.de> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Tested-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Reviewed-by:
Benjamin Franzke <ben@bnf.dev>
-
Andreas Kienast authored
This commit updates `phpstan/phpstan` to 1.11.0 and its related friends to their latest respective version. Executed command composer require --dev \ phpstan/phpdoc-parser:^1.29.0 \ phpstan/phpstan:^1.11.0 \ phpstan/phpstan-phpunit:^1.4.0 \ -W Resolves: #103823 Releases: main, 13.1, 12.4 Change-Id: Idc057895d503089c03a8cb5358be4ea7e3575e93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84221 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2][3] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below - at least for the phpXY images. * core-testing-php82: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-php83: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-apache24: Minor version release thus raising version required. * core-testing-nodejs22: Minor version release thus raising version required. * core-testing-nodejs22-chrome: Minor version release thus raising version required. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/df1e05ed52e724e0934e552c214395930022413b [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/f754d7fbd2c3cbed98296c8a772869362487d073 [3] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/4f93c5e93eb4e00fc936c13280918e60e62be567 Resolves: #103821 Releases: main, 12.4 Change-Id: I085cc0ce80682dfd009e5648f236974a380b8176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84214 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Patrick Schriner authored
To circumvent race conditions where the cache is removed between `has()` and `require()` invocations, the return value of the cache result needs to be verified, as `false` is returned if the cache entry is not available. Resolves: #103720 Releases: main, 12.4 Change-Id: Iefede04108d3adf9bd6c77cb0600cdc994f6d0fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84016 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Benjamin Franzke <ben@bnf.dev>
-
André Buchmann authored
Copy/move pages with existing translation into another site with different language setup results in orphaned problematic page translation records. It's not only about a complete page to another page, but also about copy/move of a record/content element to a page which does not have the same translations as the original page. This test verifies the current behavior as a basis for further discussions. Resolves: #103814 Related: #102345 Releases: main Change-Id: I1f4c1fb2155e303702832d969fff903fcdb09266 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83310 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Eric Harrer <info@eric-harrer.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Eric Harrer <info@eric-harrer.de>
-
Stefan Froemken authored
Remove line which extracts a version number from YamlSetDefinitionProvider as settings definitions does not contain any version number. Resolves: #103822 Releases: main Change-Id: I7e7a02a7d7dec6a264bb60d3de7fdaa1252bd9ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84215 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de>
-
- May 12, 2024
-
-
Lina Wolf authored
Resolves: #103820 Releases: main Change-Id: I4731f5579b0dd62785816441dabbe87d725bc274 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84213 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Garvin Hicking <gh@faktor-e.de>
-
- May 11, 2024
-
-
Christian Fries authored
When addressing flexform fields in TSconfig, the dots of the field names have to be escaped with a backslash. Releases: main, 12.4, 11.5 Resolves: #103786 Change-Id: I6af70fcb80e9e155ba8259ec216c5199600c5a78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84140 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
core-ci <typo3@b13.com>
-
Garvin Hicking authored
An error was made in [1] where a wrong link anchor name (parseFunc) was used after refactoring the link format, which leads to a warning in the documentation rendering process. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84193 Resolves: #103819 Releases: main, 12.4 Change-Id: I9b0c8f1852e32174b2ce5b59dc45607fd403a06c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84212 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Lina Wolf <112@linawolf.de>
-
Stefan Froemken authored
Resolves: #103816 Releases: main Change-Id: I407cf635b5e1030c943d45a99a51a0210b840a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84189 Reviewed-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
- May 10, 2024
-
-
Christoph Lehmann authored
In advanced query the operator "is in list" makes value be an array. Then switch the field to a non-array field type, and you get the following TypeError: ``` htmlspecialchars(): Argument #1 ($string) must be of type string, array given. ``` This resets the array value to an empty string. Resolves: #103487 Releases: main, 12.4, 11.5 Change-Id: Ifc6ef7e90d49a05ecb4b6d4869eea13c151b1b2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83593 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Willi Wehmeier authored
The add widget modal has a cancel button on the bottom of the modal now to match the other modal windows in the backend. Resolves: #103787 Releases: main, 12.4 Change-Id: I0c2c970b1148dfddadff1c3722d04dfcc939a69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84142 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
Hook implementation are configured with the well known $GLOBAL['TYPO3_CONF_VARS']['SC_OPTIONS'][...][] = ''; syntax since ages. Directly defining an anonymous callback function is undocumented and rarely used, but technical valid and supported by the `GeneralUtility::callUserFunction()` method. Due to the refactoring of the `ext:lowlevel` Configuration module for the revamped TypoScript parser with TYPO3 v12 the code in the `ConfigurationController` has been modified to do an array cast, which triggers the execution of the function - which can lead to some deep recursions and thus exceeding server resource limits. Direct callback function should not be executed within the backend Configuration module, which literally is a invalid execution of them. Following code in a extension `ext_localconf.php` file will lead to the resource limit issue: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['tslib/index_ts.php']['preprocessRequest'][] = function($parameters, $parent) {}; This change modifies the `ConfigurationController->renderTree()` to check if a value is a callable and display the information, and in case of an anonymous function (`Closure::__invoke`) add additional static information: Closure::__invoke (anonymous callback function: function() {}) Note: That does not make it obvious where the function is defined, but it avoids calling these callback methods. Resolves: #103813 Related: #99899 Releases: main, 12.4 Change-Id: I839d1668cf306100cf32af09ec9e24ad0120c43b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84187 Reviewed-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-