- Feb 05, 2023
-
-
Benni Mack authored
Various dependencies which have released major versions (to be compatible to further upstream packages) are now raised: * doctrine/annotations (allowing both 1.13 + 2) * doctrine/event-manager (For DBAL v4 compatibility) * doctrine/lexer (v2 + v3 instead of v1) * egulias/email-validator (4.0) using lexer Core `TYPO3\CMS\Core\Database\Schema\Parser\Parser` has got proper native types and return types to match deprecated array access on tokens returned by raised `doctrine/lexer` - which is used internal. That solved some phpstan ignore patterns as side-change. Used commands: * composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W * composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W -d typo3/sysext/core --no-update * Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #99832 Releases: main Change-Id: I8acc42933014f5d6711f2a6442499d7070a68a0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77704 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
- Feb 04, 2023
-
-
Benni Mack authored
This change introduces the combination of the newly added Locale class and SiteLanguage, allowing to work more with the objects than with strings as before. We're also adding an internal "POSIX" formatted logic to the Locale object, so the setLocale() calls can still work as before. This patch basically provides a bridge between the previously used POSIX format ("de_AT.utf-8") and the BCP-47 definition of language tags which is the base for the Locale class. However, both formats can now be used (in site configuration), and are properly formatted in setLocale() or in HTTP response headers in Frontend, which was a limitation before. Resolves: #99812 Releases: main Change-Id: Iee62e537f7dd334d614e4922cb7a0dd7222c379d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77685 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Georg Ringer authored
Provide a filter method to create a list of countries with given included and excluded countries. Resolves: #99732 Related: #99618 Releases: main Change-Id: I904b9243ddcdc6b0e455096481ed4321900f5ff4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77619 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
This change updates the main TYPO3 code base vendor/ directory to lock to latest packages from our main dependencies, ready for the next v12.x release, so the "non-composer mode" has various updated dependencies shipped. Used commands: composer update "symfony/*" "doctrine/*" "psr/*" "firebase/php-jwt" "bacon/bacon-qr-code" -W Resolves: #99831 Releases: main, 11.5 Change-Id: If208b89062dab7dac98b140fe6e16a545bf9226f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77702 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Torben Hansen authored
This patch removes all usages of `$GLOBALS['TYPO3_REQUEST']` in ext:felogin classes, by passing the extbase request object to methods requiring access to request parameters. As a result, the class `ServerRequestHandler` has been removed, which was a wrapper class for `$GLOBALS['TYPO3_REQUEST']`. Besides the removal of `$GLOBALS['TYPO3_REQUEST']`, the following cleanup and modernisation tasks have been made: - Use constructor property promotion - Use constructor dependency injection - Marked `LoginController` as `@internal` - Corrected some comments in tests and method doc headers - Simplify mock creation in some tests Resolves: #99777 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I94034fdcc83fc78c34173b119d829279f8260de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77652 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Christian Kuhn authored
The entire bootstrap tooltips plugin and Backend handling is problemetic. The patch removes usages throughout the Backend to rely solely on native browser title attributes on hover for now. Reasons: * Usage within the Backend is very inconsistent: Some modules use 'bs-toggle="tooltip"', some do, but then don't initialze JS accordingly, many don't take care at all. * The placement of tooltips is inconsistent: Some modules rely on auto placement, some don't take care, some get it right. * The plugin is fiddly: There are various hacks to for instance toggle-off on scroll, or toggle-off when a modal is overlayed to not stay on-top-of modals, these sort of things. Browser title hovers always get this right. * Usages are buggy: The page tree sometimes still fails to remove tooltips, which then tend to stay until browser reload. The list module shows both a browser hover plus the tooltip at the same time on icons, ext:form shows funny placement in preview-mode. There are more modules that get details wrong than those that work flawlessly. * Tooltips that add a lot of valuable information are problematic from an accessibility point of view. It's better to refactor UI to not rely on them too much. By avoiding bootstrap tooltips for now, we encourage to think more about properly accessible solutions instead of putting things into a "nice" overlay. With the patch, various places now fall back to the title attribute, which is also problematic, see [1] for more information. The core will continue to improve the situation with further patches and will document better best practices. * Tooltips with a lot of additional information are a no-go on touch devices. * The plugin is slow with many elements. This is easily reproducible with the "List" module, which is noticeable quicker when relying on title tags alone on weaker clients. [1] https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/title#accessibility_concerns Resolves: #99811 Resolves: #99428 Resolves: #99089 Resolves: #98061 Resolves: #97047 Resolves: #93022 Related: #89872 Releases: main Change-Id: I3cb8f0ca5e65a2c4b74d023935e1bef26c592ffd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77664 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Since #99782, we're always rendering the entire TypoScript tree. With bigger trees like a loaded bootstrap_package, these can be thousands of nodes. One bummer is the f:be.link VH call for each node. The patch suppresses this with a pretty straight hack, improving server side by about 40%. Another optimization (accessing object members) requires a change in Typo3Fluid, which needs to be prepared and released on this side first. Resolves: #99820 Related: #99782 Releases: main Change-Id: I688d1038a5e4f23c5f2172d64d7508cdda3e3ff2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77695 Reviewed-by:
-
Nikita Hovratov authored
Since the recent release of PHPUnit 9.6 some new deprecations were added which signal breaking changes for version 10. As deprecations are causing our tests to fail, they need to be addressed immediately. Method `expectErrorMessage` replaced with `expectExceptionMessage`. Method `getMockClass` replaced with `createMock` and a subsequent get_class call. Also update phpunit/phpunit to latest version: > composer update phpunit/phpunit > composer bump phpunit/phpunit Resolves: #99817 Releases: main, 11.5 Change-Id: I6d01ccca398a8ff5db735a35b19061b711c843cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77692 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #99818 Related: #97816 Releases: main Change-Id: Ibc3e5dd98d75d1c1cb4de6e8fad1f7b662d3de75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77694 Tested-by:
-
Kevin Appelt authored
Move widget registration to Services.php to allow checking for the existence of WidgetRegistry to only add the widget if EXT:dashboard is available. Resolves: #99813 Releases: main Change-Id: I3157784944cdf16ae091a8ad90da59894c94104b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77686 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Feb 03, 2023
-
-
Jasmina Ließmann authored
This followup optimizes the code introduced by a previous patch set. Newly introduced CSS classes are thereby partially removed again. Resolves: #99809 Related: #99742 Releases: main Change-Id: Ife2b6e1704837fbee2481d18c7191625a60a7979 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77683 Reviewed-by:
-
Christian Kuhn authored
Resolves: #99793 Releases: main Change-Id: I35e3216c3c84dae41fe5980d9ad6558a1eaaa6b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77667 Reviewed-by:
-
Markus Klein authored
The ObjectStorage internals return strings as keys for the elements, when iterating over the storage. Users expect JSON arrays (not objects) when rendering an ObjectStorage through a JsonView. The `toArray` method takes care of this key conversion. Resolves: #66581 Releases: main Change-Id: Ice2487f6e85e3949d9ee59174b6175c46b1ae8e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77361 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Jochen Roth authored
A new command has been intruduced named "./bin/typo3 backend:user:create" which allows to create a backend user via CLI using environment variables, cli options or a guided walk-through (questions/answers) Resolves: #99341 Releases: main Change-Id: I0daf86283da35b1884a6f3a743d6f953d7f184dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77020 Tested-by:
-
Kevin Appelt authored
This SEO widget lists pages with missing description ordered by the last changed date. Resolves: #99552 Releases: main Change-Id: I41d6895a0630946b554a1ecc42adf5c7eb031fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77396 Reviewed-by:
-
Andreas Fernandez authored
It is now possible drag items (files or folders) from the filelist iframe into the tree. Resolves: #99733 Releases: main Change-Id: I573fc5a290a14abe79a8211ecf1751a59c1e4c38 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77522 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Jasmina Ließmann authored
To improve readability, the system status text and value of the application context are displayed in default font color. The link to the system log is now also displayed in the default link color. Resolves: #99742 Related: #99538 Releases: main Change-Id: I293d5c74a7dc5bf26ff53673c9ac55767e686332 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77660 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Nikita Hovratov authored
So far TCA migrations for FlexForm were only called in FormEngine context. In order for DataHandler to always receive migrated TCA, the migration method is now moved from TcaFlexPrepare to FlexFormTools. This also fixes TCA type="file" fields inside FlexForm. TcaFlexPrepare used the TcaPreparation functionality, which would override the TCA foreign_match_fields with "dummyField" instead if the FlexForm sub key. In addition, a typo in a parameter name is fixed as a drive-by change. Resolves: #99756 Releases: main Change-Id: I07fadeddc26fa93a6fd7aebc6f0c57eac9bfe0a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77643 Tested-by:
-
Benni Mack authored
This change implements __toString() in various Toolbar Buttons, so it can be used in various templates and controllers and is now compatible with \Stringable. Custom Buttons can implement Stringable for v12.0 only, and will still be compatible with v11+12 Resolves: #99804 Releases: main Change-Id: I55c226058284f0af01f5086ffee4c0d3b178474d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77674 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Feb 02, 2023
-
-
Stefan Bürk authored
A new PSR-14 based event "SlugRedirectChangeItemCreatedEvent" is introduced, allowing extension authors to create additional redirects for a changed page slug or to remove redirect source candidates. This is especially useful to ensure creation of related redirects. This can be used to create redirects for special page types or sources build by fully respecting configured route enhancers and decorators. Custom source implementation must be provided based on already available `RedirectSourceInterface`. Further events in later steps of the process with dedicated follow-up changes will reveal the full-power, which has been kicked-off with the streamlining of #99188 and this change. Current behaviour of creating redirects only based on the raw slug value are kept by implementing a specific EventListener for it. Extensions can replace the plain slug replacment source by registering their listeners after the core listener. TYPO3 core may implement and ship an additional source listener for building source uri using the page router for page type "0", therefore repspecting configured enhancers and decorators in a dedicated patch. Resolves: #99746 Related: #99188 Releases: main Change-Id: I84356d00eda48d04d5bb35d90dc1fa3141698c75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77633 Tested-by:
-
Andreas Fernandez authored
The module `@typo3/backend/utility/collapse-state-persister` performs several JSON decoding tasks on the same objects that are read from the client's localStorage. To save some milliseconds, a `Map`-based cache is introduced that saves some JSON operations, depending on how many nodes are expanded. Resolves: #99794 Releases: main Change-Id: I6f659390243fc1dd156b20664185f96502267dc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77668 Tested-by:
-
Andreas Fernandez authored
This patch introduces a flag that enables itself once dragging was started within the document of the filelist module. If the flag is enabled, the drag&drop upload feature is *disabled* to avoid dragging an image within the filelist and having a fullsize dropzone rendered, which in fact accepts the dragged thumbnail and uploads it in the same directory. However, this will not prevent receiving images from anywhere else of the TYPO3 backend as those are technically "external" files. Resolves: #99800 Releases: main Change-Id: I9b6184088b57690a8b588e6ad3b3f7cd16d369d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77671 Tested-by:
-
Christian Kuhn authored
An ext:reports related call to GeneralUtility:_GP() is avoided by switching to the prepared interface in ext:install. Resolves: #99792 Releases: main Change-Id: Ib0aec171b676c6963f98129402ff2f5f74e413fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77666 Tested-by:
-
Andreas Fernandez authored
When using drag&drop in the page tree, many style changes happen: * a shadow node is rendered that is moved around * the content within the shadow node changes depending on whether dropping is allowed * CSS classes are changed The previous implementation was not optimal in several ways: * the nodes wrapper (aka the "tree") was updated twice which each `dragover` event, being expensive on huge trees * adding and removing CSS classes may have become redundant in some cases, triggering a re-paint every time All these cases are handled in this patch by executing tasks only when absolutely necessary. Resolves: #99786 Releases: main, 11.5 Change-Id: Ibc8cbce2785e2de646e254590b4eddbdc42839c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77658 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Christian Kuhn authored
Resolves: #99791 Releases: main Change-Id: Ib72909d91fcf9f9ad46428b9c6272939607fb610 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77665 Tested-by:
-
Oliver Bartsch authored
In a "form-check" container, the input element with class "form-check-input" must be placed before the corresponding label with class "form-check-label". This fixes a related display bug in Firefox. Resolves: #99785 Releases: main Change-Id: I2d856631d65d0b7edcf5053cb2da927f83ebac07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77663 Tested-by:
-
- Feb 01, 2023
-
-
Chris Müller authored
Related: #99618 Resolves: #99788 Releases: main Change-Id: I826a40e306a77403dd06270eb83f5131920c219d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77661 Tested-by:
-
Jasmina Ließmann authored
Align columns within the table to ensure a consistent reading flow. Position the content and buttons at the beginning of the column. Also increase space between table and "Unassigned site configurations" area. Resolves: #99789 Releases: main Change-Id: Ida72a151766ef139ed1dfae1e44ccb5d8d5756ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77662 Tested-by:
-
Christian Kuhn authored
The user authentication classes are still pretty messy. A subset of properties and information of backend user state is intitialized by middlewares and set as aspect to the context object. However, we do not want to add the entire backend user as $request attribute object, to not surface another usage of this object. Instead, it is set as $GLOBALS['BE_USER'] throughout the core, which will eventually vanish at some point, by being substituted by something better. ext:reactions currently violates this. The patch sets $GLOBALS['BE_USER'], consuming reactions should retrieve it from there if needed, just like any other backend related class does it currently. FormProtectionFactory had a similar flaw, it accessed the attribute even though no middleware ever set this. Finally, .phpstorm.meta.php is cleaned up, to not declare this request attribute any longer. Change-Id: Iae4c48a1ccc41f7aeebdf753f9cae6515bb5f9e5 Resolves: #99751 Releases: main Reviewed-on: https:...
-
Benni Mack authored
This change is the next iteration of cleaning up SVG-drag/drop code. Handling of the "positioning line" to drag nodes between other nodes (page tree only) has been encapsulated in drag-drop.ts A lot of methods and variables are renamed and comments are added in order to understand the code better. A few methods regarding draggables (the shadowed content) have been centralized so the code is easier to read where CSS classes are modified. Resolves: #99783 Releases: main Change-Id: I9e28d0ca3d886afaa8b3e2cf274593d3e45c3fa5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77656 Tested-by:
-
Andreas Fernandez authored
The change in #98069 removed the Debug Console from the TYPO3 backend. This patch removes the language file `debugger.xlf` that was forgotten back then. Resolves: #99787 Related: #98069 Releases: main Change-Id: I64122596c29317955b803ba12078da85664173d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77659 Reviewed-by:
-
Christian Kuhn authored
The module receives a similar treatment as "Active PageTsConfig", namely client side search and client side expand state persisting. This simplifies server side a bit, which is cleaned up. We're also avoiding the naming 'object browser' in file names and other places in favor of 'active'. A series of minor bug fixes is applied along the way. Resolves: #99782 Related: #99747 Releases: main Change-Id: Ibaef3123b3e6df316ef5e633582077fd0e702be0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77650 Reviewed-by:
-
Stefan Bürk authored
Support for json database field has been added basicly with #99062 and #99226. That popped up an issue with handling data of this field in DataHandler, which has been addressed within #99279. First real usage of this new field type has been added with the introduction of the new `ext:reactions`, which is also the first battleground for this field type. Using `ext:reactions` revealed an oversight regarding the proper representation and handling of the "json" field and data in the well known history&undo feature. To create "human-readable" data representation the `BackendUtilility::getProcessedValue()` method is used. This method expects to return string of the represented data, so it can compared by the diff utility. The value for json fields are the decoded value, and is therefore most likely an array. This change used `json_encode()` to prepare the value for the human-readable representation. This gives us a nice view and avoids the issue with the annoying array to string conversion warning. Resolves: #99277 Related: #98373 Related: #99279 Related: #99226 Related: #99062 Releases: main Change-Id: I4d9b80c86b4cc8fe3e1f65a7b8a62d9bcfa1ef4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77608 Tested-by:
Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Thomas Hohn authored
Sanitize the mountPointParameter in class constructor. Resolves: #99731 Releases: main, 11.5 Change-Id: Ic6fec228c462c7ec4a75a7efc934d7d17fc5c1e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77621 Reviewed-by:
-
Thomas Hohn authored
Added a guard around the calculation of $sameBeginEnd. Resolves: #99752 Releases: main, 11.5 Change-Id: I754b4e67b2b04db20dc9adb8ee26bbd2ab2651ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77639 Tested-by:
-
Benni Mack authored
This change reduces some redundancy in implementations for drag+drop for pagetree + folder tree, also adds some comments and adds some helper methods to make the code a tiny bit more understandable. In addition, to reduce our dependencies to d3-drag, the DragDropHandlers now receive the node and the original MouseEvent, as there is nothing else that the DragDrop handlers need for our solutions. Resolves: #99778 Releases: main Change-Id: Ia45a3ac5256d22ab38cf8c5d70fc4b939a53085a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77654 Tested-by:
-
Thomas Hohn authored
The variable sameBeginEnd should have the type bool, since the comparison calculation yields a bool. Resolves: #99776 Releases: main, 11.5 Change-Id: Iddbd04197b1b2f99bc96d365c0c4dde1615568da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77651 Reviewed-by:
-
Benni Mack authored
Used command: cd Build npm install "d3-drag@^3.0.0" \ "d3-selection@^3.0.0" \ "d3-dispatch@^3.0.0" \ "@types/d3-dispatch@^3.0.0" \ "@types/d3-drag@^3.0.0" \ "@types/d3-selection@^3.0.0 grunt build Resolves: #99779 Releases: main Change-Id: Ic38dc68123b475aa8f9fa1d71a7698db92891fba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77653 Reviewed-by:
-
- Jan 31, 2023
-
-
Česlav Przywara authored
Releases: main, 11.5 Resolves: #99773 Change-Id: Ife6196a387db61ab7d81506cd32d7adc14bf609d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77649 Tested-by:
-
Kees Sonnema authored
A new event is added to modify the preview image for online media providers. Resolves: #99312 Releases: main Change-Id: I67846fb5eefa2cfd5b41208bf4ef7ee4270ed1df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76994 Tested-by:
Robert van Kammen <rvkammen@hotmail.com> Reviewed-by:
-
