Skip to content
Snippets Groups Projects
Commit c01cd1c2 authored by Torben Hansen's avatar Torben Hansen Committed by Christian Kuhn
Browse files

[TASK] Avoid $GLOBALS['TYPO3_REQUEST'] usage in ext:felogin


This patch removes all usages of `$GLOBALS['TYPO3_REQUEST']`
in ext:felogin classes, by passing the extbase request object
to methods requiring access to request parameters. As a result,
the class `ServerRequestHandler` has been removed, which
was a wrapper class for `$GLOBALS['TYPO3_REQUEST']`.

Besides the removal of `$GLOBALS['TYPO3_REQUEST']`, the
following cleanup and modernisation tasks have been made:

- Use constructor property promotion
- Use constructor dependency injection
- Marked `LoginController` as `@internal`
- Corrected some comments in tests and method doc headers
- Simplify mock creation in some tests

Resolves: #99777
Releases: main
Signed-off-by: default avatarTorben Hansen <derhansen@gmail.com>
Change-Id: I94034fdcc83fc78c34173b119d829279f8260de8
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77652


Reviewed-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: default avatarAnja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarBenjamin Franzke <bfr@qbus.de>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent 1c77c838
No related merge requests found
Showing
with 229 additions and 244 deletions
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment