[TASK] Avoid $GLOBALS['TYPO3_REQUEST'] usage in ext:felogin
This patch removes all usages of `$GLOBALS['TYPO3_REQUEST']` in ext:felogin classes, by passing the extbase request object to methods requiring access to request parameters. As a result, the class `ServerRequestHandler` has been removed, which was a wrapper class for `$GLOBALS['TYPO3_REQUEST']`. Besides the removal of `$GLOBALS['TYPO3_REQUEST']`, the following cleanup and modernisation tasks have been made: - Use constructor property promotion - Use constructor dependency injection - Marked `LoginController` as `@internal` - Corrected some comments in tests and method doc headers - Simplify mock creation in some tests Resolves: #99777 Releases: main Signed-off-by:Torben Hansen <derhansen@gmail.com> Change-Id: I94034fdcc83fc78c34173b119d829279f8260de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77652 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
Showing
- typo3/sysext/felogin/Classes/Controller/AbstractLoginFormController.php 3 additions, 0 deletions...elogin/Classes/Controller/AbstractLoginFormController.php
- typo3/sysext/felogin/Classes/Controller/LoginController.php 16 additions, 10 deletionstypo3/sysext/felogin/Classes/Controller/LoginController.php
- typo3/sysext/felogin/Classes/Controller/PasswordRecoveryController.php 2 additions, 2 deletions...felogin/Classes/Controller/PasswordRecoveryController.php
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserGroupRepository.php 2 additions, 3 deletions...Classes/Domain/Repository/FrontendUserGroupRepository.php
- typo3/sysext/felogin/Classes/Domain/Repository/FrontendUserRepository.php 6 additions, 4 deletions...ogin/Classes/Domain/Repository/FrontendUserRepository.php
- typo3/sysext/felogin/Classes/Redirect/RedirectHandler.php 48 additions, 26 deletionstypo3/sysext/felogin/Classes/Redirect/RedirectHandler.php
- typo3/sysext/felogin/Classes/Redirect/RedirectModeHandler.php 22 additions, 29 deletions...3/sysext/felogin/Classes/Redirect/RedirectModeHandler.php
- typo3/sysext/felogin/Classes/Redirect/ServerRequestHandler.php 0 additions, 73 deletions.../sysext/felogin/Classes/Redirect/ServerRequestHandler.php
- typo3/sysext/felogin/Classes/Service/RecoveryService.php 7 additions, 9 deletionstypo3/sysext/felogin/Classes/Service/RecoveryService.php
- typo3/sysext/felogin/Classes/Validation/RedirectUrlValidator.php 7 additions, 9 deletions...ysext/felogin/Classes/Validation/RedirectUrlValidator.php
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserGroupRepositoryTest.php 3 additions, 8 deletions...nal/Domain/Repository/FrontendUserGroupRepositoryTest.php
- typo3/sysext/felogin/Tests/Functional/Domain/Repository/FrontendUserRepositoryTest.php 3 additions, 10 deletions...nctional/Domain/Repository/FrontendUserRepositoryTest.php
- typo3/sysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php 64 additions, 39 deletions...ysext/felogin/Tests/Unit/Redirect/RedirectHandlerTest.php
- typo3/sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php 17 additions, 4 deletions...sysext/felogin/Tests/Unit/Service/RecoveryServiceTest.php
- typo3/sysext/felogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php 29 additions, 18 deletions...elogin/Tests/Unit/Validation/RedirectUrlValidatorTest.php
Please register or sign in to comment