- Aug 26, 2021
-
-
Benjamin Franzke authored
Executed commands: cd Build/ yarn upgrade lit@^2.0.0-rc.3 \ lit-html@^2.0.0-rc.4 \ lit-element@^3.0.0-rc.3 \ @lit/reactive-element@1.0.0-rc.3 grunt rollup Resolves: #94943 Releases: master Change-Id: I5140e9782a8a98361dfbcaf8318c74cdc8a05600 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70687 Tested-by:core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
The TOTP info modal displays the OTP auth url along with a description. This content however is added to the modal body by a callback. To prevent the "modal content empty" warning from being shown, the modal is now initialized with an empty string as content. Resolves: #94999 Releases: master Change-Id: I0a8c274466d4f62da8edb26a4c2b547b66be3ba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70761 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Aug 25, 2021
-
-
Jochen Roth authored
Now that we have frontend tests in the Backend suite the name Backend for acceptance suite does not fit anymore. So the suite name was changed from Backend to Application. Resolves: #94864 Releases: master Change-Id: Ib52053f6dbbfad9b7fef1ff11e81110cffa010b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70550 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Uwe Trotzek authored
The workspace module gets an additional stage filter to reduce the amount of changes a user is facing. This is very helpful if you are dealing with a lot of changes and want to see only records which are in a certain stage e.g. "Ready to publish". Resolves: #91021 Releases: master Change-Id: I80a3fa5c00ff302c9b2257370bdeda328033c204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64197 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Aug 24, 2021
-
-
Christoph Schwob authored
Remove duplicate styles but some overrides for e.g. border already needed. Changed class .card-content to .card-body Add card-size-medium to card on ElementInformation to use some empty space, cause there's only one card. Resolves: #94529 Releases: master Change-Id: I1e8d3cdfe8e622806eff4f1e52f3a2bad1740fad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70480 Tested-by:
-
Benni Mack authored
This change uses the native web component to render icons, instead of referencing them from Fluid. This change also fixes a small issue regarding language icons and integrity icons. Resolves: #94977 Releases: master Change-Id: I3f99139497a5f4691bea30b53e399a860b050090 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70735 Tested-by:
-
Oliver Bartsch authored
The workspace review features the collapse/expand functionality for record relations. An example is tt_content which may contain several sys_file_reference relations. They are included in the listing as well but collapsed by default. Since at least v10 those relations are always processed together. This means, in case an editor checks a parent record and executes an action, e.g. publish, the same action is also executed for the relations. However, the UX was previously not really helpful as this was not visible to the editor. Therefore, and to improve the UX in workspace review, those relations are now always "bound together". This means, when selecting the parent record all relations are selected, too. The same goes the other way round. When selecting a relation, all corresponding relations as well as the parent record are selected. As mentioned, this does not change any functionality as this process was already done "under the hood". This process is now just visualized for the editor. Resolves: #94404 Releases: master, 10.4 Change-Id: I28d2c9e67747dde5ffdfb36d24f8cc7f36c246a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70712 Tested-by:
-
Oliver Bartsch authored
The multi record selection, introduced in #94906, is extended for keyboard shortcuts. They can be used to achieve similar results as by using the actions in the multi record selection dropdown. * `shift` key: check / uncheck the range between the last checked checkbox and the current one * `option` (Mac) or `ctrl` (Windows/Linux) key: Toggle the current selection Resolves: #94944 Related: #94906 Releases: master Change-Id: Ia5f6625e6b380d908bddfbf5849f2ea6233fe420 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70688 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Aug 23, 2021
-
-
Andreas Fernandez authored
The context menu skeleton is partially visible for a very short time, before its items are rendered and event listeners are attached. This is revealed by some flaky acceptance tests and was previously workarounded by an additional ->wait() call in the tests. The context menu stays hidden now until everything is set up and the workaround in the AC tests is removed again. The context menu gets hidden after 500ms once the user moved the mouse out of its boundaries. However, that timeout was never reset which closed another context menu that might have opened within that 500ms time span. To circument this issue, such timeouts are now monitored and cleared again once a new context menu is requested. Resolves: #94891 Releases: master, 10.4 Change-Id: Ia0551d8c0b41edeca27cd0b15e4285a89ad2c171 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70592 Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Stefan Bürk authored
If the dropzone was not visible, remove it without animation. Resolves: #94892 Releases: master Change-Id: Icfb0090b9383321cd1d24c0aba7026affdbb58d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70594 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Bartsch authored
Have you ever wondered why "unrelated" records got processed in workspaces review when using one of the mass actions? Simply because the workspace JavaScript component is using an internal array, holding all selected records. This internal array however was only reset on leaving the module. Therefore, all records which had been selected since the module was accessed were taken into account when a mass action was executed. This did not only affect records which were unchecked prior to mass action execution, but also records which were no longer visible at this time, e.g. due to an applied filter. In the worst case, that led to completely unrelated records got published to a live workspace. This is now fixed by resetting the mass action state whenever the listing gets updated. This way, only the selected records in the current view are taken into account when executing a mass action. Resolves: #94405 Releases: master, 10.4 Change-Id: I40cabe66fd7a4eb310a8113f69d49f234cc110a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70691 Tested-by:
-
Oliver Bartsch authored
The workspace JavaScript component tries to fetch the workspace listing on accessing the backend module. Since #94819 this results in a JavaScript TypeError since the provided selector for the progress bar component, used as indicator for the ajax request, might not exist. This is now fixed by checking if the the workspace is actually accessible prior to initiating the ajax call. Resolves: #94946 Related: #94819 Releases: master Change-Id: I0c77564acc197a57e2999f4439daf28ba3fd333c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70724 Tested-by:
-
Oliver Bartsch authored
The multi record selection component is now also used in the recycler module. This increases consistency, as custom checkbox logic could be removed. Also the recyclers' JavaScript implementation of the selection actions is simplified. To interact with the multi record selection component, some events are used. This also means, the functionality stays the same, while most of it is now handled by the Multi record selection component. Resolves: #94926 Releases: master Change-Id: I57d91d070bfa75c01d4cb87dfd0c5576d111dcfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70678 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Oliver Bartsch authored
Components, using the multi record selection, introduced in #94906, usually do not have to change any checkbox state manually. The multi record selection component is taking care of it. However, there might be cases when a consuming component needs to change checkbox state on its own. An example is the workspaces module, which may changes checkbox state of child records when their parent record got changed. See: #94404. To prevent the components from overriding each other, the multi record selection now respects a special data attribute `manually-changed`. If set on a checkbox element, the multi record selection component will not touch this checkbox, while executing its (mass) actions. Resolves: #94948 Releases: master Change-Id: I35b07ca45cab4b96d3eea93ff45426702a1532d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70713 Tested-by:
-
Oliver Bartsch authored
Resolves: #94942 Releases: master, 10.4 Change-Id: I59685f499f9a86e266b6b012a88e80bdef4d3c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70685 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Aug 20, 2021
-
-
Oliver Bartsch authored
The multi record selection component is now also used in the workspaces module. This increases consistency, as custom checkbox logic could be removed. Furthermore are the actions now shown above and below the listing, similar to the recycler module. Thanks to additional labels, it's now also clear what each action is for and which records are affected. Resolves: #94935 Releases: master Change-Id: I65d275f79390deaf30b9468f40b34856b7aee8d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70682 Tested-by:
-
- Aug 19, 2021
-
-
Oliver Bartsch authored
This does a few follow up changes to increase consistency and allow further use cases. * Introduce a wrapper class to prevent jumping of the multi record selection actions and to unify the space between the actions and the record listing * Introduce new event listener for the actions, allowing JavaScript modules to influence the display based on their custom logic * Allow defining the actions multiple times on the same page (e.g. above and below the records listing) * Move "Selection:" label to EXT:core, while using it in both, filelist and file selector now Resolves: #94928 Related: #94906 Releases: master Change-Id: Ia1c972e8d5005d895476ad7e7322e39b37036669 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70679 Tested-by:
-
- Aug 18, 2021
-
-
Jochen Roth authored
With #94778 the backend logo has been scaled down to fit into the topbar. This worked but also led to issues with smaller, such as the default TYPO3 logo, as those were now stretched. This is now fixed by removing the "height: auto" property. Resolves: #94914 Releases: master Change-Id: Id3321bf739d0b064b7113ff6a152a088860f44f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70672 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Aug 17, 2021
-
-
Oliver Bartsch authored
A new component "MultiRecordSelection" is added. It's used first for the filelist module as well as the file selector. It simply adds a consistent way of selecting multiple elements (records) and to perform actions on this selection. Therefore, the checkboxes are always displayed at the beginning of each record row. The checkbox actions, such as "check all" are available in the header row of the same column via a dropdown menu. The actions to perform on the selection, e.g. "delete" or "import", appear once a record is selected. For the filelist module, this means those actions are decoupled from the clipboard, making it easier for editors to work with multiple records. This also introduces the "Edit marked" action to the filelist module, which allows to edit the metadata of all selected files at once. Resolves: #94906 Releases: master Change-Id: Id9e2915203049235fc4b503d33a4f1a77646c133 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70515 Tested-by:
-
Nikita Hovratov authored
In a case, where the search term is empty (by removing the search term manually for example) and a node is currently selected, the loader placeholder is now removed. This is the only case, where the method "resetFilter" is not called. Resolves: #94464 Releases: master Change-Id: Iad0deca5c9793cd0823d62c3864bc63e0fb40288 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70182 Tested-by:
-
- Aug 13, 2021
-
-
Wouter Wolters authored
diff-format option has been removed. udiff is the default now since v3. composer u friendsofphp/php-cs-fixer composer/xdebug-handler php-cs-fixer/diff composer req --dev friendsofphp/php-cs-fixer:^3.0 Resolves: #94856 Releases: master Change-Id: I33470fc49b4355130e73326c85323a1848fe3562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70516 Tested-by:
-
Wouter Wolters authored
Test methods are not allowed to have a prefix "test". Use the annotation "@test" in phpDoc instead. Integration into pre-merge and nightly gitlab-ci suites. Note we now have multiple tests based on nikic/php-parser. Those should be rewritten to use one parser instance with multiple visitors to scan php code only once. The exception code checker should be rewritten to use the parser, too. This will be done with a dedicated patch. Resolves: #94859 Releases: master Change-Id: I43ba692eaf2a342a2e0ed3d8978386ea5719183f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70524 Tested-by:
waldhacker <hello@waldhacker.dev> Tested-by:
-
Jochen Roth authored
The "create new element" button in the form editor was cut off. This is fixed by calculating the height minus the doc-header height. Resolves: #94773 Releases: master Change-Id: I7dfc891138473592c76562c6802430a4311739a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70394 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Jochen Roth authored
On each keystroke the animation for validators was triggered. This is now fixed by removing the animation on an active form element. Resolves: #94775 Releases: master Change-Id: I78d454df081c035c5858f32bb0bd3a8b01679a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70395 Tested-by:
-
Andreas Fernandez authored
To be more consistent: * Rename "-s install" to "-s acceptanceInstall" * Rename "-s cglAll" to "-s cgl" * Rename "-s lint" to "-s lintPhp" Apart from that, the cgl checker also lints the files before checking cgl. The explicit pre-merge lint jobs are thus obsolete in pre-merge. We keep "lint everything" for nightlies to be sure. Resolves: #94769 Releases: master Change-Id: Ie7b409f3b2485a8792199e4ad2eaec8565daf253 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70340 Tested-by:
-
11nd11 authored
Streamline and optimize styling and markup of the form manager of form module. * Clean up markup and classes of form list * Optimize UX of the form list and use the new alternative action menu for better icon description * Use new common styles and elements for better overview and modern look Resolves: #94806 Releases: master Change-Id: I5e24be3e022480c1798745131be7d41f4a5eaf2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70450 Tested-by:
Paul H <paul+typo3@ecopixel.com> Tested-by:
-
Oliver Bartsch authored
The columns selector actions buttons did previously not respond when clicking on their icon. This is fixed by adding the event listener to the corresponding buttons instead of the outer container and by accessing the required data attribute from `event.currentTarget`. Resolves: #94881 Releases: master Change-Id: I7992a307bd5a397eff11b395c5a4b22bd9e05a40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70581 Tested-by:
-
Benni Mack authored
When having a content element on the clipboard (normal mode) the page module dynamically shows paste icons everywhere. This change centralizes the generation of the Paste icons into JavaScript, so the inline javascript usage of "top.*" functionality to park code somewhere has been removed, and the actual items are generated in JavaScript. In addition, as this code is only affecting the page module when a tt_content element is on the clipboard, the Paste.js JS module is only loaded when appropriate, thus reducing the actual loading time for "regular" visits on the Page Module. The icon in the paste button is now loaded via a native web component, and only necessary logic is used in the Paste JS module. The outer rendering for the Page Module has been simplified, moving this functionality all into PageLayoutController, reducing cross-dependencies between the PageLayout* classes. Resolves: #94840 Releases: master Change-Id: I380df9a56bfff74684616732166f25c68bbc6dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70488 Tested-by:
-
- Aug 12, 2021
-
-
Alexander Nitsche authored
Sometimes acceptance tests fail due to a failed TYPO3 backend request, which is recorded in the TYPO3 log file. Save this log file along with the Acceptance Reports folder in the gitlab-ci job artifacts. Resolves: #94843 Releases: master, 10.4, 9.5 Change-Id: I0b260c197a6a71dc23e6f9da547fc20a55fc4ce7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70497 Tested-by:
-
Benni Mack authored
The workspaces module has a better style and some improvements for editors and administrators: * Editors now get feedback if an AJAX call shows no results * Editors + Administrators now switch workspace via a selector, very helpful when having more than a couple of workspaces * Administrators can now edit a workspace record directly from the module The change cleans up a lot of unused code in the main workspaces module and brings a few UX improvements within the module. * Dropdowns instead of tabs (good when having a lot of workspaces) * Language + Depth + Action selection is now rendered via Controller+Action instead of waiting for a first AJAX round trip * Properly using "moduleData" from "uc" to store information * Solved issues related to language icon rendering * Removed unused inline settings * Consistent usage of Persistent JS module accessing BE_Users' UC * nProgress for showing progress of loading AJAX requests Next steps in this area: * Hand in the first payload as JSON to avoid AJAX call on initial page load * Remove leftover inline JavaScript Resolves: #94819 Releases: master Change-Id: Ie533656a14af56dad4a4039fcbc9b08bde693500 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70452 Tested-by:
-
Jochen Roth authored
The custom backend logo could break the layout if not properly scaled. This issue is fixed by setting max-width and max-height for the image. Resolves: #94778 Releases: master Change-Id: I98221c721e8f9d7a7a648807ce31c0e9a00390a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70397 Tested-by:
-
Alexander Nitsche authored
This patch serves as a basis for further improving the UX and new features for import / export. * Better separation between controllers and worker services * Refactor code & streamline wording * More strict typing and some PHP 8 related fixes * Streamline exception handling * Support full import configuration in CLI command impexp:import * Functional tests with increased coverage and less mocking * A set of acceptance tests for the backend interface * Minor bug fixes Note: The output of the extension has not been changed in any way, e.g. the format of the export file remains the same. Only the internal processes have been optimized. Resolves: #94772 Releases: master Change-Id: I4df66a6f615e07d6d9767723a12a769aedeb341b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70332 Tested-by:
-
Benni Mack authored
The replacement for fsMod comes with a bad side-effect when using the topbar. This change ensures that a "mount" can also be handed in as "null" value. Resolves: #94828 Related: #94762 Releases: master Change-Id: I3e8c7ba7a83384297d8af52807be11e7e4115d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70463 Tested-by:
-
Oliver Bartsch authored
Bootstrap 5.1.0, we updated to in #94752, introduced a `.vr` (vertical rule) class. This collided with our access module related styles, since we also use a `.vr` class for the legend here. To resolve the collision, our own implementation, which is only used in the access module, is now prefixed with `t3`. Resolves: #94826 Related: #94752 Releases: master Change-Id: I493baa3d0af41b78f42c9e73c9c121b29f417edd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70456 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Aug 11, 2021
-
-
Oliver Hader authored
JavaScript object :js:`top.fsMod` managing the "state" for page-tree and file-tree related contexts in the backend user-interface like this: * `top.fsMod.recentIds.web` contained the current ("recent") page or file related identifier details were shown for * `top.fsMod.navFrameHighlightedID.web` contained the currently selected identifier that was highlighted in page-tree or file-tree * `top.fsMod.currentBank` contained the current mount point or file mount ("bank") used in page-tree or file-tree To get rid of inline JavaScript and reduce usage of JavaScript `top.*`, mentioned `top.fsMod` has been deprecated and replaced by new component `ModuleStateStorage`. Reading data from `top.fsMod` is still possible as a fall-back. Resolves: #94762 Releases: master Change-Id: I9e02a1e4c59ad3a007f5244197c1cdaa2a31ce22 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67680 Tested-by: -
Benni Mack authored
This patch updates bootstrap to version 5.1.0, introducing several bugfixes. See https://github.com/twbs/bootstrap/releases/tag/v5.1.0 for further reference. In addition, Popovers now contain the option to allow HTML at any time (HTML is sanitized by default). Executed commands: yarn add bootstrap@^5.1.0 --cwd Build/ yarn add --dev @types/bootstrap@^5.1.0 --cwd Build/ Resolves: #94752 Releases: master Change-Id: I22923798288b69e9bcab61d12ce8527030527c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70294 Tested-by:
-
Robert Kärner authored
The checkbox "t3-form-field-eval-null-checkbox" lost its former CSS class "checkbox" and thus its attribute "position: relative". This happened during the recent change to streamline checkboxes in the TYPO3 Backend. This change adds the missing attribute, so that the checkbox is no longer obscured by the "t3-form-field-disable" overlay, which prevented all mouse interactions. Resolves: #94817 Related: #93310 Releases: master Change-Id: I1fba185f58cd927eb186e39feab5c6d9c783315a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70451 Tested-by:
-
- Aug 10, 2021
-
-
Oliver Bartsch authored
The clipboard related header links are refactored to not longer rely on inline JavaScript, but to use event listeners instead. Resolves: #94777 Releases: master Change-Id: I457b2b334672c5c4b727cf733e30adfb7817c677 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70396 Tested-by:
-
Nikita Hovratov authored
Since bootstrap v5.0.2 the popover module removes empty title and content html nodes. This plays however against our strategy to load csh text on demand. To prevent the automatic removal, an empty p-tag is set in the data-bs-content attribute. In addition this fixes another two small bugs: 1. Remove the unexpected argument in the setContent method. 2. Add a new update method in Popover to update the arrow position after fetching csh text. Resolves: #94482 Releases: master Change-Id: I70ba510b793e10fa6b096d9f8bf54ccf1a823a19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69719 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benni Mack authored
This change replaces an inline JavaScript code to update the form URL of the constant editor to jump to the last changed field when saving the Constant Editor module. Resolves: #94770 Releases: master Change-Id: I7a387dd2cd8ba1d5d89f0a2484bc9305b964c0d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70341 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
