- Sep 03, 2021
-
-
Benjamin Franzke authored
EventDispatcherInterface injection is easy here, therefore lets to so in order to avoid the discouraged global lookup via GeneralUtility. Also refactor to inject other dependencies. Resolves: #95101 Releases: master Change-Id: I4c6db4bbb5e0f10121b75cef5bd57956c093d2b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70883 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benjamin Franzke authored
Services are now able to control the component name that an injected logger is created with. This allows to group logs of related classes and is basically a channel system as often used in monolog. Therefore and as preparation for future monolog logging, the attribute is named Channel. The Channel attribute is supported for constructor argument injection as a class and parameter specific attribute and for LoggerAwareInterface dependency injection services as a class attribute. This feature is only available with PHP 8. The channel attribute will be gracefully ignored in PHP 7, and the classic component name will be used instead. Releases: master Resolves: #95079 Related: #95044 Change-Id: I4b710677bc20c4200fc14b299865f4c7f95e4d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70849 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
11nd11 authored
The modals duplicate form and reference overview have been adapted to the new styling of the new form wizard. * Clean up markup and use common colors of TYPO3 v11 * Use new common styles and elements for better overview and modern look Resolves: #95085 Releases: master Change-Id: I6b1fc1332230c9bb966184d66944875ec7ebc4dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70878 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Tobias Siegler <siegler.tobias@googlemail.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Tobias Siegler <siegler.tobias@googlemail.com> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
11nd11 authored
Streamline and optimize styling and markup of the new form wizard of form manager. * Clean up markup and use common colors of TYPO3 v11 * Optimize UX and Overview of the new form wizard * Use new common styles and elements for better overview and modern look Resolves: #94805 Releases: master Change-Id: I0be4753be8d414db848453a0e4db941a8b127676 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70681 Tested-by:
Tobias Siegler <siegler.tobias@googlemail.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Tobias Siegler <siegler.tobias@googlemail.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Oliver Bartsch authored
A new PSR-14 based event "ModifyClearCacheActionsEvent" is introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['additionalBackendItems']['cacheActions'] hook, which is now marked as deprecated, along with its interface "ClearCacheActionsHookInterface". The new event features the same functionality as the hook. Additionally a new convenience method `add` is available for the class properties, allowing extension authors to add their custom actions more easily. This might be the most common use case for using this event. Resolves: #95083 Releases: master Change-Id: I1e621a00b04cdf43978a6e982b66c397e9437a29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70870 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
A new PSR-14 based event "AfterFileCommandProcessedEvent" is introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_extfilefunc.php']['processData'] hook, which is now marked as deprecated, along with its interface "ExtendedFileUtilityProcessDataHookInterface". The new event features the same data, however the way they can be accessed is improved. The previous `$action` and `$cmdArr` arguments are now available within the `getCommand()` method, while the action is the array key and the command data ($cmdArr) is the value. This is more in line with the actual request. The hooks `$result` argument always contained all results of previous operations, making it unnecessary complicated to find out the actual result for the current operation. This is now resolved. The new `getResult()` method only returns the result for the currently executed operation. Finally the "getConflictMode()" method just returns the conflict mode, used for the current operation. Resolves: #95089 Releases: master Change-Id: I9991eb73aed873da5987f88d2d0255764274e143 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70874 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Andreas Fernandez authored
A new TCA config `treeConfig/startingPoints` is introduced for selectTree and category to allow multiple "roots" for the rendered tree. This new settings superseds and deprecates `treeConfig/rootUid` being capable of rendering only one root node. To be able to re-use `AbstractItemProviderparseSiteConfiguration()` without the implicit quoting, the method is split into separate parts. Resolves: #95037 Releases: master Change-Id: I3361daeed10b0f1ac1f8fa879850f79f4a85e23a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70819 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Tomasz Woldański authored
Right now some properties returns empty string or null when value is empty. i.e. title (null when empty), target ('' string when "empty"). Patch makes all serialized properties behavior consistent (null on empty string values). Resolves: #95097 Related: #94889 Releases: master Change-Id: Ib9e6db04bfc165e8dd32bb5092f33f7862696941 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70881 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Helmut Hummel authored
Also introduce internal PathUtility API to resolve the web path of extension resources and a helper public API method to check whether a path is an extension resource path. Start using the new API throughout the core. All checks of EXT prefix are replaced, further usages of getAbsoluteWebPath will be replaced in subsequent patches. Releases: master Resolves: #95022 Change-Id: I27994f309af8b35ad3822a5be59d81d164fa9cd0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70805 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Jochen Roth authored
Some acceptance tests fail radomly due to speed/timing of the checked elements or unresolved promises. This should be avoided now by using "waitForElements" instead of "canSeeElement". This may cause longer test runs but makes sure tests won't fail on performane hiccups. On top of that Icon.getIcon in DocumentSaveActions will catch unresolved promise in case a new page or reload was triggered by the button to avoid Javascript errors. For example in Scheduler -> Add Task and hit save. Resolves: #95070 Releases: master Change-Id: I927876ecfd46cbc2edae03db249982fcb8a9d2f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70860 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Paul Hansen authored
Simplify the Form Management list view by showing the pagination widgets only when there are multiple pages of forms in the list. Resolves: #95081 Releases: master Change-Id: I752933fbc26233cbe484841734e0d30ea6d1a132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70873 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Benjamin Franzke authored
Logger instances may be required to be available during object construction, LoggerAwareInterface isn't an option in that case. Therefore LoggerInterface as constructor argument is now autowired (if the service is configured to use autowiring) and instantiated with an object-specific logger. We add a symfony compiler pass that prepares an inline factory which fetches the appropriate Logger instance from the LogManager. One of the TYPO3 core classes that require this is the Scheduler. Scheduler used to contain a safety net which fetches a logger instance from LogManager in case the logger is already needed during the constructor invocation. In that case the logger was not available, as it was injected via setter injection (setLogger) later (per LoggerAwareInterface). Releases: master Resolves: #95044 Change-Id: I57539a731a305da6abc092d2383e2d2f4c1d985c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65449 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
- Sep 02, 2021
-
-
Tomasz Woldański authored
This change introduces a new immutable object "LinkResult" along with an interface, containing the base result of a generated link by TypoLink. This object contains all information needed to put together a <a> tag or return a pure URL. For the time being this new class is used to build links from the typolink link builders, and in addition should be able to be returned fully by typolink in the future. In addition, this object helps to build links needed for e.g. JSON responses to contain all information of the link to be serialized. Resolves: #94889 Releases: master Change-Id: Ic9383a1a0f0ec93ba3aa352235003268e00a2f10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70590 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
A new PSR-14 based event "ModifyFileDumpEvent" is introduced in favor of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['FileDumpEID.php']['checkFileAccess'] hook, which is now marked as deprecated, along with its interface "FileDumpEIDHookInterface". In contrast to the hook, the new event also contains the PSR-7 Request and additionally allows to replace the file, being dumped. Resolves: #95080 Releases: master Change-Id: Idbb0f2f38678c12e752e2255aa71853362f8cc46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70865 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
The original message got immediately overridden with the template representation. This is now fixed by using a different variable name. Resolves: #95084 Related: #94315 Releases: master Change-Id: I478ed832ca8944b3829a11640033882c3f50c546 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70869 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benjamin Tammling authored
Add ViewHelperResolverFactoryInterface and use it for dependency injection. ViewHelperResolverFactoryInterface is specified via ServiceProvider.php since it is needed in FailsafeContainer (install tool). Since ServiceProdiver.php itself is not API, ViewHelperResolverFactoryInterface isn't either. This will evolve over time in core. For now, we still need this interface already for some extensions edge cases, though. ServiceProviderCompilationPass is adapted to avoid alias resolution when providing factories for interfaces. Otherwise the aliased service is configured instead of the interface itself. Resolves: #95076 Releases: master Change-Id: I882fb3d1bfee65dea44d9ee4f4d7bc39275ab10e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70831 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Praetorius <simon@praetorius.me> Tested-by:
Benjamin Tammling <benjamin.tammling@sitegeist.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
Benjamin Tammling <benjamin.tammling@sitegeist.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Nikita Hovratov authored
Collection types of persistent domain objects are already resolved. This patch adds this feature to the normal ObjectConverter. This is especially useful when making use of DTOs. Resolves: #93197 Releases: master Change-Id: Ia21ba9e5870f3c17c6a4fad9e51335ed236ef239 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67320 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
A new PSR-14 based event "ProcessFileListActionsEvent" is introduced in favor of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['fileList']['editIconsHook'] hook, which is now marked as deprecated, along with its interface "FileListEditIconHookInterface" Resolves: #95077 Releases: master Change-Id: I24ea2a5871530c0e6a7b2316d3b574508e3e1687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70835 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Marvin Dosse authored
Pages with doktype > 200 had not been considered in the sql query. Now all doktypes are being fetched except for the spacer, sysfolder and recycler. Resolves: #94814 Releases: master, 10.4 Change-Id: I8a0165ceaccd89724501ecd01bfba6cebad6efa4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70492 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Marvin Dosse <marvindosse@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Marvin Dosse <marvindosse@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Mathias Brodala authored
The "Non-XML text" validator has been removed form the UI of the form editor. Here's why: * The validator has a very specific purpose since it is only useful for values which are output in an HTML context without escaping. By default, this is never the case in TYPO3 thanks to the automatic escaping in Fluid. * The form editor is meant to be used by editors and integrators where the most usecases involve output of form values within TYPO3 (website / mail). This validator does not serve any purpose then. * The form editor should be uncluttered and stripped from too technical and complex concepts. Resolves: #94876 Releases: master Change-Id: I19855d8732ce7ff79370c679763e007f7313d77f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70575 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Björn Jacob authored
The documentation now contains a chapter which describes how to access single form values in finisher templates. In addition the chapter "Frontend Rendering" has been rearranged. That way, the more important aspects for integrators are moved to the top. Resolves: #88510 Releases: master, 10.4 Change-Id: I7cc77e66829b1e0e4dd0677ceec979ac7a9f02e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70574 Tested-by:
core-ci <typo3@b13.com> Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
waldhacker <hello@waldhacker.dev>
-
Benni Mack authored
This change adds a new PSR-14 based event to hook into the booting process after all configuration has been set up and TYPO3 has fully booted. This event replaces the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['GLOBAL']['extTablesInclusion-PostProcessing'] hook and its interface TYPO3\CMS\Core\Database\TableConfigurationPostProcessingHookInterface Resolves: #95065 Releases: master Change-Id: Ibe6f1b255d641f2dd8fc85c2abbaf5e4c43d7ae6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70834 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Jochen Roth authored
Docker for Mac (and Windows?) currently misuses their users as canary testers by actively activating an "experimental" feature toggle which then ships a docker-compose v2 rc release. docker-composer v2's yaml parsing however is broken (you had ONE job!): It does not properly detect strings as strings and mumbles about this, and worse, it transforms shell "don't linebreak!" '\' operator into linebreaks. This breaks our carefully crafted and formatted testing related docker-compose.yml configuration. The situation persists for weeks already, there is no solution except manually disabling this docker for mac experimental feature toggle. The patch makes runTests.sh detect docker-composer v2, exits out with an error message telling the version is not supported and how to disable it. ddev went with a similar approach recently. Resolves: #95057 Releases: master, 10.4, 9.5 Change-Id: Iee1e6fd28d876262f00aba769a7e047c14db903c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70845 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
The multi record selection component, introduced in #94906, is now added to the recordlist as well. Since the component is not bound to the clipboard functionality, this will solve a lot of issues, editors faced when trying to perform actions for multiple records at once. For example, it was previously required to activate the clipboard, change to a numeric "pad" and to copy records to this pad, before any action could be performed. This patch also resolves some smaller bugs related to clipboard actions and does some code cleanup in the DatabaseRecordList class as well as in the corresponding JavaScript module. Resolves: #95068 Related: #94906 Releases: master Change-Id: I5bd3120f71cd4043d778f8116b3cf643b6e72064 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70803 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Wouter Wolters authored
The following core extensions are handled: * EXT:impexp * EXT:indexed_search Resolves: #94893 Releases: master Change-Id: I257d8ea33e1b4b7b04825dd92c443d0fb134293b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70602 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Elias Häußler authored
Since #63920 it is no longer required to have a trailing slash for the first argument $directory in GeneralUtility::mkdir_deep(). Therefore, the appropriate phpdoc has been adapted to avoid further confusions. Resolves: #95073 Releases: master Change-Id: I2a5cedcf5ce78f0ac375f79e340d775d40681535 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70862 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
This is a pre-patch for #95068, simplifying some code in list modules. In detail: * Multi record selection now uses a dedicated class for modules, adding the actions into a "panel" * To prevent JSON parsing errors, the action configuration is now encoded using GeneralUtility::jsonEncodeForHtmlAttribute * The code to add the "new record" button in DatabaseRecordList is streamlined Resolves: #95071 Releases: master Change-Id: If83cef25eee5976b916e9167ca25569749a5d3ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70861 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 01, 2021
-
-
Benjamin Franzke authored
The Build/composer/ directory (recently added in 95046 ) contains all core files (symlinked) once `composer install` has been executed, that means both typoscript and typescript files that end with .ts. This leads to compilation errors. These files must actually be ignored by `tsc` during `grunt build`. and should not be compiled at all (wasted ressources). While at it we also fix the tsconfig.json to include a trailing newline, in order to comply to our coding guidelines. Releases: master Resolves: #95046 Related: #94996 Change-Id: Ic8d4a4af1004e0f8c9ae5c4832b54e1018055ec2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70830 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Jochen Roth authored
The table editor is currently accessed by using a seperated wizard next to the bodytext field. On each and every "edit" a user needs to click this button to get the table editor. This has been changed by moving the table editor to the regular content edit view and replaces the text area with the table editor. The fields 'table_delimiter' and 'table_enclosure' are not working as expected, but this is not touched by this patch but will hopefully be taken care of in the future. Resolves: #95036 Releases: master Change-Id: I9497987f9d64774b2d1272e4c269ef766caf760c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70823 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Christian Kuhn authored
Specification of proper MM table layouts within TYPO3 has been troublesome ever since. There is a huge amount of possible "MM_*" TCA column field properties that have impact on a "true" MM table layout. Neither core itself, nor extensions tend to get that right. To simplify extension developers life, this patch adds a "default TCA schema" definition for MM tables. Extension developers are encouraged to drop their "MM" table definitions from ext_tables.sql. By doing so, they hand over control of those tables to the core, so core can manage and adapt schema if needed. The impact is shown with irre_tutorial extension: It can drop two definitions from ext_tables.sql, as well as ext:core's ext_tables.sql, which drops the specification of sys_category_record_mm. ext:styleguide has cases, too. Next to the business code in DefaultTcaSchema, the patch adds a series of @todo comments to the involved code, pointing out issues with current MM handling. This feature patch acts as a pre-patch to fix these. Change-Id: I95fa55416ee460cbe93d3d770c532a4f1e224608 Resolves: #95061 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70844 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
This change adds a new button to all files and folders to directly download a specific file from the file list or the context menu. In case a folder or multiple files/folders are selected, a zip file is created on-the-fly. Resolves: #90548 Releases: master Change-Id: I666d4b377b995bd95c0a8f0ca95b03fd45d05a0b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70820 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Stefan Bürk authored
Argument $skipSorting of RelationHandler->writeForeignField() is used to pass $callFromImpExp from DataHandler. The ext:impexp related @internal $callFromImpExp DataHandler property however is never used and thus obsolete itself. The patch drops DataHandler->$callFromImpExp and deprecates last RelationHandler->writeForeignField() argument. Resolves: #95062 Releases: master Change-Id: If91c2de1e762c97fb50a72c84698a849df807bf2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70848 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
The "Application Information" menu is now able to show an enabled debugger and its version, if available. Supported debuggers are xdebug and Zend Debugger at the moment. Resolves: #94966 Releases: master Change-Id: I33e30c06e39fadf2d2e243bc4d0ee511c90850d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70727 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
This resolves some problems on using the clipboard in the filelist module. Previously it was for example not possible to transfer files / folders to the clipboard again, after it was cleared, since the corresponding GET parameter was kept in the URL. This is now fixed by assigning the action to the filelist form. Further topics: - Pagination does now use the correct colspan - setCB and delete actions are now handled via multiple record selection events and do not longer rely on "trigger classes" - the superfluous internal "selectedElements" array is removed again, since the display of actions is handled by the multi record selection component anyways Resolves: #95055 Releases: master Change-Id: Iff15716e09d149ed29d72b1ae45e88ba2a43b92d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70841 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
Since #94944 the multi record selection allows keyboard shortcuts for an improved UX. It's for example possible to select ranges. Therefore, the last checked element and the current target are used to determine the range. Any operation in case no valid shortcut is used. This however prevents the last checked element from being set. As a result the range determination did not longer work reliably. This is fixed by moving the shortcut check into the already existing guard clause, which does properly set the last checked element. Resolves: #95060 Related: #95034 Releases: master Change-Id: Ibc1c2fdc314b58af3848a4934d1f5e0124de2e55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70847 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Aug 31, 2021
-
-
Christian Kuhn authored
Resolves: #95050 Releases: master, 10.4 Change-Id: I6e837617ec291812684ce6d481d84e2be635655f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70833 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Nikita Hovratov authored
The correct key is "uid" rather than "id". This got changed by accident in #94663 (9d7e4758). Resolves: #95056 Related: #94663 Releases: master Change-Id: I405de598bd7019aef56a53923a1ea7753fc65bc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70843 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
Bootstrap 5 dropped the support for data-bs-toggle="buttons". See: https://github.com/twbs/bootstrap/pull/30650 The replacement is to use the class "btn-check" in combination with the state of input fields. This has been done in the Localization module. Some other occurrences didn't rely on the bootstrap js and it was enough to simply remove the data attribute. Also remove a forgotten console.log debug. Resolves: #95048 Releases: master Change-Id: Icd31e7cc0cb9eb1581a7bcfe1448ed7dad24a935 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70832 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andrzej Kołbuc authored
Count Result query now will respect "Show even deleted entries" checkbox Resolves: #94865 Releases: master, 10.4 Change-Id: I2ed3a00f0c0d3e7f31e852a3bd2af5c83d393edf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70546 Tested-by:
core-ci <typo3@b13.com> Tested-by:
kharaf <k.haraf@macopedia.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Jonas Eberle <flightvision@googlemail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Andreas Fernandez authored
This patch groups Grunt tasks that can run simultaneously to improve the build performance. To achieve this, the package `grunt-concurrent` is used. On a 2018 Dell XPS 15 with Intel i7-9750H this saves roughly 12 seconds. To check the difference, the command `time grunt build` was executed twice: Sequential build: 48,09s user 10,06s system 154% cpu 37,565 total 50,60s user 11,89s system 154% cpu 40,539 total Parallel build: 77,91s user 5,96s system 261% cpu 28,311 total 67,43s user 5,05s system 262% cpu 27,619 total Due to issues with `grunt-contrib-imagemin`, the subscript `imagemin` is excluded from the `minify_assets` group for now. Resolves: #95016 Releases: master Change-Id: Ic12ff7c0cb43cd0ab050e3e7d1a3a783038189b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70244 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com>
-