- Nov 17, 2022
-
-
Andreas Fernandez authored
In TYPO3 v8, a "rebounce" protection was added to deny overscrolling the document on iOS devices (aka "rubber band effect"). This caused an issue in #98348 where the shortcut menu opened to the wrong side and the rubber band fix got partially reverted, breaking modals where the content is intended to be scrollable. Also, the scaffold is "broken" on Apple devices as `100vh` is treated as "100vh if the address bar is shrunk", leading to a larger and thus scrollable scaffold when using `overscroll-behavior: none` [1], which would've been the preferred solution to solve the scrolling issue. The solution for the scrollable scaffold are dynamic viewport units [2], but those are not supported in all browsers, yet, and also revert `overscroll-behavior` (tested with iPadOS 16.1). To have the original issue fixed somehow, a workaround now adds the CSS class `with-overflow` to the `body` tag to all iframes rendered in modals. [1] https://caniuse.com/css-overscroll-behavior [2] https://caniuse.com/viewport-unit-variants Resolves: #98710 Related: #98348 Releases: main Change-Id: I13159cb1894aa76f81a91b8b80863a9dcfbc1970 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76236 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Stefan Bürk authored
RootlineUtility uses a multi-staged cacheing logic. This contains the use of a dedicated rootline-cache, but also two static class internal caches. Static property caches are a horrable nightmare when it comes to keep proper clean state between test executions, beside it's a not really needed state on a non-static class. This change aims to replace the static property caches in RootlineUtility with the core runtime cache. Thus making the static properties obsolete, but keeping it until testing-framework can deal with the absence of the static properties. Remove them! `RootlineUtility::purgeCaches()` calls are replaced now with core runtime cache flush calls using tags to avoid flushing other unrelated runtime cache entries. This makes this method obsolete. This method was declared @internal, eliminate it! Additionally, default `$rootlineField` merging with the `$GLOBALS['TYPO3_CONF_VARS']['FE']['addRootLineFields']` is moved from RootlineUtility constructor to the only method using it, namely `getRecordArray`. In the same we changed it from static to non-static, as there is no need anymore for having it static. "typo3/testing-framework" has been made aware of these changes and deals with absent of these properties and method, but keep doing the guarding steps if they are still exists. See: https://github.com/TYPO3/testing-framework/pull/423 > composer u typo3/testing-framework Resolves: #99100 Releases: main Change-Id: I5fdcabd1c3727f020abc7d8bdbcf1f0276b715a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76637 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- Nov 16, 2022
-
-
Benni Mack authored
This change updates some comments for better understanding TYPO3-internal system languages vs. locales, and makes the class strict. Also the type annotations are more specific now, and an additional type check has been introduced. Resolves: #99108 Releases: main Change-Id: I9ea61bed9770c9b5a13bd7cdbb1da8e889905dca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76644 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Bürk authored
Implementing class internal caches has been done in the past, which however came with a lot of headaches. Mainly in tests it's a epic quest to properly clear the state between test runs, but it's not a good design at all. Some work has been already done to make static class `\TYPO3\CMS\Core\FormProtection\FormProtectionFactory` injectable through the DI container, which moved some parts from static to the instance part. This allows us to transform methods from static to non-static. This change injects the runtime cache, if the class is instanciated through the DI. Thus the internal static property cache for instances is removed. Tests are adjusted. TestCases testing deprecated method are moved to the UnitDeprecated to avoid failing tests. Resolves: #99098 Related: #98696 Related: #98627 Releases: main Change-Id: Ib92bb9f73f3b1bbb4995ef01c53ca973588528bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76634 Tested-by:
-
Andreas Fernandez authored
The file backend.js contained some basic preparations for the backend context that are partially not required anymore. The remaining settings are converted to a global assignment set in BackendController. The `window.name` property is now hard-coded to be `typo3-backend` for use with the EXT:adminpanel, which requires some changes in acceptance tests as `window.name` had an empty value before. `window.opener` is nulled, otherwise, this might cause issues with inter-frame communication if the backend was e.g. opened via a link in an email. With the remaining assigned being migrated, backend.js serves no purpose anymore and is dropped now. Resolves: #99101 Releases: main Change-Id: I1b92184c1e5063f7a494c62060adfb5b67a2878e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76607 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99106 Releases: main, 11.5 Change-Id: Iabddf0b2f1c98db6e3e07f26162257f696d6fd9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76642 Tested-by:
-
Torben Hansen authored
Note, that the argument usage in callback return functions had to be adjusted. Also, mocking of the `quote` function for sqlite tests had to be adapted to match the actual amount of consecutive calls. Resolves: #98805 Releases: main Change-Id: I95e4fb1941292cff7dcf6f4616c2eb768e17c43d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76641 Tested-by:
-
J. Peter M. Schuler authored
Resolves: #99107 Releases: main, 11.5 Change-Id: If5e9d1acf81bf2913405e18cc38f2a7ad5ee62cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76643 Reviewed-by:
-
Andreas Fernandez authored
Multi-step wizards may contain a lot of different steps (e.g. in localization or form management) and accidentally closing the wizard by clicking the backdrop may lead to frustration. To prevent this issue, the backdrop of such wizards is now static. Resolves: #99102 Releases: main Change-Id: I7e7adf6a8e30cc067fbadd73016cf01ec9bdf4d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76639 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benjamin Kott authored
The module menu button bar now can display dropdowns. This enables new interface interactions, like switching the current view from list to tiles or group actions like clipboard and thumbnail visibility. It will help declutter views and help the user to see more information at a glance. Each dropdown consists of different items ranging from headlines to items links that can display the current status. The button will automaticly change the icon representation to the icon of the the first active radio icon in the dropdown. It is now implemented in the File List module to switch between Thumbnails and enable Actions like Clipboard Resolves: #99093 Releases: main Change-Id: I8c0498716d82c16e5b15bbe117fccd772d13a655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76602 Tested-by:
-
Andreas Fernandez authored
The Modal API is now able to render a static backdrop to avoid closing the modal when clicking it which may come in handy in case closing the modal would result in a negative user experience, e.g. in the image cropper. The new boolean configuration option `staticBackdrop` controls whether a static backdrop should be rendered or not, defaulting to `false`. The trigger class "t3js-modal-trigger" also supports the new option by setting corresponding data attribute. Resolves: #99092 Releases: main Change-Id: I0e1c7753944b41d5266aa6232d1fa838752f95b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76605 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Stefan Bürk authored
Some changelog files containing invalid Sphinx syntax, thus adding warnings during documentation build. This change adjusts some changelog files to avoid these warnings. * use correct link target syntax * ensure correct usage of code blocks Resolves: #99099 Releases: main Change-Id: Ib883ed6cb94bad98f5eb0d893d008728a3e1dc2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76636 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
- Nov 15, 2022
-
-
Oliver Hader authored
* actually use `array_filter` internally * allow using `array_filter` modes `ARRAY_FILTER_USE_KEY` and `ARRAY_FILTER_USE_BOTH` Resolves: #99071 Releases: main, 11.5 Change-Id: I1b95ae0a7551250125a9eeabbd0ee7e66e25a6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76571 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Christian Kuhn authored
We will soon have additional TypoScript TreeBuilder classes, for instance one related to TsConfig. Rename the Frontend TypoScript related TreeBuilder to SysTemplateTreeBuilder to improve namings. Resolves: #99096 Related: #97816 Releases: main Change-Id: I32dbd8aae87614d0a2a7d6aaa21e0f71059242a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76611 Tested-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
-
Chris Müller authored
Resolves: #99085 Releases: main, 11.5 Change-Id: Ie3b337b93f43fb2c41d76427f29d793b57e9232b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76598 Tested-by:
-
Chris Müller authored
Resolves: #99037 Releases: main, 11.5 Change-Id: I86cf8b64c198d1707dc3c5f385c6ee19ffa5960c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76581 Tested-by:
-
Christian Kuhn authored
Minor class modification to make the code more dense, more strict and reduce duplication. Resolves: #99094 Releases: main Change-Id: Iac3e7926dd16351ae0e0e7c45dfd099aa2eb61b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76608 Reviewed-by:
-
Christian Kuhn authored
Create a functional test form the rather heavily mocking unit test, and streamline. Resolves: #98773 Releases: main Change-Id: I9f2275394a2f644e8e707dc3218868dbbea63e06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76609 Tested-by:
-
Christian Kuhn authored
The default configuration of new typoscript cache has been accidently added twice: In ext:frontend ext_localconf.php and in DefaultConfiguration.php. Remove the one from ext:frontend. Resolves: #99095 Related: #97816 Releases: main Change-Id: I94eff13d894b9e22bc61b61fb29546dcfd695d96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76610 Tested-by:
-
Benjamin Kott authored
The context menu JavaScript API was adapted to also support opening the menu through the "contextmenu" event type (right click) only. Configuration for the context menu was streamlined and now reflects its purpose. The trigger can now be set to "click" or "contextmenu". Before: class="t3js-contextmenutrigger" data-table="pages" data-uid="10" data-context="tree" After: data-contextmenu-trigger="click" data-contextmenu-table="pages" data-contextmenu-uid="10" data-contextmenu-context="tree" New options: data-contextmenu-trigger: click: Opens the contextmenu click and contextmenu contextmenu: Opens the contextmenu only on contextmenu Examples: <a href="#" data-contextmenu-trigger="click" data-contextmenu-table="pages" data-contextmenu-uid="10" > Click and Contextmenu </a> <a href="#" data-contextmenu-trigger="contextmenu" data-contextmenu-table="pages" data-contextmenu-uid="10" > Contextmenu only </a> Legacy configuration with `.t3js-contextmenutrigger` is still supported to avoid migration issues, but is now considered deprecated and will be removed with TYPO3 v13. Resolves: #99084 Releases: main Change-Id: I1a8429b2964f0372b3162994f49f4c1141dffc86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76595 Tested-by: -
Nikita Hovratov authored
The "icon-emphasized" class has been recently introduced for FontAwesome replacement and should be used consistently. Resolves: #99087 Related: #99038 Releases: main Change-Id: I86ee49446ed91ec44efb579bc50b6263fb2a8479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76600 Tested-by:
-
Christian Kuhn authored
Resolves: #99088 Releases: main, 11.5 Change-Id: I67f799fdca4d736c36775d50b5ac753eba93ba52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76601 Tested-by:
-
- Nov 14, 2022
-
-
Benni Mack authored
BackendUtility::getPossibleWorkspaceVersionIdsOfLiveRecordIds() is added to check for workspace versions within FormEngine foreign_field logic to first fetch a list of all records that have a versioned record within the workspace, and only apply BackendUtility::workspaceOL() for these cases. Without the patch, each live record triggers a database query to resolve a possible workspace overlay. With the patch, one query is done to see which records have workspace overlays, only those are queried for overlays. This reduces the number of performed queries a lot, since typically only a small number of records are overlaid. This only affects editing records in a workspace. Resolves: #99007 Releases: main, 11.5 Change-Id: Ia7c47e5de0082ca0ff2c68b30d9ff1bc5312981b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76446 Tested-by:
-
Benjamin Kott authored
The custom element typo3-backend-column-selector-button is a valid HTML and should be used as such. There is no need to nest buttons/links inside the element to add CSS styling. We are adding keyboard events to react on the "Enter" and "Space" keys to mimic the behavior of a button and setting defaults for the role and tabindex to make it keyboard accessible. CSS classes are now directly set to the element itself. Resolves: #99080 Releases: main Change-Id: I71dfa68174255a5d445af5fadbf1924b54a6b687 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76593 Tested-by:
-
Daniel Ziegenberg authored
Resolves: #99082 Related: #99038 Releases: main Change-Id: Icefd1b4ac8a2ae4cefee51ac9cecfd24e4f989a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76597 Tested-by:
-
Christian Kuhn authored
TSconfig plays an important role in the Backend: It configures rendering and behavior details in the Backend and can be set on pages, be_users and be_groups field, leading to UserTsConfig and PageTsConfig. Frontend users and Frontend groups have this as well on database level, together with an API in class FrontendUserAuthentication. This was probably added in the old days to allow a similar thing as Backend TSconfig for Frontend users as well. It is however unused by the core and there seems to be only a very limited number of extensions that ever used this. Developers think of "TSconfig" as Backend specific things, and that's how it should be. To reduce confusion, the patch deprecates the TSconfig database fields in fe_groups and fe_users table along with the PHP API. Resolves: #99075 Releases: main Change-Id: I599670bf5e87eee4aa5e1ba353da1e7dc9351702 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76578 Tested-by:
-
Christian Kuhn authored
> composer u typo3/testing-framework Resolves: #99078 Releases: main Change-Id: I937487add61afc30509c898004b55a62d6cb80c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76592 Tested-by:
-
marcus@schwemer.de authored
Adds a submodule to the beuser module, which provides an overview over all filemounts and allows them to modify, hide, delete and add those. Resolves: #99038 Releases: main Change-Id: I2769ad34562c0428226da4abe1ab79077fc52475 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76547 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- Nov 13, 2022
-
-
Stefan Bürk authored
NoopEventDispatcher was originally a text fixture class to help during testing. This class has been made available to extension developers with #99070. However, #98808 has been mergend without prior rebasing and having wrong namespace for this class in a test class. This change now uses the correct namespace to ensure tests are working again. Resolves: #99076 Related: #99070 Related: #98808 Releases: main Change-Id: Ibe28b8e56b18c6899e3a1935e97e6df9e68803d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76582 Reviewed-by:
-
Torben Hansen authored
Resolves: #98808 Releases: main Change-Id: I24bbb0b74a238e2488fd60c67d502bba7fa3079c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76579 Reviewed-by:
-
Benni Mack authored
The latest Doctrine DBAL 3.5 is similar to Doctrine DBAL 4, which is what we want to use in the future. Used command(s): > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/core > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/install > composer req "doctrine/dbal":"^3.5.1" \ --no-update -d typo3/sysext/redirects > composer req "doctrine/dbal":"^3.5.1" Resolves: #99072 Releases: main Change-Id: I62eaa0cd0c759ecc58c40d3b12dd751fd1b47bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76564 Tested-by: -
Torben Hansen authored
Resolves: #98806 Releases: main Change-Id: I9e87fd549f0fbc29fc392cc73944d92fbc83ddb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76580 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98754 Releases: main Change-Id: I5b11bea380acbce339e37bff4efc117cbeef769e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76575 Tested-by:
-
Nikita Hovratov authored
Resolves: #98752 Releases: main Change-Id: I8b5229ca9d2eb86072ae21a775d9368133cbba54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76573 Tested-by:
-
Nikita Hovratov authored
Resolves: #98751 Releases: main Change-Id: I5e127bebb5fdab914c535c7f16f1ff85ce1d9778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76572 Reviewed-by:
-
Nikita Hovratov authored
Resolves: #98753 Releases: main Change-Id: Ibd1b655f8d7563165683e4d8307c9445ac9d3398 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76574 Tested-by:
-
Nikita Hovratov authored
Resolves: #98755 Resolves: #98756 Releases: main Change-Id: If8484ba37f25cceb7a2d35dfc22717d95c122716 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76576 Tested-by:
-
- Nov 12, 2022
-
-
Oliver Klee authored
With the class moved out of the `Tests` namespace into the general `EventDispatcher` namespace, extensions can now also use this class for their tests. Also add unit tests for the moved class. Resolves: #99070 Releases: main, 11.5 Change-Id: I69b94f50f68dcacfe036e8eb489ba6b82fbb585a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76569 Tested-by:
-
Torben Hansen authored
Resolves: #98809 Resolves: #98810 Resolves: #98811 Resolves: #98812 Releases: main Change-Id: I043c797873be9df1ce1356fd4c3425bc0018673a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76567 Tested-by:
-
Andreas Fernandez authored
This patch updates `moment-timezone`, having a fixed vulnerability, along with the related `moment` library. In the same run, dev depencendies are updated as well. Executed commands: npm install --save \ moment@^2.29.4 \ moment-timezone@^0.5.38 npm audit fix npm run build Resolves: #99061 Releases: main, 11.5, 10.4 Change-Id: I36376bad194aa63dda0146c8bc0f481b932dc89d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76556 Tested-by:
-
