- Apr 20, 2020
-
-
Oliver Bartsch authored
The check if a user is allowed to paste content from the clipboard now evaluates the content modify and content edit permissions instead of the page edit permission. This is done in both PageLayoutView and the fluid based page module. Resolves: #90961 Releases: master, 9.5 Change-Id: I65a29a9a6cf4ae4e73af28d1319d0b730fd5f5bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64105 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
Benni Mack authored
Due to the fact that backend user objects have not been initialized properly in PSR-15 middlewares defining the current in-memory state for workspaces falls back to the users' default workspace. Basically `BackendUserAuthentication::groupData['workspace_perms']` was not initialized which results in the mentioned behavior for non-admin users. `fetchGroupData` was split up into public `initializeGroupData` to be used internally only and protected `enrichGroupData`. Resolves: #90954 Releases: master, 9.5 Change-Id: I75ad15ac600ca489b9951199482e97bcb54d1778 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64264 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Benni Mack authored
Due to the replacment of DocumentTemplate with ModuleTemplate the rendering is now different. In order to overcome this, a new flag enableDocHeader is added. see https://review.typo3.org/c/Packages/TYPO3.CMS/+/63290 Resolves: #90834 Releases: master Change-Id: Ifb278f7dff1c9b1e18b09f7587dbe33caff13732 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64261 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Remove wrong fourth parameter from the items array as this broke the whole column. Resolves: #91152 Releases: master Change-Id: I07f5a1d3fd3d25fadba88b54581ccbfc52184fb6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64266 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Georg Ringer authored
This reverts commit 47e63fc3 because of regressions. Resolves: #89989 Reverts: #88344 Releases: master, 9.5 Change-Id: I1f43d0f343484366e81581435bdb418cfebf317a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62832 Tested-by:
-
Claus Due authored
Provide the correct UID for the "edit record" link which edits the default language page record when page module is in "Languages" mode and the edit icon in top of default language's column is clicked. Releases: master Resolves: #91146 Change-Id: I17c415efdcbf80737d05982ec90a4ac62ce5abea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64258 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benni Mack authored
This patch prevents throwing and spamming the logs with 500 server errors. Resolves: #91145 Releases: master, 9.5 Change-Id: I9385a9c0a2a665cedb1340cc8397740b0bd6255e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64084 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Claus Due authored
Implements a PSR-14 event dispatched after LocalizationController has built the manifest of columns and column numbers, allowing third parties to change this manifest without XCLASS'ing LocalizationController. Releases: master Resolves: #90945 Change-Id: I5a7929512c498329841c51ceceba7b0d4c156594 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64071 Tested-by:
-
Jonas Eberle authored
This fixes some functional and visual problems in the ChangeLog: * The use of code backticks in a headline was removed as it was also output as <blockquote> on the overview page. * All warnings regarding intersphinx cross-referencing have been fixed. * The unsupported text role :mysql: has been replaced by :sql:. The rest of the warnings seem to come from the build command or will automatically be fixed after the master branching is done: WARNING: unsupported theme option 'show_sphinx' given WARNING: unsupported theme option u'show_legalinfo' given WARNING: unsupported theme option 'use_opensearch' given WARNING: unsupported theme option 'show_revision' given /Documentation/Master.rst:11: WARNING: toctree contains reference to nonexisting document u'Changelog/master/Index' Releases: master Resolves: #91118 Change-Id: I290bf8879bbee66f030a32de45ea765fd40a1b92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64237 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Josef Glatz authored
The option includeNotMenu is set to 1 if the CType menu_section is used to render a section menu for the current page even if the page is hidden in menus (pages.nav_hide). This patch adds also the necessary stdWrap functionality to the abstract class for hierarchical menus. Releases: master, 9.5 Resolves: #91044 Change-Id: I563390b4af36fb26e6a02df237563bdc48293048 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64183 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Gerrit Mohrmann authored
When resursive is set, the selected page is now added to the storagePids. Resolves: #91004 Releases: master Change-Id: Idb786c2495dd7ce6e740bc5e198e7bf05a962b5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64119 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. * unused properties in QueryView have been removed * onclick event on a submit button does not have any effect since the onsubmit event is handled first - corresponding code has been removed as well Resolves: #91111 Releases: master Change-Id: I51263b5cd71109d9a28d4edf3cb0b95097aab6b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64230 Tested-by:
-
Alexander Schnitzler authored
This patch adds an @deprecated annotation to the get method of the ObjectManager class of Extbase. Both the core and users use the object manager directly to create instances of dependencies, often like this: GeneralUtility::makeInstance(ObjectManager::class) ->get(Dependency::class); This is done to create an instance of an object along with it's own dependencies. Using the object manager directly is bad practice. Mandatory dependencies should be injected via constructor injection while optional dependencies may be injected via method and property injection. In both cases however, the underlying object container takes care of the dependency injection. This patch intentionally does not add a trigger_error call as the core itself still is a bad example and uses that technique itself a lot. Version 11.0 will remove all such usages and introduce the trigger_error call for user land code until the object manager is finally removed in version 12.0. Releases: ma... -
Susanne Moog authored
To ensure maximum compatibility, we only enable the new page module for new installations (or by manually enabling the feature flag) not for upgrades. Resolves: #91142 Releases: master Change-Id: I90f75c3caf1dd7447e4e406ee55303694f8f327d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64256 Reviewed-by:
-
Markus Klein authored
Make sure the TSFE fetched in TemplateService really is a valid TypoScriptFrontendController. This way any kind of "fake Frontend" built in Backend does not break the functionality. Resolves: #91139 Releases: master Change-Id: I571130de635f2be79301f747c5b3e1ad40987fec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64255 Tested-by:
-
Claus Due authored
Refactoring with the goal of: * Restoring entity-like nature of BackendLayout * Decreasing coupling between components of the page module processing and rendering. Implements a PageLayoutContext to hold all context-related objects and methods and passes the context to objects instead of passing the BackendLayout. Reduces number of methods on DrawingConfiguration so the configuration object only holds output- and behavior-related options and does not hold things like permission checks. Releases: master Resolves: #90882 Change-Id: I09f1d97a53a76ea96d6cbc18bb5549127b5a1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64002 Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
-
Xavier Perseguers authored
Resolves: #91130 Related: #82990 Releases: master, 9.5 Change-Id: I8337f8d24fff67ac2c8f05f16de642f46e86cfd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64250 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Christian Eßl authored
If a requested page in the view module is missing a site configuration, catch the related exception and show a meaningful flash message instead. Resolves: #91088 Releases: master Change-Id: I07e35c204ed3198530d57dd97e228fb950baf85c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64211 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Gerrit Mohrmann authored
To fire the LoginConfirmedEvent and LogoutConfirmedEvent even when redirects are active the redirect handling are moved after the events. Resolves: #91023 Releases: master Change-Id: I11fd2aba206edb68426039de7dbfa6e92d79c8a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64165 Tested-by:
-
Andreas Fernandez authored
The backend already provides the possibility for a backend user to use the first available module as "start module". However, if the UC of backend user is empty, its start module is set to "help_AboutAbout" explicitly, which contradicts the mentioned feature. Additionally, EXT:about is an optional dependency which may break the backend at this point. Because of the listed reasons, explicitly setting "help_AboutAbout" has been removed as well as the override by EXT:dashboard. Resolves: #91127 Releases: master Change-Id: I04fb79f8b59f7e8a07736ffc0d328979075f09a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64247 Reviewed-by:
-
Andreas Fernandez authored
Command executed: composer require --dev typo3/testing-framework:^6.2.3 Resolves: #91138 Releases: master Change-Id: I7047698dccc8b6bafbcb61b81f4723a1b9bba2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64254 Reviewed-by:
-
Josef Glatz authored
This change adds a human readable and meaningful main title for the documentation of ext:rte_ckeditor. Resolves: #91136 Releases: master, 9.5 Change-Id: I01804d2d4c700af6c2a72d74596cf20b04505eb8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64253 Tested-by:
-
- Apr 19, 2020
-
-
Oliver Hader authored
Dynamically created class instances using a variable name cannot be resolved in extension scanner - given the fact that a class member variable can change at any time and the scanner would have to keep that state - which is too much for static code analysis. Thus, the following source code is not analyzed. $className = SomeClass::class; $object = GeneralUtility($className); Resolves: #91128 Releases: master, 9.5 Change-Id: I7f87e7c88e9e62efb85ee54f32625c531266cbba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64251 Tested-by:
Ghanshyam Bhava <ghanshyambhava@yahoo.com> Tested-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. Resolves: #91109 Releases: master Change-Id: I1cd0f6bc1b69e600f62d00c614119c825ae02a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64228 Tested-by:
-
Oliver Bartsch authored
Also simplify doktype check by using `in_array` instead of comparing each doktype on its own. Furthermore the check for the page row is superflous because it is checked implicit by fetching the doktype. Resolves: #91126 Releases: master Change-Id: Ic9d39aacb4eaa663a03fcbff907a8d4c21fc5278 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64245 Reviewed-by:
-
Chris Müller authored
In the "Add widget" dialog the id of the group tab was not unique. This interfered with other ids in the backend. A prefix was added to make it unique. Resolves: #91129 Releases: master Change-Id: Icf528c6ff8d755470d3158e94b1916a5ce028981 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64248 Tested-by:
-
Andreas Fernandez authored
Since #91080, TemplateService tries to fetch a site configuration from TSFE. As EXT:recycler uses the f:format.html ViewHelper, a TSFE is mocked which breaks the request. This bugfix makes use of f:format.raw instead, as 1. this fixes the issue 2. f:format.html is not required at all Resolves: #91131 Related: #91080 Releases: master Change-Id: Ic2b1de9aa2b419641509e755ab4d179f69178651 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64249 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Oliver Hader authored
Fluid variable `previewUrl` is generated, but never used in templates. Resolves: #91120 Releases: master Change-Id: Ia5397f9ef63700fda2a84aee245ed2ba2bf8bc55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64240 Tested-by:
-
Benjamin Franzke authored
With the introduction of a custom DI cache in #90418, the container was used to lookup its own cache and the cache identifier. This results in bugs if the container cache is stale: Loading from the cache and flushing the cache will work, but code that runs after the cache has been flushed (ext_localconf loading) will still use the a stale container (configuration), as the instance has been created too early (to be able to clear itself). Therefore we do now avoid instantiating the symfony container before the container cache has been cleared. A positive side effect of this change is that the container cache is warmed up after the flush. Releases: master Resolves: #91114 Related: #90418 Change-Id: I5f10474ab3fab2d17cfdca6cd514b0a95f10bbbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64234 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Klee authored
Having PHPDoc parameter and return type annotations like "string[]" instead of the generic "array" will help both static code analysers as well as human readers. Resolves: #91065 Releases: master, 9.5 Change-Id: I7d39241d81ce607e9ca6050cc82126420e1e756e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64203 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by: -
Josef Glatz authored
This patch takes the changes of the new documentation theme into account. Releases: master, 9.5 Resolves: #91102 Change-Id: I3308819227dc4a66f0571e4b5afdc49939f19026 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64223 Tested-by:
-
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
-
- Apr 18, 2020
-
-
Richard Haeser authored
No additional classes are needed anymore to initialise the graphs in Dashboard Widgets. If a graphConfig is given the chart will be initialised. Resolves: #91100 Releases: master Change-Id: Id25d272e4287a0248d982b600f792e5e32e76445 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64220 Reviewed-by:
-
Benjamin Franzke authored
The installtool sends a mail when a login happens when TYPO3_CONF_VARS.BE.warning_email_addr is set. When TYPO3_CONF_VARS.EXTENSIONS.backend.loginLogo is set to provide a custom backend logo, that logo is used by the FluidEmail template via f:image viewhelper. Therefore we need to provide MetaDataRepository, as the f:image viewhelper will use that service. The (implicit) dependency chain is: <f:image> -> Resource\File -> MetaDataAspect -> MetaDataRepository Releases: master Resolves: #91107 Related: #89892 Change-Id: If4e73d607d2a6e21646ea91bd8f0a39742f133d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64236 Tested-by: -
Oliver Hader authored
Superfluous inline events have been removed or replaced with native HTML functionality (location.href -> anchor). Resolves: #91110 Releases: master Change-Id: I594fe2df3c71234de096e437b5662867469ffbb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64229 Reviewed-by:
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #91112 Releases: master Change-Id: I6fef3f196afd44a11fbd5d688bec45457a28aad6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64231 Reviewed-by:
-
Richard Haeser authored
Corrected way of accessing the AJAX urls by using the dot notation. Resolves: #91113 Releases: master Change-Id: I6c3fd48707f3d45c5432ac1e11f77b0c33d577ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64232 Tested-by:
-
