- May 11, 2020
-
-
Andreas Fernandez authored
Each link triggering the "New content element" wizard is now initially disabled and gets enabled once the according module has been loaded and initialized. Resolves: #91165 Releases: master Change-Id: Ic4073faa5bd97f9b50bb8c3ada6864539c0ae63f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64307 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
When setting a site language into free mode for translations, then "$cObj->exec_getQuery()" only returns the pages without overlays. HMENU however always expects sys_language_uid=0 records, as it does a MountPoint + overlay again. Doing an getPageOverlay of a translated page results in an empty result. The change now modifies the HMENU directory resolving to fetch the original record (cached in PageRepository), and do the overlay information as well. This also fixes the same issue in HMENU.special = updated Big Kudos to Jones for great support on tackling this issue! Resolves: #91292 Releases: master, 9.5 Change-Id: Ifc0faddb6562c2b83dc95aa84ed40f37b5a1a0e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64436 Tested-by:
Jonas Temmen <jonas.temmen@artundweise.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
The global object $GLOBALS[TYPO3_REQUEST] holding the current PSR-7 request object was introduced in TYPO3 v9.2. However, it was also marked as deprecated as we thought we were able to remove all usages again by the end of TYPO3 v9.5 development, which shows that we have more problems in various areas like hooks and Extbase where we heavily rely on this object. For this reason, it is kept but the original Feature RST still contains the information that it is considered bad practice. Removing the deprecation will result in better result for the ExtensionScanner. Resolves: #91347 Releases: master, 9.5 Change-Id: I97bb16cf7f4e7149c5c3a3528a015701f60c2628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64439 Tested-by:
-
Marcin Sągol authored
This commit fixes small typo in CSH text for frontend usergroups where instead of "of" word "or" was used, changing sens of this statement. Resolves: #91356 Releases: master, 9.5 Change-Id: Ic4f9e7544875f5d7a8d1f89e732955769041653e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64452 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- May 09, 2020
-
-
Anja Leichsenring authored
Resolves: #91349 Releases: master Change-Id: I60ffcb35a82d7e890590f836dcfd9e0739c8db03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64440 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Andreas Fernandez authored
It's safe to use getElementById() instead of querySelector() in case an element is fetched by its ID. Numbers for nerds: getElementById() is nearly 1.5x faster than querySelector(). To be fair, both functions are really fast with executing multiple million operations per second, thus nobody will notice a performance impact. See https://www.measurethat.net/Benchmarks/ShowResult/106740 Resolves: #91254 Related: #91183 Releases: master Change-Id: I2ed590d20c9af66ce818f012ac73ec45c5c9fa55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64384 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Marcin Sągol authored
This commit improves description text for backend module Form by replacing reference to "Mail Form" content element with just "Form" as this name is used in TYPO3. Resolves: #91352 Releases: master, 9.5 Change-Id: I3348d2766afad6a2c06ce7b323df775a9bf9c33b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64442 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Daniel Goerz authored
Resolves: #91343 Releases: master, 9.5 Change-Id: I1d5c48c5ba7a8d6ff977b7e0ca5d3f96d7e1963d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64437 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- May 08, 2020
-
-
Mathias Brodala authored
Releases: master Related: #85878 Resolves: #91248 Change-Id: I8eb19a7e7f2ac4527beb9befafc6b16cf79e99cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64372 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Anja Leichsenring authored
The to header is mandatory by now, so we need to supply the recipient in our testcases now. Resolves: #91346 Releases: master Change-Id: Ic1a3197a8412b27eb5cebb00a1443f10021b9326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64438 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Sebastian Iffland authored
Releases: master Resolves: #91337 Relates: #90729 Change-Id: I564f488dd653448046599a9bb1099dd05c4211f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64432 Reviewed-by:
Alexander Grein <alexander.grein@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Alexander Schnitzler authored
While switching from controller class aliases to fully qualified controller class names (internally), the structure of framework configuration slightly changed. This unfortunately broke the detection of the plugin name by action because the new structure had not been checked for. Also, there was a unit test which hasn't been adjusted to the new structure as well because it was simply overlooked. With this patch the bug is fixed and the fix is also covered again by a unit test. Releases: master Resolves: #91249 Change-Id: I9acdaeb66010563d82c818ddf0a73e2adab780db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64388 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Joschi Kuphal authored
Nested tags starting with the same literals, like `<s><span>...` or `<a ...><abbr>...` are not correctly nested due to a flaw in identifying proper start and end of HTML tags. Resolves: #91194 Releases: master Change-Id: I2029c8e01d66e5286790fd04a259153cd130c753 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64409 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Marcin Sągol authored
Improve the warning message presented to the user when a file is renamed through the Filelist module and a file with the new name already exists. Resolves: #91299 Releases: master Change-Id: If1ff921396f782c1f560fdb092755e306344d0f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64427 Reviewed-by:
-
- May 06, 2020
-
-
Benni Mack authored
Access restricted, translated pages currently always have the slug from the default language instead of their translated slug in the frontend. To generate correct urls, while using the "linkAccessRestrictedPages" option, the $disableGroupAccessCheck parameter needs to also take into account for * PageRepository::getPageOverlay() when setting the option in PageRepository::getPage(). This "hack" is currently similar to what HMENU is doing, however this public property should not be used with the Context API instead. This change however needs more refactoring on the Context API, which is why this solution is chosen for the time being (and also for v9 backport). Resolves: #90842 Resolves: #87969 Resolves: #91185 Releases: master, 9.5 Change-Id: I99a34ca7fceacba7218c6b7132781805a6b59ac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63963 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Frank Naegler authored
Resolves: #91244 Releases: master Change-Id: I107cb96ff416211028f9da524500f1ca15c3297c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64393 Tested-by:
-
Georg Ringer authored
Show the correct language title in the new fluid page module if an inconsistent content state has been detected. The title of the problematic language must be shown instead of the default language title. Furthermore a not needed sprintf call is removed as the message itself doesn't contain any placeholder which needs to be replaced. Resolves: #91313 Releases: master Change-Id: Ie1082bee58cb04068e2cea3b4f18c2b6f2b516f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64416 Tested-by:
-
Georg Ringer authored
The third argument of `GeneralUtility::callUserFunction` must be either an object or null. Ensure the argument is always null instead of false to avoid triggering a deprecation log entry. Resolves: #91184 Releases: master Change-Id: I5ee0a58d812de737bd631e5c1986895e69c158af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64415 Tested-by:
-
Oliver Hader authored
Legacy left-overs using references on class instances can be removed. Resolves: #91319 Releases: master, 9.5 Change-Id: Iad33e9e155f538fd1787d16c21e1b7d8e15bdd26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64421 Tested-by:
-
Benni Mack authored
Since TYPO3 v9.5.16 it is not possible anymore to resolve URLs with an Aspect that contains records with fe_group restrictions. This is due to a legacy solution that the Frontend User is actually initialized early enough but the groups are resolved within $TSFE->determineId() at a later point. For this reason, Routing does not handle fe_group restrictions, but the plugin should take care of that for the time being. Future TYPO3 versions can decide to resolve the fe_group restrictions earlier, but this would be a breaking change of behaviour of the Frontend Request Workflow for TYPO3 v10 + v9. Resolves: #91049 Releases: master, 9.5 Change-Id: I0e57768f5358dc06101acdca374b9c872a65c865 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64408 Tested-by:
Krystian Szymukowicz <k.szymukowicz@gmail.com> Tested-by:
-
Marcin Sągol authored
This commit fixes small typo at the end of the identifier exists validation message used in site configuration controller. Resolves: #91314 Releases: master, 9.5 Change-Id: Iccda594038a30a277d1c45255f6de564aa3dda5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64417 Tested-by:
Joerg Kummer <typo3@enobe.de> Reviewed-by:
-
- May 05, 2020
-
-
Resolves: #91308 Releases: master Change-Id: I1dc74ba54e11f35e0d4b99ebcc68e1ee77ea8598 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64410 Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Chris Müller authored
Clicking on external links (with target="_blank") in RSS widgets and buttons of Dashboard widgets can leak the referrer of the linked page. This is mostly not wanted because it reveals the URL of the TYPO3 backend. Additionally, the other page can access the "window.opener" property, which exposes security issues. Also if the other page is running a lot of JavaScript, the performance of the TYPO3 backend may also suffer, because the other page may run on the same process as the TYPO3 backend. To mitigate this behaviour rel="noreferrer" is added to external links in the according widgets. "noreferrer" also implies the "noopener" behaviour, so this is sufficient. See also: - https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer - https://developers.google.com/web/tools/lighthouse/audits/noopener Resolves: #91290 Releases: master Change-Id: Ie53b543e39bc716a5437d9a7364691de3ec7346f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64401 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
-
Richard Haeser authored
As the www prefix is not used anymore on typo3.org, the URLs of the RSS feeds are updated in the Dashboard Widgets. Resolves: #91297 Releases: master Change-Id: I4ffff83035967b0ba9b7233c82df01651599f103 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64405 Tested-by:
-
Georg Ringer authored
According to https://www.sitemaps.org/de/protocol.html the option `priority` is optional. If a SitemapProvider doesn't provide a priority information the tag must be avoided to have a valid XML structure. Resolves: #91286 Releases: master, 9.5 Change-Id: I0bd4379633359321ad39726e4357773880c15638 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64397 Tested-by:
Christian Eßl <indy.essl@gmail.com> Tested-by:
-
- May 04, 2020
-
-
Andreas Fernandez authored
This patch resets the `window.opener` for the entire TYPO3 backend and loads modules using this only in an authenticated environment. This solves an issue when `window.opener` is accessed and the login or backend were opened from a link, e.g. the password reset mail. Resolves: #91270 Resolves: #91205 Releases: master, 9.5 Change-Id: I83bdbfa7dfb80fbcd92ac4a000a6479aad22a73a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64394 Tested-by:
-
Helmut Hummel authored
Because TYPO3's DefaultConfiguration is recursively merged with settings from LocalConfiguration, it was impossible to change or remove log writers that are defined in DefaultConfiguration. One would have had to use AdditionalConfiguration for that. A simpler way to disable individual log writers is added now. It is simpler, because it allows to disable log writers directly in LocalConfiguration. To avoid misconfiguration regarding deprecation logging, E_USER_DEPRECATED is now enforced in SYS/errorHandlerErrors. E_USER_DEPRECATED needs to be enforced to avoid, that the default PHP error handler is called, which would cause these errors to be added to the output or filling up log files, depending on the global PHP configuration (php.ini). Because all other values from DefaultConfiguration.php resemble production settings and logging deprecation messages in production are not desired, the deprecation logger is now disabled by default. Last but not least, deprecation logging is now enabled/disabled in the Live and Debug presets in the install tool UI. Resolves: #84105 Resolves: #89934 Resolves: #88444 Releases: master, 9.5 Change-Id: I52a6f9c70ad13e6e0bad6a6b06b6fbfe7abc623c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/56077 Tested-by:
-
Chris Müller authored
As the class TYPO3\CMS\Dashboard\DasboardRegistry is wrong-spelled and does not exist, it is removed. Resolves: #91287 Releases: master Change-Id: I016aeb4839ed62ae7d23f011c9a87c104bb2b138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64398 Tested-by:
-
Georg Ringer authored
Improve the cache clearing label added with #88718. Resolves: #91284 Releases: master Change-Id: I8c1036af1428453a6f9cc7a801dbbf0f747011cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64396 Tested-by:
-
Stefan Froemken authored
Since TYPO3 v9, PageRepository works independently from TSFE and can and should be instantiated on its own, depending on the context. This leads to multiple initializiation calls which can and should be cached, as a page with 100 links will re-trigger the properties all the time, even if they are not needed (groupWhereClause for instance). Caching these values reduces the time needed for typolink generation a lot. Resolves: #91208 Releases: master, 9.5 Change-Id: Ied7e2b78519754af2e10eeb4e9c1c9fcbbffe2e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64321 Tested-by:
-
Oliver Bartsch authored
The ElementBrowser which is typically used for type=group, can be disabled via the `fieldControl`. This configuration is now also respected by the TableList buttons, which are also links for the ElementBrowser. Resolves: #88979 Releases: master, 9.5 Change-Id: Ib48586207480e4e61403ad6b0b694b51ee6e38c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64076 Tested-by:
-
Oliver Hader authored
* allows custom events to bubble up in DOM tree * ensures that custom events are dispatched at those elements that initially contained the `data-event-name` attributes Resolves: #91186 Releases: master Change-Id: I0c5951a573bba0bbe73967ffcecf5dcfeae2e2f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64311 Tested-by:
-
- May 03, 2020
-
-
Andreas Fernandez authored
IRRE relied on the HTML comment `<!--notloaded-->` to detect whether a record is already loaded or not. As this might collide with HTML minification, the comment has been replaced with a class placed in the panel. Resolves: #91258 Releases: master Change-Id: Ibe890317bdcb9707a71de1168de0d404fb3c67a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64385 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
- May 02, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #91264 Relates: #91253 Change-Id: Ifcd89d719494c9be3f14b7b6d943d9e0eabfff82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64383 Reviewed-by:
-
Oliver Hader authored
Resolves: #91265 Releases: master, 9.5 Change-Id: I5e413f91ae92ba666a74606767c4ecd081407f79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64389 Tested-by:
-
Helmut Hummel authored
Resolves: #91261 Releases: master Change-Id: I8e7db92d914a8423b083c08c27c6922b1341f252 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64387 Tested-by:
-
- May 01, 2020
-
-
Andreas Fernandez authored
The InlineControlContainer tried to fetch elements via `querySelector()` previously. This fails once the selector contains a character that has a specific meaning for the whole selector, e.g. a dot. Having a selector `#foo-bar-settings.test` instructs the query selector to fetch an element matching the ID `foo-bar-settings` and the class `test`. As we handle IDs only, we can safely use `getElementById()` which doesn't have the previously mentioned implications. Resolves: #91183 Releases: master Change-Id: I63d23428ee548140f42e2c551d155ac829a2b596 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64343 Tested-by:
Raphael Zschorsch <rafu1987@gmail.com> Tested-by:
Armin Vieweg <armin@v.ieweg.de> Tested-by:
-
Benni Mack authored
The CGL changes and the streamlining of the header comments is now cleaned up (via the php-cs-fixer rules) and are now applied to other files. This is a precursor patch to include this PHP-CS-Fixer configuration in our pre-merge checks. Resolves: #91253 Releases: master Change-Id: Icb75ddb2255eee4ae2ff457c4d09465cde73e638 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64380 Tested-by:
-
- Apr 30, 2020
-
-
Patrick Schriner authored
To prevent the necessity to duplicate logic of the datahandler tags are passed to the hook. Resolves: #91231 Releases: master, 9.5 Change-Id: I437f40d4bdb9c786eeaa46be279e22a3ebb5b90b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64344 Reviewed-by:
-
Andreas Fernandez authored
This patch fixes two flaws with the determination and loading of the first available backend module: * ModuleLoader::getModuleSetupInformation() only sets default options if the configuration array is not empty * The availability of the module is checked. If the configured module doesn't exist, the first available module is determined again. Resolves: #91210 Releases: master Change-Id: Idae8de6e0bf253754c4d44e50b15e81038e1315f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64309 Tested-by:
-
