Skip to content
Snippets Groups Projects
Commit 897f59f6 authored by Andreas Fernandez's avatar Andreas Fernandez
Browse files

[BUGFIX] Explicitly fetch element by ID instead of invoking querySelector

The InlineControlContainer tried to fetch elements via `querySelector()`
previously. This fails once the selector contains a character that has a
specific meaning for the whole selector, e.g. a dot. Having a selector
`#foo-bar-settings.test` instructs the query selector to fetch an
element matching the ID `foo-bar-settings` and the class `test`.

As we handle IDs only, we can safely use `getElementById()` which
doesn't have the previously mentioned implications.

Resolves: #91183
Releases: master
Change-Id: I63d23428ee548140f42e2c551d155ac829a2b596
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64343


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarRaphael Zschorsch <rafu1987@gmail.com>
Tested-by: default avatarArmin Vieweg <armin@v.ieweg.de>
Tested-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: default avatarRaphael Zschorsch <rafu1987@gmail.com>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarAndreas Fernandez <a.fernandez@scripting-base.de>
parent 6487672c
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment