- Apr 27, 2020
-
-
Anja Leichsenring authored
The current nightly run simply takes too long, we need to cut down the sheer number of tests we run. The current setup aims to execute a small subset of all tests on each DBMS and Php version, but in total every test is run in each composer stage at least once. Resolves: #91058 Releases: master, 9.5 Change-Id: I94fc6627f5da0cc6f36cf789ef8aa227d73d8daa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64152 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Andreas Fernandez authored
While migrating DataTables to tablesort, the sorting for updateable or (un)installed extensions went lost. This patch adds the ability to sort these columns again. Resolves: #91182 Related: #86343 Releases: master Change-Id: Ia33c3dcc789967a984090ccf26150f6d319e85e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64310 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 22, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. * adjusts invocations of top.TYPO3.InfoWindow.showItem * adjusts low-level inline `onchange` and `onclick` events Both JavaScript modules `TYPO3/CMS/Backend/GlobalEventHandler` and `TYPO3/CMS/Backend/ActionDispatcher` are required to actually handle these new triggers and correpsonding events - that's why they are loaded in `ModuleTemplate` and deprecated `DocumentTemplate`. Resolves: #91117 Releases: master Change-Id: Ie7012445d09c3aee253548cb3057c8e9e4b86809 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64242 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 21, 2020
-
-
Andreas Fernandez authored
This commit updates ckeditor to version 4.14.0. This release contains a bugfix for self-XSS'ing the editor: https://ckeditor.com/blog/CKEditor-4.14-with-Paste-from-LibreOffice-released/#security-issues-fixed Command executed: yarn add ckeditor4:^4.14.0 Resolves: #91149 Releases: master, 9.5 Change-Id: I46e2b95773ed0b4fd623a1843ab690a0b596728d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64262 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Apr 20, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. * unused properties in QueryView have been removed * onclick event on a submit button does not have any effect since the onsubmit event is handled first - corresponding code has been removed as well Resolves: #91111 Releases: master Change-Id: I51263b5cd71109d9a28d4edf3cb0b95097aab6b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64230 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * extracts inline JavaScript from controllers & templates * GlobalEventHandler is extended to deal with custom scenarios that acutally would trigger a browser navigate events (e.g. changing a select drop-down leads to a document refresh) * ActionDispatcher is introduced to listen and delegate events to global TYPO3 modules in `top` window scope Resolves: #91015 Releases: master Change-Id: I67bf70bba1890c0ef966a08d96823ad91b1d4167 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64130 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Apr 19, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by moving these parts to dedicated static JavaScript modules or using native HTML functionality instead of location.href. Resolves: #91109 Releases: master Change-Id: I1cd0f6bc1b69e600f62d00c614119c825ae02a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64228 Tested-by:
-
Oliver Hader authored
Module TYPO3/CMS/Core/DocumentService provides native JavaScript functions to detect DOM ready-state returning a Promise<Document>. `$(document).ready(() => {...});` can be replaced by `documentService.ready().then(() => {...});` Resolves: #91122 Releases: master Change-Id: Id812f786430f1ced6265493dd0bae472b8144588 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64241 Tested-by: -
Andreas Fernandez authored
When the MultiStepWizard is used with additional click events bound to the next or prev button, those event got stacked as the buttons don't change per step. To fix this issue, all click events are removed after switching a step and the original click event to switch the step is bound again. Furthermore the 'savePath' for duplication of a form is now correctly set if there is only one folder available and therefore no select element present in the modal. Resolves: #91094 Releases: master Change-Id: Ic95d2222441c8e1e8cf9fb46e5e7437d4e4ed85e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64214 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
- Apr 18, 2020
-
-
Richard Haeser authored
No additional classes are needed anymore to initialise the graphs in Dashboard Widgets. If a graphConfig is given the chart will be initialised. Resolves: #91100 Releases: master Change-Id: Id25d272e4287a0248d982b600f792e5e32e76445 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64220 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Christian Eßl authored
Resolves: #91103 Releases: master Change-Id: If342b9bf69574b54d598e342c3bb2773dba582cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64224 Reviewed-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Richard Haeser authored
Corrected way of accessing the AJAX urls by using the dot notation. Resolves: #91113 Releases: master Change-Id: I6c3fd48707f3d45c5432ac1e11f77b0c33d577ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64232 Tested-by:
-
Benni Mack authored
Made sure EXT:dashboard follows the guidelines for usage of ext_localconf and ext_tables and some other changed to make the code more consistent with other system extensions. Resolves: #91108 Releases: master Change-Id: I82d957a9e13aee8504b6bf8df6a3145b8fb6a5db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64221 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
- Apr 17, 2020
-
-
Andreas Fernandez authored
The page module now doesn't try to update the flag icon of a dragged record if the page module is not in "language" mode as the required information is not available. Resolves: #91096 Related: #90693 Releases: master Change-Id: I1c796a6f4b00761f3310335cf45256d75a7e3bc5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64218 Tested-by:
-
Richard Haeser authored
For proper animations during drag / drop of the widgets at the Dashboard, we need a Web Animations API polyfill for some browsers. This patch replaces the current polyfill with a lightweight MIT-licensed library. Resolves: #91072 Releases: master Change-Id: Ic04d97ab1d1a16a99aa92522552b4b060ced31e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64206 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Oliver Hader authored
Arrow functions keep using their own `thisArg` on invocation. To be able to avoid unscoped `function()` call and still retrieving `targetElement` it is passed explicitly as 2nd callback argument. Resolves: #91084 Releases: master Change-Id: I3f1087713827605ac8b59f18eb4a59becd67e460 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64209 Tested-by:
-
- Apr 16, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` events. * extracts inline JavaScript from templates * introduces `TYPO3/CMS/Backend/GlobalEventHandler` module * adjusts PHP type-hints to their correct & actual values Resolves: #91052 Releases: master Change-Id: If92391bd48f89df57fbb0ed6f8b0936da0e1a49d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64191 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90910 Change-Id: If03889ee330e96c5ca82b31ae0604fb1d1d0afc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64031 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
- Apr 15, 2020
-
-
Oliver Hader authored
This change aims to reduce the amount of inline JavaScript by removing `onchange` or `onclick` events and dynamically created JavaScript code/settings. There are still a couple of aspects that need to be solved in a general way - e.g. assigning global language labels (`TYPO3.lang`) or settings (`TYPO3.settings`). * allows `Modal` confirmation to emit `ModalResponseEvent` * extracts inline JavaScript from controllers & templates * introduces `BroadcastChannel` in `nav_frame` (folder tree) * uses plain links (`<a href="..."`) where applicable * updates folder tree when navigating in browser history Resolves: #91016 Releases: master Change-Id: Ied6a626e09df07bd1a240b9b6b4250cd6fff4c8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64154 Tested-by:
-
Benni Mack authored
TYPO3's PHP-CS-Fixer configuration is adapted to move towards the PSR-12 standard by unifying the new statement and adding proper braces argument methods and arguments. Resolves: #91026 Releases: master Change-Id: If5eb945e18fb4a2330e3c9eeaf90134126638079 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64163 Tested-by:
-
Josef Glatz authored
The icon path of an extension is only returned if the icon can be found. This prevents the JavaScript from rendering a broken extension icon. Resolves: #91038 Releases: master, 9.5 Change-Id: Ic0a4fb874215408c1781b3acb29e9ec4769150fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64176 Tested-by:
-
Andreas Fernandez authored
Resolves: #90941 Releases: master Change-Id: If205ab5308c0f1bb7e935a53bebee41e7b9e2fd2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64061 Tested-by:
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:
-
- Apr 14, 2020
-
-
Andreas Fernandez authored
To improve the user experience, the search filter in the "New Content Element" wizard is automatically focussed when the modal appears. Resolves: #91014 Releases: master Change-Id: I3e0f18bd454955af63cd797138de7b2118d9d2ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64129 Tested-by:
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:
-
- Apr 13, 2020
-
-
Alexander Schnitzler authored
As a preparation to be compatible with PSR-12, all spaces in strict type declerations are removed. Releases: master Resolves: #91009 Change-Id: I2b7c2fda42b44168b5c4c6b21711eede2eadaf2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62104 Tested-by:
-
- Apr 12, 2020
-
-
Andreas Fernandez authored
Navigating in the RteLinkBrowser by e.g. switching tabs or browsing the file tree now recovers the selections of the underlying ckeditor. This allows to invoke a browser search, navigate within the link browser and place a link afterwards. Resolves: #91006 Related: #90952 Releases: master, 9.5 Change-Id: If2d943f0b2a8b86babead8c1397d6222b0c0da7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64121 Tested-by:
-
Daniel Siepmann authored
Provide concrete classes that will be instantiated multiple times with different options. E.g. provide an RssWidget implementation, that can be used multiple times with different rss feed urls. Split configuration for UI (title, icon, …) from concrete implementation. A new WidgetConfigurationInterface is in place and used. Resolves: #90660 Resolves: #90852 Releases: master Change-Id: I194615164b7d3d1cbd63751ddfd1f66f71db64cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63563 Tested-by:
Koen Wouters <koen.wouters@maxserv.com> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
-
- Apr 08, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90913 Change-Id: If38a526547518e93b3002ffa01accebf4a12e5b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64032 Tested-by:
-
Andreas Fernandez authored
This patch updates the Docker configuration to use mssql 2019 as mssql 2017 images don't get updates anymore. Additionally to the mssql update, the shuffled chunking to 50 jobs is reverted as it didn't bring any benefit but even more hassle as the stages failed earlier and more often. Instead, the jobs are now grouped by PHP version which allows smaller chunks and reduced the probability to clog the build queue. To workaround errors thrown by Gerrit on heavy load, the cherry-pick command is now executed up to five times, with a short sleep between each execution. Last but not least we check whether there is actually a dangling Docker container instead of hard killing non-existent containers which pollutes our log. Resolves: #90965 Releases: master, 9.5 Change-Id: Ied60297127b86c3375d310759bf441ad9e10aeed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64087 Tested-by:
-
- Apr 07, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90891 Change-Id: Ie0a00688422d7088816f80364e68cac7f7232950 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64016 Tested-by:
-
- Apr 06, 2020
-
-
Alexander Schnitzler authored
Releases: master Resolves: #90893 Change-Id: Icc339442cded9a268fb66fe932b0f13de292e3b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018 Reviewed-by:
-
Josef Glatz authored
Add related links for each upgrade documentation file at the end: - link to forge issue - link to rendered rST document This makes it possible to - read the documentation as rendered html with on click - easily share an upgrade document with others - open the related forge issue Resolves: #90923 Releases: master, 9.5 Change-Id: Iedf874e31b7026a55275d6073d645e875dab1b6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64044 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Markus Klein authored
If the pageIdSelector feature is enabled for the RTE the entered page UID needs to be formatted with correct link syntax. Resolves: #82942 Releases: master, 9.5 Change-Id: I93bc583ba279d0bde549582388791fc48150d933 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64064 Tested-by:
-
- Apr 05, 2020
-
-
Andreas Fernandez authored
When the RteLinkBrowser is opened, any active ranges are now backed up and reused later when an element gets linked. This fixes clashes with the browser's internal search feature that overrides the `Selection` object. Resolves: #90952 Releases: master, 9.5 Change-Id: I155157e808370cd5ff05076a6c82f09da3b0cb3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64078 Tested-by:
-
- Apr 04, 2020
-
-
Georg Ringer authored
Integrators are now able to compare individual backend usergroups. Backend usergroups are used to split permissions into smaller parts which can be later assigned to a backend user. This feature makes it possible to compare the defined permissions including the ones inherited from sub groups. Resolves: #90826 Releases: master Change-Id: Ic2306be7091c0001c293bcc8622c4d6ea16776ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63890 Tested-by:
-
- Apr 03, 2020
-
-
Andreas Fernandez authored
This patch removes the bootstrap-slider library used to render input sliders. Such elements have been replaced with HTML input fields using `type="range"` which provides the same base functionality some time ago. Since using bootstrap-slider with TYPO3 is neither documented nor propagated, removing this library isn't considered as breaking change. Resolves: #90897 Releases: master Change-Id: I8516e2a4b98125e02873fad43c44cb2bc034e783 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64047 Reviewed-by:
-
Georg Ringer authored
Use buttons instead of span tags to make the module more accessible. Resolves: #90872 Releases: master Change-Id: Id183fa8de13ec3bea992cb9cdbe851127b1bc15c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64000 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Georg Ringer authored
The Install Tool module "Manage Language Packs" is improved by the following changes: * If all language packs of an extension are available, the download icon is still shown to make downloads of a single language pack per extension possible. * The icon itself changed from refresh to download as there is no refresh possible. There is no lock on a specific date or version to reload language packs. Every download can contain new or changed translations. Resolves: #86535 Releases: master, 9.5 Change-Id: I130c169b933b6e4b13c533928a46984bcb93979e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64003 Tested-by:
-
- Apr 02, 2020
-
-
Alexander Schnitzler authored
Several issues have been ignored because of checks on runtime constants which vary from context to context. Since we can only simulate one context, phpstan is unable to properly detect several paths. Releases: master Resolves: #90909 Change-Id: Ie3213112a299559687f27317821453137cd5322a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64030 Reviewed-by:
-
