- Dec 02, 2019
-
-
Andreas Fernandez authored
The issue #89687 introduced a smaller response for page tree nodes by moving sane default attributes to JavaScript and overriding with the actual result. However, this is also done if a new page is created via drag&drop, the attribute get in a mixed state and page tree hurts itself in confusion. The default attributes are now applied only if no DataHandler command is invoked. Additionally, some variables in TreeController were wrongly used, which has been fixed as well. Resolves: #89822 Related: #89687 Releases: master, 9.5 Change-Id: Ia91b02eaf534cb1ce65a09e1c78fa6343630bdcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62507 Tested-by: Claus Due <claus@phpmind.net> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by: Claus Due <claus@phpmind.net> Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
-
Andreas Fernandez authored
docker-compose is updated to use the latest cumulative update (cu) of MSSQL 2017. Since mssql is probably still eager to fail, its stages are executed at last in the nightly builds now. Resolves: #89826 Releases: master, 9.5, 8.7 Change-Id: Ic1e8195f9b4f90747b5843d03630fd453ebe0bc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62511 Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Benni Mack authored
There are numereous places where reflection is used in our test cases to inject dependencies, however there are methods available doing so, so the tests can be adapted, which will speed up tests. In addition, the $callInaccessibleMethod() function is also replaced by the accessible mock functionality, resulting in faster results than reflection. Resolves: #89824 Releases: master Change-Id: Ia2fc8a8ee4d3b5fc7b0d2de8759a7e5e9ceb7b87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62503 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Using the freshly released version 2.6.8 in our packages adds PHP 7.4 support for Fluid Standalone. composer req "typo3fluid/fluid:^2.6.8" Resolves: #89819 Releases: master, 9.5, 8.7 Change-Id: I986b3f8e73e3114af3aef9f65b42c3bf109f9f39 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62504 Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Benni Mack <benni@typo3.org> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
Resolves: #89820 Related: #89813 Change-Id: I165dbb813079fbb0f25ac7b1c8ab57f292f73b16 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62506 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Susanne Moog <look@susi.dev>
-
Benni Mack authored
The following new PSR-14 events are added: TYPO3\CMS\Core\Configuration\Event\ModifyLoadedPageTsConfigEvent TYPO3\CMS\Backend\Authentication\Event\SwitchUserEvent TYPO3\CMS\Backend\Controller\Event\BeforeFormEnginePageInitializedEvent TYPO3\CMS\Backend\Controller\Event\AfterFormEnginePageInitializedEvent TYPO3\CMS\Backend\LoginProvider\Event\ModifyPageLayoutOnLoginProviderSelectionEvent TYPO3\CMS\Impexp\Event\BeforeImportEvent TYPO3\CMS\Install\Service\Event\ModifyLanguagePackRemoteBaseUrlEvent TYPO3\CMS\Linkvalidator\Event\BeforeRecordIsAnalyzedEvent TYPO3\CMS\Seo\Event\ModifyUrlForCanonicalTagEvent TYPO3\CMS\Workspaces\Event\AfterCompiledCacheableDataForWorkspaceEvent TYPO3\CMS\Workspaces\Event\AfterDataGeneratedForWorkspaceEvent TYPO3\CMS\Workspaces\Event\GetVersionedDataEvent TYPO3\CMS\Workspaces\Event\SortVersionedDataEvent They replace the following "old" signals with a deprecation layer: TYPO3\CMS\Backend\LoginProvider\UsernamePasswordLoginProvider::getPageRenderer TYPO3\CMS\Backend\Controller\EditDocumentController::preInitAfter TYPO3\CMS\Backend\Controller\EditDocumentController::initAfter TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfigPreInclude TYPO3\CMS\Beuser\Controller\BackendUserController::switchUser TYPO3\CMS\Impexp\Utility\ImportExportUtility::afterImportExportInitialisation TYPO3\CMS\Lang\Service\TranslationService::postProcessMirrorUrl TYPO3\CMS\Linkvalidator\LinkAnalyzer::beforeAnalyzeRecord TYPO3\CMS\Seo\Canonical\CanonicalGenerator::beforeGeneratingCanonical TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_BeforeCaching TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GenerateDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_GetDataArray_PostProcesss TYPO3\CMS\Workspaces\Service\GridDataService::SIGNAL_SortDataArray_PostProcesss Relates: #89733 Resolves: #89813 Releases: master Change-Id: I13f2454fd8f4efb5f4c5248d0b839634b77578db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62422 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
Jo Hasenau authored
Due to deprecations (in v9) and marking properties from public to protected, some hooks are not as powerful anymore, so special getter methods are provided to overcome this issue. Resolves: #87064 Releases: master, 9.5 Change-Id: I5a05bb8b31c2a9df2801092bd9ead60061bbd15f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62480 Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Benni Mack <benni@typo3.org>
-
Benni Mack authored
Tests should be consistent and reflect the way we do things in Core. However, testing framework offers too many different ways to do things, and "_callRef" is one of that. Resolves: #89817 Releases: master Change-Id: I44759df255365d0f90e0928f3f5726b66ecf9f3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62493 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: Frank Nägler <frank.naegler@typo3.org> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
-
- Nov 29, 2019
-
-
Patrick Broens authored
In some versions of PHP there is a PCRE bug, which will be triggered when using an unquoted array syntax in Fluid templates, leading to an error and possibly not able to display the rendered template. This is solved by using the quoted array syntax where it is not used yet. Resolves: #87970 Releases: master, 9.5 Change-Id: I36f4ee86765fae24f7daa0e7e59ff9fc6741144f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62450 Reviewed-by: Rens Admiraal <rens@simplyadmire.com> Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Reviewed-by: Claus Due <claus@phpmind.net> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Susanne Moog <look@susi.dev> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Susanne Moog <look@susi.dev>
-
Benni Mack authored
TYPO3 Core now requires at least doctrine/annotations 1.7, effectively helping to upgrade to PHP 7.4. Resolves: #89812 Releases: master, 9.5 Change-Id: I8ca951711bbcb19d935baad67ff69705d8e51aa2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62498 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org>
-
Benni Mack authored
The normalizedparams middleware is not executed in the install tool anymore, which is added by the NormalizedParamsAttribute middleware. In addition, the NormalizedParams class now contains factory methods for building up NormalizedParams based on $_SERVER or a PSR-7 request object. Resolves: #89808 Releases: master Change-Id: I1b3713ba22f100f652d746ae15f58f9024808ef1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62494 Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Tested-by: Georg Ringer <georg.ringer@gmail.com>
-
Tymoteusz Motylewski authored
In order to lower response size (by 40-50%) of the page tree controller several page tree item properties are only sent when they have non-default values. Resolves: #89687 Releases: master, 9.5 Change-Id: I65ef2b21c71041994ea86d09d1b989b4515e2e42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62329 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Richard Haeser <richard@maxserv.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Richard Haeser <richard@maxserv.com> Reviewed-by: Benni Mack <benni@typo3.org>
-
Susanne Moog authored
Resolves: #89373 Releases: master Change-Id: I5ee8789c43c681d1bed310a74e5947a78130f82e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62492 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
If a preview is opened via the TYPO3 backend, the opened window has the name `newTYPO3frontendWindow` to ensure only one preview window is open. However, if somebody changes in such window into the TYPO3 backend, the window name is not changed, causing that such preview links are opened in the same window again. This patch resets the window name before a preview is opened to ensure that previews are always opened in a new window. Resolves: #89805 Releases: master, 9.5 Change-Id: Ib4b31e78da21befc27c50ea3d49762f2a81fe029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62491 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Tested-by: Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
-
Susanne Moog authored
Resolves: #89806 Releases: master Change-Id: I587bda0e8101d963e6e8c2bfc72f7f1cb3632243 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62490 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
Adds parsing of link to ensure correct order of query params and anchor. Resolves: #88095 Releases: master, 9.5 Change-Id: Ic0bb13ca3f5664e514fe523d96a0bd017fab6b8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60409 Tested-by: Susanne Moog <look@susi.dev> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
Alexander Schnitzler authored
php bin/rector process Both sets php54 and php55 have been applied at the same time because set php54 didn't result in any changes. Releases: master Resolves: #89789 Change-Id: Idddc487b34abceb300a237bd458659a10db54469 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62439 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Anja Leichsenring authored
A common abstract for both pre-merge and security-pre-merge test runs eases the adaption in case of need, for example adding PHP versions. Resolves: #89803 Releases: master, 9.5, 8.7 Change-Id: I85279ec09bac3baaca94ec517e4a69f3abf830d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62484 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Andreas Fernandez authored
Executed command: yarn upgrade codemirror Resolves: #89801 Releases: master, 9.5 Change-Id: Ib47a110c85c15a2b1fcc663804c060e67663cbdd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62479 Tested-by: Susanne Moog <look@susi.dev> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Andreas Fernandez authored
Resolves: #89802 Related: #87688 Releases: master Change-Id: Idad44540f71fb8befac7014e6c7979d102fd486d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62481 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
Susanne Moog authored
Punctuation at the end of a link will no longer be automatically included in the link. It is valid as part of a link, but has been removed from links if it is the last char. Resolves: #89786 Releases: master, 9.5 Change-Id: I6dc239ddbee71eb2ef6dc26cd11ae444421a2a9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62478 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
-
Benjamin Franzke authored
Symfony 4.4 deprecated support for non-object services: https://github.com/symfony/dependency-injection/commit/6f11b359ab9 The usage of `array` as service is therefore no longer officially supported in Symfony 5.0. It still works, but in order to make sure that a possibly introduced type declaration in a 5.x release doesnt causes a type error, we migrate the middleware service from array to ArrayObject. Change-Id: Ie544014b4aa0217b84b0c9d2cc69efde352bef27 Releases: master Resolves: #89766 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62429 Tested-by: Susanne Moog <look@susi.dev> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Susanne Moog <look@susi.dev> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
Some "methods" used in ViewHelpers to mock a class (RenderingContext) which only uses a fixture to avoid constructor calls can be achieved by using phpunit's getMockBuilder() logic itself, making this class in the testing framework useless. TYPO3 Core should not depend on this, but rather use native phpunit logic. Some other things are moved to the specific classes where they are needed, so setUp() will be much faster for other ViewHelper test classes. Resolves: #89793 Releases: master Change-Id: Ia2b2d9e3d4a7bd9a6eabd254259ff24ff3565e65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62451 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
Mathias Brodala authored
This ensures that the target of translated "shortcut" pages is properly available. Normally this value is lost due to language overlay thus the original page record needs to be retrieved to restore the original shortcut target. Now it is possible to e.g. mark shortcut menu items as active on translated pages. Resolves: #67047 Related: #36822 Releases: master, 9.5 Change-Id: I2cabc252ba1936763d6cbe1fe0a093aa74f5a4e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/39630 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Susanne Moog <look@susi.dev>
-
Benjamin Franzke authored
Upgrade wizars may contain legacy code that requires services using makeInstance. As makeInstance needs to use the PSR-11 container for services that require dependency injection, we need to provide the global container intance during upgrade wizard execution. Also ensure that only *one* (singleton) PackageManager instance is used: ProviderConfigurationLoader used to create a second PackageManager instance. It passed a constructor argument which caused GU::makeInstance to bypass the symfony (PSR-11) container and to create a new instance (on its own). This new instance was then cached as singleton instance and all subsequent makeInstance calls returned this instance instead of the global instance. Therefore we now ensure that new singleton instances will not be cached if the singleton is known by the PSR-11 container. This inconsistency caused the Typo3DbExtractionUpdate to fail because some codepaths used one PackageManager instance (through DI) and some codepaths another instance (through makeInstance). Change-Id: I947310d1c2e46f7ded6399ad48d94efa9854f347 Releases: master Resolves: #89504 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62425 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Jörg Bösche <typo3@joergboesche.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
Benni Mack authored
This change allows to change to "Copy Mode" in the clipboard without having items on the clipboard. However, switching to a different clipboard will have this selection vanish again (before and after the change). Changing this behavior is considered out of scope for this patch. Resolves: #89726 Releases: master, 9.5 Change-Id: I83483c631915b390dfb0c9584c29f0f86a44d051 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62369 Tested-by: Daniel Goerz <daniel.goerz@posteo.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
- Nov 28, 2019
-
-
Susanne Moog authored
We can use vfs stream directly nowadays. Resolves: #89798 Releases: master Change-Id: Ie41eccb21dff70c6587bfd1380488697c4f6aca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62473 Tested-by: Benni Mack <benni@typo3.org> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
Anja Leichsenring authored
There will be more tests with other PHP versions and DBMS versions in the future, a little cleanup round will ease the integration. Resolves: #89783 Releases: master, 9.5, 8.7 Change-Id: I84eb9a813087d8f94cf2800b30efd7dd0174171d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62435 Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
-
This adds an example on how to save uploaded files in ext:news' `sys_file_reference` columns. Releases: master, 9.5 Resolves: #89775 Change-Id: Id775a59ee7f39446f5b0046a486861566cfa28ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62431 Reviewed-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by: Daniel Siepmann <coding@daniel-siepmann.de> Tested-by: Björn Jacob <bjoern.jacob@tritum.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Daniel Siepmann <coding@daniel-siepmann.de>
-
Andreas Fernandez authored
Resolves: #89791 Releases: master Change-Id: I9716c810035886dd3c1a5579b6b2e33ac38f585e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62445 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
Jan Stockfisch authored
A new Extbase-based plugin is added to TYPO3's Extension "felogin" which can be used as a toggle with custom templates based on Fluid, instead of marker-based templates. A new feature toggle is added to the Settings module for Site Administrators to switch to the newly added felogin extbase plugin, or continuing using the pibase plugin, e.g. for upgrading purposes. Resolves: #84262 Releases: master Change-Id: I9d281912373a078e0403f52b27483dd3e04785f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61900 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
Oliver Hader authored
Remaining parameters need to be deflated (prepared and normalized to strings and fitting into Symfony route length and literal constraints) during route generation. However, when resolving a route remaining query parameters have to be kept as is - explained in more detail in the following examples based on using enhancer with namespace set to 'app': * https://example.org/page/route-value/app__value=inject + previously assigned `app[value]=inject` -> dirty -> rejected + not inflated anymore, kept as `app_value` * https://example.org/page/route-value/app__other=inject + previously assigned `app[other]=inject` -> okay, wrong namespace + not inflated anymore, kept as `app__other` * https://example.org/page/route-value/[32+ characters]=inject + arbitrary characters lead to OutOfRangeException -> no valid hash + previously `md5('app__@any__value')` assigned `app[@any][value]` -> dirty -> rejected + not inflated anymore, kept as `md5('app__@any__value')` Basically the mentioned OutOfRangeException revealed that misbehavior, hacking `VariableProcessor::resolveHash` would not have solve issues with (incorrectly) merged query parameters - but would have hidden it. Resolves: #87688 Releases: master, 9.5 Change-Id: I3daf02d3b4ed540b9eb098a8b116f485cc79fa72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62385 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
-
- Nov 27, 2019
-
-
Benjamin Franzke authored
The recently released symfony 4.4 introduced a deprecation for non-object services and so 5.0 dropped support. That means we run into exception with symfony 5.0 when we add synthetic non-object services. Symfony 5.0 contains a type declaration that allows for objects only: Argument 2 passed to Symfony\Component\DependencyInjection\Container::set() must be an object or null, bool given, called in […]/typo3/sysext/core/Classes/DependencyInjection/ContainerBuilder.php on line 99 at Symfony\Component\DependencyInjection\Container->set( '_early.env.is_unix', true ) We provided four boolean services in v10.0 but never used or documented these in core, therefore we drop them now: - env.is_unix - env.is_windows - env.is_cli - env.is_compoer_mode These variales can actually be substitued by using dynamic environment parameters (those are supported thanks to our EnvVarProcessor): - "%env(TYPO3:isUnix)%" - "%env(TYPO3:isWindows)%" - "%env(TYPO3:isCli)%" - "%env(TYPO3:isComposerMode)%" One more, internally used, boolean service is now migrated into the internal boot.state service: - cache.disabled Releases: master Resolves: #89764 Change-Id: If40ef73fdce61a81732b9670876aec7c457648d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62427 Reviewed-by: Frank Nägler <frank.naegler@typo3.org> Reviewed-by: Richard Haeser <richard@maxserv.com> Tested-by: Frank Nägler <frank.naegler@typo3.org> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Richard Haeser <richard@maxserv.com>
-
Alexander Schnitzler authored
composer require --dev rector/rector:"^0.5.0" This commit introduces the requirement to rector/rector to automatically process code changes by given set of rules. To make this commit more meaningful, a first set "php53" has been processed. Releases: master Resolves: #89785 Change-Id: I6e2ff9654266458ae9fb6800547ff4712b0b66d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62437 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Georg Ringer <georg.ringer@gmail.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
Andreas Fernandez authored
To have a variable import chain per environment (dev, stage etc) for example, YAML files now may contain environment variables. Resolves: #89398 Releases: master Change-Id: I274c8e78f1a072ba490f4844d545b3015f658409 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61955 Tested-by: Mathias Brodala <mbrodala@pagemachine.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Nov 26, 2019
-
-
Markus Klein authored
Remove the double html encoding of the current link in the PageLinkHandler. The HTML is encoded centrally in the BrowseLinksController. All other link handlers already send the plain content correctly. Resolves: #89773 Releases: master, 9.5 Change-Id: I83ac730f150009c1ef6fc286fa26b4a829b2b412 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62432 Tested-by: Oliver Bartsch <bo@cedev.de> Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Tobi Kretschmann <tobi@tobishome.de> Tested-by: Richard Haeser <richard@maxserv.com> Reviewed-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Tobi Kretschmann <tobi@tobishome.de> Reviewed-by: Richard Haeser <richard@maxserv.com>
-
Alexander Schnitzler authored
composer require --dev friendsofphp/php-cs-fixer:"^2.16.1" Raising the version brings support for running the fixer with PHP 7.4. Releases: master, 9.5, 8.7 Resolves: #89776 Change-Id: Ib065b38c606f17c8e58a684e819cc555e493a91f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62433 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by: Tobi Kretschmann <tobi@tobishome.de> Tested-by: Benni Mack <benni@typo3.org> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by: Tobi Kretschmann <tobi@tobishome.de> Reviewed-by: Benni Mack <benni@typo3.org>
-
Benni Mack authored
Using Indexed Search plugin, one can customize the language selector, however, you needed a TypoScript condition, as Site Handling support was not possible yet. The default behaviour should be to only search in the selected language, which can be achieved by looking into the current language. The default option is now set to "current". Existing implementations still using conditions continue to keep working. Resolves: #80840 Releases: master, 9.5 Change-Id: I7772e40d11593331cddf8fc90c8630f0a4db1758 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62382 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Daniel Gorges <daniel.gorges@b13.com> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Daniel Gorges <daniel.gorges@b13.com> Reviewed-by: Oliver Bartsch <bo@cedev.de> Reviewed-by: Susanne Moog <look@susi.dev>
-
- Nov 25, 2019
-
-
Alexander Schnitzler authored
- Adjust namespaces of classes according to PSR-4 - Add a classmap for test fixtures Releases: master Resolves: #89706 Change-Id: Iefd73f8039eb3db4de419ecaab13a18f6abb23e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62341 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Jörg Bösche <typo3@joergboesche.de> Tested-by: Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by: Jörg Bösche <typo3@joergboesche.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
-
Georg Ringer authored
The following changes are applied: - Set a title tag - Add aria labels to the various input fields Resolves: #89597 Releases: master Change-Id: I0a48e9d885b35ea81e47a29989c69f9c8d4b99f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62232 Tested-by: TYPO3com <noreply@typo3.com> Tested-by: Benni Mack <benni@typo3.org> Tested-by: Susanne Moog <look@susi.dev> Reviewed-by: Benni Mack <benni@typo3.org> Reviewed-by: Susanne Moog <look@susi.dev>
-