- Feb 27, 2022
-
-
Benjamin Franzke authored
The private container now provides access to non-public services that have been at least once injected (and thus be considered as service during DI compilation phase). This may be used to provide dependencies to functional test setups where some dependencies needs to be mocked while other should receive the vanilla dependency the container would normally inject. A functional test case does implement the ContainerInterface now, allowing tests to access both public and private services. $this->getContainer() may still be used if the default container (delivering public services only) needs to be injected into a service. Related testing-framework pull request: https://github.com/TYPO3/testing-framework/pull/331 Commands executed: composer u typo3/testing-framework git grep -l "this->getContainer()->get(" | xargs sed -i 's/this->getContainer()->get(/this->get(/g' Resolves: #97032 Releases: main, 11.5 Change-Id: I5987d5244270a3e190c8721f6a8971c7fd1309ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73646 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Klee authored
GeneralUtility::getIndpEnv can also return values other than string, e.g., PATH_INFO might return null, and TYPO3_SSL will return a bool. Also, _ARRAY will return an array of all possible scalar values. The return type annotation needs to correctly reflect that in order for static type analysis to be able to work correctly when this function is called. Resolves: #97020 Releases: main, 11.5 Change-Id: Ibb24f1a3451c6598452402fc7a7b0a96c66bbd01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73693 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Running bin/typo3 upgrade:run now encapsulates the wizard in question in double ticks. Before: > bin/typo3 upgrade:run Running Wizard Sanitize existing SVG files in fileadmin folder After: > bin/typo3 upgrade:run Running Wizard "Sanitize existing SVG files in fileadmin folder" Change-Id: I0739f836eb2b9cade517563a135f0333ecb6e055 Resolves: #97054 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73728 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Bürk authored
Update styleguide to provide latest changes. * ES6 modules and converted notification example #97006 * type=folder example #96983 * 'l10n_display' => 'defaultAsReadonly' example * example for inline children with max_items set #91808 * inline symmetric with group field example One of the styleguide changes adapted a table name which is now longer. This leads to an edit icon no longer being within view port. We fix the chrome options and increase the browser window size a bit - this gives a better overview when looking an acceptance test screenshots, too. This has minor impact on the page tree keyboard test, too. > composer u typo3/cms-styleguide Resolves: #97006 Resolves: #97056 Related: #96983 Related: #91808 Releases: main Change-Id: I257f2b0a8a51170ab7f0240f6fc2199d5e73c277 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73730 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
The filter in the Belog module is extended for a new page selector (Database browser). Using the new selector, one is able to filter logs by specific page or even page trees, when using together with the "depth" option. Additionally, the modules' access is changed to "user", which allows administrators to enable the module for specific users or user groups. Non-admin users however will never see global logs, but only logs for pages they have access to. The user will be informed by corresponding info boxes. Resolves: #97051 Related: #97031 Releases: main Change-Id: I62383d6385a8b8d5e2650b3c44ac078dae1883b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73725 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
- Feb 26, 2022
-
-
Oliver Bartsch authored
Resolves: #97050 Related: #96574 Releases: main Change-Id: I521154db1b4a7dd599ab011dd57faff9eaddbd9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73723 Tested-by:
-
Benjamin Franzke authored
Add dependency injection to PageRenderer and it's direct dependencies. Most prominently this avoids the static assets-cache injection from TYPO3 bootstrap and refactors to regular injection instead. ResourceCompressor is adapted to be delay it's initialization to be injectable without immediate side-effects. Backend Router and UriBuilder are not injected because they are a) only needed in backend context and b) should ideally be moved out of the PageRenderer into EXT:backend anyway. Resolves: #97030 Releases: main Change-Id: I8e72e5f87a095372439c3cd8106318ae272c6ce0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73594 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Björn Jacob authored
Using the legacy form template / partial variants residing in :file:`EXT:form/Resources/Private/Frontend/Templates` and :file:`EXT:form/Resources/Private/Frontend/Partials` is deprecated. The legacy templates will be removed in v13. Resolves: #95456 Releases: main Change-Id: Ib1346065d69a12d6664758a3c9bedf7efa3bd834 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71423 Tested-by:
waldhacker <hello@waldhacker.dev> Reviewed-by:
-
colin_44 authored
Add documentation for editors about validators. Add to sitetree. Resolves: #97025 Releases: main, 11.5 Change-Id: If250bae9acf265574f20bcef801d2c1fd66ceeb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73713 Tested-by:
-
colin.findeisen@tritum.de authored
This patch adds a documentation regarding form elements for editors. As a drive-by change the site trees for integrators and editors have been fixed. Resolves: #82357 Releases: main, 11.5 Change-Id: I06548dd0f51cdbd814067f1c44e49629fd56b68e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73700 Tested-by:
-
Oliver Hader authored
DefaultSanitizerBuilder for HTML sanitizer creates a new behavior for each invocation which is superfluous and can be cached in memory. Resolves: #96862 Releases: main, 11.5, 10.4 Change-Id: I4a6710524a1f2f1256c8aa7694ceaa56a627a07f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73459 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Feb 25, 2022
-
-
Oliver Bartsch authored
Previously, the Belog module was accessible in System>Log as well as a third-level module in web>info. Latter required a couple of hacks, e.g. a manual extbase bootstrap. To simplify the underlying codebase, the "log" submodule is now removed from web_info. The main benefit of the log module in web>info was the usage of the page tree to filter logs by page. This feature will be added to the System>Log module in another patch again. Also note that since TYPO3 v9 ist also possible to access relevant page and record logs in the history module. Resolves: #97031 Releases: main Change-Id: I2d445b0b9039ee9a99ba262729b34f3736448a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73708 Tested-by:
-
Nikita Hovratov authored
The TCA type group became more and more a pure database relation type throughout the years. The only annoyance that was still there is internal_type with "folder" set. Although they are very similar in the user interface, internally they are handled completely separate. They share only a fraction of common TCA properties, too. This leads to checks for internal_type !== 'folder' everywhere across the codebase. To avoid this, folder must become an own type. With folder as an own type, the code becomes much more readable and there is a lot less if-branching. Resolves: #96983 Releases: main Change-Id: Ifb746be9a5fc978a9a47af4c9e65bfc5498abf51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73622 Tested-by:
-
Björn Jacob authored
The documentation now includes an overview of the used validation messages and their error codes. While being on it, the DateRange validator has been documented as well. Resolves: #87393 Releases: main, 11.5 Change-Id: I5e91131d5464fde370609310a2a5a5a3b64941c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73714 Tested-by:
Elias Häußler <e.haeussler@familie-redlich.de> Tested-by:
-
Björn Jacob authored
The API Reference of the form framework resided inside the docs for integrators. This patch creates a new main chapter "For Developers/ API Reference" and moves all the related content there. In addition, the content has been splitted in three documents. Resolves: #97039 Releases: main, 11.5 Change-Id: Ie626f3ebdd137dfb7aef308b1bf7568dc17de985 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73710 Tested-by:
Colin Findeisen <colin.findeisen@tritum.de> Tested-by:
-
Elias Häußler authored
The localization of error with code 1521293686 in DateRangeValidator is missing. This patch adds the missing localization. Resolves: #97044 Releases: main, 11.5 Change-Id: I18c05c17d34f85b897c796cb987a94151d6da1ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73715 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Ralf Zimmermann authored
To make the form manager and form plugins load faster, the patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/58054/ optimized the parsing of form definitions. Instead of using the YAML parser, a very rudimentary "parser" was introduced. This works fine, except for the fact that YAML escapes in form labels are not unescaped when displayed. This patch partially reintroduces the parsing of YAML, but only for the label. The performance drops only slightly. 10000x "loadMetaData()" (status quo) = 0.41 seconds 10000x "loadMetaData()" + parse label with yaml parser = 0.57 seconds 10000x parse the whole form definition with yaml parser = 7.57 seconds Resolves: #95733 Releases: main, 11.5 Change-Id: I742b18313af4c8fe90d2899848518d90f543f86e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73688 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Helmut Hummel authored
As a followup to #96424, expressive API is introduced and covered with unit tests, to better convey the intention in the places it is used. Resolves: #96424 Releases: main, 11.5 Change-Id: I9596e2269b891042cbb03ccbedfcbc086f2897ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73707 Tested-by:
-
Björn Jacob authored
This patch adds a new FAQ entry. It explains how to handle duplicate form submissions. Resolves: #95074 Releases: main, 11.5 Change-Id: Ide89f57dc296ab629b9bb50d76d7896cb998c008 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73701 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
- Feb 24, 2022
-
-
Christian Kuhn authored
Scenario: * Create a page in live * Create a default language content element in live * Localize live page * Select a workspace * Localize the content element in workspaces, translate mode * Select live workspace * Delete default content element in live When deleting the default language content element in live, usually all translated content elements are deleted, too. This does not work for content element translations that have been created in workspaces (t3ver_state=1). Those elements *should* be discarded, but are not. The patch adds a method to DataHandler to take care of discarding t3ver_state=1 translations in workspaces when a live record is set to deleted, and adds two functional tests to verify behavior. Resolves: #97018 Releases: main, 11.5 Change-Id: I1bba5de52447cdfb9e80feca27aebf9855dccd28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73690 Tested-by:
-
Chris Müller authored
Resolves: #96953 Releases: main, 11.5 Change-Id: I5071050dd7e2eac39c8578fd8dcb915b94a22aa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73588 Tested-by:
Markus Gerdes <markus@madaxel.de> Tested-by:
-
Elias Häußler authored
If section containers are changed (i.e. new containers are added or existing ones are deleted), the change is now recognized by adding a class `has-change` to the appropriate container. This assures the modal on exit is shown to the backend user to avoid discarding onsaved changes. Resolves: #95290 Releases: main, 11.5 Change-Id: Iff85a98f5f93876d1151909d28641ac6cca70874 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73699 Tested-by:
-
Björn Jacob authored
The form framework ships a "date range validator". The validator can for example be added via the form editor to the "date" form element. Especially when it comes to this element, the order of the available fields is not in line with all of the other form elements. The field "Custom error message" (validationErrorMessage) is usually the last field. Since the order can only be adjusted by changing the key within the form configuration, this patch adds according comments to the form configuration. The breaking change will be done with TYPO3 13.0 to further streamline the UI. Resolves: #97019 Releases: main Change-Id: Ia39e61a5a9abce22c1c327f0786c824851a06d63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73691 Tested-by:
-
Elias Häußler authored
Since form renderable validators are stored as SplObjectStorage instances, it is currently impossible to properly reset those validators, e.g. within a configured variant in the form configuration. This is because detaching during a foreach over SplObjectStorage instances updates the internal pointer. This leads to inconsistent behavior in the foreach loop. To come around this issue, a cloned SplObjectStorage is now used to remove all currently registered validators, properly resetting all validators for the form renderable. Additionally, this edge case is now covered by a functional test case. Resolves: #96424 Releases: main, 11.5 Change-Id: I91268e28a2c08fa21d655373e272204fbb9b84f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72767 Tested-by:
-
Björn Jacob authored
Integrators have to be aware of a problem when sending emails to BCC recipients. This patch documents the problem and offers a solution as well as links to the TYPO3 Core API as well as Symfony Docs. Resolves: #92354 Releases: main, 11.5 Change-Id: Ia1594d8f8c93dfa5c4d58e12d13e61aa350ea9d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73697 Tested-by:
-
Elias Häußler authored
Resolves: #97024 Releases: main, 11.5 Change-Id: If4b85ca494226fdd793af169c1e389e529e785b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73702 Tested-by:
-
Georg Ringer authored
With #86196 the condition for `contentObject` has been accidentally removed. Resolves: #92471 Related: #86196 Releases: main, 11.5 Change-Id: I2c6ca4668141639650e3b4b1b58da2270f827f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66054 Tested-by:
-
checkmaldierethorik authored
With deprecating 3rd party usage of getTreeList() in QueryGenerator and QueryView with #92080 a comma has been missed as element list separator for a list merge with array_merge(...) in WorkspaceService. This emits a corresponding native PHP warning or error. Missing comma is added to avoid the warning and merge the elements properly. Resolves: #97011 Related: #92080 Releases: main, 11.5 Change-Id: I612eecac4ff1222191d6310e8996268e8746de69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73682 Tested-by:
-
Benni Mack authored
This change adds a separate check that if no frontend.user aspect is set, then the method "groupAccessGranted" should default to false. Resolves: #97014 Related: #96996 Releases: main Change-Id: Ifb2ab4586c49aee1ec7a1a058d4e1efcb358a061 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73686 Tested-by:
-
Stefan Bürk authored
Since the LinkBrowser uses custom templates, while usually initialized outside of ext:recordlist, the packageName has to be passed to the factory to announce the template paths. Resolves: #97007 Related: #96962 Releases: main Change-Id: I9c24c85dbfcc0dd991259ed1b4c2d0c5e0954b83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73676 Tested-by:
-
- Feb 23, 2022
-
-
Jan Delius authored
LanguageService state has been moved into runtime cache for further reducing the need to keep the LanguageService in a global state. Failing to predict the need to translate into multiple languages in the same context and process, $cacheIdentifier had not be included the language. This patch adds the current language to the $cacheIndentifier to support multiple language translation while keeping the LanguageService state clean. Resolves: #97009 Related: #94415 Releases: main, 11.5 Change-Id: If1eaa3d2724ccdd12979a974c30d722878eb55d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73680 Tested-by:
Jan Delius <me@jandelius.eu> Tested-by:
-
Oliver Bartsch authored
Since #96998, options have to be set using setOptions(). Resolves: #97010 Related: #96998 Releases: main Change-Id: I16511c732832949d73822a258b7849b63f50f26d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73681 Tested-by:
-
Björn Jacob authored
The documentation ships a page which shows the complete YAML configuration of the form framework. The page is outdated and therefor useless. Instead of having this static page, the actual configuration of the form framework can be checked via the backend module "Configuration" | "Form YAML Configuration". Resolves: #97005 Releases: main, 11.5 Change-Id: I576206df0a17101c16e5aeb89cc0f6be2eae83ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73673 Tested-by:
-
Björn Jacob authored
This patch fixes all remaining warnings in the form documentation. Resolves: #97004 Releases: main, 11.5 Change-Id: I185bbc47b9c6f5b037a1673225c33e40fcb88635 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73672 Tested-by:
-
Benni Mack authored
Since TYPO3 v11, the "debug" information from config.debug = 1 is added at a HTTP Header Level, and not as HTML comment, thus the additional check to enable content length as HTTP header does not need to respect this option anymore. Additional checks might be removed as well at a later point. Resolves: #97000 Related: #95103 Related: #82419 Releases: main Change-Id: I088314bea446971e62e96eacbc383db49e1ad311 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73649 Tested-by:
-
Oliver Bartsch authored
With the JavaScript module namespace change to @TYPO3/, the filelist context menu actions have been forgotten to be updated. Also a the contextmenu importmap tag was missing in order for the context menu to work in the file-navigation-tree. Resolves: #97001 Related: #96906 Releases: main Change-Id: Iecdc513e5f77c01a5c155e79c1df0c4505c7a53e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73650 Tested-by:
-
Christian Kuhn authored
This follows the preparations of #96332 which has been applied to v11 and v12. The Extbase validator interfaces are streamlined and more strict, setOptions() is now mandatory. All validators now declace strict_types=1 and all non-abstract validators are declared final. A ReST file of the breaking interface and AbstractValidator signature changes explains details on how to stay compatible with v11 & v12 aware extensions. Since a lot of the existing unit tests mock single validator subjects, which is no longer possible when they're final, those tests are transferred to functional tests. Change-Id: If04a04e78e2539017da00ae1607cad1c8615774f Resolves: #96998 Related: #96332 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73644 Tested-by:
-
Benni Mack authored
Record access checks are moved from TSFE to the new RecordAccessVoter class. This encapsulates corresponding logic at a central place. In addition, the existing hook $GLOBALS[TYPO3_CONF_VARS][SC_OPTIONS][tslib/class.tslib_fe.php][hook_checkEnableFields] is removed in favor of the new PSR-14 RecordAccessGrantedEvent. Resolves: #96996 Releases: main Change-Id: Ic056eb4c62d9792ee62198ae346db5231576d1bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73638 Tested-by:
-
- Feb 22, 2022
-
-
Stefan Bürk authored
Acceptance tests are the most likely tests to recover properly when automaticly retrying on test execution failure. CGL, integration, unit and functional tests on the other hand are more likely to fail with real issues and retry won't fix these issues, thus wasting CI execution time and job slots. The patch changes the default retry back to zero retries, except for 'acceptance' tests, including 'acceptanceInstall' tests. Resolves: #96999 Releases: main, 11.5 Change-Id: I570c7fc6c61fe55ab5f60b51c04161f935876d24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73647 Tested-by:
-
Christian Kuhn authored
The concept of 'validation groups' was introduced with a backport of Extbase validators from Flow back in 2013. It has never been fully implemented and is essentially dead code. The patch removes this artifact from the codebase. Change-Id: I07f24e20b59992537237433a9268849b2df986d2 Resolves: #96991 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73643 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
