- May 22, 2017
-
-
Christian Kuhn authored
A basic acceptance tests clicking through installer using a mysql db connection, checking backend login and "blank" site frontend output works. Change-Id: Ie14d9c6fd8280d382b4041f98fa04ed00ef8386c Resolves: #81285 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52880 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Claus Due <claus@phpmind.net>
-
Christer Vindberg authored
Use quoted/escaped values embedded in the SQL fragment instead of named parameters in QueryGenerator::getSelectQuery. The values of named parameters get lost when the SQL fragment is returned and subsequently used in a query. Resolves: #80872 Releases: master, 8.7 Change-Id: If22bf24b75d2aa0efe36e587e38e7c590f3ec34a Reviewed-on: https://review.typo3.org/52472 Tested-by:
Christer V <cvi@systime.dk> Reviewed-by:
Anders Kostending <aha@systime.dk> Reviewed-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- May 21, 2017
-
-
Christian Kuhn authored
Change-Id: I4ce5bae6d200bbd7eba6679136375c71cfb6e268 Resolves: #81289 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52889 Reviewed-by:
-
Christian Kuhn authored
A couple of bug fixes and a setup for acceptance tests of the installation procedure. Change-Id: I97c211acb6f65a48ee90a45885887f8d16f800b9 Resolves: #81287 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52885 Tested-by:
-
Elmar Hinz authored
Releases: master, 8.7 Resolves: #81280 Change-Id: I8689827c9e33202e7659a39bb55e7a9bfd792aa2 Reviewed-on: https://review.typo3.org/52877 Tested-by:
-
- May 20, 2017
-
-
Christian Kuhn authored
The components/ directory has been a temporary directory in v8 phase, does not exist anymore and can be removed from .gitignore. Change-Id: I0f690c8fb38733dc8d168a7e43078dffc60450ea Resolves: #81286 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52881 Tested-by:
-
- May 19, 2017
-
-
Anja Leichsenring authored
If the code given for PageNotFound_handling is a relative URL, the host determination gets skipped, resulting in a redirect of the markup of the page instead a proper redirect. Change-Id: Id9c26cba813c212438368cee031673dc59db360b Resolves: #81267 Relates: #81031 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52859 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- May 18, 2017
-
-
Thomas Schur authored
Prevent duplicated special char conversion of page title in TYPO3 backend breadcrumb and fix title cropping Resolves: #81242 Releases: master, 8.7 Change-Id: Id7710d8d8f79e20b20f43569558833d3d3f68f16 Reviewed-on: https://review.typo3.org/52820 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Josef Glatz authored
Related: #81171 Resolves: #81258 Releases: master Change-Id: I2a07571bb45aefd5927498dee5604edb99ba271b Reviewed-on: https://review.typo3.org/52855 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
The method PageRepository->checkWorkspaceAccess() does a SQL query to fetch the workspace record, then hands it over to BE_USER->checkWorkspace which has the same functionality - to fetch the full workspace record. As this is redundant code, the PageRepository code can be simplified a lot by just leaving the workspaceCache property. Resolves: #81187 Releases: master, 8.7 Change-Id: Ia82febb2269084ea9101acfc36a1c9aa20950290 Reviewed-on: https://review.typo3.org/52754 Tested-by:
-
Oliver Hader authored
Tryign to determine workspace versions for a particular database table results in a very long process execution time and possible timeout due to the following reasons: * in general a bug was introduced during the Doctrine DBAL migration which leads to misbehaviors in resolving versions for pages * the SQL query implicitly creates an INNER JOIN with a huge result set that takes a long query time * invalid types leading to possible flaws when using prepared statements The SQL query has been split into using sub-queries now. Change-Id: I4e4f69815bd73f0562f7ffbd6d411b417be7a18a Resolves: #80898 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52506 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
-
Daniel Windloff authored
In order to be consistent, change the button order and styling (according to the list module) in the InlineRecordContainer. Resolves: #78174 Releases: master, 8.7 Change-Id: I2f4498f1e822785c2b26dab697ec4fe26aae5ef0 Reviewed-on: https://review.typo3.org/50104 Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Jochen Greiner authored
The comment was wrong because the TSFE-Controller takes care of setting this option internally. Resolves: #81219 Releases: master, 8.7 Change-Id: If4af5b5aefa2758063e595e9e3e0b55892c7df27 Reviewed-on: https://review.typo3.org/52800 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Marcus Schwemer authored
Currently the prepend option is rendered together with the options argument from select viewhelper. Using the option "optionsAfterContent" renders also the prepend option after the children. The preprend option is now rendered always in the first place. Resolves: #79584 Releases: master, 8.7 Change-Id: Ia58c3b7d9b26d00cbda4d7ebce2a881a7129b331 Reviewed-on: https://review.typo3.org/51501 Reviewed-by:
-
Thomas Maroschik authored
When the Typo3DBQueryParser converts Extbase queries to Doctrine queries, it creates subselects for certain relation constraints. It fails to wrap the subselect in braces for has-many relations which leads to sql exceptions. This patch introduces braces around those subselects. Change-Id: Ie9721a01bf166391770c7a1471272af0e15f9ccb Fixes: #81240 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52817 Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Georg Ringer authored
The public method Scheduler::log accepts an optional $code as 3rd parameter. Add this information to the parameter $details of BackendUserAuthentication::writelog as otherwise it will be casted to an integer and its information will be lost. Resolves: #80592 Releases: master, 8.7 Change-Id: Iab5f1d285976e9e88795ebbe75faff9f689b1a8c Reviewed-on: https://review.typo3.org/52553 Tested-by:
-
Andreas Fernandez authored
Triggering ext:t3editor out-of-bound of FormEngine is pretty tricky and blocks further development of t3editor. To streamline this, the current implementation of t3editor within ext:tstemplate is revamped and now uses FormEngine directly to edit "constants" and "setup" of template records. Some hooks are now obsolete and dropped along the way. Resolves: #81171 Releases: master Change-Id: Iab62a15828bfb82bc9f8ad11f705bb4529a38734 Reviewed-on: https://review.typo3.org/52696 Reviewed-by:
-
Elmar Hinz authored
Update the comment of the mehtod PageRepository::getMountPointInfo(). Add hint addressing to the usage of recursive mount points. Change-Id: I095563cb940e25f8c5f004497d407733faf4cbcc Releases: master, 8.7 Resolves: #81254 Reviewed-on: https://review.typo3.org/52842 Reviewed-by:
-
Benni Mack authored
By moving Bootstrap::loadBaseTca() to the configure() call of the TYPO3 Bootstrap, the global TCA variable is now populated very early and it is obvious that this logic is then part of the actual system setup, and does not need to be handled by any RequestHandler anymore. Considering TCA is necessary for a TYPO3 environment to run, this change might be very helpful. Please note that the Install Tool application does not call configure(), so this is not affected. This also removes some issues related to Extbase Command controllers in CLI handling. Side effects: - eID requests now have full TCA loaded as well at any time - TCA is now loaded BEFORE entering any request handler check - TCA is now loaded before e.g. BackendRouting initialization, and other Backend security checks Easy to test the current behaviour: - Clear all caches via install tool - Call CLI command extbase:help which will result in a Warning / Exception Resolves: #72222 Resolves: #81201 Releases: master Change-Id: I31a0de0d0b039eb6180123678c61d3f26435dd63 Reviewed-on: https://review.typo3.org/52753 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Reviewed-by:
-
Fabian Thommen authored
Releases: master, 8.7 Resolves: #81253 Change-Id: I9920ba02349d51925610c2bd04fd8c3ea668e3a6 Reviewed-on: https://review.typo3.org/52832 Reviewed-by:
-
Helmut Hummel authored
DataHandler does a lookup in sys_log table after it performed its operations to find relevant error entries for the current request. It determines relevance by looking for entries with the same timestamp as $GLOBALS['EXEC_TIME']. However error log entries are written using time(). Now if the DataHandler operations take longer than one second, or the log entry is written directly before a next tick, it can happen, that errors will not be detected during the lookup process. Since such errors are exposed to the user, it can happen that an operation fails, but the users will not be notified. Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries. Resolves: #81244 Releases: master, 8.7, 7.6 Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e Reviewed-on: https://review.typo3.org/52822 Reviewed-by:
Felix Rauch <rauch@skaiamail.de> Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
- May 17, 2017
-
-
Gerrit Mohrmann authored
During the refactoring to doctrine in https://review.typo3.org/#/c/48574 a wrong expression was used. Use notIn() instead of in(). Resolves: #81246 Releases: master, 8.7 Change-Id: Icd1bf595fe3a75dc12d875a8a4c416c9b568c6c0 Reviewed-on: https://review.typo3.org/52825 Reviewed-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Daniel Windloff authored
In EXT:beuser -> Backend User Listing there is the possibility to add an user to the compare list. If the user is already in the compare user list, the user is removed from this list. Resolves: #81079 Releases: master, 8.7 Change-Id: If0d6c132cdb2dbbd524890c3c90f92877240a284 Reviewed-on: https://review.typo3.org/52660 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Christian Kuhn authored
Unit test: Fix namespace, test file location and class inheritance. Change-Id: Ida24b5adf747dc7c259a966fcddfdb7feb9f0951 Resolves: #80742 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52827 Tested-by:
-
Daniel Windloff authored
* move multi selector to the left * separate action icons * use info icon to open more information * move mass action actions to the left * use btn-default for actions * add icons to the mass action buttons Resolves: #81086 Releases: master, 8.7 Change-Id: Ib65343043a5c5c7ae77689d95502b389bb4acb0b Reviewed-on: https://review.typo3.org/52662 Reviewed-by:
-
Benni Mack authored
The method getRecordRaw has a very unspeakable method argument called "noWSOL" which is only used internally within PageRepository. Setting "noWSOL" to true only does a regular SQL query which can be implemented directly in the according places, as the WSOL does not need to be known. Resolves: #81218 Releases: master Change-Id: I459ead0172f4ca1a6655599dd47aee2651a452bb Reviewed-on: https://review.typo3.org/52803 Tested-by:
-
Andreas Fernandez authored
The HTML5 attribute `controlsList` is used in at least Google Chrome to limit the control buttons. The AudioTagRenderer and VideoTagRenderer classes are now aware of that attribute. Resolves: #81222 Releases: master, 8.7, 7.6 Change-Id: I9a577ae077e7e7b55b9fed7852a5a61a5fd4061a Reviewed-on: https://review.typo3.org/52801 Tested-by:
-
Christian Kuhn authored
Recent PHP unit minor upgrades fixed a bug in DateTimeZone reflection which is used as test object in our ObjectAccess reflection tests. Make the test a bit less strict to cope with youngest and older PHP versions at the same time. Change-Id: Iaf2290872938f4c04a3307b0fe73c933ca7d69d8 Resolves: #81239 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/52816 Tested-by:
-
Andreas Allacher authored
The new file extension .typoscript will be the default for TypoScript configuration files and is the only recommended one from now on. This effort is made to introduce a dedicated file extension for TypoScript configuration files, and to avoid conflicts with already existing and more spread file extensions like ".ts" for TypeScript or Video Transport Stream Files. Resolves: #78161 Resolves: #80689 Releases: master, 8.7 Change-Id: I44b41631f498e3ba39e0f1936329094a59859f4e Reviewed-on: https://review.typo3.org/50096 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Georg Ringer authored
Merge the extension into EXT:backend as it only consists of one AJAX controller - all other functionality related to context help is already in EXT:backend and deeply connected to Backend-related output code, so this is just a regular step. Resolves: #81225 Releases: master Change-Id: Ie5d577d62876f18414b61f5eefc9d9dd48d52430 Reviewed-on: https://review.typo3.org/52804 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
Remove arguments within f:be.container and f:be.pageRenderer which have been marked as deprecated before: * f:be.container->enableClickMenu * f:be.container->loadExtJs * f:be.container->loadExtJsTheme * f:be.container->enableExtJsDebug * f:be.container->loadJQuery * f:be.container->jQueryNamespace * f:be.pageRenderer->loadExtJs * f:be.pageRenderer->loadExtJsTheme * f:be.pageRenderer->enableExtJsDebug * f:be.pageRenderer->loadJQuery * f:be.pageRenderer->jQueryNamespace Resolves: #80707 Releases: master Change-Id: If1f36b3fb197e108cb12351145e312a5aaca6447 Reviewed-on: https://review.typo3.org/52520 Tested-by:
-
Susanne Moog authored
Parse time calculation in RequestHandler was wrong, additionally the same calculation is used in admin panel view. The calculation was therefore added to the TimeTracker into a common function and tested. Change-Id: Ib935664e78a62deab7818426e2a853087c00b015 Resolves: #80742 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/52727 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Wouter Wolters authored
EXT:recycler has some deprecated code that is now removed. Releases: master Resolves: #81237 Change-Id: I6db8ac155f2fe06a07528fbe17855c036f593e96 Reviewed-on: https://review.typo3.org/52642 Reviewed-by:
-
Benjamin Serfhos authored
When function is done, reset current file for further processing Resolves: #77645 Releases: master, 8.7, 7.6 Change-Id: Ibae2e3221c51c8cb45f92b0bc7dbe395cc809605 Reviewed-on: https://review.typo3.org/49616 Tested-by:
Benjamin Serfhos <serfhos@gmail.com> Tested-by:
Elmar Hinz <t3elmar@gmail.com> Reviewed-by:
-
- May 14, 2017
-
-
Faton Haliti authored
Cache the result of readLLfile() gives a better performance for cases where readLLfile() is called often. Resolves: #80788 Releases: master, 8.7 Change-Id: I59913c7c5124ebe54c567a0a7c126a32fdd60284 Reviewed-on: https://review.typo3.org/52406 Reviewed-by:
Faton Haliti <fha@systime.dk> Reviewed-by:
-
- May 12, 2017
-
-
Benni Mack authored
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
-
Mathias Brodala authored
If the title is too long, it gets cropped. Then, the link title must contain the whole string in order to provide a proper tooltip. Resolves: #81124 Releases: master, 8.7 Change-Id: I55b4784c431b4a495dc4089ab954eb3c7e1ca435 Reviewed-on: https://review.typo3.org/52692 Reviewed-by:
-
Mathias Brodala authored
This adds the link handler identifier to the error message which makes it easier to fix the missing class reference. Resolves: #81205 Releases: master, 8.7, 7.6 Change-Id: I0ce610f7ec167704d5cbc5de20d43639c18e3fc1 Reviewed-on: https://review.typo3.org/52787 Tested-by:
-
Benni Mack authored
The typolink calculation for checking of allowing frames has been encapsulated in the TypoLinkBuilder extraction, so this public property is also obsolete. Resolves: #81198 Releases: master Change-Id: Ic2d0e64a754da983abfd6c9bcaa66884eaa9af35 Reviewed-on: https://review.typo3.org/52782 Tested-by:
-
Benni Mack authored
Indexed Search still uses enableFields for querying page records, unlike most other places in the TYPO3 Core. This should be streamlined because it was forgotten in the initial migration. Resolves: #81194 Releases: master, 8.7 Change-Id: I0712f6811eefba6d2cb46ed06ff4b1d31ac7fa0b Reviewed-on: https://review.typo3.org/52768 Tested-by:
-
