- Mar 10, 2021
-
-
Benni Mack authored
This patch provides the following changes in order to have better abstractions and encapsulate the dependencies of each implementation. 1. SelectTree (Category Tree) The TreeToolbar is now clearly coupled into the SelectTree and built as LitElement inside the SelectTreeElement. SelectTree now contains all relevant functionality regarding selecting multiple items, and shows settings (SelectTreeSettings) which were only used in SelectTree. This is especially relevant for the multiple item selection, and the exclusiveKey handling. 2. PageTree + FileStorageTree Obsolete public methods are removed, and visibility is changed. Filtering is now separated in favor of a non-public property. By using Types (in e.g. PageTreeDragDrop) the visibility is also adapted Obsolete wrapper methods are removed. Resolves: #93692 Releases: master Change-Id: Ifead098bb80e37d5c7ad5e1d0eabda14aa7087ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68303 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benjamin Franzke authored
The shortcut handling added in #86248 caused the matching command to be loaded before the symfony DI container was made available to GeneralUtility::makeInstance (FailsafeContainer was still active). This caused services (e.g in #93442) that are instantiated using the GeneralUtility::makeInstance-to-DI-Container bridge to fail as these services are not available in the FailsafeContainer. Background: the symfony Application:find() method did not just search for a matching command, but it also initialized it, once found. Therefore shortcut resolving is now handled within the TYPO3 command application to ensure commands are only instantiated once the symfony container (and localconf) is fully loaded. Resolves: #93569 Related: #86248 Related: #93442 Releases: master Change-Id: I717df6aa03f4f474e437f98eef62d291e39010fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68254 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Mar 09, 2021
-
-
Benni Mack authored
The login controller now allows to set two new GET parameters "redirect" (pointing to a valid route identifier) and "redirectParams" (a list of query arguments which are rawurlencode'd). This way, the login controller can redirect to another route instead of dealing with a hard-coded "redirectURL", which can be phased out in the future. This is a first step towards allowing a defined redirect route for all other places in the TYPO3 Backend, where currently "redirectURL" is used. Also "linkThisScript" should become obsolete after this change. This change also removes the need to store a first click in the install tool when loading the distributions within the "uc". Resolves: #93674 Releases: master Change-Id: Ic00113e528d00ab97215d750e1826d1ae8467a32 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68198 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Christian Kuhn authored
Milestone: With a last series of type handling and array access fixes throughout core and in typo3/testing-framework, a first set of functional pre-merge tests can be enabled with PHP 8.0. composer req --dev typo3/testing-framework:^6.7.2 Resolves: #93686 Releases: master Change-Id: I2d35725967be563fe9408083ee8aee59ea1533e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68294 Tested-by:
-
Georg Ringer authored
LanguageService::sL(), also known as the split label function, is widely used through Core and third-party extensions. It checks if the given input is a label reference and otherwise just returns the input. Since this method is often used with dynamic values, coming from e.g. XML files, there might be whitespace in the input string. In such case the label reference can not be resolved, even if the key is valid, and the input gets returned unchanged. To prevent this behaviour, LanguageService::sL() now applies trim() to the input, whenever a specifc strpos() check takes place. Resolves: #93676 Releases: master, 10.4 Change-Id: If195b5fed75f79912edd6478ad3a47a27157155d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68255 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benni Mack authored
Native HTMLElements are more versatile than a the current NavigationComponent interface. All custom actions can be dispatched via events, that means the NavigationComponent interface, as recently introduced in #93672, is removed again. Resolves: #93685 Releases: master Change-Id: I578810ce655d1da3f34bcb456967f62756793b24 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68233 Tested-by:
-
Benni Mack authored
When in a workspace, the slug of a workspace'd page record is properly resolved (good!), but the versioned ID of the page is used within the PageArguments. This is in turn lets TSFE think that the "Page ID" is the versioned ID, which is wrong (similarly to the localized page ID / translated page ID), which always need to be the live Page ID in order to properly handle records on the page ("pid=live/default ID of the page") Resolves: #93650 Releases: master, 10.4 Change-Id: I52e3880e2edb1f774a5dfb24a7bddaf81a3dcb19 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68182 Tested-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Andreas Fernandez authored
With the update to Bootstrap 5 the CSS class name for animated progress bars changed from `active` to `progress-bar-animated`. This patch updates the wrong class names accordingly. Resolves: #93682 Releases: master Change-Id: If8f4e388513822f0457afa2a37d88ed440f6d709 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68259 Tested-by:
-
- Mar 08, 2021
-
-
Benjamin Franzke authored
The v1.1 interface adds support for parameter type declarations. Also mark as psr/container v2 compatible as we add the `bool` return type annoation for `has()` right away. (yes that is compatible with the v1.1 interface, although it doesn't contain a return type declaration) This is not yet testable against psr/container v2, but will show up in nightly composer-max stages once symfony/dependency-injection is released with support for psr/container v2. Commands used: composer require "psr/container:^1.1 || ^2.0" composer require "psr/container:^1.1 || ^2.0" \ --no-update -d typo3/sysext/core Releases: master Resolves: #93681 Change-Id: Ia0e5024bae0a05ae72b83964233d449b63896440 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68256 Tested-by: -
Benni Mack authored
TSFE now always contains the Site object so it is not necessary to use the SiteFinder based on the ID to fetch the correct Site anymore, but use TSFE->getSite() directly. Resolves: #93654 Releases: master Change-Id: I2ddd6b0409f73edc4f6fa8f6c7bb0ab21d567272 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68188 Tested-by:
-
Georg Ringer authored
If a label is too long, which is especially possible if the field name is shown, it should wrap into new lines. Resolves: #93462 Releases: master, 10.4 Change-Id: I6150e4c62e06b28c952f8b9f4f71115ffedd4401 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68189 Tested-by:
-
Benni Mack authored
Historically (even before TYPO3 3.3.0), the UI language (the language of the TYPO3 Backend of a user) is stored in ->uc['lang'], which is only filled from the database field be_users.lang when a user logs in the first time. be_user.lang is/was used for admins when creating users to set a default language when the user first logs in for the first time, but is never used afterwards. However, using "uc[lang]" in various places does not make life easier because uc always needs to be unpacked (e.g. for sending bulk mails to users, or changing languages for users as admins, listing users' preferred languages in list module). For this reason, be_users.lang now defines the users' UI language, however uc[lang] is synced on each login of a user now, if the language has changed. In addition, the TCA for be_users.lang is now handled via an itemsProcFunc, making uncached requests a tiny bit faster as Locales are not populated during TCA creation, and allows for more features such as dynamically showing available/downloaded languages in a be_users FormEngine field. The Setup module now updates be_users.lang instead of uc[lang], which makes it easier in the future to use native TCA for rendering the setup module fields. An upgrade wizard migrates all "uc[lang]" values into "be_users.lang" and ensures that empty values are never used, instead "default" (= English) is added to all user records to have an explicit value (also for new users). Resolves: #93663 Releases: master Change-Id: Icb8e07f3fabb1f3022f3adcbdce6dc9efd790302 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68192 Tested-by:
-
Oliver Bartsch authored
This improves some MFA labels and fixes some typos. Resolves: #93657 Releases: master Change-Id: I0078e606d90aebdd3110c4a753170180d2870f8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68190 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
composer req --dev typo3/cms-styleguide:~11.1.0 New version brings a series of field label changes. The FormEngine acceptance tests need a slight xpath adaption to deal with this, which also stabilizes the selectors a bit. Change-Id: I3b4ac800b3d9303228ed652f23aaf2d6c773274d Resolves: #93673 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68232 Tested-by:
-
Christian Kuhn authored
One last place in PlainDataResolver now gets the missing DeletedRestriction added to a query. This should stabilize some usages in DataHandler and a couple of other places. A detail with workspace inline scenarios and delete placeholders with sorting is changed together with the patch to not trigger side effects. The scenario is described in detail with a code comment. Resolves: #92481 Releases: master Change-Id: Id2c4d09c5c36caa299ab6ee7aa6b63c20f926dad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66011 Tested-by:
-
Daniel Goerz authored
Resolves: #93658 Releases: master Change-Id: I257f425d267114b9fa54636c66a77ddbeffa2bad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68193 Tested-by:
-
Christian Kuhn authored
PHP 8 throws warning level errors instead of notice level errors when an not existing array key is accessed. The patch fixes another batch of this kind of issues found by functional tests. Resolves: #93675 Releases: master Change-Id: I88e2a0a28af21a95b9ec3e74c7449d9cdc7a23bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68234 Tested-by:
-
Benni Mack authored
In order to use the non-iframe navigation component properly, the current ties to "PageTree" (which was de-facto the only possible navigation component to be used until TYPO3 v11 due to heavy coupling) are removed. The TreeInterface, which served as a wrapper for the PageTree Navigation Component is removed, and replaced by the NavigationComponent interface in TypeScript. In addition, loading and initializing (and keeping state) of the used navigation component now solely relies in the NavigationContainer. This in turn, finally allows to e.g. properly re-load the FileStorageTree and PageTree separately (see BackendUtility change) while incorporating some ES6 nullable functionality. In addition, the NavigationContainer is now jQuery-free. Resolves: #93672 Releases: master Change-Id: Ia16a3e789459225b21fa12efd1db6f3b4500cfef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68201 Tested-by:
-
Christian Kuhn authored
Resolves: #93638 Related: #93632 Releases: master Change-Id: I89c3b9835bc894973034841e22934608ad681403 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68174 Tested-by:
-
- Mar 06, 2021
-
-
Christian Kuhn authored
Scenario: A translated content element is hidden in live, a workspace overlay is not hidden. In workspace preview, the element should be shown - since it is not hidden in workspace. This is not the case. The patch fixes this: The 'base' db call for content elements ignores hidden & time based restrictions and elements are sorted out by versionOl() instead, if a workspace preview is requested. Resolves: #93336 Releases: master, 10.4 Change-Id: I6ed285c0fae240482da8719ab50b26f89375d599 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68185 Tested-by:
Sebastian Michaelsen <michaelsen@t3seo.de> Tested-by:
-
- Mar 04, 2021
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master Resolves: #92280 Change-Id: Id2ef49722eb608d8810bd61f46e018664eb19d51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65680 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Daniel Siepmann authored
The reference to 85829 was broken. It linked to 9.5 while the actual change was made in 9.4. Therefore the link is adjusted to link to the actual existing file. We use the :doc: syntax to allow sphinx to properly build the URL from relative file path. Resolves: #93641 Releases: master, 10.4, 9.5 Change-Id: Ia7755110b67ee4ff2efd3755cc5037d1f8e35f29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68181 Tested-by:
-
Christian Kuhn authored
Change-Id: I9b365a2adf98bfa52352a95b225f338e75f93871 Resolves: #93640 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68175 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Mar 03, 2021
-
-
Oliver Bartsch authored
Accessing the workspace module while in live workspace led to a JavaScript TypeError. This is fixed by proper type checking. Resolves: #93625 Releases: master, 10.4 Change-Id: Ief2f484f197ce068660dffc1751618fbc17c0cd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68165 Tested-by:
-
Oliver Bartsch authored
This removes some searchFields from sys_file_reference, since they are not suitable for users, searching for such records in the backend. As a side effect, a superfluous condition in workspaces is removed. Resolves: #93634 Releases: master Change-Id: I5204a79146128cbca0a3b74eda7b11ed5bcd7119 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68171 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Daniel Siepmann authored
The ViewHelper does not clear cache since 7.3.0 change: https://review.typo3.org/c/Packages/TYPO3.CMS/+/34818 Still the documentation states it will clear cache. Instead users need to take care to properly clear cache. The background: FlashMessages often tend to be part of a process and already work with proper cHash and URLs. Unique URLs often lead to unique output of FlashMessages. Under some circumstances flash messages might be created before redirecting to a generic URL. Resolves: #93636 Releases: master, 10.4 Change-Id: I15479d31671a04ce12336583767277f0fc25cbca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68173 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Martin Kutschker authored
The EXT:install ServiceProvider introduced in #89892 didn't respect that LanguagePackService implements LoggerAwareInterface. That means the logger variable was null and usages of the logger resulted in exceptions. Refactor the class to require the logger instance to always be injected via constructor injection, to prevent this from happening again. Resolves: #93630 Related: #89892 Releases: master, 10.4 Change-Id: I71309863e096e5289336831ec4da294a5bcb65cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68170 Tested-by:
Oliver Wand <wand@itaw.de> Reviewed-by:
-
Benni Mack authored
The EM is not using the API for writing and reading the UC, and can be massively simplified. Resolves: #93622 Releases: master Change-Id: I0a3e4d935437f38f49401c52826f182492690d2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68161 Tested-by:
-
- Mar 02, 2021
-
-
Oliver Bartsch authored
The workspace module features the element information modal, which displays, next to the record history, the current version records' difference to its live record. This difference is now also displayed for new and delete placeholder records. It's not reasonable forcing the user to always open the complete record to have a quick look at the values of e.g. a new record. Since new / delete placeholders basically contain all fields, defined in TCA, they are filtered using the FormDataCompiler to only show the suitable ones. Resolves: #93620 Releases: master, 10.4 Change-Id: Ib58d568664e3aecb13afa023c0e05f188662811d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68156 Tested-by:
-
Georg Ringer authored
Call the user functions with an empty array instead of null as 2nd argument. Resolves: #93513 Releases: master, 10.4 Change-Id: Ibc50b9e3ec7defc0100e5ae6447b05fca8e77cd7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68168 Tested-by:
-
Mathias Brodala authored
When there is no "cv" or "s" parameter we should not perform any image processing. This is essential e.g. for accessing PDF files in private storages. These can technically be processed but should never be since then the original PDF file becomes inaccessible. Releases: master, 10.4 Resolves: #93024 Related: #90068 Change-Id: I956cc3840a14b25d57b073be81838fb33c0250f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67333 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Christian Kuhn authored
Change-Id: Ib1e08417a716882e8c354da92d090efdb6924dc7 Resolves: #93632 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68160 Tested-by:
-
Anja Leichsenring authored
Due to a interdependency between tests and a recent reordering, the Input Range Test found itself on the wrong tab of the backend input form. The setup of the test now ensures the correct tab is active before starting to fill out fields. Resolves: #93629 Releases: master Change-Id: I21c6ac6a56db72bd347f3d4617162f61d21b6eff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68167 Tested-by:
-
Benni Mack authored
This change adds test images for checking if the installed IM/GM version can create webp images. Similar to the pdf/ai files tests, these changes are allowed to fail, and - if the browser does not support webp (https://caniuse.com/webp) - will not show up either. Resolves: #93627 Releases: master Change-Id: Ib676f2ad096d21266aba9ee14d235377432c63c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68166 Tested-by:
Daniel Sattler <sattler@b13.de> Tested-by:
-
Oliver Bartsch authored
In case of switching to a user, having MFA enabled, with a user, having MFA disabled, the switching user is required to pass the target users' MFA, because the transformed session does not contain the `mfa` key. Since it's obviously not possible to pass another users' MFA, we need some exception for such scenario. Therefore, the evaluateMfaRequirements() method from AbstractUserAuthentication is overwritten by BackendUserAuthentication to check if the current session is a switch-user session. In this case, MFA is skipped. Otherwise the parent method is executed. Skipping MFA will be logged. Resolves: #93624 Releases: master Change-Id: I0625b23bee5aa202a20e2bb7ad46b6e606769134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68164 Tested-by:
-
Oliver Bartsch authored
Since #93455 it's possible to restrict backend routes to a limited set of HTTP methods. This route property is now also displayed in the corresponding "Backend Routes" configuration module provider. Resolves: #93623 Releases: master Change-Id: Ibc2bff74894a8d5f0be571d290706909dd98c009 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68163 Tested-by:
-
- Mar 01, 2021
-
-
Anja Leichsenring authored
The acceptance test suite for the stand alone install tool can easily coexist with the other backend related tests, there is no good reason for the overhead of a separate suite. So it gets merged into the backend suite. Resolves: #93621 Releases: master, 10.4 Change-Id: I460596985cd992c4f7d59df989c7992590e479d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68158 Tested-by:
-
Stephan Großberndt authored
This patch changes the behaviour when saving the backendfilter in extensionmanager list to not allow any class unserialize as TYPO3 Core does not put any classes in the UC and no other place in Core allows to unserialize stdClass for be_users.uc. Resolves: #93617 Releases: master, 10.4 Change-Id: I4b0ba03fb1ea02e97327e11fcd76486d3bd4cda6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68155 Tested-by:
-
Jigal van Hemert authored
If the hook is used to add TypoScript, information must also be added to the rowSum array in order to generate correct cache keys. Resolves: #93597 Releases: master, 10.4 Change-Id: I9d543872206333d02b8eb6b5cdd90a53e6c6accb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68153 Reviewed-by:
-
Alexander Schnitzler authored
Several reflection methods are deprecated for a while and throw errors with PHP8. - ReflectionParameter::getClass() - ReflectionParameter::isArray() Both need to be replaced with the new api: - ReflectionParameter::getType() Releases: master, 10.4 Resolves: #92946 Change-Id: I9391cd260f0d4dba5eb03f63c1f74f01bd97e7e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66936 Tested-by:
-
