- Sep 09, 2021
-
-
Oliver Bartsch authored
DatabaseRecordList is used at various places, e.g. in the Record Selector, but also for the TableList view helper. Recently, a lot of patches touched DatabaseRecordList, leading to some problems for the usages. Therefore this patch does the following: * Include required language file in TableListViewHelper * Handle "readOnly" setting correctly in TableListViewHelper * Remove record download action in DatabaseBrowser * Replace call to non-existing method in RecordDownloadController * Add missing JavaScript modules for RecordLinkHandler * Restore "showLimit" property in DatabaseRecordList Resolves: #95120 Resolves: #95138 Releases: master Change-Id: If35d71698741c10e9b7d54f222f9fbb95e61e414 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70957 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
In single table view, there was previously the option to edit all shown fields of the listed records. This option got unintentionally removed in #95068 and is therefore now restored. Resolves: #95134 Related: #95068 Releases: master Change-Id: I65e31907032a164bd1bbad20b5fa154fbb93243a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70954 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
It's possible to assign additional attributes to context menu items. Those attributes are then available in the corresponding JavaScript callback method. Therefore, there is no need to add settings, only used in the callback methods, globally via BackendController hooks. This patch removes such hook usages from EXT:filelist and EXT:impexp, while adding the corresponding settings as attributes to the context menu items. Resolves: #95131 Releases: master Change-Id: I4972fb93a6c0007e19b848be1659553008f2c5ec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70914 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Oliver Bartsch authored
This patch does two things. 1. Fixes the display of CSH in the the setup module. More precisely, the wrapping of the field label is changed, so that styles are properly applied again. 2. Adds CSH for newly introduced fields + avatar Resolves: #95143 Releases: master Change-Id: I74c636d54a3c7fd88a615e248aa3ba21133ee456 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70961 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
Rick Septer <rick.septer@maxserv.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Dennis Prinse <dennis.prinse@maxserv.com> Reviewed-by:
Rick Septer <rick.septer@maxserv.com> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The Extbase ControllerContext is a dependency between Extbase and Fluid to communicate state. It is wired into various view related classes. To further decouple fluid from extbase, this class needs to fall. A couple of previous patches deprecated parts of the class already, this patch deprecates the rest. The fluid RenderingContext can be used in view helpers in almost all cases as substitution, especially since extbase request implements PSR-7 ServerRequestInterface. The core itself has no direct usages of ControllerContext anymore, it is only moved around at various places. Change-Id: Ic4af492b9818003321ceeb6c9e6dcd29c5662271 Resolves: #95139 Related: #93019 Related: #93016 Related: #94428 Related: #92826 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70956 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Mathias Brodala authored
Also introduce groups for the HTTP status items to make the distinction between 301/302/303 (may change HTTP method to get) and 307/308 (keep HTTP method) clear. Resolves: #94922 Releases: master, 10.4 Change-Id: Ifdbe4e73146a4510abe1ebae6bb435cd78a457cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70677 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
Rick Septer <rick.septer@maxserv.com> Tested-by:
Jorgen van der Kroon <jurgen@alternet.nl> Tested-by:
Jeroen Schutte <jeroen@besitegroup.nl> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Rick Septer <rick.septer@maxserv.com> Reviewed-by:
Jorgen van der Kroon <jurgen@alternet.nl> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
Jeroen Schutte <jeroen@besitegroup.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com>
-
- Sep 08, 2021
-
-
Oliver Bartsch authored
The ClipboardComponent JavaScript module is no longer used, since the introduction of multi record selection in #95068. Therefore, it's now removed. Resolves: #95156 Releases: master Change-Id: I3d3b1ae3f53651ec91ac9de0075c741e92ea959d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70974 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
Using tables in panels requires the tables to avoid any margin-bottom, since the panel already defines such. A special case is using the wrapper class "table-responsive", placed between the panel and the table element. This use case was previously handled by bootstrap directly, but got removed with v5. We therefore, handle this case now on our own. Resolves: #95147 Releases: master Change-Id: I9c27bf9f5100b1ee1037ea30519a9a6ad7f7d77d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70969 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Jorgen van der Kroon <jurgen@alternet.nl> Tested-by:
Dennis Prinse <dennis.prinse@maxserv.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jorgen van der Kroon <jurgen@alternet.nl> Reviewed-by:
Dennis Prinse <dennis.prinse@maxserv.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Andreas Fernandez authored
The first release of the v2 branch of guzzlehttp/psr7 was in June 30th 2021, which is around two months from now at the time of writing this commit message. Many 3rd party libraries are not compatible to version 2.0 of guzzlehttp/psr7 yet, which makes updates impossible without using nasty hacks. For this reason, the constraint is loosened to allow both, 1.7 and 2.0 of guzzlehttp/psr7. Executed commands: composer req guzzlehttp/psr7:"^1.7.0 || ^2.0" composer req guzzlehttp/psr7:"^1.7.0 || ^2.0" -d typo3/sysext/core --no-update Resolves: #95136 Related: #94454 Releases: master Change-Id: Ic1efe3da5f6aede215720e7a86ab24475922f0a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70955 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Riny van Tiggelen <info@online-gamer.nl> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Bartsch authored
Having a numeric pad selected, pasting of a single element did previously not work, using the "paste" button in the page layout due to the missing "pad" parameter in the ajax call. This is now fixed by adding the "pad" parameter, which changes the current pad to "normal" before executing the paste command. Resolves: #87118 Releases: master, 10.4 Change-Id: If96859f3ee1fad3c7c6b0f026c420f715b75626f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70963 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Hader authored
This change extracts dynamically added frontend JavaScript `openPic` and `linkTo_UnCryptMailto` which are extracted to static file `EXT:frontend/Resources/Public/JavaScript/default_frontend.js`. Mentioned file is loaded automatically as async script element. As a result, view-helper `<f:uri.email>` became obsolete, which is deprecated and considered to be removed with TYPO3 v12.0. Resolves: #95041 Releases: master Change-Id: Ic1a17e11e5acfab4a1e3fe60d921a0ddc647f83e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70827 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org>
-
- Sep 07, 2021
-
-
Stefan Bürk authored
PHP 8.1 introduces language features and deprecations. As always, the first step is having a green test suite. Testing container typo3/core-testing-php81 has just been released, coming with PHP 8.1.0 RC1. Some issues are obvious when running the test suites, they will be fixed with upcoming patches. This patch adds support for PHP 8.1 to runTests.sh, example: Build/Scripts/runTests.sh -p 8.1 -s unit Resolves: #95141 Releases: master Change-Id: Ia5d09ddc2a3114e07a8f87aa9ef14740be2785af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70960 Reviewed-by:
crell <larry@garfieldtech.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
crell <larry@garfieldtech.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Helmut Hummel authored
This replaces a lot of string-based comparisons spread around the code, which have been even wrong. Having a single place for this kind of checks is beneficial. The method is added to PathUtility as similar methods are already present there. Releases: master Resolves: #95121 Change-Id: Ic73aac5d8c758dee5e0424bf2d54cd62b4b09e0c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70913 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
Update browserslist package to update the browser versions we're supporting and respect their capabilities when building assets. Executed commands: npx browserslist@latest --update-db grunt build Resolves: #95130 Releases: master Change-Id: I0dd9634648a1df72c1449047d601ac52b758917c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70922 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Bartsch authored
The mentioned hook has been deprecated with #95105 and is therefore replaced by the corresponding PSR-14 event. Resolves: #95140 Related: #95105 Releases: master Change-Id: I16cb92f46c0e06243e55ce86bd39572e83609293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70958 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Jochen Roth authored
Processing of "Manage Reference Index" actions (check/update) can take quite some time. To give the user better feedback of the current state a loading indicator has been added and buttons are disabled during processing. Resolves: #95094 Releases: master Change-Id: Ia1d19eb6d63c4d980e548820cc795b5c0b892164 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70879 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Benni Mack authored
Change-Id: I0c887b2b4dadead96e315c0b4f5153d391e7ea94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70953 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Benni Mack authored
Change-Id: Ibae91e9f44a65697321611f49eef10ddb1a39ba9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70952 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Jochen Roth authored
Sometimes during testing the imported page 404 can't be found. The import acceptance test has been improved using the given "getPageXPathByPageName" method so it will hopefully behave in the future. Resolves: #95116 Releases: master Change-Id: Ic37d5afa014ee1c823b34f1a3700338d78c8a3b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70912 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Composer command: composer u 'doctrine/annotations' --with-all-dependencies; \ composer u 'doctrine/event-manager' --with-all-dependencies Output: - Upgrading doctrine/annotations (1.12.1 => 1.13.2) - Upgrading doctrine/event-manager (v1.0.0 => 1.1.1) Resolves: #95129 Releases: master Change-Id: I0f0ba6221ed28b38e388cdc66e49d87ce1869b01 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70923 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Oliver Hader authored
Composer command: composer update 'symfony/*' 'guzzlehttp/*' --with-all-dependencies Output: - Removing symfony/intl (v5.0.7) - Upgrading guzzlehttp/promises (1.4.0 => 1.4.1) - Upgrading symfony/cache (v5.3.0 => v5.3.7) - Upgrading symfony/config (v5.3.0 => v5.3.4) - Upgrading symfony/console (v5.3.6 => v5.3.7) - Upgrading symfony/dependency-injection (v5.3.0 => v5.3.7) - Upgrading symfony/event-dispatcher (v5.3.4 => v5.3.7) - Upgrading symfony/expression-language (v5.3.0 => v5.3.7) - Upgrading symfony/finder (v5.3.4 => v5.3.7) - Upgrading symfony/http-foundation (v5.3.1 => v5.3.7) - Upgrading symfony/lock (v5.3.2 => v5.3.4) - Upgrading symfony/mailer (v5.3.0 => v5.3.4) - Upgrading symfony/mime (v5.3.0 => v5.3.7) - Upgrading symfony/options-resolver (v5.2.1 => v5.3.7) - Upgrading symfony/polyfill-intl-icu (v1.15.0 => v1.23.0) - Upgrading symfony/process (v5.2.1 => v5.3.7) - Upgrading symfony/property-access (v5.3.0 => v5.3.7) - Upgrading symfony/property-info (v5.3.1 => v5.3.7) - Upgrading symfony/rate-limiter (v5.3.0 => v5.3.4) - Upgrading symfony/routing (v5.3.0 => v5.3.7) - Upgrading symfony/stopwatch (v5.2.1 => v5.3.4) - Upgrading symfony/string (v5.3.3 => v5.3.7) - Upgrading symfony/var-dumper (v5.3.0 => v5.3.7) - Upgrading symfony/var-exporter (v5.3.0 => v5.3.7) Resolves: #95126 Releases: master Change-Id: I9cdfee15dbcdf6c07813cdacff03dccf7b061308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70921 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 06, 2021
-
-
Oliver Hader authored
Update to CKEditor v4.16.2 which addressed browser compatibility issues and known security vulnerabilities: https://ckeditor.com/blog/ckeditor-4.16.2-with-browser-improvements-and-security-fixes/ Commands: cd Build yarn add 'ckeditor4@^4.16.2' yarn build Resolves: #95128 Releases: master, 10.4, 9.5 Change-Id: Ic0c10f2d72bb7d107f53c58dbc0668d19275914b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70917 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
The RST file used the review ID instead of correct issue #94861. For convience, all breaking changes were collected for TYPO3 v11.0, and this RST is moved accordingly - the behavior has been deprected correctly in TYPO3 v10, however actually removing it in v11.0 was forgotten. Related: #94861 Releases: master Change-Id: I03c9d3062dcd640cce9396805f99873d4be14d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70920 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Bartsch authored
Resolves: #95124 Related: #95009 Releases: master Change-Id: I41319bd20432a55a668e10b62634c82839677ea8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70915 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Hader authored
Composer commands: composer req 'christian-riesen/base32:^1.6'; \ composer update 'bacon/bacon-qr-code' --with-all-dependencies Output: - Upgrading christian-riesen/base32 (1.5.2 => 1.6.0) - Upgrading bacon/bacon-qr-code (2.0.3 => 2.0.4) References: * https://github.com/ChristianRiesen/base32/releases/tag/1.6.0 "Major bugfix [...] please require at a minimum ^1.6 in your project" Resolves: #95127 Releases: master Change-Id: Iccd3681a278667cb0438cd04c15af4ac828b7be7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70916 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Wouter Wolters authored
In #89736 hoa/core was marked as conflicting with TYPO3. This is package is not used anymore with codeception/codeception and can therefore be removed. Resolves: #95109 Related: #89736 Releases: master Change-Id: If817126c1c8098a63ceb2fd0139f145459a73776 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70893 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Jochen Roth authored
When creating a new task using PHP8 a undefined key warning is thrown. To fix this issue a fallback for "task_group" has been added. Also extended createASchedulerTask test to check for expected output in case nom settings (defaults) are given. Resolves: #95088 Releases: master Change-Id: I47a480e635eaffbad2e1a1d03426a7acc04cc494 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70871 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
Missing deterministic orderBy for database queries leads to different records retrieved across dbms and dbms version. Some major dbms tends to order by primary key implictly, where in newer versions it behaves differently. Even if the database structure and data seems to look identically, dbms tends to handle it in different ways. Test fixtures for CategeoryCollectionTests do not provide any values for sorting. Inserting the data to the database is done through plain database inserts through the testing framework, not taking care of table specific sorting fields if test data missing them, which DataHandler and RelationHandler takes care of in the core. There can be instances with extensions omitting the usage of datahandler and as such inserting nondeterministic datasets, deterministic queries must be implemented. Retrieving related records for categories has been missing the required sorting field, so sorting was unreliable. Ensuring deterministic record retrieval by adding 'uid_foreign' as last orderBy to kick in if two records have the same sorting value. This allows activation of a CategoryCollection related functional test with postgres. Even though the test data misses proper sorting field values, this is not changed to ensure deterministic sorting does not break again. This patch acts as follow up for #95061. $ Build/Scripts/runTests.sh -s functional -d postgres \ typo3/sysext/core/Tests/Functional/Category/Collection/\ CategoryCollectionTest.php Resolves: #95091 Related: #95061 Releases: master, 10.4 Change-Id: I9feec421ff9628aabe100fbab9a69c570b9dd029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70877 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
A functional test has been disabled for postgres because the test was flaky (what ever this meant exactly) and has been leading to occassional test run failure. Using git bisect the first working commit has been way back before v11.0.0 release tag 27c7de8a [!!!][TASK] Remove move placeholders #92497 as the commit before has been failing 64542d62 [TASK] Decouple Dependency logic and domain models in EM As the patch which has been fixed the related stuff for the flaky test is not an easy area (or at least I'm not in ) it is really hard to identify which exactly in that commit has fixed it. Anyway, as proven through a lot of checkouts sinces this commit and even current master (run through nightly) passed all green thus this test is activated again. Testcommands: (on different versions/commits + patch | as available ) Build/Scripts/runTests.sh -s functional -d postgres \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 10 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 11 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 12 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 13 \ typo3/sysext/core/Tests/Functional/DataHandling/IRRE/ForeignField/\ Modify/ActionTest.php Resolves: #95108 Releases: master Change-Id: I74feb7ad85f5f8540e6b1bd3baccd639d4c89a36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70892 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stefan Bürk authored
A functional test has been skipped for postgres functional test execution because it exported relations in not expected order like other databases. Mainly younger postgres versions are unreliable when undetermistic queries are used. Undetermistic database query sorting may lead to unexpected and random data returns. Generally queries should implement determistic sortings to mitigate this issue across all dbms and dbms versions. The related query for this functional test has been already made determistic through #95032 and #95045 but missed to reactive this related functional test. This patch acts as follow-up for #95045. Commands: Build/Scripts/runTests.sh -s functional -d postgres -k 9.6 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 10 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 11 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 12 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Build/Scripts/runTests.sh -s functional -d postgres -k 13 \ typo3/sysext/impexp/Tests/Functional/Export/IrreTutorialRecordsTest.php Resolves: #95107 Related: #95045 Related: #95032 Releases: master Change-Id: I49fa87a1dec1b3aaa61c9758e2b437c290046cd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70890 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Daniel Siepmann authored
The value fetched from database when using sqlite is of type string. The property page_id is typed to be integer. Assigning the string to integer would result in an TypeError. Resolves: #95078 Releases: master Change-Id: I2e961f3e3c71198c29b1ef6c288881dd28c7702b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70864 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The ProductionExceptionHandler now uses the Context API for generating the access time string, which among others, is used in the error code. Therefore, the class is also refactored to use DI. This required to remove the previously passed $configuration argument from the constructor. It will now be set via a new `setConfiguration()` method. Passing the $configuration as constructor argument is marked as deprecated, affecting installations, using custom exception handler classes. Additionally, another regression, introduced in #94315, is fixed. A custom error message, configured in TypoScript, using the `%s` placeholder, was no longer be substituted with the actual error, making any mapping between frontend output and log entry impossible. This is fixed by replacing the `%s` with the new `{code}` placeholder. Resolves: #95009 Related: #94315 Releases: master Change-Id: I63bc0bfc74cd2bc33a761241f8392c1bcda90c04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70792 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Benni Mack authored
If config.debug = 1 is added, and a page is loaded from cache, TYPO3 usually sent "<!-- Cached page generated 03-09-21 09:48. Expires 04-09-21 09:48 -->" at the end of the HTTP Response Body. This is especially painful when dealing with JSON output, where this breaks output if TYPO3 should return JSON (e.g. from a USER function). This change sends the same information as a HTTP Response Header named "X-TYPO3-Debug-Cache" including the same information, and not touching the actual rendering. Resolves: #95103 Releases: master Change-Id: I737081ae4ac4a079c038c61cc5d37b57e81ab045 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70885 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Marcin Sągol <marcin@soee.pl> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Helmut Hummel <typo3@helhum.io>
-
Anja Leichsenring authored
The changelog files for the version 11.4 must leave the master folder now and move to their final home in 11.4. Resolves: #95106 Releases: master Change-Id: Icc835750fb914e5ae27398be86bb70f1bfe80021 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70888 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Andreas Fernandez authored
The pid resolving in the `AddRecord` fieldControl is not sufficient in all cases. To allow easier extension of the pid resolving without the need to override the whole `render` method, the resolving is extracted into an own method that can be extended in custom implementations. Resolves: #95001 Releases: master Change-Id: Ie71943aa6275e9d5e7a7e3295d968198f665d5ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70767 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
- Sep 04, 2021
-
-
Andreas Fernandez authored
PhpStorm has basic support for generics since version 2021.2 which comes in handy as since the same version the "Dynamic Return Type" plugin is broken. Providing the class-string annotation and a proper return generic supersedes this and recovers the built-in autocompletion. To have the same effect for both, 3rd party code not being under our control or methods having complex returns based on their input, a `.phpstorm.meta.php` file is provided extending PhpStorms code awareness capabilities. Tons of kudos to Alexander Schnitzler providing a boilerplate configuration here: https://github.com/alexanderschnitzler/phpstorm.meta.php-typo3 For more information about capability extension consult https://www.jetbrains.com/help/phpstorm/ide-advanced-metadata.html Resolves: #95064 Releases: master, 10.4, 9.5 Change-Id: I4ea5115550ce7070de01c42c19ac3b93bf6ab4b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70872 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Anja Leichsenring authored
Used commands: composer require symfony/polyfill-php80:^1.16 composer require symfony/polyfill-php80:^1.16 \ -d typo3/sysext/form --no-update This fixes a composer min acceptance test failure, that chokes on the function str_ends_with() not being available in a PHP 7.4 environment. Resolves: #95110 Releases: master Change-Id: I54d410adc7ad813dc3c840c4292ee9ec3df6f76c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70894 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benjamin Franzke authored
This is a preparation in order to decouple LogManager and log attribute in future. Releases: master Resolves: #95099 Related: #85506 Change-Id: Ic3c864994440c690aed5e3825fd7e7b2b471d89c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70882 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benjamin Franzke <bfr@qbus.de>
-
Oliver Bartsch authored
Three new PSR-14 based events are introduced in favour of the existing $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['typo3/class.db_list_extra.inc']['actions'] hook, which is now marked as deprecated, along with its interface "RecordListHookInterface". Besides the obvious advantage of using PSR-14 events, the RecordListHookInterface also required to always implement all hook methods, even if only one of them was really used. The new events feature the same functionality, but improved and extended. The main subject, e.g. the record actions or the table header columns, is therefore equipped with extended CRUD methods, like adding a new action at a certain position. Resolves: #95105 Releases: master Change-Id: If3194474eca7c111be4d113fda04992c5bf5f16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70887 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Benni Mack <benni@typo3.org>
-
- Sep 03, 2021
-
-
Benjamin Franzke authored
EventDispatcherInterface injection is easy here, therefore lets to so in order to avoid the discouraged global lookup via GeneralUtility. Also refactor to inject other dependencies. Resolves: #95101 Releases: master Change-Id: I4c6db4bbb5e0f10121b75cef5bd57956c093d2b1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70883 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-