- May 13, 2024
-
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2][3] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below - at least for the phpXY images. * core-testing-php82: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-php83: No change required, patchlevel image version change only and pulled on gitlab runner already. * core-testing-apache24: Minor version release thus raising version required. * core-testing-nodejs22: Minor version release thus raising version required. * core-testing-nodejs22-chrome: Minor version release thus raising version required. [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/df1e05ed52e724e0934e552c214395930022413b [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/f754d7fbd2c3cbed98296c8a772869362487d073 [3] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/4f93c5e93eb4e00fc936c13280918e60e62be567 Resolves: #103821 Releases: main, 12.4 Change-Id: I085cc0ce80682dfd009e5648f236974a380b8176 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84214 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Patrick Schriner authored
To circumvent race conditions where the cache is removed between `has()` and `require()` invocations, the return value of the cache result needs to be verified, as `false` is returned if the cache entry is not available. Resolves: #103720 Releases: main, 12.4 Change-Id: Iefede04108d3adf9bd6c77cb0600cdc994f6d0fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84016 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
André Buchmann authored
Copy/move pages with existing translation into another site with different language setup results in orphaned problematic page translation records. It's not only about a complete page to another page, but also about copy/move of a record/content element to a page which does not have the same translations as the original page. This test verifies the current behavior as a basis for further discussions. Resolves: #103814 Related: #102345 Releases: main Change-Id: I1f4c1fb2155e303702832d969fff903fcdb09266 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83310 Reviewed-by:
Eric Harrer <info@eric-harrer.de> Tested-by:
-
Stefan Froemken authored
Remove line which extracts a version number from YamlSetDefinitionProvider as settings definitions does not contain any version number. Resolves: #103822 Releases: main Change-Id: I7e7a02a7d7dec6a264bb60d3de7fdaa1252bd9ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84215 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Reviewed-by:
-
- May 12, 2024
-
-
Lina Wolf authored
Resolves: #103820 Releases: main Change-Id: I4731f5579b0dd62785816441dabbe87d725bc274 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84213 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
- May 11, 2024
-
-
Christian Fries authored
When addressing flexform fields in TSconfig, the dots of the field names have to be escaped with a backslash. Releases: main, 12.4, 11.5 Resolves: #103786 Change-Id: I6af70fcb80e9e155ba8259ec216c5199600c5a78 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84140 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Chris Müller <typo3@brotkrueml.dev> Reviewed-by:
-
Garvin Hicking authored
An error was made in [1] where a wrong link anchor name (parseFunc) was used after refactoring the link format, which leads to a warning in the documentation rendering process. [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84193 Resolves: #103819 Releases: main, 12.4 Change-Id: I9b0c8f1852e32174b2ce5b59dc45607fd403a06c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84212 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Stefan Froemken authored
Resolves: #103816 Releases: main Change-Id: I407cf635b5e1030c943d45a99a51a0210b840a08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84189 Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
- May 10, 2024
-
-
Christoph Lehmann authored
In advanced query the operator "is in list" makes value be an array. Then switch the field to a non-array field type, and you get the following TypeError: ``` htmlspecialchars(): Argument #1 ($string) must be of type string, array given. ``` This resets the array value to an empty string. Resolves: #103487 Releases: main, 12.4, 11.5 Change-Id: Ifc6ef7e90d49a05ecb4b6d4869eea13c151b1b2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83593 Reviewed-by:
-
Willi Wehmeier authored
The add widget modal has a cancel button on the bottom of the modal now to match the other modal windows in the backend. Resolves: #103787 Releases: main, 12.4 Change-Id: I0c2c970b1148dfddadff1c3722d04dfcc939a69d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84142 Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Stefan Bürk authored
Hook implementation are configured with the well known $GLOBAL['TYPO3_CONF_VARS']['SC_OPTIONS'][...][] = ''; syntax since ages. Directly defining an anonymous callback function is undocumented and rarely used, but technical valid and supported by the `GeneralUtility::callUserFunction()` method. Due to the refactoring of the `ext:lowlevel` Configuration module for the revamped TypoScript parser with TYPO3 v12 the code in the `ConfigurationController` has been modified to do an array cast, which triggers the execution of the function - which can lead to some deep recursions and thus exceeding server resource limits. Direct callback function should not be executed within the backend Configuration module, which literally is a invalid execution of them. Following code in a extension `ext_localconf.php` file will lead to the resource limit issue: $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['tslib/index_ts.php']['preprocessRequest'][] = function($parameters, $parent) {}; This change modifies the `ConfigurationController->renderTree()` to check if a value is a callable and display the information, and in case of an anonymous function (`Closure::__invoke`) add additional static information: Closure::__invoke (anonymous callback function: function() {}) Note: That does not make it obvious where the function is defined, but it avoids calling these callback methods. Resolves: #103813 Related: #99899 Releases: main, 12.4 Change-Id: I839d1668cf306100cf32af09ec9e24ad0120c43b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84187 Reviewed-by:Stefan Froemken <froemken@gmail.com> Reviewed-by:
-
Mathias Brodala authored
Resolves: #103812 Releases: main, 12.4 Change-Id: I467149ad6e93900cf917d3455b24dc01c97330f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84186 Reviewed-by:
André Buchmann <andy.schliesser@gmail.com> Tested-by:
-
Markus Klein authored
"Resources/Public" may occur also within an asset path. Path detection code must therefore only check for its first occurrence. Resolves: #101701 Releases: main, 12.4 Change-Id: I8e0b62f5164593e472113ea8d294593e93abfe6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84181 Tested-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Reviewed-by:
Willi Wehmeier <wwwehmeier@gmail.com> Reviewed-by:
-
- May 09, 2024
-
-
Torben Hansen authored
Some function names for validator tests in ext:form start with an uppercase letter, which is not in line with our coding guidelines. This change ensures that test function names start with a lowercase letter. Resolves: #103809 Releases: main Change-Id: If6d02c44baba9af4c346a6a4652cb929e9f84770 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84184 Tested-by:
-
Garvin Hicking authored
The ViewHelper documentation for f:translate mentioned sprintf() from PHP, but did not link to it. This patch adds a link and also optimizes markup, plus a few more sprintf() examples with ordered parameters and number formatting. See forge issue for screenshots how this looks before and after the change. Resolves: #103808 Releases: main, 12.4 Change-Id: I237d4b668291ad68bf083e35c0bdf6510158b38b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84183 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- May 08, 2024
-
-
Albrecht Köhnlein authored
Resolves: #103807 Releases: main, 12.4 Change-Id: Ifc551dcd66bc88da8c57e7213ee80d960f365509 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84179 Reviewed-by:
-
Andreas Kienast authored
The containers used in the backend module of EXT:styleguide are now based on flex boxes and don't use absolute positioning anymore. This enabled the possibility to scroll when the navigation needs more space than the actual content and also fixes positioning in right-to-left scenarios. Resolves: #103794 Releases: main Change-Id: Ie3fcbf7f7141bf16749dc66b45e185168e469260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84147 Reviewed-by:
Frank Nägler <frank.naegler@typo3.com> Reviewed-by:
-
- May 07, 2024
-
-
Torben Hansen authored
This change changes extbase persistence tests to use CSV files where suitable. The `addSimpleObjectTest` has been removed, since `addObjectSetsDefaultLanguageTest` also tests, if a simple object can be added. Additionally, one test is moved from `AddTest.php` to `UpdateTest.php`, because this test actually tests an update- scenario instead of an add-scenario. Resolves: #103668 Releases: main Change-Id: I4b95a8f6f28be17d50f9f2b88f005a7f02248322 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84153 Tested-by:
-
Torben Hansen authored
Extbase persistence does not treat nullable properties like DataHandler does. A nullable domain model property, which either implements `DomainObjectInterface` or is of type `DateTime`, can not be set to null again, when the object is already persisted with a value not equal to null. DataHandler respects this scenario by using the value of the `default` config TCA key for affected relation fields or by typecasting an empty value to integer for `datetime` fields. For `datetime` fields, additionally the `dbType` is evaluated and an empty value is transformed to the corresponding dbType empty value. This change covers both scenarios in extbase persistence, so it is possible to set properties to `null`, if the property either implements `DomainObjectInterface` or is of type `DateTime`. Resolves: #103641 Related: #88515 Releases: main Change-Id: I17767b34ac75bb7387a6fc3c6e7345a7d3d25d86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83839 Tested-by:
-
- May 06, 2024
-
-
Willi Wehmeier authored
The folder containing the charset conversion table files should have the unicode license.txt file. Resolves: #103796 Releases: main, 12.4, 11.5 Change-Id: I2577fea6e1b5326cd45da622ec6fbbc563bc140a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84150 Tested-by:
-
Torben Hansen authored
One part of the classname in a `throws` doc comment in `MvcPropertyMappingConfigurationService` is wrong. Instead of `EXTBASE` it should be `Extbase`. Resolves: #103792 Releases: main, 12.4 Change-Id: I6be6e53640d82d39ff9f2ce99015877e693b8428 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84146 Reviewed-by:
-
- May 05, 2024
-
-
Andreas Kienast authored
Executed commands: composer require --dev sokil/php-isocodes-db-i18n:^4.0.22 Build/Scripts/updateIsoDatabase.php Resolves: #103791 Releases: main, 12.4 Change-Id: I624ce17a6abaa2cb5c0479744db43bdf17cd069a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84144 Tested-by:
-
- May 03, 2024
-
-
Andreas Kienast authored
The module `@typo3/backend/element/table-wizard-element` is tightly coupled to FormEngine's `TextTableElement`, therefore said module is moved to the FormEngine namespace. Additionally, the element gets renamed to `typo3-formengine-table-wizard`. Resolves: #103725 Releases: main, 12.4 Change-Id: I1c020a4ec6045007ab4c1f42289fe0a9c842f794 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84022 Tested-by:
-
Andreas Kienast authored
TYPO3 has a method to ensure an integer is always positive: `MathUtility::convertToPositiveInteger()`. However, the method is rather "heavy" as it internally calls `MU::forceIntegerInRange()` and therefore misuses a clamp mechanism to convert the integer to a positive number. Also, the method name doesn't reflect what it actually does. Negative numbers are not converted to their positive counterpart, but are swapped with `0`. Due to the naming issue and the fact that the method can be superseded by a simple `max()` call, the method is therefore deprecated. Resolves: #103785 Releases: main Change-Id: I4fd0548ec6bc7289008057ade4e64f9437c2da7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84141 Tested-by:
-
Lina Wolf authored
The $pageLayoutName is treated as 'action' and is passed through ucfirst in TYPO3Fluid\Fluid\View\TemplatePaths:: resolveTemplateFileForControllerAndActionAndFormat Therefore if a backend layout starts with a lowercase name, then the template name still has to start with a uppercase name. Resolves: #103774 Releases: main Change-Id: Ica31c073719d183a5bd66fdaf937dad6707ac07e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84101 Tested-by:
-
Nikita Hovratov authored
With the introduction of BeforeLoadedUserTsConfigEvent, it is now possible to add user tsconfig before global file user.tsconfig is evaluated. The registry-like `doktypesToShowInNewPageDragArea` list always overrides possible items added in this event. The fix is to use the `addToList` modifier, so that default doktypes are appended. Resolves: #103584 Related: #101818 Releases: main Change-Id: I4cc90d2a89e4619849cd41085d091903353efe72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83726 Reviewed-by:
-
Oliver Hader authored
Commands: composer req 'enshrined/svg-sanitize:^0.18.0' composer req 'enshrined/svg-sanitize:^0.18.0' \ -d typo3/sysext/core --no-update Resolves: #103722 Releases: main, 12.4, 11.5 Change-Id: I9a20a46b27b3abbfd18f7ca6027e4def9ce5b59b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84110 Reviewed-by:
-
Torben Hansen authored
With this change, the following changes have been applied to the toolbar of the CKEditor "full" configuration preset: * Remove superfluous `clipboard` toolbar item, since CKEditor 5 does not provide a UI for the clipboard plugin. * Rename wrong `find` toolbar item to `findAndReplace`. * Added `TableProperties` and `TableCellProperties` toolbar items. * Move the `findAndReplace` toolbar item before the `link` toolbar item, because we also have this order in the `default` preset. * Move the `selectAll` toolbar item to a dedicated group Resolves: #103745 Releases: main, 12.4 Change-Id: I021b8c2f990c8e302bf169c3e368bf04928dd200 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84048 Tested-by:
-
Georg Ringer authored
Allow the valid return type false which is returned by the function exec on failure. Resolves: #103778 Releases: main, 12.4 Change-Id: I8f0391efb6f890ebc0095ddb8a1f93ee9c36e18c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84135 Tested-by:
-
Andreas Nedbal authored
Newer rollup major versions feature optimizations in build output. The rollup source files are now natively parsed as ESM modules by NodeJS. Earlier rollup versions implicitly transpiled ESM to CJS and allowed a mixture of ESM and CJS imports (both `import` statements and `require()` calls) in one module. With the switch to ESM-only modules we now make use of `createRequire` utility method when node-require resolution is needed for CJS path lookups. Since our main project (Build/) is still in CJS mode by default (for grunt), we apply a sub-project module type overwrite for the Build/rollup/ folder via Build/rollup/package.json to ensure rollup configuration runs in native ESM mode. See https://nodejs.org/docs/latest-v18.x/api/packages.html > Node.js will treat the following as ES modules when passed to node as > the initial input, or when referenced by import statements or import() > expressions: > […] > * Files with a .js extension when the nearest parent package.json file > contains a top-level "type" field with a value of "module". Executed commands: npm install --save-dev \ rollup@^4.17.2 \ @rollup/plugin-commonjs@^25.0.7 \ @rollup/plugin-node-resolve@^15.2.3 \ @rollup/plugin-replace@^5.0.5 npm run build -- exec:rollup Resolves: #103775 Releases: main, 12.4 Change-Id: I6793bd9233b2907ce5ed06d68c7008b349237360 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84102 Tested-by:
-
Benjamin Franzke authored
The node version used for building TYPO3 assets is raised to 22.0. See https://nodejs.org/en/blog/announcements/v22-release-announce for further details. Resolves: #103780 Releases: main, 12.4 Change-Id: Ibc5b8c88ca5baedb7ae500adb5ef26a33617df4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84103 Reviewed-by:
-
- May 02, 2024
-
-
Jasmina Ließmann authored
Since #103670 the "Workspaces" module has a slightly different look. In order to keep the "History/Undo" module visually synchronous, the badges are now displayed in color - depending on the action type. In addition, the label for the action type "add" was changed based on the wording from the "Workspaces" module. Resolves: #103765 Releases: main Change-Id: I7f63fc05fe766db8ee9fd85d12720d247009125f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84087 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
When using integer types when calling the fallowing method like `ImageProcessingInstructions::fromCropScaleValues(.., .., '500m', 0)`, a PHP type error for `str_contains` is issued. Resolves: #103781 Releases: main Change-Id: Ib36f8584f2a90d999a02dc2ea70249371b312461 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84108 Reviewed-by:
-
Frank Naegler authored
This patch addresses two key accessibility issues in the recycler module: it adds a caption element to the table for better context and provides labels for dropdown icons used in multi-selection, ensuring screen reader compatibility. Resolves: #103764 Releases: main, 12.4 Change-Id: Ia8b839cbc438396c8438969087d225c37a479bcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84085 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Willi Wehmeier authored
The clear-input button now has a proper title and additionally an aria-label to guide visually impaired users. The button isn't read out by screenreaders when navigating the site linearly (due to tabindex="-1") but when hold-pressing the button with the mouse pointer, a screenreader will search for a human readable label. We therefore add an aria-label attribute. The title attribute is added for sighted users but will be ignored by screenreaders since it's value equals the value of the aria-label attribute. Resolves: #103417 Releases: main, 12.4 Change-Id: I4cbbe5200476a7d84ef1d675911ddd51f5899e87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83501 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Chris Müller authored
With the introduction of site sets also a console command was made available which lists all available site sets. Knowing this command makes it easier for integrators to set the dependencies. Resolves: #103771 Related: #103437 Releases: main Change-Id: I86e45c1a63fc3ddc5aaf8a2b1b72da7b24febe08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84098 Tested-by:
-
- May 01, 2024
-
-
Oliver Hader authored
The new factory method `HashValue::hash('test')` creates the hash from the raw payload `'test'`. This is a simpler shortcut for using `HashValue::create(hash('sha256', 'test', true))`. Resolves: #103772 Releases: main, 12.4 Change-Id: Id201e166eeabc856b8d8dc498cc73cde8d5eb801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84100 Tested-by:
-
- Apr 30, 2024
-
-
Torben Hansen authored
The frontend login extension currently validates a given redirect URL by ensuring, that the URL is either relative or the host is known to TYPO3. In some scenarios, it might however be useful to allow a redirect URL, which does not match the existing rules. This change adds the `ModifyRedirectUrlValidationResultEvent` PSR-14 event, allowing developers to implement custom validation logic for the redirect URL. Resolves: #103019 Releases: main Change-Id: I81b387f23e90adbaf4a586c9108766275f5e1273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82763 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Stephan Bauer authored
An error was previously shown and is now removed if no backend type is selected. Releases: main, 12.4, 11.5 Resolves: #103766 Change-Id: Ia83552de40abffb880244e8b0eb0f4c28f0e6637 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84095 Tested-by:
-
Oliver Bartsch authored
The EXT:styleguide extension currently provides two ways of frontend rendering. The "old" way using a `sys_template` record and the "new" way, using site sets. To not only test the new site sets feature, but also the new PAGEVIEW cObject is the corresponding TypoScript now using the PAGEVIEW for page rendering. This one hand is the best practice and on the other hand also allows to test both ways: FLUIDTEMPLATE and PAGEVIEW in one extension. Required structural changes also showcase what has to be done when migrating extensions to site sets and PAGEVIEW. Resolves: #103733 Releases: main Change-Id: I71bb28a6e6d39b1232d5283e548044b421d3b5c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84037 Reviewed-by:
-
