- Apr 02, 2020
-
-
Benni Mack authored
In TYPO3 v10 locale is set very early in due to the availability of the Site Language, making the whole set up working properly without having to evaluate config.locale_all TypoScript. This code can now safely be removed. Resolves: #82491 Releases: master Change-Id: I9df3ec2d2e111e0ec035971fe42efcc280ac6afd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64045 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
- Apr 01, 2020
-
-
Benni Mack authored
Used composer command: composer req "phpdocumentor/type-resolver:^1.1.0" \ "phpdocumentor/reflection-docblock:^5.1.0" Output - Updating phpdocumentor/type-resolver (0.7.2 => 1.1.0) - Updating phpdocumentor/reflection-docblock (4.3.4 => 5.1.0) Resolves: #90886 Releases: master Change-Id: Ibbb03bfa646f661a44c94fdf1f8a758890d0944e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64008 Tested-by:Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The code that executes the drawItem hook must be called before the fluid-preview is rendered, in order to allow rendering of custom variables within the Fluid preview. This way, it behaves the same way as in the non-Fluidbased page module. Resolves: #90906 Releases: master Change-Id: Id7998446b211763da3d3b7be89a4d7016f2fb54f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64020 Tested-by:
Achim Fritz <af@achimfritz.de> Tested-by:
-
- Mar 31, 2020
-
-
Oliver Bartsch authored
By expanding an inline record the AJAX request calls the `detailAction` in `FormInlineAjaxController`. The parent data array created in this function does not contain the parent record's uid nor its database row. In order to ensure that the uid is not NULL, in any FormDataProvider, the uid is now added to the parent data array. This value is then used as fallback in case there is no database row given in the `compileChild` function which calls the FormDataProviders. Resolves: #90734 Releases: master, 9.5 Change-Id: I66a4a20980d6c62a3e87496b6261b25f5e22aea6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63686 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Eßl <indy.essl@gmail.com> Reviewed-by:
-
Benni Mack authored
Used composer command: composer update "symfony/*" --with-all-dependencies Output: - Updating symfony/filesystem (v5.0.6 => v5.0.7) - Updating symfony/config (v5.0.6 => v5.0.7) - Updating symfony/console (v5.0.6 => v5.0.7) - Updating symfony/dependency-injection (v5.0.6 => v5.0.7) - Updating symfony/var-exporter (v5.0.6 => v5.0.7) - Updating symfony/cache (v5.0.6 => v5.0.7) - Updating symfony/expression-language (v5.0.6 => v5.0.7) - Updating symfony/finder (v5.0.6 => v5.0.7) - Updating symfony/mime (v5.0.6 => v5.0.7) - Updating symfony/event-dispatcher (v5.0.6 => v5.0.7) - Updating symfony/mailer (v5.0.6 => v5.0.7) - Updating symfony/inflector (v5.0.6 => v5.0.7) - Updating symfony/property-access (v5.0.6 => v5.0.7) - Updating symfony/property-info (v5.0.6 => v5.0.7) - Updating symfony/routing (v5.0.6 => v5.0.7) - Updating symfony/yaml (v5.0.6 => v5.0.7) - Updating symfony/css-selector (v5.0.6 => v5.0.7) - U...
-
- Mar 30, 2020
-
-
Andreas Fernandez authored
This patch replaces DataTables with the lightweight alternative tablesort and adjusts all usages of DataTables. Since using DataTables with TYPO3 is neither documented nor propagated, removing this library isn't considered as breaking change. Resolves: #86343 Releases: master Change-Id: Ied7a3a8d471d508f00cc568a15fb930eec4f274b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63958 Tested-by:
-
Benni Mack authored
The methods within ContentObjectRenderer are only needed for rendering an IMAGE <img> tag and are moved to the right place in order to make cObj less fat: - cImage() - getBorderAttr() - getImageTagTemplate() - getImageSourceCollection() - linkWrap() - getAltParam() "imageLinkWrap()" is marked as internal for the time being, in order to refactor this code in TYPO3 v11. Resolves: #90861 Releases: master Change-Id: I4c11a5b3df393dbe63ad7401869d0faaa61b2418 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63949 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
Resolves: #90888 Releases: master Change-Id: Id5448d8536c9078b9cb37c952f33bb1deab272ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64010 Reviewed-by:
-
Benni Mack authored
This code is either protected or marked as internal, and not in use and can be removed. Resolves: #90889 Releases: master Change-Id: I45636e9117d00c05e7880275919b5ba30c12d6d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64013 Reviewed-by:
-
Tymoteusz Motylewski authored
to avoid conflict with a method from the testing framework. Resolves: #90887 Releases: master Change-Id: Ib55c69f67ceb32037f94183fe630e20391ad4481 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64009 Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
-
Alexander Schnitzler authored
This reverts commit 9c0e151e. The original patch followed the misconception that when using json as format query parameter, Extbase would automatically use the JsonView object. Instead, Extbase should only try to find a template file with a .json file type. Change-Id: Id224ad901d1e415687c8cd2207d516b19a09fd99 Releases: master Resolves: #90875 Reverts: #90788 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63974 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Benni Mack authored
Used composer command: composer update "symfony/*" --with-all-dependencies Output - Removing symfony/debug (v4.4.4) - Updating typo3/cms-composer-installers (v2.2.3 => v2.2.4) - Updating symfony/polyfill-ctype (v1.14.0 => v1.15.0) - Updating symfony/filesystem (v5.0.4 => v5.0.6) - Updating symfony/config (v4.4.0 => v5.0.6) - Updating symfony/service-contracts (v1.1.8 => v2.0.1) - Updating symfony/polyfill-php73 (v1.14.0 => v1.15.0) - Updating symfony/polyfill-mbstring (v1.12.0 => v1.15.0) - Updating symfony/console (v4.4.0 => v5.0.6) - Updating symfony/dependency-injection (v4.4.0 => v5.0.6) - Updating symfony/var-exporter (v4.4.0 => v5.0.6) - Updating symfony/cache-contracts (v1.1.7 => v2.0.1) - Updating psr/log (1.1.2 => 1.1.3) - Updating symfony/cache (v4.4.0 => v5.0.6) - Updating symfony/expression-language (v4.4.0 => v5.0.6) - Updating symfony/finder (v4.4.0 => v5.0.6) - Updating symfony/polyfill-php72 (...
-
Benni Mack authored
When using "typolink.JSwindow_params" the target set by typolink.target or the encoded "typolink parameter", but always falls back to "FEopenLink". If the property "target" is now set, the JSwindow_params "target" value is now also taken into account. Resolves: #31636 Releases: master Change-Id: Ie4b4c40641db30c163a6cf778ccaf5c5a3dc9b7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63922 Tested-by:
-
- Mar 29, 2020
-
-
Helmut Hummel authored
Allow installation of version 3.0 of composer installers, which will be compatible with Composer 2.0. composer req typo3/cms-composer-installers:"^2.0 || ^3.0" Resolves: #90877 Releases: 9.5, master Change-Id: I5200b64b0d6402617bb355da9c7d2c59cdd54b03 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63998 Tested-by:
-
Susanne Moog authored
Resolves: #90864 Releases: master Change-Id: I3936c3a0c51f8bd05a6388f07240fe0e7d530779 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63997 Tested-by:
-
Claus Due authored
Followup with minor corrections for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63918 * Relaxes method signature of getSelectedBackendLayout to restore compatibilty with third party XCLASS. * Avoids parsing empty configuration strings (in use cases where configuration is passed to BackendLayout as array, not TS string). * Uses DrawingConfiguration instance provided from BackendLayout instead of creating a new instance to override the one returned from BackendLayout. * Fixes a method call with unused return value. Releases: master Resolves: #90839 Change-Id: If6fe1286d3ce6530de30ea4c534ac1799e63177e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63968 Tested-by:
-
Andreas Fernandez authored
The "Import selection" button in the Element Browser is now disabled by default, as no selection is done yet. (De)selecting items toggles the import button accordingly. Resolves: #90869 Releases: master Change-Id: I55e30abe83bf189c2825c30551b357cbd0174f44 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63992 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Christian Eßl authored
The old, non-fluidbased PageLayoutView was missing the translate button for editors, even when they had the right permissions to edit content, because the property $pageinfo wasn't initialized early enough before the permission check. Resolves: #90874 Related: #90858 Releases: master Change-Id: Ie6f4d1c0a1c2867978de87082e2a31f2907e2cdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63971 Tested-by:
-
- Mar 28, 2020
-
-
Jonas Eberle authored
This adds phpdoc for the public AssetCollector::add...() functions and notes for users migrating from PageRenderer::add...(). Resolves: #90870 Releases: master Change-Id: I8896b83f172a0e70ff5bdae61106c3a66d29667c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63970 Tested-by:
-
Jonas Eberle authored
As boolean HTML attributes shall either have a value equal to the attribute name (e.g. async="async") or have no value at all (only allowed in HTML5), the ViewHelper reflects that now. All boolean HTML attributes on <script> (async, defer, nomodule) and <link> (disabled) have been changed to Fluid "bool" ("0" and "false" is false, rest is true). This allows using the ViewHelpers with e.g. async="1" which before would have output <script async="1">. Now it is registered as async="async" with AssetCollector. References: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link Resolves: #90871 Releases: master Change-Id: I5052ff6ad86e14a9b55f507ba0f3dcf7ea3010e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63996 Tested-by: -
Jonas Eberle authored
Although registered as "string" argument in the ViewHelper, an incoming string that is_numeric() is cast to an integer, leading to a TypeError. Resolves: #90873 Releases: master Change-Id: Ic2b0cd8df1a75c46a22a605d6f7e3a0e2438a1d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63993 Tested-by:
-
Benni Mack authored
Currently TYPO3 Core does trimming based on the user (AbstractUserAuthentication) but in order to allow third-party extensions to integrate users / passwords with spaces at the end and beginning, this code is moved to the Authentication Service which allows for custom services to trim or not to trim individually. Resolves: #77715 Releases: master Change-Id: Ie31a5b97293275d15513abfae39599f4462262c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63925 Tested-by:
-
Christian Eßl authored
The AssetCollector does not necessarily need a filled array with attributes for adding javascript or stylesheets. Make the $attributes argument optional and default to an empty array. Resolves: #90868 Releases: master Change-Id: I7a6e5dad8724f36c0450d13cda853e90b1929e71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63969 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Frank Naegler authored
The Fluid ViewHelper `<f:widget.autocomplete>` has been marked as deprecated and will be removed in TYPO3 v11. Resolves: #90856 Releases: master Change-Id: I4088f235f03a2545d90bf7abacc18afc174de7bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63954 Tested-by:
-
Susanne Moog authored
To allow the dashboard to be positioned out of the "Web" main module, we rebuilt the module menu to allow direct top level modules. Additionally, the styling for the module menu was adjusted to allow mobile and keyboard friendly navigation and layout. Resolves: #90862 Releases: master Change-Id: I1005bac37a214530fb9e304fec2406799fe92240 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63718 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
Some minor details are changed within TSFE. - metaCharset is now evaluated at the same time as other TypoScript options making this option available earlier in the process - getFromCache() and headerNoCache() now optionally receive a PSR-7 request to evaluate serverParams from the PSR-7 request and not the superglobals Resolves: #90853 Releases: master Change-Id: I443925c5d056db10cafb4e81aa30fc7db91c3c71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63948 Tested-by:
-
Georg Ringer authored
Migrate the mails in SystemStatusUpdateTask to FluidEmails. As the current content format is rather limited it is not changed and only plain mails are sent. Resolves: #90726 Releases: master Change-Id: I97fc5c01326d9997cacfd56b2b917e79fe0688d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63725 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Mar 27, 2020
-
-
Christian Eßl authored
Do not show the inline edit form, when double clicking the title in the pagetree, if the editor has no access permissions to the default language or is not allowed to modify a page. Resolves: #90855 Releases: master, 9.5 Change-Id: I51b34451043ce7abeb73250ea050bc084c23647b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63952 Tested-by:
-
Christian Eßl authored
When using c-style multiline comments in the ext_tables.sql of an extension, the SchemaMigrator would then ignore the subsequent "CREATE TABLE" statement, because the SqlReader also read the multiline comments into the statement array. This patch fixes this behaviour. Now the following comments are possible inside ext_tables.sql: /* Some comment text more text */ /* Same line c-style comment */ /* More multiline comments */ CREATE TABLE table1 ( header varchar(255) DEFAULT '' NOT NULL, bodytext text ); Resolves: #89714 Releases: master, 9.5 Change-Id: I49e687215d0b42d6ca5416c687fdbc19b44d237d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63951 Tested-by: -
Alexander Schnitzler authored
Releases: master Resolves: #90802 Change-Id: I84da713c7b8c68ae67b6b9c33ad66dcbac8d72bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63810 Tested-by:
-
Christian Eßl authored
Add missing documentation to IconViewHelper and extend some of the already existing argument descriptions. Resolves: #90859 Releases: master, 9.5 Change-Id: Id681f796e94db5b5bc0727a4a68dd19fecf8af77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63955 Tested-by:
-
Andreas Wolf authored
This adds a similar condition that already existed in the old link generation for the new routing-based link building. The conditions are adjusted accordingly. Change-Id: I467f0ce9695fd33ab1e1545e1ba0728c037d3e93 Resolves: #89068 Releases: master, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61615 Tested-by:
-
Georg Ringer authored
Links with an invalid syntax or not supported type must not lead to exceptions for an editor or users. Resolves: #87792 Releases: master Change-Id: Ica0791e3400d5aff18ecc25a2e8d57edf55af40c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63942 Tested-by:
-
Markus Klein authored
If the URL cannot be calculated by the UriBuilder an empty URL is returned. In this case no a-tag is rendered to avoid links with an empty href-attribute. Resolves: #90857 Releases: master, 9.5, 8.7 Change-Id: I597a4b11d986a3b6155a695e6fd3c84a94588a1a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63953 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
Benni Mack authored
PageLayoutView now builds a "Configuration" model for both variants PageLayoutView is not set up via the DrawingConfiguration object, which is now based on a factory method. PageLayoutController now injects all RequireJS modules in one place, and not in fluid anymore. Minor bugs regarding "getLanguageColumns" are fixed. The main "pageLayoutConfiguration" is now injected and used where it does not differ from the backend module configuration. Resolves: #90858 Releases: master Change-Id: I16925488e0bff75ec73f9dddbfd047cca3bd2da1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63938 Tested-by:
-
Stefan Horst authored
Update the template to not generate a url containing & which results in not working ajax call. Releases: master, 9.5 Resolves: #90091 Change-Id: If164f1a4c5d4aa6bf7cb830b27ed5ac5d5d5d525 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62849 Tested-by:
-
Georg Ringer authored
Show the detailed information about how many orphaned records have been found in which table by default and don't hide it behind a verbose flag. Additionally also show the ids of those records. Resolves: #87777 Releases: master, 9.5 Change-Id: I112b3d128109ea9bab358d9cbe215c0f5d45a820 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63940 Tested-by:
-
Benni Mack authored
Resolves: #90851 Releases: master Change-Id: I472845920d31449164a632b0edae442dd2b56f7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63945 Tested-by:
-
Stephan Großberndt authored
The sys_file_processedfile.configuration column will contain a serialized object after saving an image with a crop definition in the image manipulation editor. Avoid an exception being thrown on PostgreSQL due to this string containing NULL bytes not saved properly in a "text" column by changing the column type to "blob". Resolves: #90844 Releases: master, 9.5 Change-Id: I9bb751f6e0622a042e2f1b40925d7070fe656285 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63935 Tested-by:
-
Andreas Fernandez authored
Disabled input fields now contain the `data-formengine-input-name` attribute. The slug creation is now able to determine disabled fields as well to take them into consideration. Resolves: #90141 Releases: master, 9.5 Change-Id: I153a2d8e3e3e67fd6d865bd4e72691c67ab18c3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63947 Tested-by:
-
