- Jun 26, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104210 Releases: main, 12.4, 11.5 Change-Id: Id20216f2b920b5f5c0d665a370536c447590f53c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84916 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
core-ci <typo3@b13.com>
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator or adding a null tyype to an union type definition. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104211 Releases: main, 12.4, 11.5 Change-Id: Ic086fc77872c54f763d774f4118517658d8d52e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84919 Tested-by:
-
Stefan Bürk authored
Since recently upgraded PHP-version the 10mb big xml unit test failes. The `\LIBXML_PARSEHUGE` xml option could be used to mitigate this case but would not explain the change from PHP yet. Thus the decision has been made to disable the failing data set as a temporary solution to avoid disturbance for core contribution until this issue has been investigated and reported to PHP itself. Resolves: #104218 Releases: main, 12.4, 11.5 Change-Id: Ifef4f18818e661312b9e56e013bb8f479146b806 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84849 Reviewed-by:
-
Oliver Bartsch authored
For additional context does the PolicyMutatedEvent now provide the current PSR-7 Request. Resolves: #104141 Releases: main, 12.4 Change-Id: I1817366e77f20f6c43eef0ee209fbb419e7237e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84848 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Christian Kuhn authored
> composer req --dev typo3/testing-framework:^8.2.0 A minor release upgrade of TF needs minor type hint adaptions to keep phpstan happy. Resolves: #104212 Releases: 12.4 Change-Id: I1af6f9eca81962719878fa56394520897a6fa01e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84922 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jun 25, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104206 Releases: main, 12.4, 11.5 Change-Id: I0d82e0474143f63870f772002de52d26c6c960fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84907 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104205 Releases: main, 12.4, 11.5 Change-Id: Iaca12350ce8b28943fd5ce8181d42b91feb471e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84904 Reviewed-by:
-
Andreas Kienast authored
All FormEngine field types shipped in TYPO3 core use a CSS class `hasDefaultValue` that was never defined or referenced since its introduction in TYPO3 4.7 with #33235. This commit removes the remaining traces of said CSS class. Resolves: #104207 Related: #33235 Releases: main, 12.4 Change-Id: I10d70fb61f79a0c0974a6d101efb3b4cb5463060 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84847 Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Reifenscheid authored
The AbstractModule class is located within the 'ModuleApi' folder, so the namespace must be \TYPO3\CMS\Adminpanel\ModuleApi\AbstractModule. This patch fixes the issue. Releases: main, 12.4 Resolves: #104204 Change-Id: I28dc1777fe8900665e8a3d43a8655674dbb82185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84846 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In case of union type the null is added as additional type. This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104203 Releases: main, 12.4, 11.5 Change-Id: I1e264d242e53e4d258abe82831e612ee43234d0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84899 Tested-by:
-
Stefan Bürk authored
This change modifies the `Build/Scripts/runTests.sh` dispatcher script to add new database version. Added versions: * MySQL 8.4 * MariaDB 11.2 * MariaDB 11.3 * MariaDB 11.4 Note that for TYPO3 v12 and v11 also missing versions up to these are added now. This is not a official supported version statement. [1] https://endoflife.date/mariadb [2] https://endoflife.date/mysql [3] https://endoflife.date/postgresql Resolves: #104200 Releases: main, 12.4, 11.5 Change-Id: I338a7f0973a46fb8bc6a582a5c478c4715a8000e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84894 Reviewed-by:
-
Stefan Bürk authored
This change modifies the `Build/Script/runTests.sh` command dispatcher to allow passing composer options to the `composer install` subcommand, for example Build/Scripts/runTests.sh -s composerInstall \ -- --prefer-source Note that this is already possible using the generic `-s composer` dispatcher but would resolve some user confusion. This is useful to install dependencies as git checkouts, for example when working on packages like `typo3/testing-framework` changes. Albeit the need to remove the vendor folder first is needed in case of the example. Resolves: #104186 Releases: main, 12.4, 11.5 Change-Id: Id07c90f3b6902ad8866249563eceeb2dafbc919b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84844 Tested-by: -
Oliver Bartsch authored
The ext:form EmailFinisher allows to retreive recipients via different ways. Next to the default yaml configuration is it also possible to set recipients via flexform or via TypoScript. In such cases there might be additional whitespaces added, which would lead to the function not returning the recipients address since GU:validEmail() would fail. Since recipients are mandatory, this leads to an exception in the finisher. To prevent such "false positives", the address is now trimmed before being checked. Resolves: #104198 Releases: main, 12.4 Change-Id: Ia66cc73d477507aee6c954995d6afd6a771e6354 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84841 Tested-by:
-
Stefan Bürk authored
This change adds a `@` silence operator to the usage of `preg_match()` in the `RedirectService`. This prevents errors in case of manually-entered malformed regexp patterns and follows existing similar usages of the service. Additionally, a todo comment is added to evaluate future early pattern evaluation in record creation/editing so that a proper response to invalid patterns can be emitted. Resolves: #102176 Releases: main, 12.4, 11.5 Change-Id: I88687c128986ae6fa1e2b7a3a4bf414ee8f952f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84842 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104196 Releases: main, 12.4, 11.5 Change-Id: Iec724407eed8edefed48c2e032b2105b42cabc94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84884 Tested-by:
Fabien Udriot <fudriot@omic.ch> Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104197 Releases: main, 12.4, 11.5 Change-Id: Ie2fbd6369e6c59c275939c42daa8c45c22334e48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84887 Tested-by:
-
- Jun 24, 2024
-
-
Marcin Sągol authored
The `typo3-backend-icon` component code contains a duplicated code fragment. This patch removes one occurrence. Resolves: #104199 Releases: main, 12.4 Change-Id: I0530f89f646c5c2fda8a170f3792a28a2c04243d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84840 Tested-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104185 Releases: main, 12.4, 11.5 Change-Id: I12462595d622efa1bbe2a479f159d68a984bda23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84868 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104187 Releases: main, 12.4 Change-Id: I80b1494413016658e6c5ed88485cce887178fdbf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84874 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is deprecated and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104188 Releases: main, 12.4 Change-Id: I3a3273b9176fce9b0e64a084654acf17c8738da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84876 Reviewed-by:
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] This prepares the way towards PHP 8.4 compatibility. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated Resolves: #104184 Releases: main, 12.4, 11.5 Change-Id: I1e1a60a36ae2b5244bbd8c3cf963f2165077dbad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84865 Reviewed-by:
-
Andreas Kienast authored
This commit updates TypeScript to 5.5, along with its related friends. Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.13.1 \ @typescript-eslint/parser@^7.13.1 \ @typescript-eslint/typescript-estree@^7.13.1 \ typescript@^5.5.2 npm run build Resolves: #104189 Releases: main, 12.4 Change-Id: Ic2b66c65485845ae62371228f6f8b62c8a320172 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84878 Tested-by: -
Oliver Bartsch authored
Since #96515, is's possible to configure aliases for backend modules. Those are handled by the UriBuilder to allow using those aliases for building links to the corresponding module. Using the ActionDispatcher JS component for building module links via the "TYPO3.ModuleMenu.showModule" action, it's now also possible to use corresponding aliases. Therefore, the BackendController now adds the module aliases to the module information JS array and the module JS component properly checks for those aliases when resolving a given module name / identifier. Resolves: #104165 Related: #96515 Releases: main, 12.4 Change-Id: Ia8372a503f4973d81deb285a9945fa13ade24dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84839 Tested-by:
-
- Jun 23, 2024
-
-
Stefan Bürk authored
With PHP 8.4 marking method parameter implicitly nullable is depreacted and will emit a `E_DEPRECATED` warning. One recommended way to resolve this, is making it explicitly nullable using the `?` nullable operator. [1] In cases, where are implicitly nullable parameter exists before not-nullable parameters in a method or constructor, making it explicitly nullable will emit a Optional parameter <paramname> declared before required parameter <paramname> is implicitly treated as a required parameter since PHP 8.0 [2]. This change adds the `?` nullable operator [1] and removes the null default value when one or more non-optional argument follows [2] to mitigate both issues. Note that the second case is a edge case in this change. This prepares the way towards PHP 8.4 compatibility and unifies towards using `?` nullable operator over union null type when possible. [1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated [2] https://php.watch/versions/8.0/deprecate-required-param-after-optional Resolves: #104182 Releases: main, 12.4, 11.5 Change-Id: I68362a89458117eca4f0488c67a0b9ed17e7b929 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84858 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Jun 21, 2024
-
-
Garvin Hicking authored
Internally, all allowedAspectRatios will replace a "." character with "_" to prevent problems with Fluid variable key access. The lead to a situation that the backend was unable to reference the current selectedRatio, because the comparison was not performed on the "fixed" key name. This patch now uses a central "fix" method Ratio::prepareAspectRatioId in both the value object preparation as well as the configuration instantiation. This workaround should be addressed as a breaking change in TYPO3v14, a note has been added. Resolves: #103047 Releases: main, 12.4 Change-Id: I8999b5d54627cda7044662ca5da17f4886a700e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84852 Tested-by:
-
Georg Ringer authored
The view "List of indexed pages" lists all indexed pages with the page arguments used during indexing. To avoid errors in rendering those, the viewhelper `f:format.json` is used. Resolves: #99125 Releases: main, 12.4 Change-Id: I91038cef9c76d884c2c484925ecef4a70070e153 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84830 Tested-by:
-
Sybille Peters authored
The class EditableRestriction is used in EXT:linkvalidator to apply permission restrictions to database queries for current (non-admin) BE user. In case of table sys_file_reference, the value for $GLOBALS['TCA'][$table]['ctrl']['type'] might be "uid_local:type". In that case, the class EditableRestriction tried to access the TCA configuration for this field via $GLOBALS['TCA']['sys_file_reference'] ['columns']['uid_local:type']['config'] when in fact this will be empty (and the type refers to the table sys_file). We now check if the resulting array is empty and skip the check if that is the case. Resolves: #103559 Related: #83835 Releases: main, 12.4, 11.5 Change-Id: Idbe653ef9f1c21c077fcb79c03212e606cc71830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84828 Tested-by:
-
Peter Kraume authored
Using constants in the LinkHandler TSConfig does not work in the redirects module. Resolves: #103205 Releases: main, 12.4, 11.5 Change-Id: I29dda248c5e80e077d53c8ecead9fb29fd041f76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84825 Tested-by:
-
Garvin Hicking authored
When filtering the page tree with characters that have special meaning for a regular expression (for example, ")" or "(" or "?" and some others), the filtering would return a "Page Tree error". JavaScript does not have something like "preg_quote", so this uses the escape string provided by the MDN with fixed special characters. Resolves: #104092 Releases: main, 12.4, 11.5 Change-Id: I4a29c62eaca8b7643c8ef78dda1d8337b3e1e53a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84722 Reviewed-by:Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Christian Rath-Ulrich authored
This commit fixes a minor issue where the header tag in PaletteAndSingleContainer was incorrectly set as h4. The tag has been changed to h3 for better readability and semantics. Simultaneously, visually hidden headers were also added to tabs to improve accessibility. Resolves: #104021 Releases: main, 12.4 Change-Id: Ic2301eabb23d1d17169056ec8e9ec40a5824c52c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84822 Tested-by:
-
Oliver Bartsch authored
Using the multi record selection, it's possible to change the state of checkboxes via multiple ways, e.g. by clicking on the table row. The central functionality for changing the connected checkbox state now also considers the disabled attribute and therefore only changes the checked state in case the checkbox is not disabled. Additionally, next to the custom event, which is triggered on checkbox state changes, the multi record selection now also dispatches the standard "change" event. FormEngine validation for example is listening on this event to mark the field as changed. Resolves: #104142 Releases: main, 12.4 Change-Id: I9854709ee624d88821757fff3baf38c892e5f11d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84823 Tested-by:
-
Marcin Sągol authored
Adjust request token header name to match the value defined in RequestToken::HEADER_NAME. Fix code example. Releases: main, 12.4 Resolves: #104167 Change-Id: I8e78c0385962b8bdc085a6cc2896794930a96238 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84834 Tested-by:
-
Leon Dietsch authored
When switching between cropVariants with multiple coverAreas, all of the previous coverAreas are properly removed, only showing those that belong to a specific cropVariant. See details and screenshots in the related ticket. (A new styleguide TCA element crop_9 is also added to showcase multiple coverAreas in multiple cropVariants) Resolves: #103389 Releases: main, 12.4 Change-Id: I7649aa0fe5bc01939326119b24dbdafd5f09a708 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84837 Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
-
Benni Mack authored
This change allows to explicitly set includeRecordsWithoutDefaultTranslation = 0 in TypoScript. Resolves: #93881 Releases: main, 12.4 Change-Id: Ieef59efa320f401345c0c40c2514f988bd1d6715 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84836 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Georg Ringer authored
Add the configuration example to the full demo of list properties. Resolves: #100852 Releases: main, 12.4 Change-Id: I77afff52cd51d0c527e6f4a9b569accc3e60dab4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84835 Tested-by:
-
Georg Ringer authored
The IP anonymization task uses its own configuration and doesn't allow a fallback to the configuration defined in the settings. Therefore the misleading text is removed. Resolves: #97161 Releases: main, 12.4 Change-Id: If569c0ee75fd58ed2e069387776e9c15f7b41d18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84833 Tested-by:
-
Jonathan Kieling authored
the array of translation files was not sorted by key descending. Resolves: #95212 Releases: main, 12.4 Change-Id: Ieb9d98af33cbe0d1a5ef34cb2993a247d0821031 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84832 Tested-by:
-
- Jun 20, 2024
-
-
Garvin Hicking authored
The `PackageArtifactBuilder` takes care of publishing `Resources/Public/...` directories of installed TYPO3 extensions into the public directory. In case this publishing fails, now a warning message is presented, so that action can be taken. Now also an info message is shown, when an extension does not have a Resources/Public directory. This message is only shown with increased verbosity, since this can be intentionally like so. Further cleanup is preformed and code that does not apply any more since composer installers v5 is required, is removed. Last but not least, asset publishing is now decoupled into a dedicated method, that receives installed packages as input and returns resulting messages as output. Future refactoring of the publishing code into a distinct class is kept for a future change. Resolves: #103898 Releases: main, 12.4 Change-Id: I6636a024490a0cb3c5e77f6f935f63094035d489 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84759 Tested-by:
-
Christian Weiske authored
When a scheduler task throws an exception, an error is logged. The log message does not tell us the reason for the failure: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2 Up to TYPO3 v10, this message did include more information: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 2, > Code: 56, OpenSSL SSL_read: Connection reset by peer, errno 104 This behavior was changed (probably unintentional) with patch "[BUGFIX] Make logger usage PSR-3 compliant" https://review.typo3.org/c/Packages/TYPO3.CMS/+/69425 Besides the task class and UID, the log message now contains the exception code, message, file and line. Example: > Task failed to execute successfully. > Class: TYPO3\CMS\Scheduler\Task\ExecuteSchedulableCommandTask, UID: 6, > Code: 500, "FailTask fail message" > in /var/www/typo3/vendor/[...]/Classes/Command/FailTask.php#19 Resolves: #103799 Related: #94356 Releases: main, 12.4 Change-Id: I179f059e551966944288b6fda6f2a26a4daace3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84807 Reviewed-by:
-
Christian Kuhn authored
phpunit 11.2.5 comes with further memory consumption improvements that obsolete some hacks we've had in typo3/testing-framework. Raise both. > composer req --dev phpunit/phpunit:^10.5.24 > composer req --dev typo3/testing-framework:^8.1.0 Resolves: #104164 Releases: main, 12.4 Change-Id: Ib1c9d55833f7a950f98e2f902f8864eae289a6c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84801 Tested-by:
-
