Skip to content
Snippets Groups Projects
Commit fd5320af authored by Stefan Bürk's avatar Stefan Bürk
Browse files

[TASK] Avoid implicitly nullable class method parameter in `EXT:webhooks`

With PHP 8.4 marking method parameter implicitly nullable
is deprecated and will emit a `E_DEPRECATED` warning. One
recommended way to resolve this, is making it explicitly
nullable using the `?` nullable operator. [1]

This prepares the way towards PHP 8.4 compatibility.

[1] https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Resolves: #104187
Releases: main, 12.4
Change-Id: I80b1494413016658e6c5ed88485cce887178fdbf
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84874


Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Tested-by: default avatarGarvin Hicking <gh@faktor-e.de>
Tested-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarGarvin Hicking <gh@faktor-e.de>
parent 73f6adf1
Branches
Tags
No related merge requests found
......@@ -46,11 +46,11 @@ class WebhookInstructionFactory
string $method = 'POST',
bool $verifySSL = true,
array $additionalHeaders = [],
string $name = null,
string $description = null,
WebhookType $webhookType = null,
string $identifier = null,
int $uid = null,
?string $name = null,
?string $description = null,
?WebhookType $webhookType = null,
?string $identifier = null,
?int $uid = null,
): WebhookInstruction {
return new WebhookInstruction(
$url,
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment