- Aug 11, 2023
-
-
Christian Kuhn authored
The lexer is used in the core ext_tables.sql parser. Other dependencies that use it allow 3.0 already, it comes with more PHP type hints, it should be fair to require ^3.0 with core v13. > composer req doctrine/lexer:^3.0 > composer req doctrine/lexer:^3.0 -d typo3/sysext/core --no-update Resolves: #101659 Releases: main Change-Id: Iaae9f9c5ffc4087bd4bcb3772df3c22c6fab18cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80520 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
Similar to #101642, the single DataType classes are modernized towards better PHP types, are made `@internal` and cleaned up a bit. Resolves: #101651 Related: #101642 Related: #101553 Releases: main Change-Id: I9ed750a2b2feffe17136f922de1fc0a1a9a04346 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80510 Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Stefan B�rk <stefan@buerk.tech> Tested-by:
-
Nikita Hovratov authored
The csp.yaml shouldn't be taken into account when merging current and new site configuration via the GUI. Resolves: #101626 Releases: main, 12.4 Change-Id: Ib08b7707cfb43733985b0c7aa5bf12bcc5fa603c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80468 Tested-by:
J�rg B�sche <typo3@joergboesche.de> Tested-by:
-
- Aug 10, 2023
-
-
Torben Hansen authored
With the update from CKEditor 4 to CKEditor 5, parts of the extension documentation got outdated. This patch includes the following changes: * Updated external links to CKEditor 5 documentation * Updated screenshots to show CKEditor 5 * Updated configuration examples and removed unsupported options * Updated configuration reference * Added "Grouping toolbar items in drop-downs" example * Added "How do I create a custom plugin?" example Resolves: #101465 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Iefa020a577ab3ab03f95ba8584607196f69b8886 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80244 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Chris M�ller <typo3@krue.ml> Tested-by:
-
Andreas Fernandez authored
The TYPO3 system extension "backend" accumulated many graphical assets over the years that became unused piece by piece. This patch now removes said files EXT:backend. NB: The file `Logo.png` from EXT:backend was required in tests of EXT:frontend ((╯°□°)╯︵ ┻━┻), but since there are already fixture assets, a different file is used instead. Resolves: #101647 Releases: main Change-Id: Ic371feec6c3904b688ab1129d3d21b544685893c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80503 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow best practices and avoid deprecation warnings later with PHPUnit 11. We do this by creating dedicated fixture subclasses of the affected abstract classes. Resolves: #101630 Related: #101601 Releases: main Change-Id: I27f526cb7ee4e1f2081c05befd3d70549dd0e2fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80470 Tested-by:
-
Tomasz Woldański authored
This implements a rather unexpected detail when combining reference "=<" and copy "<" operator from old TypoScript parser. Copy operator: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target < lib.source1 tt_content.target < lib.source2 Result: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The tt_content.target existing value from lib.source1 is kept, but children are reset - lib.source1.value is not within tt_content.target anymore. Now reference first, then copy: lib.source1 = TEXT lib.source1.value = source1Value lib.source2.otherValue = source2OtherValue tt_content.target =< lib.source1 tt_content.target < lib.source2 Old parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.value = source1Value tt_content.target.otherValue = source2OtherValue New parser after resolving reference in FE: tt_content.target = TEXT tt_content.target.otherValue = source2OtherValue The old parser keeps existing references when the copy operator does not reset the value to something else. The patch adapts the new parser to behave identical and refactors the AST copy method to better documented, more easy and eventually also quicker code. Resolves: #100115 Releases: main, 12.4 Change-Id: Ia03cefd6e550833bdc9120a179881d04bf70d117 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80461 Reviewed-by:
Tomek Wolda?ski <t.woldanski@macopedia.com> Tested-by:
-
Christian Kuhn authored
Minor cleanup in extensionmanager FileHandlingUtility to make a dependency more explicit, everything else is within InstallUtility: * No explicit singleton since this service is shared by default * More injection over GU::makeInstance() * Avoid extbase LocalizationUtility, use core LanguageService * More strict types * Inline a series of low-liner methods and protect more API to clean up class signature Resolves: #101648 Related: #101643 Releases: main Change-Id: Ice4614300eaf559a39cdbdc966df1e0e0e5852db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80506 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/scheduler/scheduler` module in favor of native APIs. Extra fields are now hidden via the `hidden` attribute and not via CSS styling anymore. Resolves: #101619 Releases: main, 12.4 Change-Id: Ida87f82cde264785c8cd5b0d3619304bc6dfadfc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80462 Tested-by:
-
Benjamin Franzke authored
Also raise the fixed linters to error level in order to not introduce similar errors again. The linter @typescript-eslint/no-explicit-any is disabled for now, in order for errors to be visible at first glance. Resolves: #101645 Releases: main, 12.4 Change-Id: I48229f148298ac13acd6d12deb55d606a3c7ef59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80500 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Andreas Fernandez authored
The current color picker plugin based on jQuery is now replaced with alwan [1]. alwan is a dependency-free color picker solution that also allows us to integrate color swatches in the future. [1]: https://sofianchouaib.github.io/alwan/ Resolves: #101646 Releases: main Change-Id: I9e902e9eb5630e3190f8973bca0d1fa6fd37b3d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80501 Reviewed-by:
-
Benjamin Franzke authored
Missing declarations caused some method calls and assignments to not be type checked, as all members of the (top.|window.)TYPO3 object were declared to `any`. This actually revealed some invalid API usage. which is fixed as a drive-by. (No real bugs were found, as type checking in the APIs caught/ignored such cases) Resolves: #101644 Releases: main, 12.4 Change-Id: I2e188e53a02d9e0ae875084cadc28600c7a59aa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80471 Tested-by:
-
Christian Kuhn authored
Service classes in Extensionmanager\Utility are a great example on "when class abstraction goes wrong" - we're fighting with those for lots of major versions already. To tame this mess, this first patch applies a rather straight streamlining to InstallUtility: Use constructor property promotion, move public methods up in the class, remove heavy-mocking and useless unit tests that only check if certain sub-methods are called. Resolves: #101643 Releases: main Change-Id: If27bee98f22120ca739659c453c26fa1795c49d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80499 Reviewed-by:
-
Christian Kuhn authored
Classes in TYPO3\CMS\Core\Database\Schema\Parser\AST are intermediate DTO's created by the ext_tables.sql parser to transfer them into doctrine objects. They are modernized with more type hints and constructor property promotion to be more reliable with upcoming refactorings. Resolves: #101642 Related: #101553 Releases: main Change-Id: Ia9290b5ea4c35020f3d5b82b7cb4b5d722360e76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80498 Tested-by:
-
Andreas Fernandez authored
In the effort of removing jQuery from the Install Tool, this patch migrates the `InfoBox` and `FlashMessage` components to custom Lit elements. Resolves: #101588 Releases: main Change-Id: I755d88eafddb8ca57a0aef0345c1c6d282ee4b7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80403 Reviewed-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80494 Tested-by:
-
Christian Kuhn authored
The extension manager `@internal` class `FileHandlingUtility` has a circular dependency to `InstallUtility`: Both inject each other. The patch resolves this by implementing `reloadPackageInformation()` in `FileHandlingUtility` on its own. The class is modernized along the way with more type hints, constructor property promotion, having all public methods on top, and a unit test cleanup. Resolves: #101641 Releases: main Change-Id: I86061da7c92ad00c7c7df89d6b31a9b3ec03e9a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80495 Tested-by:
-
Benni Mack authored
* Avoids static methods (which were copied from BackendUtility) * Uses proper UriBuilder everywhere * Moves some HTML rendering into Fluid * Removes unused methods Resolves: #101622 Releases: main Change-Id: I0b1937cbc71d45aaab952fdfba4acc20a222dd37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80464 Reviewed-by:
-
Andreas Fernandez authored
Executed commands: npm install --save bootstrap@^5.3.1 npm run build Resolves: #101629 Releases: main, 12.4 Change-Id: Idcb9f78543e945e0e948a19bb2574827b15806b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80466 Tested-by: -
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/backend/layout-module/paste` module in favor of native APIs. Resolves: #101617 Releases: main Change-Id: I201eaf575a328bc805dc0fb90a364a918686900a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80460 Reviewed-by:
-
Oliver Klee authored
Fix a case where the name of the testcase did not follow the name of the tested class. Resolves: #101631 Releases: main, 12.4 Change-Id: Ic5225f692c8610b18769bbceb5acdb427ef4c5d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80469 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Christian Kuhn authored
When core DefaultTcaSchema auto creates more and more column definitions, ext_tables.sql can end up with a table definition without columns: CREATE TABLE tx_foo ( ); This would be invalid as such in most DBMS since tables usually must have at least one column. However, it is a valid definition in the scope of ext_tables.sql files when the core enriches fields from TCA. The parser currently chokes on tables without columns, which is fixed with the patch. Resolves: #101623 Related: #101553 Releases: main Change-Id: Icab369bff6a93e6c293803ed2dfb3473b41d8a97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80465 Tested-by:
-
- Aug 08, 2023
-
-
Oliver Klee authored
This change fixes places where the code violates the contract. Also, the change will avoid type errors when the `GeneralUtility` array functions are switched to native type declarations. All of these changes fix places where the acceptance test break with the GU array methods using native type declarations. Resolves: #101616 Related: #101453 Releases: main, 12.4 Change-Id: I6f86f7a371d50b20a34275ebc771604d407917bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80459 Tested-by:
-
Oliver Wand authored
Tables with TCA columns set to type="file" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is the first patch in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=file. It goes through various functional test related .csv fields, and adapts a broken TCA configuration in the blog_example fixture extension revealed by this change. Resolves: #101571 Related: #101553 Releases: main Change-Id: Iae2c4bad2a0dc54628a8862b0c39f4913b0c5892 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80374 Tested-by:
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80463 Tested-by:
-
Oliver Klee authored
`getMockForAbstractClass` has been (soft-)deprecated in PHPUnit 10.1: https://github.com/sebastianbergmann/phpunit/issues/5241 Hence, we should replace its usages to follow current best practices. This changes tackles the classes where we can mock an interface instead of an abstract class, allowing us to use `createMock` instead of `getMockForAbstractClass`. Resolves: #101609 Related: #101601 Releases: main, 12.4 Change-Id: I995f70d779a1bc6251bc4479c3dcb2ee548314f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80455 Tested-by:
-
Jürgen Venne authored
The "global" extbase/Tests/Fixtures folder is unfortunate: Fixtures should be located in more dedicated folders and should not be shareable between unit and functional tests. The patch moves a couple of fixtures to more dedicated locations to avoid confusion. Resolves: #101530 Releases: main, 12.4 Change-Id: I3faad97ca05e7790da8443d615309da03ff91201 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80456 Tested-by:
-
Christian Kuhn authored
MM tables only need a uid column when "multiple" is true. With primary keys finally being properly set on MM relations without "multiple", we can remove "MM_hasUidField" and derive the information whether a uid column is needed from "multiple" flag, which obsoletes "MM_hasUidField". Resolves: #101554 Related: #101425 Releases: main Change-Id: I2b39da902d2a6a8a85b840daa813a2af712bfd82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80434 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80435 Reviewed-by:
-
Benni Mack authored
This change adds a new method buildUriFromRequest inside TYPO3's Backend UriBuilder in order to generate links to the current (or any) request with additional parameters. This is quite helpful to link to the same module /route when a request is given, thus reducing code duplication and unifies link generation. In addition, the determineScriptUrl() and getScriptUrl() methods inside LinkBrowsers and ElementBrowsers are removed, and have been removed from the LinkParameterProviderInterface as well. Resolves: #101612 Releases: main Change-Id: Ibaa2d2872178374e4553cf5899ee8ae19168480b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80433 Reviewed-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80391 Reviewed-by:
Jochen Roth <rothjochen@gmail.com> Tested-by:
-
- Aug 07, 2023
-
-
Benni Mack authored
The PSR-7 Request is now handed in some methods of the Element Browser code. This is a prepatch in order to avoid hidden dependencies, simplify abstraction and adapt the related interfaces. Resolves: #101610 Releases: main Change-Id: I9a6486732a2f166c82edd46e62eb2ad0d4bbb633 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80294 Tested-by:
-
Andreas Fernandez authored
The module menu is currently in a bad shape where different loose DOM elements and scripts are tangled together and do stuff. Previously, the module state was stored as a JSON-encoded string in the container of the actual module menu, which isn't refreshed when the module menu is reloaded via AJAX, leading to endless "loading" modules a freshly installed extension may add. Also, the JSON string gets parsed once and is then cached for faster access times. This patch accomplished multiple things: * the module state information is moved to the `nav` element of the module menu that's part of the reload process, always having the current state * an internal `flushModuleCache()` function is introduced to clear the cached, parsed state This is not an ideal solution but the best way the issue can be fixed in short-term. In long-term, the whole module structure and its handling need refactoring. Resolves: #100493 Releases: main, 12.4 Change-Id: I28342d7b207638e307c2ca7f4f50f2f4e6d27dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78501 Tested-by:
-
Oliver Bartsch authored
Resolves: #101605 Releases: main, 12.4 Change-Id: I1da8af5b5b0025ad0f25349fe6d4893eddbd5eaf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80425 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #101595 Related: #101585 Releases: main Change-Id: I75edc68ba4d2bd967530cf3389d6dc944fe347b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80411 Tested-by:
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80426 Tested-by:
-
Christian Kuhn authored
Remove -j and -k and only use -i to specify database versions. This is more easy to use, parse and validate. Resolves: #101604 Releases: main, 12.4, 11.5 Change-Id: Ie6b9343c6f244a294d636f0e5c09d24c5e1845fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80424 Tested-by:
-
Oliver Bartsch authored
This introduces a new PSR-14 event, enabling extension authors to modify the overlay icon identifier of any record icon. This replaces the previously available hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Core\Imaging\IconFactory']['overrideIconOverlay'] which is therefore now removed. Resolves: #101603 Releases: main Change-Id: If7d56003f29663903507092cf4826d17d2da2445 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80422 Tested-by:
-
- Aug 06, 2023
-
-
Rémy DANIEL authored
Linkvalidator extension has a couple of known issues, especially with external link checking. Those issues are now documented, so integrators can acknowledge them and implement counter-measures. Resolves: #101597 Releases: main, 12.4, 11.5 Change-Id: I00dc01243426fc56c21a4bd11815c3009e3dd3ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80421 Tested-by:
-
Christian Kuhn authored
Fix a happy little regex to deal with "TCEforms" removal of #97126. This should fix finisher override FormEngine rendering. Resolves: #101050 Related: #97126 Releases: main, 12.4 Change-Id: Ia8d893c3f3b31f7af83b3d9f2ae533b3e557f5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80423 Reviewed-by:
Jan Helke <j.helke@helke.de> Tested-by:
-
